[GitHub] storm issue #2698: STORM-2882: shade storm-client dependencies

2018-06-06 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2698 @revans2 If I'm understanding the problem correctly, the bug is that if shaded-deps is in the same reactor as the other modules, Maven will read the "normal" pom, rather than the dependency r

[GitHub] storm issue #2698: STORM-2882: shade storm-client dependencies

2018-06-06 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2698 Thanks @ptgoetz ---

[GitHub] storm issue #2704: STORM-1038: Upgrade to Netty 4

2018-06-06 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2704 One of the tests is flaky, currently trying to figure out why. https://travis-ci.org/apache/storm/jobs/388836374. The client is reporting that it's connected before channelActive has been called

[GitHub] storm pull request #2704: STORM-1038: Upgrade to Netty 4

2018-06-06 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2704#discussion_r193493524 --- Diff: storm-client/src/jvm/org/apache/storm/pacemaker/codec/ThriftEncoder.java --- @@ -12,59 +12,54 @@ package org.apache.storm.pacemaker.codec

[GitHub] storm pull request #2704: STORM-1038: Upgrade to Netty 4

2018-06-06 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2704#discussion_r193481874 --- Diff: storm-client/src/jvm/org/apache/storm/messaging/netty/Client.java --- @@ -135,19 +141,29 @@ saslChannelReady.set

[GitHub] storm pull request #2704: STORM-1038: Upgrade to Netty 4

2018-06-06 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2704#discussion_r193462962 --- Diff: storm-core/pom.xml --- @@ -456,29 +456,29 @@ - org.apache.storm

[GitHub] storm pull request #2704: STORM-1038: Upgrade to Netty 4

2018-06-06 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2704#discussion_r193462736 --- Diff: storm-core/pom.xml --- @@ -365,17 +365,17 @@ ${basedir}/src/resources

[GitHub] storm pull request #2704: STORM-1038: Upgrade to Netty 4

2018-06-06 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2704#discussion_r193462295 --- Diff: storm-server/src/main/java/org/apache/storm/pacemaker/PacemakerServer.java --- @@ -83,48 +88,51 @@ public PacemakerServer(IServerMessageHandler

[GitHub] storm pull request #2704: STORM-1038: Upgrade to Netty 4

2018-06-06 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2704#discussion_r193461968 --- Diff: storm-client/src/jvm/org/apache/storm/pacemaker/PacemakerClient.java --- @@ -100,23 +99,25 @@ public PacemakerClient(Map config, String host

[GitHub] storm issue #2698: STORM-2882: shade storm-client dependencies

2018-06-06 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2698 Thanks for addressing the comments. Looks good to me. I think it makes sense to add shaded-deps as a module to the root pom though. It will likely address the release issue, and means we don't have

[GitHub] storm issue #2703: [STORM-3094] : Added topology name validation at client s...

2018-06-06 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2703 +1, it seems fine to me to duplicate the check for convenience ---

[GitHub] storm pull request #2704: STORM-1038: Upgrade to Netty 4

2018-06-05 Thread srdo
GitHub user srdo opened a pull request: https://github.com/apache/storm/pull/2704 STORM-1038: Upgrade to Netty 4 This is a continuation of the work done at https://github.com/apache/storm/pull/728. ### Important changes: * Split MessageEncoder into multiple encoders

[GitHub] storm issue #2698: STORM-2882: shade storm-client dependencies

2018-06-05 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2698 Just so you don't spend too much time on it, neither HBase nor Cassandra work with Java 9 right now. I skipped those modules when testing it last year. Also I didn't get farther than building

[GitHub] storm pull request #2698: STORM-2882: shade storm-client dependencies

2018-06-05 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2698#discussion_r193104685 --- Diff: storm-core/pom.xml --- @@ -193,10 +193,6 @@ curator-framework compile - --- End diff

[GitHub] storm pull request #2698: STORM-2882: shade storm-client dependencies

2018-06-05 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2698#discussion_r193103356 --- Diff: storm-server/src/main/java/org/apache/storm/testing/InProcessZookeeper.java --- @@ -12,15 +12,16 @@ package org.apache.storm.testing

[GitHub] storm pull request #2698: STORM-2882: shade storm-client dependencies

2018-06-05 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2698#discussion_r193084777 --- Diff: storm-client/src/jvm/org/apache/storm/container/cgroup/SystemOperation.java --- @@ -54,8 +55,8 @@ public static String exec(String cmd) throws

[GitHub] storm pull request #2698: STORM-2882: shade storm-client dependencies

2018-06-05 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2698#discussion_r193080442 --- Diff: shaded-deps/pom.xml --- @@ -0,0 +1,272 @@ + + + +http://maven.apache.org/POM/4.0.0; + xmlns:xsi="http://www.w3.org

[GitHub] storm pull request #2698: STORM-2882: shade storm-client dependencies

2018-06-04 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2698#discussion_r192818795 --- Diff: storm-client/src/jvm/org/apache/storm/container/cgroup/SystemOperation.java --- @@ -54,8 +55,8 @@ public static String exec(String cmd) throws

[GitHub] storm pull request #2698: STORM-2882: shade storm-client dependencies

2018-06-04 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2698#discussion_r192816102 --- Diff: shaded-deps/pom.xml --- @@ -0,0 +1,272 @@ + + + +http://maven.apache.org/POM/4.0.0; + xmlns:xsi="http://www.w3.org

[GitHub] storm pull request #2698: STORM-2882: shade storm-client dependencies

2018-06-04 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2698#discussion_r192822576 --- Diff: storm-client/test/jvm/org/apache/storm/security/auth/ClientAuthUtilsTest.java --- @@ -172,59 +178,47 @@ public void makeDigestPayloadTest() throws

[GitHub] storm pull request #2698: STORM-2882: shade storm-client dependencies

2018-06-04 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2698#discussion_r192822955 --- Diff: storm-core/pom.xml --- @@ -193,10 +193,6 @@ curator-framework compile - --- End diff

[GitHub] storm pull request #2698: STORM-2882: shade storm-client dependencies

2018-06-04 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2698#discussion_r192823787 --- Diff: storm-server/src/main/java/org/apache/storm/testing/InProcessZookeeper.java --- @@ -12,15 +12,16 @@ package org.apache.storm.testing

[GitHub] storm pull request #2698: STORM-2882: shade storm-client dependencies

2018-06-04 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2698#discussion_r192814731 --- Diff: shaded-deps/pom.xml --- @@ -0,0 +1,272 @@ + + + +http://maven.apache.org/POM/4.0.0; + xmlns:xsi="http://www.w3.org

[GitHub] storm pull request #2698: STORM-2882: shade storm-client dependencies

2018-06-04 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2698#discussion_r192814411 --- Diff: shaded-deps/pom.xml --- @@ -0,0 +1,272 @@ + + + +http://maven.apache.org/POM/4.0.0; + xmlns:xsi="http://www.w3.org

[GitHub] storm pull request #2685: STORM-1294: Port netty-unit-test to Java

2018-06-03 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2685#discussion_r192583770 --- Diff: storm-core/test/jvm/org/apache/storm/messaging/netty/NettyTest.java --- @@ -0,0 +1,382 @@ +/* + * Copyright 2018 The Apache Software

[2/2] storm git commit: Merge branch 'STORM-3086' of https://github.com/srdo/storm into asfgit-master

2018-06-01 Thread srdo
Merge branch 'STORM-3086' of https://github.com/srdo/storm into asfgit-master Project: http://git-wip-us.apache.org/repos/asf/storm/repo Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/41f977a9 Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/41f977a9 Diff: http://git-wip

[GitHub] storm issue #2696: STORM-3086: Add documentation for invoking static factory...

2018-06-01 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2696 The examples are slightly adjusted versions of some code that appears in the flux-core tests https://github.com/apache/storm/blob/master/flux/flux-core/src/test/resources/configs/config-methods

storm git commit: STORM-3089: Describe worker hooks in documentation

2018-06-01 Thread srdo
Repository: storm Updated Branches: refs/heads/1.1.x-branch fe7717108 -> d52854081 STORM-3089: Describe worker hooks in documentation Project: http://git-wip-us.apache.org/repos/asf/storm/repo Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/d5285408 Tree:

storm git commit: STORM-3089: Describe worker hooks in documentation

2018-06-01 Thread srdo
Repository: storm Updated Branches: refs/heads/1.x-branch aeb69dd13 -> bfa578058 STORM-3089: Describe worker hooks in documentation Project: http://git-wip-us.apache.org/repos/asf/storm/repo Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/bfa57805 Tree:

[GitHub] storm issue #2697: STORM-3089: Describe worker hooks in documentation

2018-06-01 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2697 Thanks for the review ---

[1/2] storm git commit: STORM-3089: Describe worker hooks in documentation

2018-06-01 Thread srdo
Repository: storm Updated Branches: refs/heads/master b0bdbf082 -> f7ab952b2 STORM-3089: Describe worker hooks in documentation Project: http://git-wip-us.apache.org/repos/asf/storm/repo Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/befc2db7 Tree:

[2/2] storm git commit: Merge branch 'STORM-3089' of https://github.com/srdo/storm into asfgit-master

2018-06-01 Thread srdo
Merge branch 'STORM-3089' of https://github.com/srdo/storm into asfgit-master Project: http://git-wip-us.apache.org/repos/asf/storm/repo Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/f7ab952b Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/f7ab952b Diff: http://git-wip

[GitHub] storm pull request #2699: STORM-3087: Make FluxBuilder.canInvokeWithArgs che...

2018-06-01 Thread srdo
GitHub user srdo opened a pull request: https://github.com/apache/storm/pull/2699 STORM-3087: Make FluxBuilder.canInvokeWithArgs check whether the actu… …al argument type is assignable to Number before deciding that a method with a primitive parameter can be invoked 1

[GitHub] storm issue #2686: STORM-3053 prevent race deleting blobs before topologies ...

2018-06-01 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2686 Thanks @agresch, merged to master. I forgot to check that commits were squashed, hopefully it doesn't bother anyone too much. ---

[1/3] storm git commit: STORM-3053 prevent race deleting blobstores before topologies can be submitted

2018-06-01 Thread srdo
Repository: storm Updated Branches: refs/heads/master 0bc4e26d1 -> b0bdbf082 STORM-3053 prevent race deleting blobstores before topologies can be submitted Project: http://git-wip-us.apache.org/repos/asf/storm/repo Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/99f47570 Tree:

[2/3] storm git commit: review rework

2018-06-01 Thread srdo
review rework Project: http://git-wip-us.apache.org/repos/asf/storm/repo Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/787a4340 Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/787a4340 Diff: http://git-wip-us.apache.org/repos/asf/storm/diff/787a4340 Branch:

[3/3] storm git commit: Merge branch 'agresch_storm3053' of https://github.com/agresch/storm into STORM-3053-merge

2018-06-01 Thread srdo
Merge branch 'agresch_storm3053' of https://github.com/agresch/storm into STORM-3053-merge Project: http://git-wip-us.apache.org/repos/asf/storm/repo Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/b0bdbf08 Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/b0bdbf08 Diff:

[GitHub] storm issue #2686: STORM-3053 prevent race deleting blobs before topologies ...

2018-06-01 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2686 +1, thanks for addressing my nitpicks. ---

[GitHub] storm pull request #2697: STORM-3089: Describe worker hooks in documentation

2018-05-29 Thread srdo
GitHub user srdo opened a pull request: https://github.com/apache/storm/pull/2697 STORM-3089: Describe worker hooks in documentation https://issues.apache.org/jira/browse/STORM-3089 You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] storm pull request #2696: STORM-3086: Add documentation for invoking static ...

2018-05-28 Thread srdo
GitHub user srdo opened a pull request: https://github.com/apache/storm/pull/2696 STORM-3086: Add documentation for invoking static factory methods fro… …m Flux https://issues.apache.org/jira/browse/STORM-3086 You can merge this pull request into a Git repository

[GitHub] storm pull request #2695: STORM-3087: Make FluxBuilder.canInvokeWithArgs che...

2018-05-28 Thread srdo
GitHub user srdo opened a pull request: https://github.com/apache/storm/pull/2695 STORM-3087: Make FluxBuilder.canInvokeWithArgs check whether the actu… …al argument type is assignable to Number before deciding that a method with a primitive parameter can be invoked

[GitHub] storm pull request #2686: STORM-3053 prevent race deleting blobs before topo...

2018-05-26 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2686#discussion_r191042445 --- Diff: storm-server/src/main/java/org/apache/storm/DaemonConfig.java --- @@ -279,6 +279,12 @@ @isString public static final String

[GitHub] storm pull request #2686: STORM-3053 prevent race deleting blobs before topo...

2018-05-26 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2686#discussion_r191043439 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -828,12 +831,54 @@ private static boolean isTopologyActive

[GitHub] storm pull request #2686: STORM-3053 prevent race deleting blobs before topo...

2018-05-26 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2686#discussion_r191042475 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -828,12 +831,54 @@ private static boolean isTopologyActive

[GitHub] storm pull request #2686: STORM-3053 prevent race deleting blobs before topo...

2018-05-26 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2686#discussion_r191043807 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -828,12 +831,54 @@ private static boolean isTopologyActive

[GitHub] storm pull request #2686: STORM-3053 prevent race deleting blobs before topo...

2018-05-26 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2686#discussion_r191043657 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -371,6 +372,8 @@ private static final List EMPTY_STRING_LIST

[GitHub] storm pull request #2686: STORM-3053 prevent race deleting blobs before topo...

2018-05-26 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2686#discussion_r191043922 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -828,12 +831,54 @@ private static boolean isTopologyActive

[GitHub] storm pull request #2686: STORM-3053 prevent race deleting blobs before topo...

2018-05-26 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2686#discussion_r191043819 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -828,12 +831,54 @@ private static boolean isTopologyActive

[GitHub] storm pull request #2686: STORM-3053 prevent race deleting blobs before topo...

2018-05-26 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2686#discussion_r191042463 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -828,12 +831,54 @@ private static boolean isTopologyActive

[GitHub] storm issue #2687: STORM-3061: thrift 0.11

2018-05-23 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2687 +1 ---

[GitHub] storm pull request #2687: STORM-3061: thrift 0.11

2018-05-23 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2687#discussion_r190294254 --- Diff: storm-client/src/genthrift.sh --- @@ -17,7 +17,7 @@ rm -rf gen-javabean gen-py py rm -rf jvm/org/apache/storm/generated -thrift

[GitHub] storm pull request #2687: STORM-3061: thrift 0.11

2018-05-23 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2687#discussion_r190183265 --- Diff: storm-client/src/genthrift.sh --- @@ -17,7 +17,7 @@ rm -rf gen-javabean gen-py py rm -rf jvm/org/apache/storm/generated -thrift

[GitHub] storm pull request #2687: STORM-3061: thrift 0.11

2018-05-23 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2687#discussion_r190175640 --- Diff: storm-client/src/genthrift.sh --- @@ -17,7 +17,7 @@ rm -rf gen-javabean gen-py py rm -rf jvm/org/apache/storm/generated -thrift

[2/2] storm git commit: Merge branch 'STORM-3073' of https://github.com/srdo/storm into STORM-3073-merge

2018-05-21 Thread srdo
Merge branch 'STORM-3073' of https://github.com/srdo/storm into STORM-3073-merge Project: http://git-wip-us.apache.org/repos/asf/storm/repo Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/66559c6f Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/66559c6f Diff: http://git-wip

[1/2] storm git commit: STORM-3073: Uncap pendingEmits for bolt executors, and prevent LoadSpout from overflowing pendingEmits in spout executors

2018-05-21 Thread srdo
Repository: storm Updated Branches: refs/heads/master afba24e79 -> 66559c6f1 STORM-3073: Uncap pendingEmits for bolt executors, and prevent LoadSpout from overflowing pendingEmits in spout executors Project: http://git-wip-us.apache.org/repos/asf/storm/repo Commit:

[GitHub] storm issue #2676: STORM-3073: Uncap pendingEmits for bolt executors, and pr...

2018-05-21 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2676 Thanks for the quick review ---

[2/2] storm git commit: Merge branch 'master' of https://github.com/srdo/storm into STORM-3070-merge

2018-05-21 Thread srdo
Merge branch 'master' of https://github.com/srdo/storm into STORM-3070-merge Project: http://git-wip-us.apache.org/repos/asf/storm/repo Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/afba24e7 Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/afba24e7 Diff: http://git-wip

[1/2] storm git commit: STORM-3070: Rewind buffer position if MessageDecoder encounters a BackpressureStatus message code, but the rest of the message hasn't been received yet

2018-05-21 Thread srdo
Repository: storm Updated Branches: refs/heads/master fbeafdcbb -> afba24e79 STORM-3070: Rewind buffer position if MessageDecoder encounters a BackpressureStatus message code, but the rest of the message hasn't been received yet Project: http://git-wip-us.apache.org/repos/asf/storm/repo

[GitHub] storm issue #2676: STORM-3073: Uncap pendingEmits for bolt executors, and pr...

2018-05-21 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2676 @HeartSaVioR You're right, uncapped the queue in both types of executor, and removed the test code. ---

[GitHub] storm pull request #2685: STORM-1294: Port netty-unit-test to Java

2018-05-20 Thread srdo
GitHub user srdo opened a pull request: https://github.com/apache/storm/pull/2685 STORM-1294: Port netty-unit-test to Java https://issues.apache.org/jira/browse/STORM-1294 The batch-test was not being run, and wouldn't pass with the given configuration. It was disabled

[GitHub] storm pull request #2675: STORM-3061: Upgrade lots of dependencies

2018-05-20 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2675#discussion_r189455082 --- Diff: examples/storm-rocketmq-examples/src/main/java/org/apache/storm/rocketmq/trident/WordCountTrident.java --- @@ -76,19 +74,16 @@ public static

[GitHub] storm pull request #2675: STORM-3061: Upgrade lots of dependencies

2018-05-20 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2675#discussion_r189456044 --- Diff: external/storm-jms/pom.xml --- @@ -62,8 +62,7 @@ org.apache.activemq -activemq-core

[GitHub] storm issue #2669: [STORM-3055] remove conext connection cache

2018-05-16 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2669 LGTM, thanks for addressing comments ---

[GitHub] storm pull request #2633: STORM-3028 HdfsSpout: handle empty file in case of...

2018-05-16 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2633#discussion_r188594538 --- Diff: external/storm-hdfs/src/main/java/org/apache/storm/hdfs/spout/HdfsSpout.java --- @@ -221,14 +221,18 @@ public void nextTuple() { while

[GitHub] storm issue #2682: STORM-3076:Fix the bug which results in the failure of co...

2018-05-16 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2682 The travis test isn't stable outside the current master, I wouldn't worry about it on this branch. The branch you're targeting isn't the current 0.9.x branch, the current branch is https

[GitHub] storm issue #2673: STORM-3070: Rewind buffer position if MessageDecoder enco...

2018-05-15 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2673 Okay, pretty sure I've seen this break now. Ran the TVL topology and got occasional worker crashes, e.g. ``` 2018-05-15 16:36:01.018 o.a.s.m.n.StormClientHandler client-worker-1 [INFO

[GitHub] storm pull request #2669: [STORM-3055] remove conext connection cache

2018-05-15 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2669#discussion_r188377925 --- Diff: storm-client/src/jvm/org/apache/storm/messaging/IContext.java --- @@ -38,6 +38,7 @@ /** * This method establishes a server

[GitHub] storm issue #2669: [STORM-3055] remove conext connection cache

2018-05-15 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2669 As far as I can tell all connections are still being shut down with this change. The connections cached by WorkerState are closed during worker shutdown in https://github.com/apache/storm/blob

[2/2] storm git commit: Merge branch 'STORM-3072' of https://github.com/srdo/storm into STORM-3072-merge

2018-05-15 Thread srdo
Merge branch 'STORM-3072' of https://github.com/srdo/storm into STORM-3072-merge Project: http://git-wip-us.apache.org/repos/asf/storm/repo Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/14b0b4fc Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/14b0b4fc Diff: http://git-wip

[1/2] storm git commit: STORM-3072: Reduce fork count for storm-sql-core tests to 1, the tests appear to interfere

2018-05-15 Thread srdo
Repository: storm Updated Branches: refs/heads/master 53f38bc31 -> 14b0b4fc5 STORM-3072: Reduce fork count for storm-sql-core tests to 1, the tests appear to interfere Project: http://git-wip-us.apache.org/repos/asf/storm/repo Commit:

[2/9] storm-site git commit: Rebuild site

2018-05-15 Thread srdo
http://git-wip-us.apache.org/repos/asf/storm-site/blob/df5612be/content/releases/current/STORM-UI-REST-API.html -- diff --git a/content/releases/current/STORM-UI-REST-API.html b/content/releases/current/STORM-UI-REST-API.html

[7/9] storm-site git commit: Rebuild site

2018-05-15 Thread srdo
http://git-wip-us.apache.org/repos/asf/storm-site/blob/df5612be/content/releases/1.1.2/Defining-a-non-jvm-language-dsl-for-storm.html -- diff --git a/content/releases/1.1.2/Defining-a-non-jvm-language-dsl-for-storm.html

[5/9] storm-site git commit: Rebuild site

2018-05-15 Thread srdo
http://git-wip-us.apache.org/repos/asf/storm-site/blob/df5612be/content/releases/1.2.1/Setting-up-a-Storm-cluster.html -- diff --git a/content/releases/1.2.1/Setting-up-a-Storm-cluster.html

[4/9] storm-site git commit: Rebuild site

2018-05-15 Thread srdo
http://git-wip-us.apache.org/repos/asf/storm-site/blob/df5612be/content/releases/2.0.0-SNAPSHOT/Distributed-RPC.html -- diff --git a/content/releases/2.0.0-SNAPSHOT/Distributed-RPC.html

[6/9] storm-site git commit: Rebuild site

2018-05-15 Thread srdo
http://git-wip-us.apache.org/repos/asf/storm-site/blob/df5612be/content/releases/1.1.2/storm-hdfs.html -- diff --git a/content/releases/1.1.2/storm-hdfs.html b/content/releases/1.1.2/storm-hdfs.html index b1940c7..3baa2dc 100644

[3/9] storm-site git commit: Rebuild site

2018-05-15 Thread srdo
http://git-wip-us.apache.org/repos/asf/storm-site/blob/df5612be/content/releases/2.0.0-SNAPSHOT/storm-elasticsearch.html -- diff --git a/content/releases/2.0.0-SNAPSHOT/storm-elasticsearch.html

[9/9] storm-site git commit: Rebuild site

2018-05-15 Thread srdo
Rebuild site Project: http://git-wip-us.apache.org/repos/asf/storm-site/repo Commit: http://git-wip-us.apache.org/repos/asf/storm-site/commit/df5612be Tree: http://git-wip-us.apache.org/repos/asf/storm-site/tree/df5612be Diff: http://git-wip-us.apache.org/repos/asf/storm-site/diff/df5612be

[8/9] storm-site git commit: Rebuild site

2018-05-15 Thread srdo
http://git-wip-us.apache.org/repos/asf/storm-site/blob/df5612be/content/releases/1.0.6/STORM-UI-REST-API.html -- diff --git a/content/releases/1.0.6/STORM-UI-REST-API.html b/content/releases/1.0.6/STORM-UI-REST-API.html index

[1/9] storm-site git commit: Style tables so they appear similar to how they look on Github

2018-05-15 Thread srdo
Repository: storm-site Updated Branches: refs/heads/asf-site af5fa474f -> df5612be8 Style tables so they appear similar to how they look on Github Project: http://git-wip-us.apache.org/repos/asf/storm-site/repo Commit: http://git-wip-us.apache.org/repos/asf/storm-site/commit/b9737c21 Tree:

[GitHub] storm-site issue #5: Style tables so they appear similar to how they look on...

2018-05-15 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm-site/pull/5 Thanks for the reviews, I'll merge and push this to the site. @erikdw I probably should have thought to include a screenshot, thanks :) ---

[GitHub] storm pull request #2676: STORM-3073: Uncap pendingEmits for bolt executors,...

2018-05-15 Thread srdo
GitHub user srdo opened a pull request: https://github.com/apache/storm/pull/2676 STORM-3073: Uncap pendingEmits for bolt executors, and prevent LoadSpout from overflowing pendingEmits in spout executors https://issues.apache.org/jira/browse/STORM-3073 The first commit

[GitHub] storm issue #2637: STORM-3060: Map of Spout configurations from storm-kafka ...

2018-05-14 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2637 @srishtyagrawal I noticed that too, I think we can fix it by copying a bit of CSS from Github https://github.com/apache/storm-site/pull/5 ---

[GitHub] storm pull request #2674: STORM-3072: Reduce fork count for storm-sql-core t...

2018-05-14 Thread srdo
GitHub user srdo opened a pull request: https://github.com/apache/storm/pull/2674 STORM-3072: Reduce fork count for storm-sql-core tests to 1, the test… …s appear to interfere https://issues.apache.org/jira/browse/STORM-3072 You can merge this pull request into a Git

[GitHub] storm issue #2668: STORM-3065: Reduce storm-server test fork count to 1, fix...

2018-05-13 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2668 Thanks for the review. Merged to master. ---

[2/2] storm git commit: Merge branch 'STORM-3065' of https://github.com/srdo/storm into STORM-3065-merge

2018-05-13 Thread srdo
Merge branch 'STORM-3065' of https://github.com/srdo/storm into STORM-3065-merge Project: http://git-wip-us.apache.org/repos/asf/storm/repo Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/3dbc67f4 Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/3dbc67f4 Diff: http://git-wip

[1/2] storm git commit: STORM-3065: Reduce storm-server test fork count to 1, fix some test-specific NPEs

2018-05-13 Thread srdo
Repository: storm Updated Branches: refs/heads/master 5deba40fc -> 3dbc67f4c STORM-3065: Reduce storm-server test fork count to 1, fix some test-specific NPEs Project: http://git-wip-us.apache.org/repos/asf/storm/repo Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/d541e60b

[GitHub] storm-site pull request #5: Style tables so they appear similar to how they ...

2018-05-12 Thread srdo
GitHub user srdo opened a pull request: https://github.com/apache/storm-site/pull/5 Style tables so they appear similar to how they look on Github I think the table styling we have right now is hard to read. Compare the table at the bottom of https://storm.apache.org/releases

storm-site git commit: Empty commit to hopefully unstick sync between ASF repo and Github

2018-05-12 Thread srdo
Repository: storm-site Updated Branches: refs/heads/asf-site 0183bf7e1 -> af5fa474f Empty commit to hopefully unstick sync between ASF repo and Github Project: http://git-wip-us.apache.org/repos/asf/storm-site/repo Commit: http://git-wip-us.apache.org/repos/asf/storm-site/commit/af5fa474

[33/51] [partial] storm-site git commit: Rebuild content based on new 2.0.0-SNAPSHOT docs

2018-05-12 Thread srdo
http://git-wip-us.apache.org/repos/asf/storm-site/blob/0183bf7e/content/releases/2.0.0-SNAPSHOT/javadocs/org/apache/storm/ILocalCluster.html -- diff --git

[28/51] [abbrv] [partial] storm-site git commit: Publish up to date 2.0.0-SNAPSHOT documentation

2018-05-12 Thread srdo
http://git-wip-us.apache.org/repos/asf/storm-site/blob/ef81b5ca/releases/2.0.0-SNAPSHOT/javadocs/org/apache/storm/Thrift.html -- diff --git a/releases/2.0.0-SNAPSHOT/javadocs/org/apache/storm/Thrift.html

[17/51] [abbrv] [partial] storm-site git commit: Publish up to date 2.0.0-SNAPSHOT documentation

2018-05-12 Thread srdo
http://git-wip-us.apache.org/repos/asf/storm-site/blob/ef81b5ca/releases/2.0.0-SNAPSHOT/javadocs/org/apache/storm/blobstore/LocalFsBlobStoreSynchronizer.html -- diff --git

[26/51] [abbrv] [partial] storm-site git commit: Publish up to date 2.0.0-SNAPSHOT documentation

2018-05-12 Thread srdo
http://git-wip-us.apache.org/repos/asf/storm-site/blob/ef81b5ca/releases/2.0.0-SNAPSHOT/javadocs/org/apache/storm/assignments/ILocalAssignmentsBackend.html -- diff --git

[42/51] [abbrv] [partial] storm-site git commit: Publish up to date 2.0.0-SNAPSHOT documentation

2018-05-12 Thread srdo
http://git-wip-us.apache.org/repos/asf/storm-site/blob/ef81b5ca/releases/2.0.0-SNAPSHOT/javadocs/index-all.html -- diff --git a/releases/2.0.0-SNAPSHOT/javadocs/index-all.html b/releases/2.0.0-SNAPSHOT/javadocs/index-all.html

[20/51] [partial] storm-site git commit: Rebuild content based on new 2.0.0-SNAPSHOT docs

2018-05-12 Thread srdo
http://git-wip-us.apache.org/repos/asf/storm-site/blob/0183bf7e/content/releases/2.0.0-SNAPSHOT/javadocs/org/apache/storm/blobstore/BlobStore.html -- diff --git

[21/51] [partial] storm-site git commit: Rebuild content based on new 2.0.0-SNAPSHOT docs

2018-05-12 Thread srdo
http://git-wip-us.apache.org/repos/asf/storm-site/blob/0183bf7e/content/releases/2.0.0-SNAPSHOT/javadocs/org/apache/storm/blobstore/BlobStore.BlobStoreFileInputStream.html -- diff --git

[34/51] [partial] storm-site git commit: Rebuild content based on new 2.0.0-SNAPSHOT docs

2018-05-12 Thread srdo
http://git-wip-us.apache.org/repos/asf/storm-site/blob/0183bf7e/content/releases/2.0.0-SNAPSHOT/javadocs/org/apache/storm/ExclamationTopology.ExclamationBolt.html -- diff --git

[37/51] [partial] storm-site git commit: Rebuild content based on new 2.0.0-SNAPSHOT docs

2018-05-12 Thread srdo
http://git-wip-us.apache.org/repos/asf/storm-site/blob/0183bf7e/content/releases/2.0.0-SNAPSHOT/javadocs/org/apache/storm/Config.html -- diff --git a/content/releases/2.0.0-SNAPSHOT/javadocs/org/apache/storm/Config.html

[12/51] [partial] storm-site git commit: Rebuild content based on new 2.0.0-SNAPSHOT docs

2018-05-12 Thread srdo
http://git-wip-us.apache.org/repos/asf/storm-site/blob/0183bf7e/content/releases/2.0.0-SNAPSHOT/javadocs/org/apache/storm/blobstore/NimbusBlobStore.html -- diff --git

[28/51] [partial] storm-site git commit: Rebuild content based on new 2.0.0-SNAPSHOT docs

2018-05-12 Thread srdo
http://git-wip-us.apache.org/repos/asf/storm-site/blob/0183bf7e/content/releases/2.0.0-SNAPSHOT/javadocs/org/apache/storm/StormTimer.StormTimerTask.html -- diff --git

[22/51] [partial] storm-site git commit: Rebuild content based on new 2.0.0-SNAPSHOT docs

2018-05-12 Thread srdo
http://git-wip-us.apache.org/repos/asf/storm-site/blob/0183bf7e/content/releases/2.0.0-SNAPSHOT/javadocs/org/apache/storm/assignments/class-use/ILocalAssignmentsBackend.html -- diff --git

<    3   4   5   6   7   8   9   10   11   12   >