Re: [PR] Test for reading read statistics from parquet files without statistics [datafusion]

2024-05-21 Thread via GitHub
alamb commented on PR #10608: URL: https://github.com/apache/datafusion/pull/10608#issuecomment-2123435559 This PR also appears to have a conflict now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[PR] KAFKA-16809: Run Javadoc in CI [kafka]

2024-05-21 Thread via GitHub
gharris1727 opened a new pull request, #16025: URL: https://github.com/apache/kafka/pull/16025 Until now, javadoc warnings can be added in PRs, and are only noticed when someone else runs `./gradlew javadoc`. Now introducing problems in javadocs will immediately fail the PR CI build,

Re: [PR] HIVE-28271: DirectSql fails for AlterPartitions. [hive]

2024-05-21 Thread via GitHub
ayushtkn commented on PR #5256: URL: https://github.com/apache/hive/pull/5256#issuecomment-2123433971 cc. @wecharyu -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] Create a geoparquet module and add dependencies [incubator-baremaps]

2024-05-21 Thread via GitHub
bchapuis opened a new pull request, #855: URL: https://github.com/apache/incubator-baremaps/pull/855 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Improve `UserDefinedLogicalNodeCore::from_template` API to return Result [datafusion]

2024-05-21 Thread via GitHub
alamb commented on PR #10597: URL: https://github.com/apache/datafusion/pull/10597#issuecomment-2123433357 I took the liberty of merging this branch up from main to resolve a conflict. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] DRAFT: Parquet 3 metadata with decoupled column metadata [parquet-format]

2024-05-21 Thread via GitHub
emkornfield commented on code in PR #242: URL: https://github.com/apache/parquet-format/pull/242#discussion_r1608945075 ## src/main/thrift/parquet.thrift: ## @@ -1165,6 +1317,62 @@ struct FileMetaData { 9: optional binary footer_signing_key_metadata } +/** Metadata for a

Re: [I] [2.17.1] AsyncLogger thread is stuck on 100% CPU on lmax-34. queue polling (logging-log4j2)

2024-05-21 Thread via GitHub
ppkarwasz commented on issue #2169: URL: https://github.com/apache/logging-log4j2/issues/2169#issuecomment-2123431545 The documentation of `Yield` was fixed in #2577 . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [I] [2.17.1] AsyncLogger thread is stuck on 100% CPU on lmax-34. queue polling (logging-log4j2)

2024-05-21 Thread via GitHub
ppkarwasz closed issue #2169: [2.17.1] AsyncLogger thread is stuck on 100% CPU on lmax-34. queue polling URL: https://github.com/apache/logging-log4j2/issues/2169 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [I] Kernel Build Apps [nuttx]

2024-05-21 Thread via GitHub
MainframeReboot commented on issue #12356: URL: https://github.com/apache/nuttx/issues/12356#issuecomment-2123431521 Thanks for your reply @acassis. I can definitely look into a blog post of my findings once I get this to work! I took a look, and I am not sure where the init ELF is

Re: [PR] [GOBBLIN-2070] Add eventTimeMillis field to leaseAttemptStatus for adhoc flows where… [gobblin]

2024-05-21 Thread via GitHub
arjun4084346 merged PR #3951: URL: https://github.com/apache/gobblin/pull/3951 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Update shields on README [trafficserver]

2024-05-21 Thread via GitHub
moonchen merged PR #11380: URL: https://github.com/apache/trafficserver/pull/11380 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HDDS-10890. [hsync] Increase default value for hdds.container.ratis.log.appender.queue.num-elements. [ozone]

2024-05-21 Thread via GitHub
jojochuang commented on PR #6711: URL: https://github.com/apache/ozone/pull/6711#issuecomment-2123429860 With this configuration, 1 client thread: sudo -u hdfs ozone freon dne --clients=32 --container-id=4 -t 1 -n 100 --ratis --sleep-time-ms=0 mean rate =

Re: [PR] GH-41681: [GLib] Generate separate version macros for each GLib library [arrow]

2024-05-21 Thread via GitHub
kou commented on code in PR #41721: URL: https://github.com/apache/arrow/pull/41721#discussion_r1608942594 ## dev/release/utils-prepare.sh: ## @@ -40,6 +40,15 @@ update_versions() { meson.build rm -f meson.build.bak git add meson.build + +

Re: [PR] Improve `UserDefinedLogicalNodeCore::from_template` API to return Result [datafusion]

2024-05-21 Thread via GitHub
alamb commented on code in PR #10597: URL: https://github.com/apache/datafusion/pull/10597#discussion_r1608941760 ## datafusion/expr/src/logical_plan/extension.rs: ## @@ -248,23 +248,27 @@ pub trait UserDefinedLogicalNodeCore: /// For example: `TopK: k=10` fn

Re: [I] Stateless prepared statements wrap `DoPutPreparedStatementResult` with `Any` which is differs from Go implementation [arrow-rs]

2024-05-21 Thread via GitHub
zeroshade commented on issue #5731: URL: https://github.com/apache/arrow-rs/issues/5731#issuecomment-2123428663 I think in the current situation I think that unless we can get alignment across the ecosystem fairly quickly, it might make the most sense for us first to get the Go

Re: [PR] View: add property to describe advisory read mode [iceberg]

2024-05-21 Thread via GitHub
rdblue commented on PR #10362: URL: https://github.com/apache/iceberg/pull/10362#issuecomment-2123427489 Can you give an example? I can't think of any pushdown operation that exposes data to user code. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [MNG-7902] Sort plugins in the validation report [maven]

2024-05-21 Thread via GitHub
slawekjaranowski commented on code in PR #1510: URL: https://github.com/apache/maven/pull/1510#discussion_r1608940037 ## maven-core/src/main/java/org/apache/maven/plugin/internal/DefaultPluginValidationManager.java: ## @@ -23,17 +23,7 @@ import java.nio.file.Path; import

Re: [PR] KAFKA-16739: Exclude protected members from aggregated release Javadocs [kafka]

2024-05-21 Thread via GitHub
gharris1727 merged PR #15940: URL: https://github.com/apache/kafka/pull/15940 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] FINERACT-1932: Fineract modularization - fineract-charge [fineract]

2024-05-21 Thread via GitHub
adamsaghy merged PR #3897: URL: https://github.com/apache/fineract/pull/3897 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16739: Exclude protected members from aggregated release Javadocs [kafka]

2024-05-21 Thread via GitHub
gharris1727 commented on PR #15940: URL: https://github.com/apache/kafka/pull/15940#issuecomment-2123422940 Build passes, CI test failures appear unrelated, and this passes for me locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Improve modularization [incubator-baremaps]

2024-05-21 Thread via GitHub
bchapuis merged PR #852: URL: https://github.com/apache/incubator-baremaps/pull/852 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [NIFI-13247] - Property Verification [nifi]

2024-05-21 Thread via GitHub
mcgilman commented on code in PR #8857: URL: https://github.com/apache/nifi/pull/8857#discussion_r1608849065 ##

[PR] HDDS-10890. [hsync] Increase default value for hdds.container.ratis.log.appender.queue.num-elements. [ozone]

2024-05-21 Thread via GitHub
jojochuang opened a new pull request, #6711: URL: https://github.com/apache/ozone/pull/6711 ## What changes were proposed in this pull request? HDDS-10890. [hsync] Increase default value for hdds.container.ratis.log.appender.queue.num-elements. Please describe your PR in

Re: [PR] Updating refereces from parquet-mr -> parquet-java [parquet-site]

2024-05-21 Thread via GitHub
emkornfield commented on code in PR #60: URL: https://github.com/apache/parquet-site/pull/60#discussion_r1608936158 ## content/en/docs/Overview/_index.md: ## @@ -18,14 +18,14 @@ The parquet-format repository hosts the official specification of the Apache Par As a repository

Re: [PR] feat: extend `unnest` to support Struct datatype [datafusion]

2024-05-21 Thread via GitHub
duongcongtoai commented on code in PR #10429: URL: https://github.com/apache/datafusion/pull/10429#discussion_r1608935540 ## datafusion/expr/src/expr_schema.rs: ## @@ -123,7 +123,8 @@ impl ExprSchemable for Expr { Ok(field.data_type().clone())

[PR] added pytest.mark.flaky for test_big_query_write_temp_table_append_sc… [beam]

2024-05-21 Thread via GitHub
liferoad opened a new pull request, #31364: URL: https://github.com/apache/beam/pull/31364 …hema_update following https://github.com/apache/beam/pull/31350, retry the entire test for now. Thank you for your contribution! Follow this checklist to

Re: [PR] [WIP][SPARK-47353][SQL] Enable collation support for the Mode expression using GroupMapReduce [spark]

2024-05-21 Thread via GitHub
GideonPotok commented on PR #46597: URL: https://github.com/apache/spark/pull/46597#issuecomment-2123419758 @uros-db I have made changes for all but your latest suggestion (re whitelists -- will add that soon) -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] KAFKA-15974: Enforce that event processing respects user-provided timeout [kafka]

2024-05-21 Thread via GitHub
kirktrue commented on code in PR #15640: URL: https://github.com/apache/kafka/pull/15640#discussion_r1608934073 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -281,64 +276,15 @@ void testEnsureMetadataUpdateOnPoll() {

Re: [PR] Implement a dialect-specific rule for unparsing an identifier with or without quotes [datafusion]

2024-05-21 Thread via GitHub
alamb commented on code in PR #10573: URL: https://github.com/apache/datafusion/pull/10573#discussion_r1608928216 ## datafusion-examples/examples/plan_to_sql.rs: ## @@ -52,7 +52,7 @@ fn simple_expr_to_sql_demo() -> Result<()> { let expr =

Re: [PR] [SPARK-48220][PYTHON] Allow passing PyArrow Table to createDataFrame() [spark]

2024-05-21 Thread via GitHub
ianmcook commented on PR #46529: URL: https://github.com/apache/spark/pull/46529#issuecomment-2123415459 Here is a PDF of the Apache Arrow in PySpark user guide page rendered from this PR: [Apache Arrow in PySpark — PySpark master

Re: [PR] Bump mongodb.version from 5.0.1 to 5.1.0 (logging-log4j2)

2024-05-21 Thread via GitHub
ppkarwasz commented on PR #2554: URL: https://github.com/apache/logging-log4j2/pull/2554#issuecomment-2123414803 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] The PostCommit XVR PythonUsingJavaSQL Dataflow job is flaky [beam]

2024-05-21 Thread via GitHub
Abacn closed issue #30593: The PostCommit XVR PythonUsingJavaSQL Dataflow job is flaky URL: https://github.com/apache/beam/issues/30593 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Decrypt account and domain configurations when needed [cloudstack]

2024-05-21 Thread via GitHub
blueorangutan commented on PR #9088: URL: https://github.com/apache/cloudstack/pull/9088#issuecomment-2123414115 @weizhouapache a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

Re: [I] The PostCommit XVR Samza job is flaky [beam]

2024-05-21 Thread via GitHub
Abacn closed issue #30601: The PostCommit XVR Samza job is flaky URL: https://github.com/apache/beam/issues/30601 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [I] The PostCommit Java Nexmark Dataflow job is flaky [beam]

2024-05-21 Thread via GitHub
Abacn closed issue #30606: The PostCommit Java Nexmark Dataflow job is flaky URL: https://github.com/apache/beam/issues/30606 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] The PostCommit XVR Spark3 job is flaky [beam]

2024-05-21 Thread via GitHub
Abacn closed issue #30602: The PostCommit XVR Spark3 job is flaky URL: https://github.com/apache/beam/issues/30602 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Decrypt account and domain configurations when needed [cloudstack]

2024-05-21 Thread via GitHub
weizhouapache commented on PR #9088: URL: https://github.com/apache/cloudstack/pull/9088#issuecomment-2123411755 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] HADOOP-18508. S3A: Support parallel integration test runs on same bucket [hadoop]

2024-05-21 Thread via GitHub
mukund-thakur commented on PR #5081: URL: https://github.com/apache/hadoop/pull/5081#issuecomment-2123413022 These two tests are failing on trunk as well. `[ERROR] testEverything(org.apache.hadoop.fs.s3a.commit.ITestS3ACommitterFactory) Time elapsed: 6.661 s <<< FAILURE!

Re: [PR] [NIFI-13257] codemirror light and dark mode theme [nifi]

2024-05-21 Thread via GitHub
rfellows commented on code in PR #8855: URL: https://github.com/apache/nifi/pull/8855#discussion_r1608930171 ## nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/assets/styles/_codemirror-theme.scss: ## Review Comment: I logged this JIRA for

Re: [PR] Run tests for Providers also for Airflow 2.8 [airflow]

2024-05-21 Thread via GitHub
potiuk commented on PR #39606: URL: https://github.com/apache/airflow/pull/39606#issuecomment-2123410713 > @potiuk Airflow 2.8.4 requires (constraints) universal-path 0.1.4 which is indeed not compatible with python 3.12. However., I am not sure if this is related. The `namespace` property

Re: [PR] HADOOP-18508. S3A: Support parallel integration test runs on same bucket [hadoop]

2024-05-21 Thread via GitHub
mukund-thakur commented on PR #5081: URL: https://github.com/apache/hadoop/pull/5081#issuecomment-2123411289 Re-ran parallelly in two terminals and I think we are good apart from the above failure. and the above test passes in my trunk branch. -- This is an automated message from

Re: [PR] move timezone support to extension [arrow-julia]

2024-05-21 Thread via GitHub
omus commented on PR #482: URL: https://github.com/apache/arrow-julia/pull/482#issuecomment-2123410362 It looks like the use of `@tz_str` is the issue at the moment. I updated to use `TimeZone(...)` and got this: ```julia julia> @time @time_imports using Arrow ... 25.9 ms

Re: [PR] move timezone support to extension [arrow-julia]

2024-05-21 Thread via GitHub
omus commented on PR #482: URL: https://github.com/apache/arrow-julia/pull/482#issuecomment-2123406667 With the release of TimeZones.jl 1.16 I decide to re-run the timings Julia 1.9.4 with TimeZones 1.15: ```julia (Arrow) pkg> st Project Arrow v2.7.2 Status

Re: [I] c: define async version of ArrowArrayStream [arrow-adbc]

2024-05-21 Thread via GitHub
zeroshade commented on issue #811: URL: https://github.com/apache/arrow-adbc/issues/811#issuecomment-2123404768 @CurtHagenlocher @lidavidm What do you two think about the following idea: ```c++ struct AsyncArrowStream { int (*on_schema)(struct AsyncArrowStream* self, struct

Re: [PR] Fix kie-issues #1217 - Replace quay.io with docker.io [incubator-kie-kogito-runtimes]

2024-05-21 Thread via GitHub
porcelli commented on code in PR #3525: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3525#discussion_r1608926340 ## quarkus/addons/tracing-decision/deployment/src/main/resources/application.properties: ## @@ -17,4 +17,4 @@ # under the License. #

Re: [PR] feat: RewriteCycle API for short-circuiting optimizer loops [datafusion]

2024-05-21 Thread via GitHub
alamb commented on PR #10386: URL: https://github.com/apache/datafusion/pull/10386#issuecomment-2123403077 Is this PR ready for the next round of review @erratic-pattern ? Or do you plan to make further changes to it? -- This is an automated message from the Apache Git Service. To

Re: [PR] KAFKA-15045: (KIP-924 pt. 8) Added TopicPartitionAssignmentInfo [kafka]

2024-05-21 Thread via GitHub
apourchet commented on code in PR #16024: URL: https://github.com/apache/kafka/pull/16024#discussion_r1608924234 ## streams/src/main/java/org/apache/kafka/streams/processor/assignment/TopicPartitionAssignmentInfo.java: ## @@ -0,0 +1,45 @@ +package

Re: [PR] feat: extend unnest to support Struct datatype [datafusion]

2024-05-21 Thread via GitHub
alamb commented on code in PR #10429: URL: https://github.com/apache/datafusion/pull/10429#discussion_r1608917787 ## datafusion/sqllogictest/test_files/unnest.slt: ## @@ -288,6 +308,18 @@ select unnest(array_remove(column1, 12)) from unnest_table; 5 6 +## unnest

Re: [PR] Fix kie-issues #1217 - Replace quay.io with docker.io [incubator-kie-kogito-runtimes]

2024-05-21 Thread via GitHub
ricardozanini commented on code in PR #3525: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3525#discussion_r1608922285 ## quarkus/addons/tracing-decision/integration-tests/src/test/resources/application.properties: ## @@ -31,6 +31,6 @@

Re: [PR] Fix kie-issues #1217 - Replace quay.io with docker.io [incubator-kie-kogito-runtimes]

2024-05-21 Thread via GitHub
ricardozanini commented on code in PR #3525: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3525#discussion_r1608922041 ## quarkus/addons/tracing-decision/deployment/src/main/resources/application.properties: ## @@ -17,4 +17,4 @@ # under the License. #

Re: [PR] KAFKA-16515: Fix the ZK Metadata cache confusion between brokers and controllers [kafka]

2024-05-21 Thread via GitHub
cmccabe commented on code in PR #16006: URL: https://github.com/apache/kafka/pull/16006#discussion_r1608921813 ## core/src/main/scala/kafka/server/metadata/ZkMetadataCache.scala: ## @@ -350,11 +347,7 @@ class ZkMetadataCache( override def getAliveBrokerNode(brokerId: Int,

Re: [PR] feat(table): Table with Time Comparison [superset]

2024-05-21 Thread via GitHub
github-actions[bot] commented on PR #28057: URL: https://github.com/apache/superset/pull/28057#issuecomment-2123398229 @Antonio-RiveroMartnez Ephemeral environment spinning up at http://34.210.222.153:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and

Re: [PR] [MNG-7902] Sort plugins in the validation report [maven]

2024-05-21 Thread via GitHub
gnodet commented on code in PR #1510: URL: https://github.com/apache/maven/pull/1510#discussion_r1608920864 ## maven-core/src/main/java/org/apache/maven/plugin/internal/DefaultPluginValidationManager.java: ## @@ -222,7 +212,12 @@ private void

Re: [PR] Bump pymysql from 1.1.0 to 1.1.1 in /sdks/python/container/py311 [beam]

2024-05-21 Thread via GitHub
github-actions[bot] commented on PR #31361: URL: https://github.com/apache/beam/pull/31361#issuecomment-2123397629 Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers` -- This is an automated

Re: [PR] [HUDI-7774] Add Avro Logical type support for Merciful Java convertor [hudi]

2024-05-21 Thread via GitHub
yihua commented on code in PR #11265: URL: https://github.com/apache/hudi/pull/11265#discussion_r1608917941 ## hudi-common/src/main/java/org/apache/hudi/avro/AvroLogicalTypeEnum.java: ## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[I] Adapt KIE Tools release jobs to sign and upload release candidate artifacts to dist.apache.org [incubator-kie-issues]

2024-05-21 Thread via GitHub
rodrigonull opened a new issue, #1245: URL: https://github.com/apache/incubator-kie-issues/issues/1245 As part of the release automation process for Apache KIE 10 release we need to adapt the existing release jobs to sign the artifacts and upload them to

Re: [PR] KAFKA-15045: (KIP-924 pt. 8) Added TopicPartitionAssignmentInfo [kafka]

2024-05-21 Thread via GitHub
apourchet commented on code in PR #16024: URL: https://github.com/apache/kafka/pull/16024#discussion_r1608918902 ## streams/src/main/java/org/apache/kafka/streams/processor/assignment/TopicPartitionAssignmentInfo.java: ## @@ -0,0 +1,45 @@ +package

Re: [PR] KAFKA-16516: Fix the controller node provider for broker to control channel [kafka]

2024-05-21 Thread via GitHub
cmccabe commented on PR #16008: URL: https://github.com/apache/kafka/pull/16008#issuecomment-2123394515 > Are there any tests that we should add or do the existing test cover this functionality? I think there are some that cover it already, but I added a test of controller failover

Re: [PR] KAFKA-15045: (KIP-924 pt. 8) Added TopicPartitionAssignmentInfo [kafka]

2024-05-21 Thread via GitHub
ableegoldman commented on code in PR #16024: URL: https://github.com/apache/kafka/pull/16024#discussion_r1608917448 ## streams/src/main/java/org/apache/kafka/streams/processor/assignment/TopicPartitionAssignmentInfo.java: ## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache

Re: [I] AIP-44 Migrate TaskInstance.schedule_downstream_tasks to Internal API [airflow]

2024-05-21 Thread via GitHub
potiuk commented on issue #29308: URL: https://github.com/apache/airflow/issues/29308#issuecomment-2123391216 Yes. I think it should be done like that AIP-44 goal is not to improve performance but increase isolation, so removing of mini-scheduler is likely a good idea. -- This is an

Re: [PR] Add metrics for scan server reservation write out time and collisions [accumulo]

2024-05-21 Thread via GitHub
DomGarguilo commented on PR #4577: URL: https://github.com/apache/accumulo/pull/4577#issuecomment-2123388801 @keith-turner, I reimplemented things based on your feedback. Was able to see these values when metrics were set to be logged: ``` METRICS: 2024-05-21T16:23:46,854,

Re: [PR] [Java] Add warning to gcpTempLocation when its bucket has soft delete enabled [beam]

2024-05-21 Thread via GitHub
damccorm merged PR #31358: URL: https://github.com/apache/beam/pull/31358 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Bump org.apache.logging:logging-parent from 11.0.0 to 11.1.0 [logging-log4j-jakarta]

2024-05-21 Thread via GitHub
github-actions[bot] merged PR #31: URL: https://github.com/apache/logging-log4j-jakarta/pull/31 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Fix acknowledged functionality in deferrable mode for PubSubPullSensor [airflow]

2024-05-21 Thread via GitHub
potiuk merged PR #39711: URL: https://github.com/apache/airflow/pull/39711 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [HUDI-7774] Add Avro Logical type support for Merciful Java convertor [hudi]

2024-05-21 Thread via GitHub
Davis-Zhang-Onehouse commented on code in PR #11265: URL: https://github.com/apache/hudi/pull/11265#discussion_r1608799784 ## hudi-common/src/main/java/org/apache/hudi/avro/MercifulJsonConverter.java: ## @@ -187,196 +178,774 @@ private static Object

Re: [I] Ruby driver [age]

2024-05-21 Thread via GitHub
btihen commented on issue #370: URL: https://github.com/apache/age/issues/370#issuecomment-2123384540 An early first version `0.1.0` of a rails plugin / gem can be found at: https://rubygems.org/gems/rails_age It does not yet support all features, but Edges and Nodes are workable.

Re: [PR] KAFKA-15045: (KIP-924 pt. 8) Added TopicPartitionAssignmentInfo [kafka]

2024-05-21 Thread via GitHub
ableegoldman commented on code in PR #16024: URL: https://github.com/apache/kafka/pull/16024#discussion_r1608911390 ## streams/src/main/java/org/apache/kafka/streams/processor/assignment/TopicPartitionAssignmentInfo.java: ## @@ -0,0 +1,45 @@ +package

Re: [PR] KAFKA-15974: Enforce that event processing respects user-provided timeout [kafka]

2024-05-21 Thread via GitHub
lianetm commented on code in PR #15640: URL: https://github.com/apache/kafka/pull/15640#discussion_r1608897877 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -281,64 +276,15 @@ void testEnsureMetadataUpdateOnPoll() {

Re: [PR] KAFKA-15974: Enforce that event processing respects user-provided timeout [kafka]

2024-05-21 Thread via GitHub
lianetm commented on code in PR #15640: URL: https://github.com/apache/kafka/pull/15640#discussion_r1608897877 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -281,64 +276,15 @@ void testEnsureMetadataUpdateOnPoll() {

Re: [PR] TEZ-4566: NPE in TezChild while fetching attemptId when container is asked to shut down [tez]

2024-05-21 Thread via GitHub
ayushtkn commented on PR #358: URL: https://github.com/apache/tez/pull/358#issuecomment-2123380280 Ran the tests locally **tez-dag** ``` INFO] --- surefire:3.0.0-M4:test (default-test) @ tez-dag --- [INFO] [INFO] ---

Re: [PR] feat(rust): add the driver manager [arrow-adbc]

2024-05-21 Thread via GitHub
alexandreyc commented on PR #1803: URL: https://github.com/apache/arrow-adbc/pull/1803#issuecomment-2123379544 @lidavidm Is there anything you want me to change before merging this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] feat(table): Table with Time Comparison [superset]

2024-05-21 Thread via GitHub
Antonio-RiveroMartnez commented on PR #28057: URL: https://github.com/apache/superset/pull/28057#issuecomment-2123379418 /testenv up FEATURE_CHART_PLUGINS_EXPERIMENTAL=true -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Fix `Coalesce` casting logic to follows what Postgres and DuckDB do. Introduce signature that do non-comparison coercion [datafusion]

2024-05-21 Thread via GitHub
alamb commented on PR #10268: URL: https://github.com/apache/datafusion/pull/10268#issuecomment-2123378506 Basically I worry this is just changing behavior rather than fixing a bug and will result in churn for no benefit downstream. I may be mis understanding the change and rationale

Re: [PR] KAFKA-16793: Heartbeat API for upgrading ConsumerGroup [kafka]

2024-05-21 Thread via GitHub
dongnuo123 commented on code in PR #15988: URL: https://github.com/apache/kafka/pull/15988#discussion_r1608908254 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -4209,31 +4241,67 @@ private void removePendingSyncMember(

Re: [PR] KAFKA-15905 Restarts of MirrorCheckpointTask should not permanently i… [kafka]

2024-05-21 Thread via GitHub
edoardocomar commented on code in PR #15910: URL: https://github.com/apache/kafka/pull/15910#discussion_r1608907673 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/OffsetSyncStoreTest.java: ## @@ -82,77 +86,131 @@ public void testOffsetTranslation() {

Re: [PR] Fix `Coalesce` casting logic to follows what Postgres and DuckDB do. Introduce signature that do non-comparison coercion [datafusion]

2024-05-21 Thread via GitHub
alamb commented on PR #10268: URL: https://github.com/apache/datafusion/pull/10268#issuecomment-2123377440 In general I am concerned about the potential downstream effects of this change. I don't fully understand them What I would ideally like to do is to run the influxdb_iox

Re: [PR] KAFKA-16516: Fix the controller node provider for broker to control channel [kafka]

2024-05-21 Thread via GitHub
cmccabe commented on code in PR #16008: URL: https://github.com/apache/kafka/pull/16008#discussion_r1608907374 ## core/src/main/scala/kafka/raft/RaftManager.scala: ## @@ -313,4 +314,8 @@ class KafkaRaftManager[T]( override def leaderAndEpoch: LeaderAndEpoch = {

[PR] Bump org.apache.logging:logging-parent from 11.0.0 to 11.1.0 [logging-log4j-jakarta]

2024-05-21 Thread via GitHub
dependabot[bot] opened a new pull request, #31: URL: https://github.com/apache/logging-log4j-jakarta/pull/31 Bumps [org.apache.logging:logging-parent](https://github.com/apache/logging-parent) from 11.0.0 to 11.1.0. Commits

Re: [PR] KAFKA-16793: Heartbeat API for upgrading ConsumerGroup [kafka]

2024-05-21 Thread via GitHub
dongnuo123 commented on code in PR #15988: URL: https://github.com/apache/kafka/pull/15988#discussion_r1608907132 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -4274,6 +4342,77 @@ private void

Re: [PR] KAFKA-15905 Restarts of MirrorCheckpointTask should not permanently i… [kafka]

2024-05-21 Thread via GitHub
edoardocomar commented on code in PR #15910: URL: https://github.com/apache/kafka/pull/15910#discussion_r1608896699 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/OffsetSyncStoreTest.java: ## @@ -82,77 +86,131 @@ public void testOffsetTranslation() {

Re: [PR] DRAFT: Parquet 3 metadata with decoupled column metadata [parquet-format]

2024-05-21 Thread via GitHub
emkornfield commented on code in PR #242: URL: https://github.com/apache/parquet-format/pull/242#discussion_r1608906723 ## README.md: ## @@ -107,12 +113,97 @@ start locations. More details on what is contained in the metadata can be found in the Thrift definition.

Re: [PR] feat: support `grouping` aggregate function [datafusion]

2024-05-21 Thread via GitHub
alamb commented on code in PR #10208: URL: https://github.com/apache/datafusion/pull/10208#discussion_r1608905520 ## datafusion/physical-expr/src/aggregate/grouping.rs: ## @@ -96,8 +113,172 @@ impl PartialEq for Grouping { self.name == x.name

Re: [PR] KAFKA-16516: Fix the controller node provider for broker to control channel [kafka]

2024-05-21 Thread via GitHub
cmccabe commented on code in PR #16008: URL: https://github.com/apache/kafka/pull/16008#discussion_r1608906143 ## raft/src/main/java/org/apache/kafka/raft/internals/VoterSet.java: ## @@ -366,4 +368,16 @@ public static VoterSet fromInetSocketAddresses(String listener, Map

Re: [PR] DRAFT: Parquet 3 metadata with decoupled column metadata [parquet-format]

2024-05-21 Thread via GitHub
emkornfield commented on code in PR #242: URL: https://github.com/apache/parquet-format/pull/242#discussion_r1608904923 ## src/main/thrift/parquet.thrift: ## @@ -467,6 +467,35 @@ struct SchemaElement { 10: optional LogicalType logicalType } +struct SchemaElementV3 { +

Re: [PR] KAFKA-16516: Fix the controller node provider for broker to control channel [kafka]

2024-05-21 Thread via GitHub
cmccabe commented on code in PR #16008: URL: https://github.com/apache/kafka/pull/16008#discussion_r1608904666 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -2548,6 +2549,10 @@ public OptionalLong highWatermark() { } } +public

Re: [PR] Open NoOpBarrierStep for extensibility [tinkerpop]

2024-05-21 Thread via GitHub
xiazcy commented on PR #2612: URL: https://github.com/apache/tinkerpop/pull/2612#issuecomment-2123372810 VOTE +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] removed stale code [airflow]

2024-05-21 Thread via GitHub
potiuk merged PR #39744: URL: https://github.com/apache/airflow/pull/39744 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16515: Fix the ZK Metadata cache confusion between brokers and controllers [kafka]

2024-05-21 Thread via GitHub
jsancio commented on code in PR #16006: URL: https://github.com/apache/kafka/pull/16006#discussion_r1608902290 ## core/src/main/scala/kafka/server/metadata/ZkMetadataCache.scala: ## @@ -350,11 +347,7 @@ class ZkMetadataCache( override def getAliveBrokerNode(brokerId: Int,

Re: [PR] KAFKA-15045: (KIP-924 pt. 6) Post process new assignment structure [kafka]

2024-05-21 Thread via GitHub
ableegoldman merged PR #16002: URL: https://github.com/apache/kafka/pull/16002 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] [Parquet][C++] Behaviour of unknown logical type when encountered in Parquet reader [arrow]

2024-05-21 Thread via GitHub
jorisvandenbossche commented on issue #41764: URL: https://github.com/apache/arrow/issues/41764#issuecomment-2123367801 You can actually reproduce this easily with the new float16 logical type, by writing it with the latest Arrow: ```python >>> table = pa.table({"a":np.array([0.1,

Re: [I] Support `date_bin` on timestamps with timezone, properly accounting for Daylight Savings Time [datafusion]

2024-05-21 Thread via GitHub
appletreeisyellow commented on issue #10602: URL: https://github.com/apache/datafusion/issues/10602#issuecomment-2123367235 I'd like to work on this issue ‍♀️ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] KAFKA-15045: (KIP-924 pt. 6) Post process new assignment structure [kafka]

2024-05-21 Thread via GitHub
ableegoldman commented on PR #16002: URL: https://github.com/apache/kafka/pull/16002#issuecomment-2123367972 Test failures are unrelated, merging to trunk Worth noting that the `org.apache.kafka.streams.processor.internals.assignment.TaskAssignorConvergenceTest` did fail, which may

Re: [PR] Add back 'numRowsResultSet' to BrokerResponse, and retain it when result table is hidden [pinot]

2024-05-21 Thread via GitHub
klsince commented on code in PR #13198: URL: https://github.com/apache/pinot/pull/13198#discussion_r1608900537 ## pinot-common/src/main/java/org/apache/pinot/common/response/broker/BrokerResponseNativeV2.java: ## @@ -83,6 +84,16 @@ public ResultTable getResultTable() {

[Github-comments] [geany/geany] I have just solved my socket problem in my computer. (Issue #3880)

2024-05-21 Thread Sergio Abreu A. via Github-comments
As the conflict was between my normal user and root (which **all linux users will have**) I decided to take action: 1) Wrote a Perl script that finds the owner of the file passed in the argument If is root, appends a **sudo** in front of the command 2) Replaced "geany %F" in

Re: [PR] KAFKA-16516: Fix the controller node provider for broker to control channel [kafka]

2024-05-21 Thread via GitHub
jsancio commented on code in PR #16008: URL: https://github.com/apache/kafka/pull/16008#discussion_r1608891761 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -2548,6 +2549,10 @@ public OptionalLong highWatermark() { } } +public

Re: [PR] PARQUET-2473: Clarify records can not be split across v2 pages or PageIndex [parquet-format]

2024-05-21 Thread via GitHub
etseidl commented on code in PR #244: URL: https://github.com/apache/parquet-format/pull/244#discussion_r1608899535 ## src/main/thrift/parquet.thrift: ## @@ -995,8 +1005,9 @@ struct PageLocation { 2: required i32 compressed_page_size /** - * Index within the RowGroup

Re: [PR] KAFKA-15974: Enforce that event processing respects user-provided timeout [kafka]

2024-05-21 Thread via GitHub
lianetm commented on code in PR #15640: URL: https://github.com/apache/kafka/pull/15640#discussion_r1608897877 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -281,64 +276,15 @@ void testEnsureMetadataUpdateOnPoll() {

Re: [PR] KAFKA-15974: Enforce that event processing respects user-provided timeout [kafka]

2024-05-21 Thread via GitHub
lianetm commented on code in PR #15640: URL: https://github.com/apache/kafka/pull/15640#discussion_r1608897877 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -281,64 +276,15 @@ void testEnsureMetadataUpdateOnPoll() {

Re: [PR] KAFKA-15974: Enforce that event processing respects user-provided timeout [kafka]

2024-05-21 Thread via GitHub
lianetm commented on code in PR #15640: URL: https://github.com/apache/kafka/pull/15640#discussion_r1608897877 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -281,64 +276,15 @@ void testEnsureMetadataUpdateOnPoll() {

Re: [PR] KAFKA-15905 Restarts of MirrorCheckpointTask should not permanently i… [kafka]

2024-05-21 Thread via GitHub
edoardocomar commented on code in PR #15910: URL: https://github.com/apache/kafka/pull/15910#discussion_r1608896699 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/OffsetSyncStoreTest.java: ## @@ -82,77 +86,131 @@ public void testOffsetTranslation() {

<    1   2   3   4   5   6   7   8   9   10   >