Re: [PR] [SPARK-48220][PYTHON] Allow passing PyArrow Table to createDataFrame() [spark]

2024-05-21 Thread via GitHub
ianmcook commented on code in PR #46529: URL: https://github.com/apache/spark/pull/46529#discussion_r1608812796 ## python/pyspark/sql/pandas/conversion.py: ## @@ -236,15 +236,15 @@ def toArrow(self) -> "pa.Table": from pyspark.sql.pandas.utils import

Re: [PR] [fix](short circurt) fix return default value issue [doris]

2024-05-21 Thread via GitHub
doris-robot commented on PR #34186: URL: https://github.com/apache/doris/pull/34186#issuecomment-2123254911 TPC-DS: Total hot run time: 181354 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] KAFKA-16452: Don't throw OOORE when converting the offset to metadata [kafka]

2024-05-21 Thread via GitHub
kamalcph commented on code in PR #15825: URL: https://github.com/apache/kafka/pull/15825#discussion_r1608823231 ## storage/src/test/java/org/apache/kafka/tiered/storage/actions/EraseBrokerStorageAction.java: ## @@ -19,24 +19,35 @@ import

Re: [PR] HBASE-28425 Allow specify cluster key without zookeeper in replication [hbase]

2024-05-21 Thread via GitHub
Apache-HBase commented on PR #5865: URL: https://github.com/apache/hbase/pull/5865#issuecomment-2123252666 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s |

Re: [PR] KAFKA-16804: Replace archivesBaseName with archivesName. [kafka]

2024-05-21 Thread via GitHub
gharris1727 commented on PR #16016: URL: https://github.com/apache/kafka/pull/16016#issuecomment-2123252147 I verified that this change resolves the relevant build warnings, and produces an identical published result as the current trunk implementation. Thank you @frankvicky for

Re: [PR] KAFKA-16804: Replace archivesBaseName with archivesName. [kafka]

2024-05-21 Thread via GitHub
gharris1727 commented on code in PR #16016: URL: https://github.com/apache/kafka/pull/16016#discussion_r1608820947 ## build.gradle: ## @@ -341,7 +341,7 @@ subprojects { artifact task } -artifactId = archivesBaseName +

Re: [I] [R] CRAN packaging checklist for version 16.1.0 [arrow]

2024-05-21 Thread via GitHub
assignUser commented on issue #41647: URL: https://github.com/apache/arrow/issues/41647#issuecomment-2123250635 I am going to upload a tarball to winbuilder (though it passing there doesn't really mean anything) -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] HBASE-28596 Optimise BucketCache usage upon regions splits/merges. [hbase]

2024-05-21 Thread via GitHub
Apache-HBase commented on PR #5906: URL: https://github.com/apache/hbase/pull/5906#issuecomment-2123250036 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 55s |

Re: [PR] [SPARK-48220][PYTHON] Allow passing PyArrow Table to createDataFrame() [spark]

2024-05-21 Thread via GitHub
ianmcook commented on code in PR #46529: URL: https://github.com/apache/spark/pull/46529#discussion_r1608820275 ## python/pyspark/sql/pandas/conversion.py: ## @@ -236,15 +236,15 @@ def toArrow(self) -> "pa.Table": from pyspark.sql.pandas.utils import

Re: [PR] HBASE-28596 Optimise BucketCache usage upon regions splits/merges. [hbase]

2024-05-21 Thread via GitHub
Apache-HBase commented on PR #5906: URL: https://github.com/apache/hbase/pull/5906#issuecomment-2123249071 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s |

Re: [PR] Bump org.apache.logging:logging-parent from 11.0.0 to 11.1.0 [logging-log4j-jmx-gui]

2024-05-21 Thread via GitHub
github-actions[bot] merged PR #12: URL: https://github.com/apache/logging-log4j-jmx-gui/pull/12 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] kie-issues#1238: Update Kogito prepare-release Jenkins jobs to trigger nightly and weekly jobs after setting up branches [incubator-kie-drools]

2024-05-21 Thread via GitHub
rodrigonull merged PR #5964: URL: https://github.com/apache/incubator-kie-drools/pull/5964 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HBASE-28596 Optimise BucketCache usage upon regions splits/merges. [hbase]

2024-05-21 Thread via GitHub
Apache-HBase commented on PR #5906: URL: https://github.com/apache/hbase/pull/5906#issuecomment-2123248505 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s |

[PR] Update shields on README [trafficserver]

2024-05-21 Thread via GitHub
moonchen opened a new pull request, #11380: URL: https://github.com/apache/trafficserver/pull/11380 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] HBASE-28596 Optimise BucketCache usage upon regions splits/merges. [hbase]

2024-05-21 Thread via GitHub
Apache-HBase commented on PR #5906: URL: https://github.com/apache/hbase/pull/5906#issuecomment-2123247668 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s |

[PR] Bump org.apache.logging:logging-parent from 11.0.0 to 11.1.0 [logging-log4j-jmx-gui]

2024-05-21 Thread via GitHub
dependabot[bot] opened a new pull request, #12: URL: https://github.com/apache/logging-log4j-jmx-gui/pull/12 Bumps [org.apache.logging:logging-parent](https://github.com/apache/logging-parent) from 11.0.0 to 11.1.0. Commits

Re: [PR] Bump net.openhft:chronicle-core from 2.25ea14 to 2.25ea15 [pinot]

2024-05-21 Thread via GitHub
Jackie-Jiang merged PR #13192: URL: https://github.com/apache/pinot/pull/13192 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] feat: correlation support [datafusion-comet]

2024-05-21 Thread via GitHub
codecov-commenter commented on PR #456: URL: https://github.com/apache/datafusion-comet/pull/456#issuecomment-2123243529 ##

Re: [PR] [NIFI-13082] Created SplitPcap processor, Pcap supporting class, and … [nifi]

2024-05-21 Thread via GitHub
dan-s1 commented on code in PR #8691: URL: https://github.com/apache/nifi/pull/8691#discussion_r1608585813 ## nifi-extension-bundles/nifi-network-bundle/nifi-network-processors/src/main/java/org/apache/nifi/processors/network/pcap/Header.java: ## @@ -0,0 +1,151 @@ +// MIT

Re: [I] [R] CRAN packaging checklist for version 16.1.0 [arrow]

2024-05-21 Thread via GitHub
nealrichardson commented on issue #41647: URL: https://github.com/apache/arrow/issues/41647#issuecomment-2123241502 > Ok, that's an issue: https://www.r-project.org/nosvn/R.check/r-release-windows-x86_64/arrow-00install.html They have turned off network access for the windows build as

Re: [PR] chore(tags): Handle tagging as part of asset update call [superset]

2024-05-21 Thread via GitHub
hug commented on PR #28570: URL: https://github.com/apache/superset/pull/28570#issuecomment-2123239836 Also @Vitor-Avila we need to update the calls for `Query` and `Dataset` to make sure they have the same ability to update the tags as well -- This is an automated message from the

Re: [PR] [SPARK-48220][PYTHON] Allow passing PyArrow Table to createDataFrame() [spark]

2024-05-21 Thread via GitHub
ianmcook commented on code in PR #46529: URL: https://github.com/apache/spark/pull/46529#discussion_r1608812796 ## python/pyspark/sql/pandas/conversion.py: ## @@ -236,15 +236,15 @@ def toArrow(self) -> "pa.Table": from pyspark.sql.pandas.utils import

Re: [PR] [SPARK-48220][PYTHON] Allow passing PyArrow Table to createDataFrame() [spark]

2024-05-21 Thread via GitHub
ianmcook commented on code in PR #46529: URL: https://github.com/apache/spark/pull/46529#discussion_r1608803682 ## python/pyspark/sql/connect/dataframe.py: ## @@ -1770,8 +1770,9 @@ def _to_table(self) -> Tuple["pa.Table", Optional[StructType]]: return (table, schema)

[I] What does the Lucene community think about dimensionality reduction for vectors, and should it be something the library does internally (at merge time perhaps)? [lucene]

2024-05-21 Thread via GitHub
gautamworah96 opened a new issue, #13403: URL: https://github.com/apache/lucene/issues/13403 ### Description I opened this issue as a discussion topic. With the advancement in int8, int4 type vector storage, I believe Lucene takes the unquantized vectors as inputs, intelligently

Re: [I] [R] CRAN packaging checklist for version 16.1.0 [arrow]

2024-05-21 Thread via GitHub
assignUser commented on issue #41647: URL: https://github.com/apache/arrow/issues/41647#issuecomment-2123238061 Ok, that's an issue: https://www.r-project.org/nosvn/R.check/r-release-windows-x86_64/arrow-00install.html They have turned off network access for the windows build as well.

Re: [PR] Added new Parameter to exclude specific classes from default value generation [cxf-xjc-utils]

2024-05-21 Thread via GitHub
reta commented on PR #129: URL: https://github.com/apache/cxf-xjc-utils/pull/129#issuecomment-2123237773 > @reta sorry for my late response, i am runnning out of time atm. Not a problem @marcelhdl , thank you a lot for spending your time on that, I will pick it up shortly, looks like

Re: [PR] Fix automatic termination issue in EmrOperator by ensuring `waiter_max_attempts` is set for deferrable triggers [airflow]

2024-05-21 Thread via GitHub
boring-cyborg[bot] commented on PR #38658: URL: https://github.com/apache/airflow/pull/38658#issuecomment-2123237486 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional

Re: [PR] Fix automatic termination issue in EmrOperator by ensuring `waiter_max_attempts` is set for deferrable triggers [airflow]

2024-05-21 Thread via GitHub
vincbeck merged PR #38658: URL: https://github.com/apache/airflow/pull/38658 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [fix](short circurt) fix return default value issue [doris]

2024-05-21 Thread via GitHub
doris-robot commented on PR #34186: URL: https://github.com/apache/doris/pull/34186#issuecomment-2123237019 TPC-H: Total hot run time: 42128 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch

Re: [PR] [WIP] Don't merge verify 16.1.0 CRAN release. [arrow]

2024-05-21 Thread via GitHub
github-actions[bot] commented on PR #41762: URL: https://github.com/apache/arrow/pull/41762#issuecomment-2123236438 Revision: 7dd1d34074af176d9e861a360e135ae57b21cf96 Submitted crossbow builds: [ursacomputing/crossbow @

Re: [PR] TEZ-4566: NPE in TezChild while fetching attemptId when container is asked to shut down [tez]

2024-05-21 Thread via GitHub
abstractdog commented on PR #358: URL: https://github.com/apache/tez/pull/358#issuecomment-2123234816 this is a very weird edge case and I'm shocked we haven't bumped into it more often the whole, moved block is useless when the container should die so this patch makes sense this

Re: [PR] [SPARK-48220][PYTHON] Allow passing PyArrow Table to createDataFrame() [spark]

2024-05-21 Thread via GitHub
ianmcook commented on code in PR #46529: URL: https://github.com/apache/spark/pull/46529#discussion_r1608803682 ## python/pyspark/sql/connect/dataframe.py: ## @@ -1770,8 +1770,9 @@ def _to_table(self) -> Tuple["pa.Table", Optional[StructType]]: return (table, schema)

Re: [I] [R] CRAN packaging checklist for version 16.1.0 [arrow]

2024-05-21 Thread via GitHub
assignUser commented on issue #41647: URL: https://github.com/apache/arrow/issues/41647#issuecomment-2123232854 crossbow jobs from r-release branch: https://github.com/apache/arrow/pull/41762 -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] [WIP] Don't merge verify 16.1.0 CRAN release. [arrow]

2024-05-21 Thread via GitHub
assignUser commented on PR #41762: URL: https://github.com/apache/arrow/pull/41762#issuecomment-2123231544 @github-actions crossbow submit -g r -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [WIP] Don't merge verify 16.1.0 CRAN release. [arrow]

2024-05-21 Thread via GitHub
github-actions[bot] commented on PR #41762: URL: https://github.com/apache/arrow/pull/41762#issuecomment-2123230730 Thanks for opening a pull request! If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue

Re: [PR] [HUDI-7774] Add Avro Logical type support for Merciful Java convertor [hudi]

2024-05-21 Thread via GitHub
Davis-Zhang-Onehouse commented on code in PR #11265: URL: https://github.com/apache/hudi/pull/11265#discussion_r1608801275 ## hudi-common/src/test/java/org/apache/hudi/avro/TestMercifulJsonConverter.java: ## @@ -55,6 +70,649 @@ public void basicConversion() throws IOException {

[PR] [WIP] Don't merge verify 16.1.0 CRAN release. [arrow]

2024-05-21 Thread via GitHub
assignUser opened a new pull request, #41762: URL: https://github.com/apache/arrow/pull/41762 don't merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] HIVE-28270: Fix missing partition paths bug on drop_database [hive]

2024-05-21 Thread via GitHub
sonarcloud[bot] commented on PR #5255: URL: https://github.com/apache/hive/pull/5255#issuecomment-2123229192 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [issue-368] knative integration with DataIndex and JobService [incubator-kie-kogito-serverless-operator]

2024-05-21 Thread via GitHub
ricardozanini commented on PR #467: URL: https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/467#issuecomment-2123228981 @jianrongzhang89 I'll do another review round tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] View: add property to describe advisory read mode [iceberg]

2024-05-21 Thread via GitHub
rdblue commented on PR #10362: URL: https://github.com/apache/iceberg/pull/10362#issuecomment-2123228246 @jackye1995 can you help me understand the case that this is protecting against? I'm not sure I understand the loophole that this is attempting to close. -- This is an automated

Re: [PR] [HUDI-7774] Add Avro Logical type support for Merciful Java convertor [hudi]

2024-05-21 Thread via GitHub
Davis-Zhang-Onehouse commented on code in PR #11265: URL: https://github.com/apache/hudi/pull/11265#discussion_r1608799784 ## hudi-common/src/main/java/org/apache/hudi/avro/MercifulJsonConverter.java: ## @@ -187,196 +178,774 @@ private static Object

Re: [I] [sqllqb] Superset always fires "show create view" although it is a table which results in "error while fetching table metadata" [superset]

2024-05-21 Thread via GitHub
john-bodley commented on issue #26740: URL: https://github.com/apache/superset/issues/26740#issuecomment-2123227813 Re-opening because the fix was reverted in https://github.com/apache/superset/pull/28613. -- This is an automated message from the Apache Git Service. To respond to the

[I] [sqllqb] Superset always fires "show create view" although it is a table which results in "error while fetching table metadata" [superset]

2024-05-21 Thread via GitHub
rabindragogoi opened a new issue, #26740: URL: https://github.com/apache/superset/issues/26740 ### Bug description Superset version : 3.0.3 Error in show table schema / fetching metadata Superset always fires "show create view" although it is a table which results in "error

Re: [I] Failure on creation of a new Presto dataset due to failure to load columns [superset]

2024-05-21 Thread via GitHub
john-bodley commented on issue #25962: URL: https://github.com/apache/superset/issues/25962#issuecomment-2123227541 Re-opening because the fix was reverted in https://github.com/apache/superset/pull/28613. -- This is an automated message from the Apache Git Service. To respond to the

[I] Failure on creation of a new Presto dataset due to failure to load columns [superset]

2024-05-21 Thread via GitHub
eyalsh99 opened a new issue, #25962: URL: https://github.com/apache/superset/issues/25962 We have a Presto database connection working fine with virtual datasets (added throw SQLLab). When trying to add a new dataset of a physical table we're getting an error. ### Reproducing the

Re: [I] [sqllab] Tableschemaview fails to load with presto using parquet format files [superset]

2024-05-21 Thread via GitHub
john-bodley commented on issue #25636: URL: https://github.com/apache/superset/issues/25636#issuecomment-2123227316 Re-opening because the fix was reverted in https://github.com/apache/superset/pull/28613. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [SPARK-48374][PYTHON] Support additional PyArrow Table column types [spark]

2024-05-21 Thread via GitHub
ianmcook commented on PR #46688: URL: https://github.com/apache/spark/pull/46688#issuecomment-2123227176 The tests will fail until after #46529 is merged and I rebase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] SOLR-17304: PKG_VERSIONS not honored when loading the schema plugins [solr]

2024-05-21 Thread via GitHub
AndreyBozhko commented on code in PR #2471: URL: https://github.com/apache/solr/pull/2471#discussion_r1608792092 ## solr/core/src/java/org/apache/solr/core/SolrResourceLoader.java: ## @@ -694,9 +694,14 @@ public boolean addToCoreAware(T obj) { } } + void

[I] [sqllab] Tableschemaview fails to load with presto using parquet format files [superset]

2024-05-21 Thread via GitHub
tullis opened a new issue, #25636: URL: https://github.com/apache/superset/issues/25636 ### Summary On Superset version 3.1.0 the table schema previews fail to load on `sqllab/` and `dataset/add/` paths when using presto datasources and parquet format files. These were working

Re: [PR] [HUDI-7774] Add Avro Logical type support for Merciful Java convertor [hudi]

2024-05-21 Thread via GitHub
Davis-Zhang-Onehouse commented on code in PR #11265: URL: https://github.com/apache/hudi/pull/11265#discussion_r1608797800 ## hudi-common/src/main/java/org/apache/hudi/avro/AvroLogicalTypeEnum.java: ## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Pass original message down through conversion for storage write api [beam]

2024-05-21 Thread via GitHub
reuvenlax commented on PR #31106: URL: https://github.com/apache/beam/pull/31106#issuecomment-2123223998 If I understand this correctly, we are now propagating both ElementT and StorageApiWritePayload - correct? Doesn't this double the amount of data being processed? -- This is an

Re: [PR] [fix](short circurt) fix return default value issue [doris]

2024-05-21 Thread via GitHub
doris-robot commented on PR #34186: URL: https://github.com/apache/doris/pull/34186#issuecomment-2123223020 TeamCity be ut coverage result: Function Coverage: 35.70% (9018/25261) Line Coverage: 27.34% (74556/272708) Region Coverage: 26.55% (38539/145172) Branch Coverage:

Re: [PR] [Python] Disable soft delete policy when creating new default bucket. [beam]

2024-05-21 Thread via GitHub
Abacn merged PR #31344: URL: https://github.com/apache/beam/pull/31344 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [SPARK-48220][PYTHON] Allow passing PyArrow Table to createDataFrame() [spark]

2024-05-21 Thread via GitHub
ianmcook commented on PR #46529: URL: https://github.com/apache/spark/pull/46529#issuecomment-2123221915 @zhengruifeng I broke out the non-required changes into separate PRs and I simplified the implementations. I think it should be easier to follow now. More than half of the added code is

Re: [PR] Remove dev-v1 reference from dev mode test [incubator-kie-kogito-images]

2024-05-21 Thread via GitHub
ricardozanini commented on PR #1767: URL: https://github.com/apache/incubator-kie-kogito-images/pull/1767#issuecomment-2123220588 @nmirasch the CI won't run because we can't find a fork with the name: ``` stderr: remote: Repository not found. fatal: repository

[PR] patching this to maser [superset]

2024-05-21 Thread via GitHub
hug opened a new pull request, #28629: URL: https://github.com/apache/superset/pull/28629 ### SUMMARY Hiccup on my end merging this PR to 4.0 vs. master. To save the work @visharavana did I'm resubmitting the PR here https://github.com/apache/superset/pull/28559

Re: [PR] Add metrics about task CPU and memory usage [airflow]

2024-05-21 Thread via GitHub
vincbeck commented on code in PR #39650: URL: https://github.com/apache/airflow/pull/39650#discussion_r1608779978 ## airflow/task/task_runner/standard_task_runner.py: ## @@ -186,3 +194,19 @@ def get_process_pid(self) -> int: if self.process is None: raise

Re: [PR] Custom configuration property reader for segment metadata files [pinot]

2024-05-21 Thread via GitHub
klsince commented on code in PR #12440: URL: https://github.com/apache/pinot/pull/12440#discussion_r1608761946 ## pinot-spi/src/test/java/org/apache/pinot/spi/env/VersionedPropertyConfigTest.java: ## @@ -0,0 +1,224 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Add metrics about task CPU and memory usage [airflow]

2024-05-21 Thread via GitHub
vincbeck commented on code in PR #39650: URL: https://github.com/apache/airflow/pull/39650#discussion_r160827 ## airflow/task/task_runner/standard_task_runner.py: ## @@ -186,3 +194,19 @@ def get_process_pid(self) -> int: if self.process is None: raise

Re: [PR] DRAFT: Parquet 3 metadata with decoupled column metadata [parquet-format]

2024-05-21 Thread via GitHub
pitrou commented on code in PR #242: URL: https://github.com/apache/parquet-format/pull/242#discussion_r1608326106 ## src/main/thrift/parquet.thrift: ## @@ -1165,6 +1317,62 @@ struct FileMetaData { 9: optional binary footer_signing_key_metadata } +/** Metadata for a

Re: [PR] first draft build local multi-arch images [tika-docker]

2024-05-21 Thread via GitHub
tballison merged PR #21: URL: https://github.com/apache/tika-docker/pull/21 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Upgrade from jammy to noble [tika-docker]

2024-05-21 Thread via GitHub
tballison merged PR #22: URL: https://github.com/apache/tika-docker/pull/22 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] [Bug] messageTTL on namespaces doesn't work as expected [pulsar]

2024-05-21 Thread via GitHub
dao-jun closed issue #22316: [Bug] messageTTL on namespaces doesn't work as expected URL: https://github.com/apache/pulsar/issues/22316 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] [Bug] messageTTL on namespaces doesn't work as expected [pulsar]

2024-05-21 Thread via GitHub
dao-jun commented on issue #22316: URL: https://github.com/apache/pulsar/issues/22316#issuecomment-2123211095 can be fixed by https://github.com/apache/pulsar/pull/22535. closing... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] DRAFT: Parquet 3 metadata with decoupled column metadata [parquet-format]

2024-05-21 Thread via GitHub
pitrou commented on code in PR #242: URL: https://github.com/apache/parquet-format/pull/242#discussion_r1608770331 ## README.md: ## @@ -107,12 +113,97 @@ start locations. More details on what is contained in the metadata can be found in the Thrift definition. Metadata is

Re: [PR] Rename quay to docker in image bundles [incubator-kie-kogito-images]

2024-05-21 Thread via GitHub
ricardozanini commented on PR #1768: URL: https://github.com/apache/incubator-kie-kogito-images/pull/1768#issuecomment-2123209804 @jstastny-cz I think we will fix it in the way we see problems in the CI. But essentially this is related to now using `:main` tag instead of

Re: [PR] Pass original message down through conversion for storage write api [beam]

2024-05-21 Thread via GitHub
johnjcasey commented on code in PR #31106: URL: https://github.com/apache/beam/pull/31106#discussion_r1608769452 ## sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiLoads.java: ## @@ -52,16 +52,18 @@ /** This {@link PTransform}

Re: [PR] Fix comparison of Long objects to use primitives [cloudstack]

2024-05-21 Thread via GitHub
codecov[bot] commented on PR #9079: URL: https://github.com/apache/cloudstack/pull/9079#issuecomment-2123209162 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9079?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report

Re: [PR] Pass original message down through conversion for storage write api [beam]

2024-05-21 Thread via GitHub
johnjcasey commented on code in PR #31106: URL: https://github.com/apache/beam/pull/31106#discussion_r1608768600 ## sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiLoads.java: ## @@ -52,16 +52,18 @@ /** This {@link PTransform}

Re: [PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-05-21 Thread via GitHub
rmdmattingly commented on code in PR #5868: URL: https://github.com/apache/hbase/pull/5868#discussion_r1608768506 ## hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupManager.java: ## @@ -295,51 +298,31 @@ public ArrayList getAncestors(BackupInfo backupInfo)

Re: [PR] Fix kie-issues #1217 - Replace quay.io with docker.io [incubator-kie-kogito-apps]

2024-05-21 Thread via GitHub
ricardozanini commented on PR #2056: URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2056#issuecomment-2123208220 @tiagobento I'm refraining from removing out dated files if it's not needed, but to replace them with the newly valid image repos. And I'm not aware of the usage

[I] OntModel enhancements [jena]

2024-05-21 Thread via GitHub
sszuev opened a new issue, #2487: URL: https://github.com/apache/jena/issues/2487 ### Version 5.1.0 ### Feature There is some functionality that is present in the old model, but is missing in the new one - methods `OntModel#writeAll` - builtin annotation

Re: [I] [Enhancement] Add eventmesh-spring-boot-starter (eventmesh)

2024-05-21 Thread via GitHub
github-actions[bot] commented on issue #4576: URL: https://github.com/apache/eventmesh/issues/4576#issuecomment-2123208083 It has been 90 days since the last activity on this issue. Apache EventMesh values the voices of the community. Please don't hesitate to share your latest insights on

Re: [PR] Pass original message down through conversion for storage write api [beam]

2024-05-21 Thread via GitHub
johnjcasey commented on code in PR #31106: URL: https://github.com/apache/beam/pull/31106#discussion_r1608768007 ## sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiLoads.java: ## @@ -52,16 +52,18 @@ /** This {@link PTransform}

Re: [PR] DRAFT: Parquet 3 metadata with decoupled column metadata [parquet-format]

2024-05-21 Thread via GitHub
pitrou commented on code in PR #242: URL: https://github.com/apache/parquet-format/pull/242#discussion_r1608765310 ## README.md: ## @@ -107,12 +113,97 @@ start locations. More details on what is contained in the metadata can be found in the Thrift definition. Metadata is

[PR] FINERACT-2081: Remove Disable Schedule Extension For DownPayment unus… [fineract]

2024-05-21 Thread via GitHub
alberto-art3ch opened a new pull request, #3899: URL: https://github.com/apache/fineract/pull/3899 …ed code ## Description Remove Disable Schedule Extension For DownPayment functionality. The above functionality became deprecated due to the rework of down payment handling.

Re: [I] Verify CouchDB Installation fails with create view [couchdb]

2024-05-21 Thread via GitHub
NETEROabdelrahman commented on issue #5062: URL: https://github.com/apache/couchdb/issues/5062#issuecomment-2123203692 i still get the same issue, ![Screenshot (117)](https://github.com/apache/couchdb/assets/114447180/041f53b5-c47d-42a7-af2c-a5e0f11c43d4) ![Screenshot

Re: [I] [MS14] Documentation revamp 1/5 (logging-log4j2)

2024-05-21 Thread via GitHub
grobmeier closed issue #2538: [MS14] Documentation revamp 1/5 URL: https://github.com/apache/logging-log4j2/issues/2538 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [I] [MS14] Documentation revamp 1/5 (logging-log4j2)

2024-05-21 Thread via GitHub
grobmeier commented on issue #2538: URL: https://github.com/apache/logging-log4j2/issues/2538#issuecomment-2123204067 Checked and completed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[Github-comments] Re: [geany/geany] Remove custom WIN32 compiler macro in favor of _WIN32 (PR #3878)

2024-05-21 Thread Jiří Techet via Github-comments
@techee commented on this pull request. > @@ -418,7 +418,7 @@ static unsigned int re_string_context_at (const > re_string_t *input, int idx, #define re_string_skip_bytes(pstr,idx) ((pstr)->cur_idx += (idx)) #define re_string_set_index(pstr,idx) ((pstr)->cur_idx = (idx)) -#ifdef WIN32

[PR] Refactor parquet row group pruning into a struct [datafusion]

2024-05-21 Thread via GitHub
alamb opened a new pull request, #10607: URL: https://github.com/apache/datafusion/pull/10607 ## Which issue does this PR close? Closes #. ## Rationale for this change ## What changes are included in this PR? ## Are these changes tested?

Re: [PR] feat(python): DLPack support on CBufferView [arrow-nanoarrow]

2024-05-21 Thread via GitHub
paleolimbot commented on code in PR #469: URL: https://github.com/apache/arrow-nanoarrow/pull/469#discussion_r1608762196 ## python/tests/test_dlpack.py: ## @@ -0,0 +1,97 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements.

Re: [PR] Reroute AutoML operator links to Google Translation links [airflow]

2024-05-21 Thread via GitHub
e-galan commented on code in PR #39668: URL: https://github.com/apache/airflow/pull/39668#discussion_r1608761585 ## airflow/providers/google/cloud/links/translate.py: ## Review Comment: Hey @Taragolis , I added the tests, please check. -- This is an automated message

Re: [PR] Bump io.quarkiverse.amazonservices:quarkus-amazon-services-bom from 2.14.0 to 2.15.0 [camel-quarkus]

2024-05-21 Thread via GitHub
jamesnetherton merged PR #6070: URL: https://github.com/apache/camel-quarkus/pull/6070 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] PARQUET-2472: Close in finally block in ParquetFileWriter#end [parquet-java]

2024-05-21 Thread via GitHub
Fokko commented on PR #1350: URL: https://github.com/apache/parquet-java/pull/1350#issuecomment-2123197645 @amogh-jahagirdar do you want to backport this to 1.14.1 as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] pwm/pwm_da1469x: Preserve timer state on frequency change. [mynewt-core]

2024-05-21 Thread via GitHub
vrahane commented on PR #3229: URL: https://github.com/apache/mynewt-core/pull/3229#issuecomment-2123195483 We did speak about this and seems fine to me. Haven't tested it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [Java] Add warning to gcpTempLocation when its bucket has soft delete enabled [beam]

2024-05-21 Thread via GitHub
shunping commented on PR #31358: URL: https://github.com/apache/beam/pull/31358#issuecomment-2123195821 Run Java PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] HIVE-28271: DirectSql fails for AlterPartitions. [hive]

2024-05-21 Thread via GitHub
sonarcloud[bot] commented on PR #5256: URL: https://github.com/apache/hive/pull/5256#issuecomment-2123195371 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [openlineage] fix: Prevent error when extractor can't be imported [airflow]

2024-05-21 Thread via GitHub
mobuchowski merged PR #39736: URL: https://github.com/apache/airflow/pull/39736 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] fix: revert fix(presto preview): re-enable schema previsualization for Trino/Presto table/schemas" [superset]

2024-05-21 Thread via GitHub
michael-s-molina merged PR #28613: URL: https://github.com/apache/superset/pull/28613 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] UI changes for DAG Reparsing feature [airflow]

2024-05-21 Thread via GitHub
bbovenzi commented on PR #39636: URL: https://github.com/apache/airflow/pull/39636#issuecomment-2123191828 Looks great to me! Do the Dags list and dag details pages refresh once the DAG is reparsed? -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] chore(tags): Handle tagging as part of asset update call [superset]

2024-05-21 Thread via GitHub
hug commented on code in PR #28570: URL: https://github.com/apache/superset/pull/28570#discussion_r1608754326 ## superset/charts/schemas.py: ## @@ -284,7 +285,9 @@ class ChartPutSchema(Schema): ) is_managed_externally = fields.Boolean(allow_none=True,

Re: [PR] [CORE] Enable SortShuffleSuite with ColumnarShuffleManager [incubator-gluten]

2024-05-21 Thread via GitHub
acvictor commented on PR #5816: URL: https://github.com/apache/incubator-gluten/pull/5816#issuecomment-2123191459 @rui-mo I think the Clickhouse CI has failed but I'm not sure how to access it. Should I disable the suite for CH? -- This is an automated message from the Apache Git

Re: [PR] [CORE] Remove duplicate pipeline metrics measurement [incubator-gluten]

2024-05-21 Thread via GitHub
GlutenPerfBot commented on PR #5821: URL: https://github.com/apache/incubator-gluten/pull/5821#issuecomment-2123191083 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] feat(python): DLPack support on CBufferView [arrow-nanoarrow]

2024-05-21 Thread via GitHub
AlenkaF commented on code in PR #469: URL: https://github.com/apache/arrow-nanoarrow/pull/469#discussion_r1608753547 ## python/tests/test_dlpack.py: ## @@ -0,0 +1,97 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See

Re: [PR] WIP: checkpoint on preserve CR issue [daffodil]

2024-05-21 Thread via GitHub
mbeckerle commented on PR #1244: URL: https://github.com/apache/daffodil/pull/1244#issuecomment-2123190163 > I tested as far back as 3.1.0 and all of them did the CR -> LF mapping. So this is not a regression. Maybe not the preferred behavior, but probably a change we wait for 4.0.0 to

Re: [PR] [HUDI-7774] Add Avro Logical type support for Merciful Java convertor [hudi]

2024-05-21 Thread via GitHub
yihua commented on code in PR #11265: URL: https://github.com/apache/hudi/pull/11265#discussion_r1608752328 ## hudi-common/src/main/java/org/apache/hudi/avro/MercifulJsonConverter.java: ## @@ -187,196 +178,774 @@ private static Object convertJsonToAvroField(Object value,

Re: [PR] [HUDI-7774] Add Avro Logical type support for Merciful Java convertor [hudi]

2024-05-21 Thread via GitHub
yihua commented on code in PR #11265: URL: https://github.com/apache/hudi/pull/11265#discussion_r1608735139 ## hudi-common/src/main/java/org/apache/hudi/avro/AvroLogicalTypeEnum.java: ## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] HDDS-10372. SCM and Datanode communication for reconciliation [ozone]

2024-05-21 Thread via GitHub
errose28 commented on code in PR #6506: URL: https://github.com/apache/ozone/pull/6506#discussion_r1608748520 ## hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/container/ContainerReplicaInfo.java: ## @@ -35,6 +40,8 @@ public final class ContainerReplicaInfo {

Re: [PR] PhysicalExpr Orderings with Range Information [datafusion]

2024-05-21 Thread via GitHub
alamb commented on code in PR #10504: URL: https://github.com/apache/datafusion/pull/10504#discussion_r1608748477 ## datafusion/functions/src/math/monotonicity.rs: ## @@ -0,0 +1,241 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

<    3   4   5   6   7   8   9   10   11   12   >