Thanks!
On Wed, Aug 3, 2016, at 01:49 PM, Christophe Fergeau wrote:
> Hey,
>
> I've pushed the patch now, thanks!
>
> Christophe
>
> On Tue, Jul 26, 2016 at 01:47:16PM +0300, Alon Levy wrote:
> > On fedora 24 this function is tail optimized, resulting in a busy
On fedora 24 this function is tail optimized, resulting in a busy wait.
This happens to me with virt-manager running a win7 vm
usbredir-0.7.1-2.fc24.x86_64
---
Hi Guys!
One liner to fix an issue I had with virt-manager - symptom is 100% cpu
taken in it, stack traced to the problem fixed by
On 04/29/2015 09:22 PM, r...@openmailbox.org wrote:
On 2015-04-29 11:41, Alon Levy wrote:
On 04/29/2015 02:20 PM, r...@openmailbox.org wrote:
Hi. I am trying to get a virtual smartcard attached to a vm but I want
it to use GPG instead of NSS. RedHat focuses on NSS becuase of PKCS#11
On 04/29/2015 02:20 PM, r...@openmailbox.org wrote:
Hi. I am trying to get a virtual smartcard attached to a vm but I want
it to use GPG instead of NSS. RedHat focuses on NSS becuase of PKCS#11
requirements and FIPS approval, but for most of the community its GPG
that matters for smartcards.
On 01/08/2015 04:10 PM, Jeremy White wrote:
On 01/08/2015 03:53 AM, Uri Lublin wrote:
Hi Jeremy,
Ack.
Thanks.
h-length is unsigned.
1. Why is there a need to check that h-length 0 ?
There is no need, changed.
2. What happens if h-length == 0 ?
Note that I believe that could
[snip]
At the same time, I'm not sure mailing lists are the right tool for code
review. It's difficult to track which patches have been reviewed and
which haven't.
http://patchwork.freedesktop.org/project/Spice/list/ can help, linked
from the wiki btw
On 12/06/2014 12:00 AM, Jonathon Jongsma wrote:
On Fri, 2014-12-05 at 23:41 +0200, Alon Levy wrote:
[snip]
At the same time, I'm not sure mailing lists are the right tool for code
review. It's difficult to track which patches have been reviewed and
which haven't.
http
On 11/27/2014 02:02 PM, Charles Ricketts wrote:
Well, I have Spice working perfectly fine in a Windows install. However,
seeing as that's not pertinent to the Linux side of things I went ahead
and installed Ubuntu 14.04 in Qemu and, as expected, everything worked.
I didn't bother with the git
On 11/26/2014 01:37 PM, Devesh Mishra(NABFS00) wrote:
Hi,
I am trying to get byteArray from a String using below code. But getting an
error.
var _strEncode:String = Sample String;
This is a 13 byte string (no nul at the end iirc), so it seems from the
error message (didn't try this code)
On 11/21/2014 05:03 PM, Jeremy White wrote:
Thanks for the careful review.
+static void push_apdu(smartcard_ccid_t *ccid, void *data, int len)
+{
+apdu_t *a = calloc(1, sizeof(*a) + len);
+apdu_t **p;
+
+a-data = malloc(len);
+memcpy(a-data, data, len);
1. No need to
On 11/12/2014 11:23 PM, modjkl...@comcast.net wrote:
For what it's worth, Matlab produces 72057594037927936.
A power of 2 is not divisible by 5 and hence not by 10 so it cannot end
in a zero. So any answer with a trailing zero is wrong.
In general, 64-bit math is limited in accuracy to
Hi,
I'm new at flash development, have tried IntelliJ and now mostly using
FlashBuilder 4.7 while still trying to get a non IDE make working on
linux. But this is just an introduction, I'm mostly interested in having
a fast build and FlashBuilder 4.7 falls short for me (1 minute builds).
I've
On 10/30/2014 06:39 PM, vtoso...@redhat.com wrote:
From: Christophe Fergeau cferg...@redhat.com
This commit adds GStreamer 1.0 support.
To enable GStreamer 1.0: --with-audio=gstreamer1
commit first line should say audio somewhere.
There is only a few changes between those versions, worth
On 10/08/2014 01:10 PM, Marc-André Lureau wrote:
ping
I didn't test this, looks good, just one single line if, do with it as
you will. And unrelated, but you use TRUE/FALSE constants for handled,
maybe nice to use them too (at least be consistent that is) in
vdagent_x11_handle_event.
On Mon,
On 10/22/2014 11:37 AM, Hans de Goede wrote:
Hi,
Forwarding this to you guys from the xorg-devel list.
Regards,
Hans
Forwarded Message
Subject: a question about Xspice
Date: Tue, 21 Oct 2014 17:30:54 +0800 (CST)
From: cynthia cynthia_...@163.com
To:
and nullified while
it's still being used.
This commit corrects the bug by introducing a boolean to
track whether or not the sign buffer should be freed in
the function exit path.
My bad, thanks for catching this.
Reviewed-by: Alon Levy a...@pobox.com
Signed-off-by: Ray Strode rstr
On 10/16/2014 04:25 AM, Greg Sheremeta wrote:
Hey all,
Using a high-end Fedora 20 host, I get very poor choppy performance running
flash full-screen
in a Windows VM. I need to use Windows due to DRM stuff (nflsundayticket.tv).
I've tried
different virtual graphics adapters, but nothing
On 10/12/2014 03:24 PM, Marc-André Lureau wrote:
From: Marc-Andre Lureau marcandre.lur...@redhat.com
When qemu qxl device reaches a guest bug, it might set the
QXL_INTERRUPT_ERROR interrupt flag, and stops processing guest
commands. Therefore, it makes sense to check that flag in the guest
On 09/29/2014 03:30 PM, Jeremy White wrote:
If the idea seems sensible, then I'd propose that we work on the Wiki
until
we feel it stands mostly on it's own, and when we hit that point, we
shift
the main pages to reflect that.
The website/wiki content needs some reorganization for sure, and
On 09/15/2014 05:30 AM, Brade-Atrust wrote:
Hi guys,
This is brade huang from taiwan, right now I try to dig into spice
client source code and hopefully do some developments on spice, but when
I investigated the code, I realized it already enhanced to protocol v2.
I tried very hard to
On 09/01/2014 09:01 PM, Brad Campbell wrote:
G'day All,
I'm attempting to run an OSX guest using spice as the remote display
protocol (Yes, it's running on Apple hardware). The guest is using the
standard vga driver.
I'm using the latest git of spice, spice-gtk, qemu and the kernel.
With agent running we do.
On August 22, 2014 7:55:19 AM EDT, Marc-André Lureau mlur...@redhat.com
wrote:
Hi Jeremy
I wish we could have dynamic allocation for Xspice, avoiding those
parameters, but this could be improved later.
Few remarks below:
- Original Message -
Also adjust the
wrote:
On 08/22/2014 07:52 AM, Alon Levy wrote:
With agent running we do.
?? I'm sorry, I don't follow. Can you explain what you mean?
Cheers,
Jeremy
On August 22, 2014 7:55:19 AM EDT, Marc-André Lureau
mlur...@redhat.com wrote:
Hi Jeremy
I wish we could have dynamic
On August 22, 2014 9:16:31 AM EDT, Jeremy White jwh...@codeweavers.com wrote:
On 08/22/2014 08:07 AM, Alon Levy wrote:
Sorry for top posting. I was replying to Marc-Andre's assertion. If
the
subject isnt arbitrary resolution, aka dynamic, continuous, then I
missed it. If it is, since agent
On 08/06/2014 05:27 AM, Cody Chan wrote:
Bad display of the download-section,
http://cgit.freedesktop.org/spice/spice-gtk/
Tag Download
v0.25 commit 31c099c931...
v0.24 commit 6356941903...
v0.23 commit 75176968b0...
v0.22 commit 2e3aa29794...
v0.21 commit 632836ed77...
v0.20 commit
On 08/06/2014 06:14 PM, Jeremy White wrote:
And, finally, if that's all right - on to the next question: where
should spiceccid fit in the XSpice stack? Should it be part of the Xorg
driver? Should it be a vd_agent process?
I'm not sure - I was thinking a third part, this time it's a bit
On 08/06/2014 06:17 PM, Jeremy White wrote:
I would advice against going for a protocol translater, your time would
better spend on doing this properly right away.
You don't think the kernel guys will push back, saying there is already
an existing ip-to-usb device, and we should just use
On 07/25/2014 12:01 AM, Jeremy White wrote:
I think I have a tentative, but sufficient grasp of how the Smart Card
stuff flows from the client into the server. It's not quite as clear
how the server bridges it into qemu, but I think I have the gist of it.
However, that doesn't work for
On 07/24/2014 02:12 PM, Alon Levy wrote:
From: Alon Levy al...@redhat.com
Fixed build error at glsl_parser.yy for Visual Studio 2013
Signed-off-by: Alon Levy al...@redhat.com
Not required, my bad, I was looking at an old master, patch
8c879ac1977a265ae513a5569ee3af35dbc6b1aa already does
On 07/28/2014 07:13 PM, Brian Paul wrote:
On 07/22/2014 03:07 PM, Alon Levy wrote:
Under VS2013 compiler that is distinguished by _MSC_VER of 1800 those two
are already defined, use the SDK definition.
Another option would have been to undef and use the definitions here -
I'm
not sure which
From: Alon Levy al...@redhat.com
Fixed build error at glsl_parser.yy for Visual Studio 2013
Signed-off-by: Alon Levy al...@redhat.com
---
Thanks for the review. I verified and VS2013 (vs12) doesn't include strcasecmp,
I corrected the file you mentioned, here is a better patch. (this supercedes
On 07/24/2014 02:12 PM, Alon Levy wrote:
From: Alon Levy al...@redhat.com
Forgot to add Ian as cc.
Fixed build error at glsl_parser.yy for Visual Studio 2013
Signed-off-by: Alon Levy al...@redhat.com
---
Thanks for the review. I verified and VS2013 (vs12) doesn't include
strcasecmp
On 07/24/2014 07:50 PM, Emil Velikov wrote:
On 24/07/14 17:07, Matt Turner wrote:
On Thu, Jul 24, 2014 at 5:44 AM, Emil Velikov emil.l.veli...@gmail.com
wrote:
On 23/07/14 22:16, Ian Romanick wrote:
On 07/22/2014 02:07 PM, Alon Levy wrote:
Signed-off-by: Alon Levy al...@redhat.com
On 23.07.2014 14:40, Marc-André Lureau wrote:
ack, thanks!
Are you picking up this one for Fedora?
The actual patches for any relevant bugs should already be there, doing a
rebase will probably happen the next time someone needs to fix something (i.e.
some bz).
remote desktop fan
On 07/24/2014 03:58 PM, poma wrote:
On 24.07.2014 14:43, Alon Levy wrote:
On 23.07.2014 14:40, Marc-André Lureau wrote:
ack, thanks!
Are you picking up this one for Fedora?
The actual patches for any relevant bugs should already be there,
doing a rebase will probably happen the next time
: restore cursor after resolution change
fix cursor2 support in older kernels
FD 79317 - prevent crash on dual head systems
Enjoy,
Alon
Alon Levy (11):
tests/xspice_util.py: fix hardcoded port
spiceqxl_spice_server: no need to call spice_server_set_noauth twice
xspice: chown both
Signed-off-by: Alon Levy al...@redhat.com
---
NEWS | 10 ++
configure.ac | 2 +-
2 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/NEWS b/NEWS
index 4ece9fe..86fe9f8 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,13 @@
+Major changes in 0.1.2
: restore cursor after resolution change
fix cursor2 support in older kernels
FD 79317 - prevent crash on dual head systems
Enjoy,
Alon
Alon Levy (11):
tests/xspice_util.py: fix hardcoded port
spiceqxl_spice_server: no need to call spice_server_set_noauth twice
xspice: chown both
: restore cursor after resolution change
fix cursor2 support in older kernels
FD 79317 - prevent crash on dual head systems
Enjoy,
Alon
Alon Levy (11):
tests/xspice_util.py: fix hardcoded port
spiceqxl_spice_server: no need to call spice_server_set_noauth twice
xspice: chown both
Signed-off-by: Alon Levy al...@redhat.com
---
src/glsl/glsl_parser.yy | 4
1 file changed, 4 insertions(+)
diff --git a/src/glsl/glsl_parser.yy b/src/glsl/glsl_parser.yy
index faaf438..25370cd 100644
--- a/src/glsl/glsl_parser.yy
+++ b/src/glsl/glsl_parser.yy
@@ -26,6 +26,10 @@
#include
Signed-off-by: Alon Levy al...@redhat.com
---
This file is common so this warning comes up a lot.
src/gallium/auxiliary/util/u_math.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/auxiliary/util/u_math.h
b/src/gallium/auxiliary/util/u_math.h
index 60995d7
use util_snprintf that is already defined in other systems by u_string.h
to as snprintf, so to not change behavior in other systems.
Signed-off-by: Alon Levy al...@redhat.com
---
src/gallium/auxiliary/util/u_debug_flush.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git
) scons 2.3.2 seems broken wrt def files, I opened issue
http://scons.tigris.org/issues/show_bug.cgi?id=2966 and used the patch
included there to successfully build the dll.
Alon
Alon Levy (7):
gallium/u_math.h: don't redefine INFINITY and NAN in VS2013
glsl/glsl_parser.yy: vs12 doesn't have
Under VS2013 compiler that is distinguished by _MSC_VER of 1800 those two
are already defined, use the SDK definition.
Another option would have been to undef and use the definitions here - I'm
not sure which is better.
---
This removes warnings, this patch is not actually required to build.
Remove incorrect struct prefix, ir_variable is a class
Signed-off-by: Alon Levy al...@redhat.com
---
src/glsl/opt_dead_builtin_varyings.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/glsl/opt_dead_builtin_varyings.cpp
b/src/glsl/opt_dead_builtin_varyings.cpp
index
Signed-off-by: Alon Levy al...@redhat.com
---
src/gallium/state_trackers/wgl/stw_pixelformat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/state_trackers/wgl/stw_pixelformat.c
b/src/gallium/state_trackers/wgl/stw_pixelformat.c
index 1ef302d..7e5561b 100644
Signed-off-by: Alon Levy al...@redhat.com
---
src/mesa/main/shaderimage.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/main/shaderimage.c b/src/mesa/main/shaderimage.c
index d1e752d..298ede2 100644
--- a/src/mesa/main/shaderimage.c
+++ b/src/mesa/main/shaderimage.c
This is to please vncviewer.
https://bugzilla.redhat.com/show_bug.cgi?id=1117764
ACK
---
src/vdagent-x11-priv.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/vdagent-x11-priv.h b/src/vdagent-x11-priv.h
index 4a5729b..38f852e 100644
---
This is to please vncviewer.
Commit message can say 'add TIMESTAMP handling'. ACK.
btw wrt the TODO, xsel seems to do the same as you.
https://bugzilla.redhat.com/show_bug.cgi?id=1117764
---
src/vdagent-x11-priv.h | 1 +
src/vdagent-x11.c | 15 +++
2 files changed, 16
On 07/09/2014 10:08 PM, Jeremy White wrote:
This allows the vdagent to be used in the Xsetup phase of an xdm session;
otherwise, it's X11 connection fails because of the greeter display grab.
The issue is that we daemonize before attempting the X connection.
We then immediately exit the main
On 06/23/2014 06:59 PM, Damien Dye wrote:
Hi all
am testing Xspice to replace VNC at our company an have some questions I
can't seam to solve
1) when I set the color depth in the config file to 16 the server fails to
start saying it's unsupported.
I never tried it. Seems sensible - I
On 07/02/2014 01:22 PM, Marc-André Lureau wrote:
From: Marc-André Lureau marcandre.lur...@gmail.com
The Spice server qemu reset the cursor state when
changing resolution. Although X does restore the
cursor on framebuffer changes, it doesn't for crtc
config. Restoring the cursor here is the
On 06/23/2014 11:41 PM, Jeremy White wrote:
ACK
Signed-off-by: Jeremy White jwh...@codeweavers.com
---
src/vdagentd.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/src/vdagentd.c b/src/vdagentd.c
index 1098fb6..fa47997 100644
--- a/src/vdagentd.c
On 06/24/2014 12:05 AM, Jeremy White wrote:
This allows the vdagent to be used in the Xsetup phase of an xdm session;
otherwise, its X11 connection fails because of the greeter display grab.
relies on the fact the socketpair fd's are never 0 (i.e. fd[1] below is
never 0). Which I think is
On 06/24/2014 12:05 AM, Jeremy White wrote:
This allows the vdagent to be used in the Xsetup phase of an xdm session;
otherwise, its X11 connection fails because of the greeter display grab.
But could you make the comment contain the discussion where you
explained this in more detail?
On 07/03/2014 07:49 PM, Marc-André Lureau wrote:
Proxy errors are already reported with G_IO_ERROR_PROXY messages,
however proxy name lookup error can be more detailed.
ACK
https://bugzilla.redhat.com/show_bug.cgi?id=1115986
---
gtk/spice-session.c | 1 +
1 file changed, 1 insertion(+)
On 06/24/2014 12:05 AM, Jeremy White wrote:
ACK
Signed-off-by: Jeremy White jwh...@codeweavers.com
---
src/vdagentd.c | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/src/vdagentd.c b/src/vdagentd.c
index fa47997..b5c7d14 100644
--- a/src/vdagentd.c
On Mon, Jun 09, 2014 at 04:08:37PM +0300, Alon Levy wrote:
Signed-off-by: Alon Levy al...@redhat.com
---
src/qxl_driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/qxl_driver.c b/src/qxl_driver.c
index b9aa0e9..d9bf447 100644
--- a/src/qxl_driver.c
Since 3d511c30206bd8c9a207c436186a03af0bb02962 Xspice building is broken
due to undefined MAX_RELOCS when not building with XF86DRM_MODE.
---
src/qxl_image.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/qxl_image.c b/src/qxl_image.c
index eb66b63..8927fd4 100644
--- a/src/qxl_image.c
Shut up Coverity's complaint about unchecked fcntl return values,
and especially make the code simpler and more efficient.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Reviewed-by: Alon Levy al...@redhat.com
one question below.
---
hw/usb/ccid-card-emulated.c | 29
On 06/17/2014 04:08 PM, David Mansfield wrote:
On 06/17/2014 03:24 AM, Alon Levy wrote:
On 06/16/2014 04:16 PM, David Mansfield wrote:
On 06/09/2014 09:29 AM, Alon Levy wrote:
On 06/09/2014 04:18 PM, David Mansfield wrote:
On 06/09/2014 07:18 AM, Alon Levy wrote:
On 06/03/2014 04:14 PM
On 06/16/2014 04:16 PM, David Mansfield wrote:
On 06/09/2014 09:29 AM, Alon Levy wrote:
On 06/09/2014 04:18 PM, David Mansfield wrote:
On 06/09/2014 07:18 AM, Alon Levy wrote:
On 06/03/2014 04:14 PM, David Mansfield wrote:
Bump. I'll make it easy. This is a multiple choice response form
On 05/29/2014 11:16 AM, aaron_0119 wrote:
hi,
guys, i built the spice-gtk on an arm board(Contex A9). i test it and found
that it is not very smoothly when i playing the video.
so i decided to how the video streamer be transmitted or compressed between
the server and client. i try to read
On 06/04/2014 07:45 PM, Marc-André Lureau wrote:
From: Marc-André Lureau marcandre.lur...@gmail.com
When both the client and the agent advertize
VD_AGENT_CAP_ANY_SELECTION_TYPE capability, the existing
VDAgentClipboard messages are modified to embed string
representation of the selection
On 06/03/2014 04:14 PM, David Mansfield wrote:
Bump. I'll make it easy. This is a multiple choice response form.
Anyone reading this can respond with one letter so save time and effort.
a) We're too busy with RHEL 7/paying clients, come back in a month/some
timeframe
b) There's an SEP
On 06/09/2014 02:20 PM, Marc-André Lureau wrote:
- Original Message -
On 06/04/2014 07:45 PM, Marc-André Lureau wrote:
From: Marc-André Lureau marcandre.lur...@gmail.com
When both the client and the agent advertize
VD_AGENT_CAP_ANY_SELECTION_TYPE capability, the existing
Signed-off-by: Alon Levy al...@redhat.com
---
src/qxl_kms.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/src/qxl_kms.c b/src/qxl_kms.c
index c31c62d..d952495 100644
--- a/src/qxl_kms.c
+++ b/src/qxl_kms.c
@@ -164,8 +164,8 @@ Bool qxl_pre_init_kms(ScrnInfoPtr pScrn
Signed-off-by: Alon Levy al...@redhat.com
---
src/qxl_driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/qxl_driver.c b/src/qxl_driver.c
index b9aa0e9..d9bf447 100644
--- a/src/qxl_driver.c
+++ b/src/qxl_driver.c
@@ -1242,7 +1242,7 @@ qxl_init_scrn (ScrnInfoPtr pScrn
On 06/09/2014 04:18 PM, David Mansfield wrote:
On 06/09/2014 07:18 AM, Alon Levy wrote:
On 06/03/2014 04:14 PM, David Mansfield wrote:
Bump. I'll make it easy. This is a multiple choice response form.
Anyone reading this can respond with one letter so save time and effort.
a) We're too
them with QEMU, based on Ray Strode's useful tutorial at
https://blogs.gnome.org/halfline/2013/09/08/another-smartcard-post/
but with ccid-card-emulated or vscclient instead of SPICE.
Cc: Alon Levy al...@redhat.com
Cc: Ray Strode rstr...@redhat.com
Did you mean Robert Relyea rrel...@redhat.com
12.05.2014 13:20, Markus Armbruster wrote:
Michael Tokarev m...@tls.msk.ru writes:
11.05.2014 11:58, Alon Levy wrote:
On 05/08/2014 08:19 PM, Michael Tokarev wrote:
libcacard has many functions which initializes local variables
at declaration time, which are always assigned some values later
/vcard_emul_nss.c | 16 ++--
libcacard/vreader.c| 10 --
libcacard/vscclient.c | 7 +++
4 files changed, 15 insertions(+), 31 deletions(-)
Reviewed-by: Alon Levy al...@redhat.com
Hi,
Hopefully this is not something someone discussed in the 193 unread
mails from spice-devel I have.
I'm trying to look more closely at the glz code, and it seems to be
split: decoder in glz, encoder in spice.
I propose to move them to spice-common. any objections?
The reason I propose
On 05/08/2014 08:19 PM, Michael Tokarev wrote:
libcacard has many functions which initializes local variables
at declaration time, which are always assigned some values later
(often right after declaration). Clean up these initializers.
How is this an improvement? Doesn't the compiler ignore
On 05/08/2014 06:54 PM, Michael Tokarev wrote:
This patch replaces g_malloc() in libcacard into g_new()
or g_new0() where appropriate (removing some init-to-zero
surrounding code), g_malloc+memcpy into g_memdup() and the
like.
Reviewed-by: Alon Levy al...@redhat.com
just one comment below
On 05/05/2014 07:36 PM, Michael Tokarev wrote:
05.05.2014 18:49, Alon Levy wrote:
On 04/29/2014 09:02 AM, Michael Tokarev wrote:
Basically libgthread has been rewritten in glib version 2.31, and old ways
to use thread primitives stopped working while new ways appeared. The two
interfaces
. This is
because of large addition to glib-compat.h, plus addition of compat
code to vscclient, to make it independent of qemu.
and a few others.
Thanks,
Reviewed-by: Alon Levy al...@redhat.com
Tested-by: Alon Levy al...@redhat.com
This would be nice to have too (it has nothing to do with your
On 05/02/2014 02:21 PM, Marc-André Lureau wrote:
- Original Message -
Two benchmarks:
1. standalone, actually uses LIBCMT's memcpy to compare.
2. Part of qxldd.dll (in display/res.c called from display/driver.c)
so using the same implementation.
Note: next commit removes
On 04/30/2014 07:28 PM, Marc-André Lureau wrote:
ack,
should the bug state be changed back to ASSIGNED?
I did that.
- Original Message -
From: Yonit Halperin yhalp...@redhat.com
This reverts commit 49feefa95d3595f04355c4aed53ec5bf26551046.
The patch causes the display to get
On 04/30/2014 07:32 PM, Marc-André Lureau wrote:
- Original Message -
---
xddm/build.bat | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/xddm/build.bat b/xddm/build.bat
index 1d19875..7dfe51b 100755
--- a/xddm/build.bat
+++ b/xddm/build.bat
FeatureScore is the only difference between the _vista options and the
rest, so just setting it also for windows xp using drivers results in a
simplification of the inf file, and no downside.
According to [1] we use a feature score of FC to indicate a windows 2000
display driver
[1]
---
xddm/build.bat | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/xddm/build.bat b/xddm/build.bat
index 1d19875..7dfe51b 100755
--- a/xddm/build.bat
+++ b/xddm/build.bat
@@ -16,6 +16,12 @@ if not DEFINED SPICE_COMMON_DIR (
set
---
xddm/build.bat | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/xddm/build.bat b/xddm/build.bat
index 7dfe51b..b2c5149 100755
--- a/xddm/build.bat
+++ b/xddm/build.bat
@@ -30,9 +30,10 @@ if not x%1 == x set DEST=%1
:build
cd miniport
-build -cZg
+build -ceZg
cd
---
xddm/display/amd64/x64.asm | 1 +
xddm/display/sources | 1 +
2 files changed, 2 insertions(+)
create mode 100644 xddm/display/amd64/x64.asm
diff --git a/xddm/display/amd64/x64.asm b/xddm/display/amd64/x64.asm
new file mode 100644
index 000..e32b0df
--- /dev/null
+++
---
xddm/display/res.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xddm/display/res.h b/xddm/display/res.h
index 6ce9a68..4d179c5 100644
--- a/xddm/display/res.h
+++ b/xddm/display/res.h
@@ -74,4 +74,4 @@ void EmptyReleaseRing(PDev *pdev);
void
---
xddm/display/driver.c | 14 --
1 file changed, 14 deletions(-)
diff --git a/xddm/display/driver.c b/xddm/display/driver.c
index aa4fe42..5a3dbfa 100644
--- a/xddm/display/driver.c
+++ b/xddm/display/driver.c
@@ -1252,20 +1252,6 @@ char *BitmapTypeToStr(int type)
#include utils.h
From: Yonit Halperin yhalp...@redhat.com
This reverts commit 49feefa95d3595f04355c4aed53ec5bf26551046.
The patch causes the display to get stuck. Till we understand exactly
why, I'm reverting it.
---
xddm/miniport/qxl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/xddm/miniport/qxl.c
---
xddm/display/res.c | 15 ++-
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git a/xddm/display/res.c b/xddm/display/res.c
index bfb3571..289ece5 100644
--- a/xddm/display/res.c
+++ b/xddm/display/res.c
@@ -1811,13 +1811,11 @@ static void FreeBitmapImage(PDev *pdev,
: halve
QXL_IO_UPDATE_IRQ calls is included.
Alon Levy (11):
miniport/qxl.inf: simplify by having FeatureScore for everyone
display/res.h: remove whitespace at EOF
display\driver.c: remove unused FlotaToFixed
build.bat: fix copy to install dir for amd64
build.bat: more verbose build
xddm
It is common practice to use RtlCopyMemory. Currently it is defined by the
preprocessor to be memcpy, which outperforms our implementation, see
previous benchmark commit.
This commit removes the benchmarks and our internal implementation in
favor of RtlCopyMemory.
RHBZ: 705785
---
---
xddm/display/amd64/x64.asm | 13 +
xddm/display/res.c | 4
2 files changed, 17 insertions(+)
diff --git a/xddm/display/amd64/x64.asm b/xddm/display/amd64/x64.asm
index e32b0df..36971d3 100644
--- a/xddm/display/amd64/x64.asm
+++ b/xddm/display/amd64/x64.asm
@@ -1
Two benchmarks:
1. standalone, actually uses LIBCMT's memcpy to compare.
2. Part of qxldd.dll (in display/res.c called from display/driver.c)
so using the same implementation.
Note: next commit removes benchmark code as well as fast_memcpy_* code
and related SSE check and FPU save/restore.
Some notes:
Follows AMD64 calling conventions.
Uses masm 64 (ml64.exe).
Dropped in the next patches because it is too slow.
---
xddm/display/amd64/x64.asm | 236 +
xddm/display/res.c | 13 +--
2 files changed, 241 insertions(+), 8 deletions(-)
I forgot to mention in the cover letter: I fixed the comment here per
old review by Yonit.
Review appreciated!
On 04/30/2014 05:40 PM, Alon Levy wrote:
FeatureScore is the only difference between the _vista options and the
rest, so just setting it also for windows xp using drivers results
On 04/21/2014 12:09 PM, Michael Tokarev wrote:
21.04.2014 13:01, Michael Tokarev wrote:
libtool has an argument for .syms file, which is -export-symbols.
There's no argument `-export-syms', and it looks like at least on
linux, -export-syms is just ignored. Use the correct argument,
. This makes the binary as twice
as large, but allows to have cleaner export table for libcacard.so.
Reviewed-by: Alon Levy al...@redhat.com
Any chance to get this through the trivial patch queue?
Signed-off-by: Michael Tokarev m...@tls.msk.ru
---
libcacard/Makefile |4 ++--
1 file
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 04/02/2014 12:27 PM, Christophe Fergeau wrote:
Ping ?
If this doesn't break (i.e. we have a -I directive for every required
directory) then ack.
On Tue, Mar 25, 2014 at 04:40:14PM +0100, Christophe Fergeau
wrote:
Since the (de)marshallers
The command ring and cursor rings are pushed to by the guest, and
cleared asynchronously by qemu's spice thread. It is easy to have
them non empty by bad guest behaviour, and we must never abort on bad
guest behaviour.
Signed-off-by: Alon Levy al...@redhat.com
---
hw/display/qxl.c | 8
On 03/19/2014 07:33 PM, Marc-André Lureau wrote:
Hi
On Mon, Mar 17, 2014 at 8:54 AM, Alon Levy al...@redhat.com wrote:
Would be nice to use an actual constant for this instead of relying on
G_MAXUINT16 here and above.
Sorry, I forgot to address your comments.
What about
On 02/28/2014 02:16 PM, Marc-André Lureau wrote:
From: Marc-André Lureau marcandre.lur...@redhat.com
See spice-common for protocol details. phodav, a webdav server library,
is imported thanks to a submodule, until this project has a stable API
and releases.
The webdav channel is
1 - 100 of 4078 matches
Mail list logo
