> On April 14, 2013, 7:08 p.m., Matěj Laitl wrote:
> > src/dialogs/EqualizerDialog.cpp, lines 100-102
> > <http://git.reviewboard.kde.org/r/108995/diff/4/?file=138625#file138625line100>
> >
> > code style: no space between if and (
>
> Harsh Gupta w
> On March 29, 2013, 12:03 a.m., Harsh Gupta wrote:
> > src/EngineController.cpp, line 793
> > <http://git.reviewboard.kde.org/r/108995/diff/2/?file=119751#file119751line793>
> >
> > How am I suppose to stage changes in a line ( line 791 ) in which a
>
en if and (
ooppss !!!
- Harsh
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108995/#review31016
---
On April 15, 2
my PC.
File Attachments
Equalizer snapshot
http://git.reviewboard.kde.org/media/uploaded/files/2013/02/17/equalizer.png
Thanks,
Harsh Gupta
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo
crashing on my PC.
File Attachments
Equalizer snapshot
http://git.reviewboard.kde.org/media/uploaded/files/2013/02/17/equalizer.png
Thanks,
Harsh Gupta
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman
> On March 29, 2013, 12:03 a.m., Harsh Gupta wrote:
> > src/EngineController.cpp, line 793
> > <http://git.reviewboard.kde.org/r/108995/diff/2/?file=119751#file119751line793>
> >
> > How am I suppose to stage changes in a line ( line 791 ) in which a
>
> On March 29, 2013, 12:03 a.m., Harsh Gupta wrote:
> > src/EngineController.cpp, line 793
> > <http://git.reviewboard.kde.org/r/108995/diff/2/?file=119751#file119751line793>
> >
> > How am I suppose to stage changes in a line ( line 791 ) in which a
>
://git.reviewboard.kde.org/r/108995/diff/
Testing
---
All unit test cases passed.
Note : I have tested it with gstreamer only. Xine phonon keep crashing on my PC.
File Attachments
Equalizer snapshot
http://git.reviewboard.kde.org/media/uploaded/files/2013/02/17/equalizer.png
Thanks,
Harsh
/dialogs/GeneralConfig.ui 4e33f64
Diff: http://git.reviewboard.kde.org/r/109585/diff/
Testing
---
All test case passed.
File Attachments
Screenshot
http://git.reviewboard.kde.org/media/uploaded/files/2013/03/19/moodbar.png
Thanks,
Harsh Gupta
> On March 29, 2013, 12:03 a.m., Harsh Gupta wrote:
> > src/EngineController.cpp, line 793
> > <http://git.reviewboard.kde.org/r/108995/diff/2/?file=119751#file119751line793>
> >
> > How am I suppose to stage changes in a line ( line 791 ) in which a
>
g/r/108995/#comment22381>
How am I suppose to stage changes in a line ( line 791 ) in which a
variable is first renamed and then get deleted ? Should I commit all the
changes again in order to make two different patches ?
- Harsh Gupta
On March 14, 2013, 11 p.m., Harsh Gupta
://git.reviewboard.kde.org/r/109585/diff/
Testing
---
All test case passed.
File Attachments (updated)
Screenshot
http://git.reviewboard.kde.org/media/uploaded/files/2013/03/19/moodbar.png
Thanks,
Harsh Gupta
___
Amarok
/
Testing
---
All test case passed.
Thanks,
Harsh Gupta
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
files/2013/02/17/equalizer.png
Thanks,
Harsh Gupta
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
y, visit:
http://git.reviewboard.kde.org/r/108995/#review28117
-------
On Feb. 18, 2013, 11:38 a.m., Harsh Gupta wrote:
>
> ---
> This is an automatically gener
snapshot
http://git.reviewboard.kde.org/media/uploaded/files/2013/02/17/equalizer.png
Thanks,
Harsh Gupta
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
.
Note : I have tested it with gstreamer only. Xine phonon keep crashing on my PC.
File Attachments
Equalizer snapshot
http://git.reviewboard.kde.org/media/uploaded/files/2013/02/17/equalizer.png
Thanks,
Harsh Gupta
___
Amarok-devel
> On Feb. 10, 2013, 7:34 p.m., Commit Hook wrote:
> > This review has been submitted with commit
> > 62ce5195cfe30b78ec3e234f1d1f5dbed7534a4b by Mat?j Laitl on behalf of Harsh
> > Gupta to branch master.
Thanks :)
- Harsh
--
d.kde.org/r/108716/#review27117
---
On Feb. 10, 2013, 7:16 p.m., Harsh Gupta wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewb
(updated)
-
ChangeLog 139ffa5
src/MainWindow.h 4b23679
src/MainWindow.cpp 8587784
Diff: http://git.reviewboard.kde.org/r/108716/diff/
Testing
---
All tests passed.
Thanks,
Harsh Gupta
___
Amarok-devel mailing list
Amarok-devel
://bugs.kde.org/show_bug.cgi?id=208061
Diffs (updated)
-
src/MainWindow.h 4b23679
src/MainWindow.cpp 8587784
Diff: http://git.reviewboard.kde.org/r/108716/diff/
Testing
---
All tests passed.
Thanks,
Harsh Gupta
___
Amarok-devel
tically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108716/#review27059
-------
On Feb. 10, 2013, 2:21 a.m., Harsh Gupta wrote:
>
> ---
> This is an
---
All tests passed.
Thanks,
Harsh Gupta
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
: http://git.reviewboard.kde.org/r/108716/diff/
Testing
---
All tests passed.
Thanks,
Harsh Gupta
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
/
Testing (updated)
---
All tests passed.
File Attachments
http://git.reviewboard.kde.org/media/uploaded/files/2013/02/02/0001-Randomize-playlist-with-Ctrl-H.patch
Thanks,
Harsh Gupta
___
Amarok-devel mailing list
Amarok
http://git.reviewboard.kde.org/media/uploaded/files/2013/02/02/0001-Randomize-playlist-with-Ctrl-H.patch
Thanks,
Harsh Gupta
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
26 matches
Mail list logo
