Re: [PATCH 2/4] drm/amdgpu: return -ENODEV to user space when vram is lost v2

2017-05-23 Thread zhoucm1
On 2017年05月23日 23:16, Christian König wrote: Am 23.05.2017 um 17:08 schrieb Deucher, Alexander: -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Chunming Zhou Sent: Tuesday, May 16, 2017 5:26 AM To: amd-gfx@lists.freedesktop.org Cc: Zhou, Dav

[PATCH xf86-video-amdgpu 1/1] Update URLs

2017-05-23 Thread Michel Dänzer
From: Michel Dänzer * Point to the amd-gfx mailing list * Specify the component in all bugzilla URLs * Use https:// for all HTML URLs (Ported from radeon commit d80d01a73c2eaba2e3649b7bc0a3541b3ff782f6) Signed-off-by: Michel Dänzer --- README | 14 +++--- configure.ac | 2 +

Re: [PATCH] drm/amd/display: Limit DCN to x86 arch

2017-05-23 Thread Michel Dänzer
On 23/05/17 10:37 PM, Harry Wentland wrote: > On 2017-05-20 04:13 AM, Christian König wrote: >> Am 19.05.2017 um 22:28 schrieb Harry Wentland: >>> >>> I realize this is raising a lot of concern. I was concerned myself >>> when I first saw this. Beside calling kernel_fpu_begin() and >>> kernel_fpu_

RE: [PATCH 0/5] GFX9 KIQ

2017-05-23 Thread Liu, Shaoyun
I don't have any test for KCQ , but KFD use the KIQ to invalidate_tlbs , I try to add some print message in the code to prove it go through the new code path , but seems I don't see any messages I added. I tried pr_info , pr_err and printk , DRM_ERROR and nothing works , anything changed

RE: [PATCH] drm/amd/amdgpu: Return error if initiating read out of range on vram

2017-05-23 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Tom St Denis > Sent: Tuesday, May 23, 2017 11:59 AM > To: amd-gfx@lists.freedesktop.org > Cc: StDenis, Tom > Subject: [PATCH] drm/amd/amdgpu: Return error if initiating read out of > range on

Re: [PATCH 0/5] GFX9 KIQ

2017-05-23 Thread Alex Deucher
On Tue, May 23, 2017 at 5:31 PM, Alex Deucher wrote: > On Fri, May 12, 2017 at 7:11 AM, Tom St Denis wrote: >> On 11/05/17 07:33 PM, Tom St Denis wrote: >>> >>> On 11/05/17 02:35 PM, Alex Deucher wrote: These are the laste of the gfx9 KIQ patches that haven't landed yet. Can someo

Re: [PATCH 0/5] GFX9 KIQ

2017-05-23 Thread Alex Deucher
On Fri, May 12, 2017 at 7:11 AM, Tom St Denis wrote: > On 11/05/17 07:33 PM, Tom St Denis wrote: >> >> On 11/05/17 02:35 PM, Alex Deucher wrote: >>> >>> These are the laste of the gfx9 KIQ patches that haven't landed yet. Can >>> someone with gfx9 capable hw test this (vega10 or raven)? This is

[PATCH 2/4] drm/radeon/ci: disable mclk switching for high refresh rates (v2)

2017-05-23 Thread Alex Deucher
Even if the vblank period would allow it, it still seems to be problematic on some cards. v2: fix logic inversion (Nils) bug: https://bugs.freedesktop.org/show_bug.cgi?id=96868 Signed-off-by: Alex Deucher --- drivers/gpu/drm/radeon/ci_dpm.c | 6 ++ 1 file changed, 6 insertions(+) diff --g

[PATCH 3/4] drm/amd/powerplay/smu7: add vblank check for mclk switching (v2)

2017-05-23 Thread Alex Deucher
Check to make sure the vblank period is long enough to support mclk switching. v2: drop needless initial assignment (Nils) bug: https://bugs.freedesktop.org/show_bug.cgi?id=96868 Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 31 +--- 1 f

[PATCH 1/4] drm/amdgpu/ci: disable mclk switching for high refresh rates (v2)

2017-05-23 Thread Alex Deucher
Even if the vblank period would allow it, it still seems to be problematic on some cards. v2: fix logic inversion (Nils) bug: https://bugs.freedesktop.org/show_bug.cgi?id=96868 Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/ci_dpm.c | 6 ++ 1 file changed, 6 insertions(+) diff

[PATCH 4/4] drm/amd/powerplay/smu7: disable mclk switching for high refresh rates

2017-05-23 Thread Alex Deucher
Even if the vblank period would allow it, it still seems to be problematic on some cards. bug: https://bugs.freedesktop.org/show_bug.cgi?id=96868 Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [PATCH] winsys/amdgpu: align VA allocations to fragment size

2017-05-23 Thread Marek Olšák
On Tue, May 23, 2017 at 6:43 PM, Christian König wrote: > From: Christian König > > BOs larger than the minimum fragment size should have their VA > alignet to at least the fragment size for optimal performance. > > Signed-off-by: Christian König > --- > src/amd/common/ac_gpu_info.c

Re: [PATCH] drm/radeon: Fix oops upon driver load on PowerXpress laptops

2017-05-23 Thread Alex Deucher
On Tue, May 23, 2017 at 2:47 PM, Deucher, Alexander wrote: >> -Original Message- >> From: Lukas Wunner [mailto:lu...@wunner.de] >> Sent: Monday, May 22, 2017 11:51 PM >> To: Michel Dänzer >> Cc: Nicolai Stange; Sean Paul; Deucher, Alexander; dri- >> de...@lists.freedesktop.org; amd-gfx@lis

Re: [PATCH 7/7] drm/amdgpu: enable huge page handling in the VM v2

2017-05-23 Thread Felix Kuehling
Do you need something in amdgpu_vm_update_level to stop it from overwriting huge page PTEs? Regards, Felix On 17-05-23 12:52 PM, Christian König wrote: > From: Christian König > > The hardware can use huge pages to map 2MB of address space with only one PDE. > > v2: few cleanups and rebased >

Re: [PATCH 1/7] drm/amdgpu: cleanup adjust_mc_addr handling v3

2017-05-23 Thread Felix Kuehling
On 17-05-23 12:52 PM, Christian König wrote: > --- a/drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c > @@ -395,7 +395,13 @@ > static uint64_t gmc_v6_0_get_vm_pte_flags(struct amdgpu_device *adev, > return pte_flag; > } > +static uint64_t gmc_v6_0_ge

[PATCH umr] Add error checking to umr_read_vram().

2017-05-23 Thread Tom St Denis
Signed-off-by: Tom St Denis --- src/lib/read_vram.c | 27 ++- 1 file changed, 18 insertions(+), 9 deletions(-) diff --git a/src/lib/read_vram.c b/src/lib/read_vram.c index deb958dc4c88..80ef4a5664de 100644 --- a/src/lib/read_vram.c +++ b/src/lib/read_vram.c @@ -155,7 +155

RE: [PATCH] drm/radeon: Fix oops upon driver load on PowerXpress laptops

2017-05-23 Thread Deucher, Alexander
> -Original Message- > From: Lukas Wunner [mailto:lu...@wunner.de] > Sent: Monday, May 22, 2017 11:51 PM > To: Michel Dänzer > Cc: Nicolai Stange; Sean Paul; Deucher, Alexander; dri- > de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org; Koenig, > Christian > Subject: Re: [PATCH] drm

RE: [PATCH 1/2] drm/amdgpu: fix null point error when rmmod amdgpu.

2017-05-23 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Rex Zhu > Sent: Monday, May 22, 2017 5:10 AM > To: amd-gfx@lists.freedesktop.org > Cc: Zhu, Rex > Subject: [PATCH 1/2] drm/amdgpu: fix null point error when rmmod amdgpu. > > this bug happene

RE: [PATCH] drm/amd: include instead of "linux/delay.h"

2017-05-23 Thread Deucher, Alexander
> -Original Message- > From: Koenig, Christian > Sent: Monday, May 22, 2017 4:12 AM > To: Christian König; Masahiro Yamada; dri-de...@lists.freedesktop.org; > Daniel Vetter; Deucher, Alexander; Daenzer, Michel; linux- > ker...@vger.kernel.org; amd-gfx@lists.freedesktop.org > Subject: Re: [P

RE: [PATCH] iommu/amd: flush IOTLB for specific domains only (v3)

2017-05-23 Thread Deucher, Alexander
> -Original Message- > From: Arindam Nath [mailto:anath@gmail.com] On Behalf Of > arindam.n...@amd.com > Sent: Monday, May 22, 2017 3:48 AM > To: io...@lists.linux-foundation.org > Cc: amd-gfx@lists.freedesktop.org; Joerg Roedel; Deucher, Alexander; > Bridgman, John; dr...@endlessm.com;

RE: [PATCH] drm/amdgpu: fix ocl test performance drop

2017-05-23 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Flora Cui > Sent: Thursday, May 18, 2017 11:37 PM > To: Christian K�nig > Cc: amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH] drm/amdgpu: fix ocl test performance drop > > btw, what's ab

RE: [PATCH xf86-video-ati] Update URLs

2017-05-23 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Michel Dänzer > Sent: Wednesday, May 17, 2017 10:17 PM > To: amd-gfx@lists.freedesktop.org > Subject: [PATCH xf86-video-ati] Update URLs > > From: Michel Dänzer > > * Point to the amd-gfx m

Huge page support for Vega10

2017-05-23 Thread Christian König
another round of this patch set, I've dropped all not necessary patches. Going to handle all the cleanups later on when I have more time to test. Anyway huge pages now at least not cause any any performance regression any more, but they still doesn't seem to have the desired effect speedup effec

[PATCH 2/7] drm/amdgpu: add some extra VM error handling

2017-05-23 Thread Christian König
From: Christian König If updating the PDs fails we now invalidate all entries to try again later. Signed-off-by: Christian König Reviewed-by: Chunming Zhou Reviewed-by: Junwei Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 34 +- 1 file changed, 33 inserti

[PATCH 6/7] drm/amdgpu: increase fragmentation size for Vega10

2017-05-23 Thread Christian König
From: Christian König The fragment bits work differently for Vega10 compared to previous generations. Increase the fragment size to 2MB for now to better handle that. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 5 +++-- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c

[PATCH 1/7] drm/amdgpu: cleanup adjust_mc_addr handling v3

2017-05-23 Thread Christian König
From: Christian König Rename adjust_mc_addr to get_vm_pde and check the address bits in one place. v2: handle vcn as well, keep setting the valid bit manually, add a BUG_ON() for GMC v6, v7 and v8 as well. v3: handle vcn_v1_0_enc_ring_emit_vm_flush as well. Signed-off-by: Christian König -

[PATCH 4/7] drm/amdgpu: cache the complete pde

2017-05-23 Thread Christian König
From: Christian König Makes it easier to update the PDE with huge pages. Signed-off-by: Christian König Reviewed-by: Junwei Zhang Reviewed-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 16 +--- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/driver

[PATCH 5/7] drm/amdgpu: stop joining VM PTE updates

2017-05-23 Thread Christian König
From: Christian König This isn't beneficial any more since VRAM allocations are now split so that they fits into a single page table. Signed-off-by: Christian König Reviewed-by: Junwei Zhang Reviewed-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 61 --

[PATCH 3/7] drm/amdgpu: Return EINVAL if no PT BO

2017-05-23 Thread Christian König
From: Harish Kasiviswanathan This change is also useful for the upcoming changes where page tables can be updated by CPU. Change-Id: I07510ed60c94cf1944ee96bb4b16c40ec88ea17c Signed-off-by: Harish Kasiviswanathan Reviewed-by: Christian König Reviewed-by: Junwei Zhang --- drivers/gpu/drm/amd/

[PATCH 7/7] drm/amdgpu: enable huge page handling in the VM v2

2017-05-23 Thread Christian König
From: Christian König The hardware can use huge pages to map 2MB of address space with only one PDE. v2: few cleanups and rebased Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 95 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 4 ++

[PATCH] winsys/amdgpu: align VA allocations to fragment size

2017-05-23 Thread Christian König
From: Christian König BOs larger than the minimum fragment size should have their VA alignet to at least the fragment size for optimal performance. Signed-off-by: Christian König --- src/amd/common/ac_gpu_info.c | 1 + src/amd/common/ac_gpu_info.h | 1 + src/g

Re: [PATCH] drm/amd/amdgpu: Return error if initiating read out of range on vram

2017-05-23 Thread Christian König
Am 23.05.2017 um 17:59 schrieb Tom St Denis: If you initiate a read that is out of the VRAM address space return ENXIO instead of 0. Reads that begin below that point will read upto the VRAM limit as before. Signed-off-by: Tom St Denis Reviewed-by: Christian König --- drivers/gpu/drm/am

RE: [PATCH] drm/amdgpu: add an INFO query for monitoring VRAM CPU page faults

2017-05-23 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Marek Olšák > Sent: Wednesday, May 17, 2017 2:06 PM > To: amd-gfx@lists.freedesktop.org > Subject: [PATCH] drm/amdgpu: add an INFO query for monitoring VRAM > CPU page faults > > From: Marek

[PATCH] drm/amd/amdgpu: Return error if initiating read out of range on vram

2017-05-23 Thread Tom St Denis
If you initiate a read that is out of the VRAM address space return ENXIO instead of 0. Reads that begin below that point will read upto the VRAM limit as before. Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drive

Re: [PATCH 6/6] drm/amd/display: Tidy up mem_input_program_surface_flip_and_addr()

2017-05-23 Thread Harry Wentland
On 2017-05-23 11:17 AM, Deucher, Alexander wrote: -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Tom St Denis Sent: Tuesday, May 16, 2017 10:22 AM To: amd-gfx@lists.freedesktop.org Cc: StDenis, Tom Subject: [PATCH 6/6] drm/amd/display: Tidy up

RE: [PATCH] drm/amdgpu: update golden settings

2017-05-23 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Ken Wang > Sent: Wednesday, May 17, 2017 5:08 AM > To: amd-gfx@lists.freedesktop.org > Cc: Wang, Ken > Subject: [PATCH] drm/amdgpu: update golden settings > > Change-Id: Ifcc39748c36273fa764c

RE: [PATCH] gpu: drm: radeon: refactor code

2017-05-23 Thread Deucher, Alexander
> -Original Message- > From: Koenig, Christian > Sent: Wednesday, May 17, 2017 4:23 AM > To: Gustavo A. R. Silva; Deucher, Alexander; David Airlie > Cc: amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; linux- > ker...@vger.kernel.org > Subject: Re: [PATCH] gpu: drm: radeon: r

RE: [PATCH xf86-video-amdgpu] Use plain glamor_egl_create_textured_screen().

2017-05-23 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Michel Dänzer > Sent: Wednesday, May 17, 2017 3:16 AM > To: amd-gfx@lists.freedesktop.org > Subject: [PATCH xf86-video-amdgpu] Use plain > glamor_egl_create_textured_screen(). > > From: Eric

Re: [PATCH] drm/amd/display: Limit DCN to x86 arch

2017-05-23 Thread Felix Kuehling
On 17-05-23 09:37 AM, Harry Wentland wrote: > > > On 2017-05-20 04:13 AM, Christian König wrote: >> Are you aware of anyone using our GPUs on non-X86 architectures? If >> so, I never heard of it. >> >> Yeah, there are actually quite a number of people. That's one of the >> reasons why we still have

Re: [PATCH 2/4] drm/amdgpu: return -ENODEV to user space when vram is lost v2

2017-05-23 Thread Christian König
Am 23.05.2017 um 17:08 schrieb Deucher, Alexander: -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Chunming Zhou Sent: Tuesday, May 16, 2017 5:26 AM To: amd-gfx@lists.freedesktop.org Cc: Zhou, David(ChunMing) Subject: [PATCH 2/4] drm/amdgpu: re

RE: [PATCH 6/6] drm/amd/display: Tidy up mem_input_program_surface_flip_and_addr()

2017-05-23 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Tom St Denis > Sent: Tuesday, May 16, 2017 10:22 AM > To: amd-gfx@lists.freedesktop.org > Cc: StDenis, Tom > Subject: [PATCH 6/6] drm/amd/display: Tidy up > mem_input_program_surface_flip_and_

RE: [PATCH 2/4] drm/amdgpu: return -ENODEV to user space when vram is lost v2

2017-05-23 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Chunming Zhou > Sent: Tuesday, May 16, 2017 5:26 AM > To: amd-gfx@lists.freedesktop.org > Cc: Zhou, David(ChunMing) > Subject: [PATCH 2/4] drm/amdgpu: return -ENODEV to user space when > vram

RE: [PATCH 2/2] drm/amd/amdgpu: Clean up gmc6 wait_for_idle

2017-05-23 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Tom St Denis > Sent: Monday, May 15, 2017 2:26 PM > To: amd-gfx@lists.freedesktop.org > Cc: StDenis, Tom > Subject: [PATCH 2/2] drm/amd/amdgpu: Clean up gmc6 wait_for_idle > > Signed-off-by:

RE: [PATCH 2/2] drm/amd/amdgpu: Tidy up static int dce_v6_0_get_num_crtc()

2017-05-23 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Tom St Denis > Sent: Monday, May 15, 2017 10:58 AM > To: amd-gfx@lists.freedesktop.org > Cc: StDenis, Tom > Subject: [PATCH 2/2] drm/amd/amdgpu: Tidy up static int > dce_v6_0_get_num_crtc() >

Re: [PATCH 5/5] drm/amd/amdgpu: Use modern 32/64-bit types in gfx6

2017-05-23 Thread Tom St Denis
On 23/05/17 10:28 AM, Deucher, Alexander wrote: -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Tom St Denis Sent: Monday, May 15, 2017 9:49 AM To: amd-gfx@lists.freedesktop.org Cc: StDenis, Tom Subject: [PATCH 5/5] drm/amd/amdgpu: Use modern 3

RE: [PATCH 1/5] drm/amd/amdgpu: Clean up GFX6 tilemode programming

2017-05-23 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Tom St Denis > Sent: Monday, May 15, 2017 9:49 AM > To: amd-gfx@lists.freedesktop.org > Cc: StDenis, Tom > Subject: [PATCH 1/5] drm/amd/amdgpu: Clean up GFX6 tilemode > programming > > Signed

RE: [PATCH 5/5] drm/amd/amdgpu: Use modern 32/64-bit types in gfx6

2017-05-23 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Tom St Denis > Sent: Monday, May 15, 2017 9:49 AM > To: amd-gfx@lists.freedesktop.org > Cc: StDenis, Tom > Subject: [PATCH 5/5] drm/amd/amdgpu: Use modern 32/64-bit types in gfx6 > > Switch t

[PATCH 27/31] drm/amd/display: fix YUV surface address programming sequence

2017-05-23 Thread Harry Wentland
From: Tony Cheng need to program DCSURF_PRIMARY_SURFACE_ADDRESS last as HW automatically latch rest of addr regs on write when SURFACE_UPDATE_LOCK is not used Change-Id: I9284f3cebd02ed3c25c844bc14a95ecc45b1d123 Signed-off-by: Tony Cheng Reviewed-by: Yongqiang Sun Acked-by: Harry Wentland ---

[PATCH 20/31] drm/amd/display: Fix indentation in dce120_tg_program_timing()

2017-05-23 Thread Harry Wentland
From: Tom St Denis Change-Id: I8f7cb2a366d112414fe4058affe36b14b38e7105 Signed-off-by: Tom St Denis Reviewed-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/dce120/dce120_timing_generator.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/disp

[PATCH 30/31] drm/amd/display: Remove unused addr var in TG

2017-05-23 Thread Harry Wentland
Change-Id: I3a2032942816f66fc8a89ea0911d3cac3d187d19 Signed-off-by: Harry Wentland Reviewed-by: Sun peng Li Reviewed-by: Roman Li Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/dce120/dce120_timing_generator.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/gpu/d

[PATCH 08/31] drm/amd/display: Fix dcn10 cursor set position hang

2017-05-23 Thread Harry Wentland
From: "Leo (Sunpeng) Li" Calling dcn10_cursor_set_position() before dcn10_cursor_set_attributes() with invalid (0-value) attributes can cause the ASIC to hang. This fix checks that address.quadpart is non-zero within set_position before calling set_attributes. Change-Id: I89d45b5e66b60bb936c02b9

[PATCH 25/31] drm/amd/display: Query for update plane type.

2017-05-23 Thread Harry Wentland
From: Andrey Grodzovsky Use DC interface to query for plane update type so in case of FULL update you flush any outstanding commits. Change-Id: If9104ba3072f115a2fe2fe1e86882b1a8b07bb5e Signed-off-by: Andrey Grodzovsky Reviewed-by: Harry Wentland --- .../drm/amd/display/amdgpu_dm/amdgpu_dm_ty

[PATCH 26/31] drm/amd/display: Remove redundant condition.

2017-05-23 Thread Harry Wentland
From: Andrey Grodzovsky You cannot have modeset and flip in the same call for same CRTC, in such case it will be set mode and set plane, not a flip. Change-Id: If7e7ef4a62dfc1c62b2a3fef63a4a6316d0155d3 Signed-off-by: Andrey Grodzovsky Reviewed-by: Andrey Grodzovsky Acked-by: Harry Wentland --

[PATCH 31/31] drm/amd/display: No need to assert on stream_status

2017-05-23 Thread Harry Wentland
This will be NULL on a new stream. DC handles it gracefully. Signed-off-by: Harry Wentland --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_types.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_types.c b/drivers/gpu/drm/amd/display/amdg

[PATCH 22/31] drm/amd/display: Clean up indentation in dce120_tg_set_blank()

2017-05-23 Thread Harry Wentland
From: Tom St Denis Change-Id: Ib2f7b1a4c55033028b88351e8d278cfb77b71c4d Signed-off-by: Tom St Denis Reviewed-by: Harry Wentland --- .../drm/amd/display/dc/dce120/dce120_timing_generator.c | 16 +--- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/amd

[PATCH 28/31] drm/amd/display: remove GRPH_SURFACE_UPDATE_IMMEDIATE_EN field programming

2017-05-23 Thread Harry Wentland
From: Dmytro Laktyushkin This is causing asserts for dce 8 and 10 since they do not contain this field. It is also unnecessary for later DCEs as it is left in it's default state of 0 Change-Id: Icdc977f8f1990065d3762efda5dd85224d9c534b Signed-off-by: Dmytro Laktyushkin Reviewed-by: Tony Cheng

[PATCH 19/31] drm/amd/display: Tidy up dce120_timing_generator_enable_advanced_request()

2017-05-23 Thread Harry Wentland
From: Tom St Denis Simplify the function by removing identical looking code blocks. Change-Id: Ibaad41529f5657189599328493d12d951de1e304 Signed-off-by: Tom St Denis Reviewed-by: Harry Wentland --- .../display/dc/dce120/dce120_timing_generator.c| 37 +++--- 1 file changed,

[PATCH 11/31] drm/amd/display: read VM settings from MMHUB

2017-05-23 Thread Harry Wentland
From: Tony Cheng instead of GC, as after GFX off, GC can be power gated any time Change-Id: Ia40d341ffd06fb1928bd8d95a4b3ef7eca4f73d1 Signed-off-by: Tony Cheng Reviewed-by: Dmytro Laktyushkin Acked-by: Harry Wentland --- .../gpu/drm/amd/display/dc/dcn10/dcn10_mem_input.h | 24 +++

[PATCH 29/31] drm/amd/display: fix flip register write sequence

2017-05-23 Thread Harry Wentland
From: Dmytro Laktyushkin Change-Id: I0a1b924f5a9e66b3e24f8ac2ca1b6597da919305 Signed-off-by: Dmytro Laktyushkin Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- .../gpu/drm/amd/display/dc/dcn10/dcn10_mem_input.c | 56 ++ .../gpu/drm/amd/display/dc/dcn10/dcn10_mem_input

[PATCH 18/31] drm/amd/display: Fix ASSR enablement on DP to EDP converter

2017-05-23 Thread Harry Wentland
From: Ayyappa Chandolu ASSR mode is not enable when we connect eDP panel via DP to eDP converter. connector_signal is coming as SIGNAL_TYPE_DISPLAY_PORT. Present code ignoring panel_mode_edp for SIGNAL_TYPE_DISPLAY_PORT. Added checking panel_mode_edp for all signals. Change-Id: I2dbfe6aea7ad6035

[PATCH 24/31] drm/amd/display: Tidy up mem_input_program_surface_flip_and_addr()

2017-05-23 Thread Harry Wentland
From: Tom St Denis Change-Id: I0f893a9abad76da9b403da6103b192af39174088 Signed-off-by: Tom St Denis Reviewed-by: Harry Wentland Reviewed-by: Tony Cheng --- drivers/gpu/drm/amd/display/dc/dce/dce_mem_input.c | 25 -- 1 file changed, 9 insertions(+), 16 deletions(-) diff --

[PATCH 17/31] drm/amd/display: Add missed wait_for_prev_commits.

2017-05-23 Thread Harry Wentland
From: Andrey Grodzovsky Change-Id: Ie5f33497e8ab22da8ae3549028023e0e5837867f Signed-off-by: Andrey Grodzovsky Reviewed-by: Harry Wentland --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_types.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu

[PATCH 13/31] drm/amd/display: make dc_get_validate_context re-entrant

2017-05-23 Thread Harry Wentland
From: Dmytro Laktyushkin Change-Id: Ie999d2dc977f0018ee289bfaee48e84d6135de2e Signed-off-by: Dmytro Laktyushkin Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/core/dc.c | 44 ++ drivers/gpu/drm/amd/display/dc/core/dc_resource.

[PATCH 10/31] drm/amd/display: Unify loop for surface update and page flip.

2017-05-23 Thread Harry Wentland
From: Andrey Grodzovsky Remove extra loop we have for page flips and do flips in same loop we do for surface create/update. Add documentation for synchronization between commits on different crtcs. Rename function to have DM prefix. Change-Id: Ibb6644b15f75981eae7c65a891a9314fb5c23fe9 Signed-off

[PATCH 16/31] drm/amd/display: Implement input gamma LUT

2017-05-23 Thread Harry Wentland
From: "Leo (Sunpeng) Li" 1. Implemented dcn10_ipp_program_input_lut(), following the existing interface. 2. Added missing registers as needed 3. Change to REG_GET for *ram_select() funcs. 4. Removed gamma table init from DiagsDM::make_surface() for resolving CRC errors. Reason: Legacy LUT w

[PATCH 14/31] drm/amd/display: revert dc_get_validate_context re-entrancy fix

2017-05-23 Thread Harry Wentland
From: Dmytro Laktyushkin Apply dc_get_validate_context re-entrancy fix to dc_validate_resources instead Change-Id: I8502010ff24f6b3b4ea932e1042fdca1a02a5a0c Signed-off-by: Dmytro Laktyushkin Reviewed-by: Dmytro Laktyushkin Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/core/dc.c

[PATCH 23/31] drm/amd/display: Tidy up dce120_clock_source_create()

2017-05-23 Thread Harry Wentland
From: Tom St Denis Also change sizeof to be automatic based on type declaration. Change-Id: I0353d84fdbc889ba0be162566e711a8a7fbc0256 Signed-off-by: Tom St Denis Reviewed-by: Harry Wentland Reviewed-by: Tony Cheng --- drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c | 4 ++-- 1 file c

[PATCH 21/31] drm/amd/display: Make dce120_tg_is_blanked() more legible

2017-05-23 Thread Harry Wentland
From: Tom St Denis Change-Id: I0a0cb44a5224a74dd4f0a819c3e8c38c2afca8a1 Signed-off-by: Tom St Denis Reviewed-by: Harry Wentland --- .../drm/amd/display/dc/dce120/dce120_timing_generator.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/amd/

[PATCH 02/31] drm/amd/display: fix mpo blanking out on one of planes being set not visible

2017-05-23 Thread Harry Wentland
From: Dmytro Laktyushkin Change-Id: Ib270db25b4bcb14226f740aa5a8926d0f9c736ca Signed-off-by: Dmytro Laktyushkin Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/dce/dce_mem_input.c | 3 +- drivers/gpu/drm/amd/display/dc/dce/dce_mem_input.h | 3 +- .../amd/

[PATCH 05/31] drm/amd/display: dce 8 - 12 mem_input refactor to new style

2017-05-23 Thread Harry Wentland
From: Dmytro Laktyushkin Change-Id: Ie24528a1e8e70a94eb4f029289ea1c4e8f8722b7 Signed-off-by: Dmytro Laktyushkin Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/dce/dce_mem_input.c | 306 +-- drivers/gpu/drm/amd/display/dc/dce/dce_mem_input.h | 1

[PATCH 12/31] drm/amd/display: Fix 5th display lightup on Vega10

2017-05-23 Thread Harry Wentland
From: Roman Li - fixing bug in calculation of reg offset for D5VGA_CONTROL Change-Id: I0e08d59d03c8daaaf4848a71fac38c37eba492c5 Signed-off-by: Roman Li Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/dce120/dce120_timing_generator.c | 2 +- 1 file changed,

[PATCH 15/31] drm/amd/display: Refactor use_lut() from dce110 to dce

2017-05-23 Thread Harry Wentland
From: "Leo (Sunpeng) Li" use_lut() checks if the input surface's pixel format is compatible with a 256 entry LUT. This function can be used across different versions and not just dce11. Change-Id: Ia2813007c91f39939e0ceef65e2f68af0a5e235c Signed-off-by: Leo (Sunpeng) Li Reviewed-by: Tony Cheng

[PATCH 06/31] drm/amd/display: Use dc_update_surfaces_for_stream for flip.

2017-05-23 Thread Harry Wentland
From: Andrey Grodzovsky Today we use special interface for flip because of fear of cuncurency issues over dc->current_ctx. This should be no longer an issue when flipping on multiple CRTCs concurently since for fast update (as flip is) no new context is created and the exsisitng is not destroyed.

[PATCH 07/31] drm/amd/display: Clen unused interface.

2017-05-23 Thread Harry Wentland
From: Andrey Grodzovsky Change-Id: Icf443def80e33f255d2d4c151a36c06951d275d2 Signed-off-by: Andrey Grodzovsky Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/core/dc.c | 26 -- drivers/gpu/drm/amd/display/dc/dc.h | 12 --

[PATCH 04/31] drm/amd/display: Disable ABM when eDP is disabled

2017-05-23 Thread Harry Wentland
From: Amy Zhang - Add immediate ABM disable when eDP is disabled - Fix purple screen when ABM is mistakenly enabled on non eDP display Change-Id: Iff09807f7051126ba95b043061a2f7b1600b34a2 Signed-off-by: Amy Zhang Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- drivers/gpu/drm/amd/displa

[PATCH 03/31] drm/amd/display: Fix slow FPS.

2017-05-23 Thread Harry Wentland
From: Andrey Grodzovsky Typo in expresion. Change-Id: I156388e19ccfa40996a16383c1532ffde687427e Signed-off-by: Andrey Grodzovsky Reviewed-by: Andrey Grodzovsky Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletion

[PATCH 01/31] drm/amd/display: Program CSC Mode For BT2020

2017-05-23 Thread Harry Wentland
From: Amy Zhang - Add BT2020 color space in the set output csc default Change-Id: I50a4aa392b0bfb403b9e633c083ae230485b2f35 Signed-off-by: Amy Zhang Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_opp.c | 3 +++ 1 file changed, 3 insertions(+)

[PATCH 09/31] drm/amd/display: add missing GRPH_UPDATE_LOCK field macro for dce_mem_input

2017-05-23 Thread Harry Wentland
From: Dmytro Laktyushkin Change-Id: I891ab6c4681da08dd2d9111cb77a1f87348b2420 Signed-off-by: Dmytro Laktyushkin Reviewed-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/dce/dce_mem_input.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_mem_inpu

[PATCH 00/31] DC Linux Patches May 23, 2017

2017-05-23 Thread Harry Wentland
* Use update_surfaces for stream instead of special casing it * Fix wrong scanline reporting * Bunch of other bug fixes for Raven, Vega, and others * Some small cleanups and a large cleanup in memory interface Amy Zhang (2): drm/amd/display: Program CSC Mode For BT2020 drm/amd/display: Dis

Re: [PATCH] drm/radeon: fix "force the UVD DPB into VRAM as well"

2017-05-23 Thread Alex Deucher
On Thu, May 18, 2017 at 8:24 AM, Christian König wrote: > From: Christian König > > The DPB must be in VRAM, but not in the first segment. > > Signed-off-by: Christian König > Tested-by: Arthur Marsh Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/radeon/radeon_uvd.c | 2 +- > 1 file chan

Re: [PATCH] drm/amdgpu: correct emit frame size for vcn dec/enc ring

2017-05-23 Thread Alex Deucher
On Mon, May 15, 2017 at 6:16 AM, Hawking Zhang wrote: > only mmhub will be invalidated during vcn dec/enc vm flush > > Change-Id: Ide47c892c98a12c6a50918237595135fd7bf208b > Signed-off-by: Hawking Zhang Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 4 ++-- > 1 file

Re: [PATCH] drm/amdgpu: correct vmhub for vcn dec/enc ring

2017-05-23 Thread Alex Deucher
On Mon, May 15, 2017 at 5:06 AM, Hawking Zhang wrote: > Change-Id: I63002c95c25cc3e2df3931d7d0e6b886b1b7e373 > Signed-off-by: Hawking Zhang Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/amd/am

Re: [PATCH] drm/amd/display: Limit DCN to x86 arch

2017-05-23 Thread Harry Wentland
On 2017-05-20 04:13 AM, Christian König wrote: Am 19.05.2017 um 22:28 schrieb Harry Wentland: On 2017-05-19 04:18 PM, Dave Airlie wrote: On 20 May 2017 at 05:36, Harry Wentland wrote: On 2017-05-19 11:02 AM, Christian König wrote: Am 19.05.2017 um 16:01 schrieb Harry Wentland: DCN bw

Re: [PATCH] drm/radeon: Fix oops upon driver load on PowerXpress laptops

2017-05-23 Thread Daniel Vetter
On Tue, May 23, 2017 at 12:00:16PM +0200, Lukas Wunner wrote: > On Mon, May 22, 2017 at 09:24:34PM +0200, Daniel Vetter wrote: > > On Thu, May 18, 2017 at 09:33:44PM +0200, Lukas Wunner wrote: > > > Nicolai Stange reports the following oops which is caused by > > > dereferencing rdev->pdev before i

RE: [PATCH xf86-video-amdgpu] Simplify tracking of PRIME scanout pixmap

2017-05-23 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Michel Dänzer > Sent: Friday, May 12, 2017 6:11 AM > To: amd-gfx@lists.freedesktop.org > Subject: [PATCH xf86-video-amdgpu] Simplify tracking of PRIME scanout > pixmap > > From: Michel Dänzer

RE: [PATCH 1/1] amdgpu: move asic id table to a separate file

2017-05-23 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Michel Dänzer > Sent: Thursday, May 11, 2017 8:50 PM > To: Li, Samuel > Cc: amd-gfx@lists.freedesktop.org; Yuan, Xiaojie > Subject: Re: [PATCH 1/1] amdgpu: move asic id table to a separate fil

Re: [PATCH 0/3] drm/amdgpu: Tweaks for high pressure on CPU visible VRAM

2017-05-23 Thread Marek Olšák
On Tue, May 23, 2017 at 2:45 AM, Michel Dänzer wrote: > On 22/05/17 07:09 PM, Marek Olšák wrote: >> On Mon, May 22, 2017 at 12:00 PM, Michel Dänzer wrote: >>> On 20/05/17 06:26 PM, Marek Olšák wrote: On May 20, 2017 3:26 AM, "Michel Dänzer" >>> > wrote:

Re: [PATCH] drm/radeon: Fix oops upon driver load on PowerXpress laptops

2017-05-23 Thread Christian König
Am 23.05.2017 um 12:14 schrieb Lukas Wunner: On Tue, May 23, 2017 at 09:32:38AM +0200, Christian König wrote: Am 23.05.2017 um 05:55 schrieb Michel Dänzer: On 23/05/17 12:50 PM, Lukas Wunner wrote: On Tue, May 23, 2017 at 12:09:49PM +0900, Michel Dänzer wrote: On 22/05/17 11:04 PM, Lukas Wunn

Re: [PATCH] drm/radeon: Fix oops upon driver load on PowerXpress laptops

2017-05-23 Thread Lukas Wunner
On Tue, May 23, 2017 at 09:32:38AM +0200, Christian König wrote: > Am 23.05.2017 um 05:55 schrieb Michel Dänzer: > >On 23/05/17 12:50 PM, Lukas Wunner wrote: > >>On Tue, May 23, 2017 at 12:09:49PM +0900, Michel Dänzer wrote: > >>>On 22/05/17 11:04 PM, Lukas Wunner wrote: > On Sun, May 21, 2017

Re: [PATCH] drm/radeon: Fix oops upon driver load on PowerXpress laptops

2017-05-23 Thread Lukas Wunner
On Mon, May 22, 2017 at 09:24:34PM +0200, Daniel Vetter wrote: > On Thu, May 18, 2017 at 09:33:44PM +0200, Lukas Wunner wrote: > > Nicolai Stange reports the following oops which is caused by > > dereferencing rdev->pdev before it's subsequently set by > > radeon_device_init(). Fix it. > > > >

Re: [PATCH] drm/radeon: Fix oops upon driver load on PowerXpress laptops

2017-05-23 Thread Lukas Wunner
On Mon, May 22, 2017 at 03:35:48PM -0400, Sean Paul wrote: > On Mon, May 22, 2017 at 04:04:07PM +0200, Lukas Wunner wrote: > > On Sun, May 21, 2017 at 09:31:09AM +0200, Nicolai Stange wrote: > > > On Thu, May 18 2017, Lukas Wunner wrote: > > [snip] > > > > Reported-by: Nicolai Stange > > > > Fixes

Re: [PATCH] drm/radeon: Fix oops upon driver load on PowerXpress laptops

2017-05-23 Thread Christian König
Am 23.05.2017 um 09:36 schrieb Daniel Vetter: On Tue, May 23, 2017 at 09:32:38AM +0200, Christian König wrote: Am 23.05.2017 um 05:55 schrieb Michel Dänzer: On 23/05/17 12:50 PM, Lukas Wunner wrote: On Tue, May 23, 2017 at 12:09:49PM +0900, Michel Dänzer wrote: On 22/05/17 11:04 PM, Lukas Wun

Re: [PATCH] drm/radeon: Fix oops upon driver load on PowerXpress laptops

2017-05-23 Thread Daniel Vetter
On Tue, May 23, 2017 at 09:36:44AM +0200, Daniel Vetter wrote: > On Tue, May 23, 2017 at 09:32:38AM +0200, Christian König wrote: > > Am 23.05.2017 um 05:55 schrieb Michel Dänzer: > > > On 23/05/17 12:50 PM, Lukas Wunner wrote: > > > > On Tue, May 23, 2017 at 12:09:49PM +0900, Michel Dänzer wrote:

Re: [PATCH] drm/radeon: Fix oops upon driver load on PowerXpress laptops

2017-05-23 Thread Daniel Vetter
On Tue, May 23, 2017 at 09:32:38AM +0200, Christian König wrote: > Am 23.05.2017 um 05:55 schrieb Michel Dänzer: > > On 23/05/17 12:50 PM, Lukas Wunner wrote: > > > On Tue, May 23, 2017 at 12:09:49PM +0900, Michel Dänzer wrote: > > > > On 22/05/17 11:04 PM, Lukas Wunner wrote: > > > > > On Sun, May

Re: [PATCH] drm/radeon: Fix oops upon driver load on PowerXpress laptops

2017-05-23 Thread Christian König
Am 23.05.2017 um 05:55 schrieb Michel Dänzer: On 23/05/17 12:50 PM, Lukas Wunner wrote: On Tue, May 23, 2017 at 12:09:49PM +0900, Michel Dänzer wrote: On 22/05/17 11:04 PM, Lukas Wunner wrote: On Sun, May 21, 2017 at 09:31:09AM +0200, Nicolai Stange wrote: On Thu, May 18 2017, Lukas Wunner wr