Re: [PATCH] drm/amdkfd: Move process doorbell allocation into kfd device

2020-09-14 Thread Felix Kuehling
Am 2020-09-01 um 8:21 p.m. schrieb Mukul Joshi: > Move doorbell allocation for a process into kfd device and > allocate doorbell space in each PDD during process creation. > Currently, KFD manages its own doorbell space but for some > devices, amdgpu would allocate the complete doorbell > space

RE: [PATCH 2/4] drm/amdgpu: fix xgmi perfmon a-b-a problem

2020-09-14 Thread Kasiviswanathan, Harish
[AMD Official Use Only - Internal Distribution Only] Few minor comments. -Original Message- From: amd-gfx On Behalf Of Jonathan Kim Sent: Tuesday, September 8, 2020 9:06 AM To: amd-gfx@lists.freedesktop.org Cc: Kuehling, Felix ; Kim, Jonathan Subject: [PATCH 2/4] drm/amdgpu: fix xgmi

RE: [PATCH 1/4] drm/amdgpu: stop resetting xgmi perfmons on disable

2020-09-14 Thread Kasiviswanathan, Harish
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Harish Kasiviswanathan -Original Message- From: amd-gfx On Behalf Of Jonathan Kim Sent: Tuesday, September 8, 2020 9:06 AM To: amd-gfx@lists.freedesktop.org Cc: Kuehling, Felix ; Kim, Jonathan Subject: [PATCH 1/4]

Re: [PATCH 1/1] drm/amdgpu: Convert to using devm_drm_dev_alloc()

2020-09-14 Thread Alex Deucher
On Fri, Sep 11, 2020 at 4:50 PM Luben Tuikov wrote: > > On 2020-09-08 16:09, Luben Tuikov wrote: > > On 2020-09-07 04:07, Daniel Vetter wrote: > >> On Mon, Sep 07, 2020 at 10:06:08AM +0200, Daniel Vetter wrote: > >>> On Sat, Sep 05, 2020 at 11:50:05AM -0400, Alex Deucher wrote: > On Thu, Sep

Re: [PATCH] drm/amdgpu: Update RAS init handling

2020-09-14 Thread Deucher, Alexander
[AMD Public Use] Also, general nit, per kernel coding style, braces should be on the same line as the if or else, E.g., } else { Alex From: amd-gfx on behalf of Zhang, Hawking Sent: Friday, September 11, 2020 2:02 AM To: Clements, John ; amd-gfx list ;

Re: [PATCH 01/20] drm/amdgpu: Introduce GEM object functions

2020-09-14 Thread Christian König
Am 14.09.20 um 17:05 schrieb Thomas Zimmermann: Hi Am 13.08.20 um 12:22 schrieb Christian König: Am 13.08.20 um 10:36 schrieb Thomas Zimmermann: GEM object functions deprecate several similar callback interfaces in struct drm_driver. This patch replaces the per-driver callbacks with

Re: [PATCH 1/1] drm/amdgpu: fix a typo

2020-09-14 Thread Deucher, Alexander
[AMD Public Use] This is not upstream, but Acked-by: Alex Deucher From: amd-gfx on behalf of Nirmoy Das Sent: Tuesday, September 8, 2020 11:57 AM To: amd-gfx@lists.freedesktop.org Cc: Das, Nirmoy ; Kazlauskas, Nicholas Subject: [PATCH 1/1] drm/amdgpu: fix a

Re: [PATCH] drm/amdgpu/gmc9: remove mmhub client duplicated case

2020-09-14 Thread Felix Kuehling
Am 2020-09-14 um 11:42 a.m. schrieb Alex Deucher: > Copy paste typo. > > Reported-by: kernel test robot > Signed-off-by: Alex Deucher Reviewed-by: Felix Kuehling > --- > drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git

Re: [PATCH v2] drm/amdgpu/dc: Require primary plane to be enabled whenever the CRTC is

2020-09-14 Thread Michel Dänzer
On 2020-09-14 5:33 p.m., Kazlauskas, Nicholas wrote: On 2020-09-14 11:22 a.m., Michel Dänzer wrote: On 2020-09-14 4:37 p.m., Kazlauskas, Nicholas wrote: On 2020-09-14 3:52 a.m., Michel Dänzer wrote: P.S. Since DCN doesn't make a distinction between primary or overlay planes in hardware,

[PATCH] drm/amdgpu/gmc9: remove mmhub client duplicated case

2020-09-14 Thread Alex Deucher
Copy paste typo. Reported-by: kernel test robot Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c index d0645ad3446e..2bdfc861028a 100644 ---

Re: [PATCH v2] drm/amdgpu/dc: Require primary plane to be enabled whenever the CRTC is

2020-09-14 Thread Kazlauskas, Nicholas
On 2020-09-14 11:22 a.m., Michel Dänzer wrote: On 2020-09-14 4:37 p.m., Kazlauskas, Nicholas wrote: On 2020-09-14 3:52 a.m., Michel Dänzer wrote: On 2020-09-07 9:57 a.m., Daniel Vetter wrote: On Fri, Sep 04, 2020 at 12:43:04PM +0200, Michel Dänzer wrote: From: Michel Dänzer Don't check

Re: [PATCH v2] drm/amdgpu/dc: Require primary plane to be enabled whenever the CRTC is

2020-09-14 Thread Michel Dänzer
On 2020-09-14 4:37 p.m., Kazlauskas, Nicholas wrote: On 2020-09-14 3:52 a.m., Michel Dänzer wrote: On 2020-09-07 9:57 a.m., Daniel Vetter wrote: On Fri, Sep 04, 2020 at 12:43:04PM +0200, Michel Dänzer wrote: From: Michel Dänzer Don't check drm_crtc_state::active for this either, per its

Re: [PATCH] drm/radeon: revert "Prefer lower feedback dividers"

2020-09-14 Thread Alex Deucher
Reviewed-by: Alex Deucher On Fri, Sep 11, 2020 at 3:35 AM Christian König wrote: > > Ping, we need to revert this ASAP. > > Christian. > > Am 09.09.20 um 13:16 schrieb Christian König: > > Turns out this breaks a lot of different hardware. > > > > This reverts commit

Re: [PATCH 01/20] drm/amdgpu: Introduce GEM object functions

2020-09-14 Thread Thomas Zimmermann
Hi Am 13.08.20 um 12:22 schrieb Christian König: > Am 13.08.20 um 10:36 schrieb Thomas Zimmermann: >> GEM object functions deprecate several similar callback interfaces in >> struct drm_driver. This patch replaces the per-driver callbacks with >> per-instance callbacks in amdgpu. The only

Re: [PATCH] drm/amdgpu: Include sienna_cichlid in USBC PD FW support.

2020-09-14 Thread Deucher, Alexander
[AMD Public Use] Reviewed-by: Alex Deucher From: Grodzovsky, Andrey Sent: Monday, September 14, 2020 10:32 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: Re: [PATCH] drm/amdgpu: Include sienna_cichlid in USBC PD FW support. Ping Andrey

Re: [PATCH v2] drm/amdgpu/dc: Require primary plane to be enabled whenever the CRTC is

2020-09-14 Thread Kazlauskas, Nicholas
On 2020-09-14 3:52 a.m., Michel Dänzer wrote: On 2020-09-07 9:57 a.m., Daniel Vetter wrote: On Fri, Sep 04, 2020 at 12:43:04PM +0200, Michel Dänzer wrote: From: Michel Dänzer Don't check drm_crtc_state::active for this either, per its documentation in include/drm/drm_crtc.h:   * Hence

Re: Power-saving/performance toggles for amdgpu

2020-09-14 Thread Bastien Nocera
On Mon, 2020-09-14 at 01:46 -0400, Alex Deucher wrote: > > On older radeons (e.g., pre-GCN hardware), there were separate power > states for battery and AC, but these asics are supported by the > radeon > kernel driver. None of the hardware supported by amdgpu exposes > anything like that

Re: [PATCH] drm/amdgpu: Include sienna_cichlid in USBC PD FW support.

2020-09-14 Thread Andrey Grodzovsky
Ping Andrey On 9/10/20 2:05 PM, Andrey Grodzovsky wrote: Create sysfs interface also for sienna_cichlid. Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c

RE: [PATCH] drm/amdgpu: drop BOOLEAN define in display part

2020-09-14 Thread Chen, Guchun
[AMD Public Use] Reviewed-by: Guchun Chen Regards, Guchun -Original Message- From: amd-gfx On Behalf Of Flora Cui Sent: Monday, September 14, 2020 2:37 PM To: amd-gfx@lists.freedesktop.org Cc: Cui, Flora Subject: [PATCH] drm/amdgpu: drop BOOLEAN define in display part use bool

RE: [PATCH] drm/amd/pm: support runtime pptable update for sienna_cichlid etc.

2020-09-14 Thread Quan, Evan
[AMD Official Use Only - Internal Distribution Only] Better to split this into two patches: one for the dpm disablement skipping and another for gfxoff ctrl. Either way this patch is reviewed-by: Evan Quan -Original Message- From: Jiansong Chen Sent: Monday, September 14, 2020 4:10 PM

RE: [PATCH] drm/amd/pm: support runtime pptable update for sienna_cichlid etc.

2020-09-14 Thread Chen, Jiansong (Simon)
It makes nonsense to call gfxoff when smu failure has happened. Regards, Jiansong -Original Message- From: Chen, Guchun Sent: Monday, September 14, 2020 4:14 PM To: Chen, Jiansong (Simon) ; amd-gfx@lists.freedesktop.org Cc: Zhou1, Tao ; Feng, Kenneth ; Quan, Evan ; Chen, Jiansong

RE: [PATCH] drm/amd/pm: support runtime pptable update for sienna_cichlid etc.

2020-09-14 Thread Chen, Guchun
[AMD Public Use] ret = smu_late_init(adev); + if (ret) + return ret; One counter leak happens? It needs to call amdgpu_gfx_off_ctrl(smu->adev, true) before returning? Regards, Guchun -Original Message- From: amd-gfx On Behalf Of Jiansong Chen Sent: Monday,

RE: [PATCH] drm/amd/pm: support runtime pptable update for sienna_cichlid etc.

2020-09-14 Thread Feng, Kenneth
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Kenneth Feng -Original Message- From: Jiansong Chen Sent: Monday, September 14, 2020 4:10 PM To: amd-gfx@lists.freedesktop.org Cc: Zhou1, Tao ; Feng, Kenneth ; Quan, Evan ; Chen, Jiansong (Simon) Subject: [PATCH]

[PATCH] drm/amd/pm: support runtime pptable update for sienna_cichlid etc.

2020-09-14 Thread Jiansong Chen
This avoids smu issue when enabling runtime pptable update for sienna_cichlid and so on. Runtime pptable udpate is needed for test and debug purpose. Signed-off-by: Jiansong Chen Change-Id: I70b704ab4d6efd169f579c392e5dbc2737dc1fb2 --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 12 +---

Re: [PATCH v2] drm/amdgpu/dc: Require primary plane to be enabled whenever the CRTC is

2020-09-14 Thread Michel Dänzer
On 2020-09-07 9:57 a.m., Daniel Vetter wrote: On Fri, Sep 04, 2020 at 12:43:04PM +0200, Michel Dänzer wrote: From: Michel Dänzer Don't check drm_crtc_state::active for this either, per its documentation in include/drm/drm_crtc.h: * Hence drivers must not consult @active in their various

Re: [PATCH 1/2] drm/amdgpu: Add comment to function amdgpu_ttm_alloc_gart

2020-09-14 Thread Christian König
Reviewed-by: Christian König for the series. Am 11.09.20 um 20:25 schrieb Oak Zeng: Add comments to refect what function does Signed-off-by: Oak Zeng --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git

[PATCH] drm/amdgpu: drop BOOLEAN define in display part

2020-09-14 Thread Flora Cui
use bool directly Signed-off-by: Flora Cui --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_pp_smu.c | 2 +- drivers/gpu/drm/amd/display/dc/dm_pp_smu.h | 4 +--- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git