Re: [PATCH 1/1] drm/amd/powerplay: return current DCEFCLK on sysfs read

2020-06-23 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Alex Deucher From: amd-gfx on behalf of Nirmoy Das Sent: Tuesday, June 23, 2020 5:43 AM To: amd-gfx@lists.freedesktop.org Cc: Das, Nirmoy Subject: [PATCH 1/1] drm/amd/powerplay: return current

Re: [PATCH 1/1] drm/amdgpu: remove unused functions

2020-06-18 Thread Deucher, Alexander
[AMD Public Use] Reviewed-by: Alex Deucher From: amd-gfx on behalf of Nirmoy Das Sent: Thursday, June 18, 2020 10:52 AM To: amd-gfx@lists.freedesktop.org Cc: Das, Nirmoy Subject: [PATCH 1/1] drm/amdgpu: remove unused functions Remove unused

Re: [PATCH 1/4] drm/amdgpu: label internally used symbols as static

2020-06-18 Thread Deucher, Alexander
[AMD Public Use] Series is: Reviewed-by: Alex Deucher From: amd-gfx on behalf of Nirmoy Das Sent: Thursday, June 18, 2020 9:17 AM To: amd-gfx@lists.freedesktop.org Cc: Das, Nirmoy Subject: [PATCH 1/4] drm/amdgpu: label internally used symbols as static Used

Re: [PATCH] drm/amdgpu: vcn_v2_5_mc_resume_dpg_mode() can be static

2020-06-17 Thread Deucher, Alexander
[AMD Public Use] James, please feel free to commit this. Alex From: amd-gfx on behalf of James Zhu Sent: Wednesday, June 17, 2020 4:41 PM To: amd-gfx@lists.freedesktop.org Cc: Zhu, James ; kernel test robot Subject: [PATCH] drm/amdgpu:

Re: [PATCH] drm/amd/amdgpu: Add SQ debug registers to GFX10 headers

2020-06-09 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] Might as well add it for gfx9 as well. With that fixed: Reviewed-by: Alex Deucher From: amd-gfx on behalf of Tom St Denis Sent: Tuesday, June 9, 2020 1:59 PM To: amd-gfx@lists.freedesktop.org Cc: StDenis,

Re: [PATCH] drm/amd/powerplay: move maximum sustainable clock retrieving to .hw_init

2020-06-08 Thread Deucher, Alexander
[AMD Public Use] Acked-by: Alex Deucher From: Quan, Evan Sent: Monday, June 8, 2020 6:46 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Quan, Evan ; Cui, Flora Subject: [PATCH] drm/amd/powerplay: move maximum sustainable clock retrieving

Re: [PATCH] drm/amdgpu/soc15: fix nullptr issue in soc15_read_register() for reg base accessing

2020-06-08 Thread Deucher, Alexander
[AMD Public Use] Reviewed-by: Alex Deucher From: Liang, Prike Sent: Monday, June 8, 2020 3:34 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Huang, Ray ; Liang, Prike Subject: [PATCH] drm/amdgpu/soc15: fix nullptr issue in soc15_read_register

Re: [PATCH 4/4] drm/amd/powerplay: use the same interval as PMFW on retrieving metrics table

2020-06-05 Thread Deucher, Alexander
[AMD Public Use] Series is: Reviewed-by: Alex Deucher From: Quan, Evan Sent: Friday, June 5, 2020 2:07 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Quan, Evan Subject: [PATCH 4/4] drm/amd/powerplay: use the same interval as PMFW

Re: [PATCH 1/3] drm/amd/powerplay: stop thermal IRQs on suspend

2020-05-28 Thread Deucher, Alexander
[AMD Public Use] Series is: Reviewed-by: Alex Deucher From: Quan, Evan Sent: Thursday, May 28, 2020 5:02 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Quan, Evan Subject: [PATCH 1/3] drm/amd/powerplay: stop thermal IRQs on suspend Added

Re: [PATCH] drm/amdgpu: Improve the MTYPE comments

2020-05-27 Thread Deucher, Alexander
[AMD Public Use] Reviewed-by: Alex Deucher From: amd-gfx on behalf of Yong Zhao Sent: Tuesday, May 26, 2020 8:57 PM To: amd-gfx@lists.freedesktop.org Cc: Zhao, Yong Subject: [PATCH] drm/amdgpu: Improve the MTYPE comments Use words insteads of acronym for

Re: [PATCH 1/2] drm/amd/powerplay: remove the support of xgmi pstate on vega20 from swsmu

2020-05-20 Thread Deucher, Alexander
[AMD Public Use] Series is: Reviewed-by: Alex Deucher From: Wang, Kevin(Yang) Sent: Tuesday, May 19, 2020 11:50 PM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander ; Wang, Kevin(Yang) Subject: [PATCH 1/2] drm/amd/powerplay: remove

Re: [PATCH AUTOSEL 5.6 33/50] drm/amdgpu: bump version for invalidate L2 before SDMA IBs

2020-05-19 Thread Deucher, Alexander
; dri-devel ; Deucher, Alexander ; Koenig, Christian Subject: Re: [PATCH AUTOSEL 5.6 33/50] drm/amdgpu: bump version for invalidate L2 before SDMA IBs Hi Sasha, I disagree with this. Bumping the driver version will have implications on other new features, because it's like an ABI barrier exposing

Re: [PATCH] drm/amdgpu: turn back rlcg write for gfx_v10

2020-05-12 Thread Deucher, Alexander
[AMD Public Use] Acked-by: Alex Deucher From: Yintian Tao Sent: Tuesday, May 12, 2020 6:17 AM To: Deucher, Alexander ; Liu, Monk ; Liu, Shaoyun Cc: amd-gfx@lists.freedesktop.org ; Tao, Yintian Subject: [PATCH] drm/amdgpu: turn back rlcg write for gfx_v10

Re: [PATCH 2/2] Revert "drm/amdgpu: Add ReadSerial defines for Arcturus"

2020-05-07 Thread Deucher, Alexander
[AMD Public Use] Series is: Reviewed-by: Alex Deucher From: amd-gfx on behalf of Kent Russell Sent: Thursday, May 7, 2020 2:54 PM To: amd-gfx@lists.freedesktop.org Cc: Russell, Kent Subject: [PATCH 2/2] Revert "drm/amdgpu: Add ReadSerial defines for

Re: [PATCH] drm/amdgpu: Don't report unique_id for Arcturus

2020-05-07 Thread Deucher, Alexander
[AMD Public Use] Shouldn't all of this code be moved later anyway to make sure the SMU is up and running already? Alex From: amd-gfx on behalf of Kent Russell Sent: Thursday, May 7, 2020 9:53 AM To: amd-gfx@lists.freedesktop.org Cc: Russell, Kent Subject:

Re: [PATCH 2/3] drm/amdgpu: optimize amdgpu device attribute code

2020-05-06 Thread Deucher, Alexander
From: Wang, Kevin(Yang) Sent: Wednesday, May 6, 2020 7:04 AM To: Zhang, Hawking ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Liu, Monk ; Feng, Kenneth Subject: Re: [PATCH 2/3] drm/amdgpu: optimize amdgpu device attribute code [AMD Official Use Only

RE: [PATCH 0/1] Fiji GPU audio register timeout when in BACO state

2020-04-27 Thread Deucher, Alexander
[AMD Public Use] > -Original Message- > From: Nicholas Johnson > Sent: Sunday, April 26, 2020 12:02 PM > To: linux-ker...@vger.kernel.org > Cc: Deucher, Alexander ; Koenig, Christian > ; Zhou, David(ChunMing) > ; Nicholas Johnson opensou...@outlook.com.au> >

Re: drm/amdgpu: apply AMDGPU_IB_FLAG_EMIT_MEM_SYNC to compute IBs too

2020-04-27 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] Do we have open source code UMD code which uses this? Alex From: Christian König Sent: Sunday, April 26, 2020 4:55 AM To: Marek Olšák ; Koenig, Christian Cc: Deucher, Alexander ; amd-gfx mailing list

Re: drm/amdgpu: invalidate L2 before SDMA IBs (on gfx10)

2020-04-27 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] Please split the patch into two, one to update the emit IB sequence, and one to bump the minor version. That way we can make sure older kernels get the new sequence. Also do we need an sdma fw version check for the new packet in the emi IB

Re: drm/amdgpu: add tiling flags from Mesa

2020-04-20 Thread Deucher, Alexander
[AMD Public Use] Acked-by: Alex Deucher From: amd-gfx on behalf of Marek Olšák Sent: Friday, April 17, 2020 9:06 PM To: amd-gfx mailing list Subject: drm/amdgpu: add tiling flags from Mesa Hi, This is needed for displayable DCC on gfx10. Mesa will add the

Re: [PATCH 05/35] drm/amd/display: Remove byte swapping for dmcub abm config table

2020-04-16 Thread Deucher, Alexander
[AMD Public Use] I would drop this patch unless it only applies to APUs. On Linux, people may run the driver on big endian systems. Alex From: amd-gfx on behalf of Rodrigo Siqueira Sent: Thursday, April 16, 2020 7:40 PM To: amd-gfx@lists.freedesktop.org Cc:

Re: [PATCH] Revert "drm/amdgpu: Disable gfx off if VCN is busy"

2020-04-16 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] Is this ok for navi1x gfxoff? Reviewed-by: Alex Deucher From: amd-gfx on behalf of James Zhu Sent: Thursday, April 16, 2020 12:24 PM To: amd-gfx@lists.freedesktop.org Cc: Zhu, James ; Zhu, Changfeng

Re: [PATCH] drm/amdgpu: Disable FRU read on Arcturus

2020-04-16 Thread Deucher, Alexander
[AMD Public Use] Reviewed-by: Alex Deucher From: amd-gfx on behalf of Kent Russell Sent: Thursday, April 16, 2020 8:26 AM To: amd-gfx@lists.freedesktop.org Cc: Russell, Kent Subject: [PATCH] drm/amdgpu: Disable FRU read on Arcturus Update the list with

RE: [PATCH] drm/amdgpu: change SH MEM alignment mode for gfx10

2020-04-16 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] > -Original Message- > From: amd-gfx On Behalf Of > Michel Dänzer > Sent: Thursday, April 16, 2020 5:57 AM > To: Gao, Likun ; Marek Olšák ; > Pierre-Eric Pelloux-Prayer > Cc: amd-gfx@lists.freedesktop.org; Zhang, Hawking > > Subject:

Re: [PATCH] drm/amd/powerplay: fix resume failed as smu table initialize early exit

2020-04-15 Thread Deucher, Alexander
[AMD Public Use] Reviewed-by: Alex Deucher From: Liang, Prike Sent: Wednesday, April 15, 2020 11:43 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Huang, Ray ; Liang, Prike Subject: [PATCH] drm/amd/powerplay: fix resume failed as smu table

Re: [PATCH] Optimized division operation to shift operation

2020-04-15 Thread Deucher, Alexander
Airlie ; Kuehling, Felix ; LKML ; amd-gfx list ; ker...@vivo.com ; Huang, Ray ; Russell, Kent ; Deucher, Alexander ; Sam Ravnborg ; Yuan, Xiaojie Subject: Re: [PATCH] Optimized division operation to shift operation Am 15.04.20 um 09:41 schrieb Jani Nikula: > On Tue, 14 Apr 2020, Alex Deuc

Re: [PATCH v4] drm/amdkfd: Provide SMI events watch

2020-04-15 Thread Deucher, Alexander
[AMD Public Use] We use the drm major/minor in all cases. Bump KMS_DRIVER_MINOR in amdgpu_drv.c and add a note about what was added in the comment. Alex From: Lin, Amber Sent: Wednesday, April 15, 2020 9:36 AM To: Deucher, Alexander ; Kuehling, Felix ; amd

Re: [PATCH] drm/amdgpu/vcn: fix gfxoff issue

2020-04-15 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] Do we know if whatever issue was actually fixed on renoir? If not, I'd say just leave it for now. Alex From: amd-gfx on behalf of Zhu, Changfeng Sent: Wednesday, April 15, 2020 7:27 AM To: Zhang, Hawking

Re: [PATCH v4] drm/amdkfd: Provide SMI events watch

2020-04-14 Thread Deucher, Alexander
[AMD Public Use] Some good advice on getting ioctls right: https://www.kernel.org/doc/html/v5.4-preprc-cpu/ioctl/botching-up-ioctls.html Alex From: amd-gfx on behalf of Felix Kuehling Sent: Tuesday, April 14, 2020 10:40 PM To: Lin, Amber ;

Re: [PATCH] Revert "drm/amdgpu: use the BAR if possible in amdgpu_device_vram_access v2"

2020-04-14 Thread Deucher, Alexander
[AMD Public Use] If this causes an issue, any access to vram via the BAR could cause an issue. Alex From: amd-gfx on behalf of Russell, Kent Sent: Tuesday, April 14, 2020 10:19 AM To: Koenig, Christian ; amd-gfx@lists.freedesktop.org Cc: Kuehling, Felix ;

Re: [PATCH] drm/amdgpu/sriov move program of sq_config to PF

2020-04-08 Thread Deucher, Alexander
[AMD Public Use] Acked-by: Alex Deucher From: amd-gfx on behalf of Jack Zhang Sent: Wednesday, April 8, 2020 6:33 AM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Jack (Jian) Subject: [PATCH] drm/amdgpu/sriov move program of sq_config to PF Since SQ_CONFIG

Re: [PATCH] drm/amdgpu: unify fw_write_wait for new gfx9 asics

2020-04-08 Thread Deucher, Alexander
[AMD Public Use] Reviewed-by: Alex Deucher From: Liu, Aaron Sent: Wednesday, April 8, 2020 2:45 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Huang, Ray ; Dai, Yuxian (David) ; Liu, Aaron Subject: [PATCH] drm/amdgpu: unify fw_write_wait

Re: [PATCH] drm/amdgpu: Re-enable FRU check for most models v4

2020-04-07 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Alex Deucher From: amd-gfx on behalf of Kent Russell Sent: Monday, April 6, 2020 11:52 AM To: amd-gfx@lists.freedesktop.org Cc: Russell, Kent Subject: [PATCH] drm/amdgpu: Re-enable FRU check

Re: [PATCH] drm/amdgpu: Re-enable FRU check for most models

2020-04-03 Thread Deucher, Alexander
[AMD Public Use] Does this need to be protected by a asic_type check as well or is just the vbios version enough? Will we have other asics with D360 in the vbios version? Alex From: amd-gfx on behalf of Kent Russell Sent: Friday, April 3, 2020 10:43 AM To:

Re: [PATCH] drm/amd/powerplay: error out on forcing clock setting not supported

2020-04-03 Thread Deucher, Alexander
[AMD Public Use] Reviewed-by: Alex Deucher From: Quan, Evan Sent: Friday, April 3, 2020 3:03 AM To: amd-gfx@lists.freedesktop.org Cc: Russell, Kent ; Deucher, Alexander ; Quan, Evan Subject: [PATCH] drm/amd/powerplay: error out on forcing clock setting

RE: [PATCH v3] PCI: Use ioremap(), not phys_to_virt() for platform ROM

2020-03-30 Thread Deucher, Alexander
[AMD Public Use] > -Original Message- > From: Bjorn Helgaas > Sent: Saturday, March 28, 2020 4:19 PM > To: Mikel Rychliski > Cc: amd-gfx@lists.freedesktop.org; linux-...@vger.kernel.org; > nouv...@lists.freedesktop.org; Deucher, Alexander > ; Koenig, Christian >

Re: [PATCH 2/2] drm/amd/powerplay: move the ASIC specific nbio operation out of smu_v11_0.c

2020-03-27 Thread Deucher, Alexander
[AMD Public Use] Series is: Reviewed-by: Alex Deucher From: amd-gfx on behalf of Evan Quan Sent: Friday, March 27, 2020 3:57 AM To: amd-gfx@lists.freedesktop.org Cc: Quan, Evan Subject: [PATCH 2/2] drm/amd/powerplay: move the ASIC specific nbio operation

Re: [PATCH] drm/amd/amdgpu: Fix SMUIO/PWR Confusion (v2)

2020-03-25 Thread Deucher, Alexander
[AMD Public Use] While you are at it, can you clean up the local defines of these registers in drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c drivers/gpu/drm/amd/powerplay/smu_v12_0.c drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c and verify that the appropriate offset is used for both Renoir and

Re: [PATCH 1/1] drm/amdgpu: add missing if clause guard

2020-03-25 Thread Deucher, Alexander
[AMD Public Use] Reviewed-by: Alex Deucher From: Nirmoy Das Sent: Wednesday, March 25, 2020 11:24 AM To: amd-gfx@lists.freedesktop.org Cc: Liu, Monk ; Koenig, Christian ; Deucher, Alexander ; Das, Nirmoy Subject: [PATCH 1/1] drm/amdgpu: add missing if clause

Re: [PATCH] drm/amdgpu: fix hpd bo size calculation error

2020-03-25 Thread Deucher, Alexander
[AMD Public Use] Reviewed-by: Alex Deucher From: Wang, Kevin(Yang) Sent: Wednesday, March 25, 2020 6:44 AM To: Koenig, Christian ; Deucher, Alexander ; Zhang, Hawking Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: fix hpd bo size

Re: [PATCH 1/4] drm/amdgpu: add stride to calculate oss ring offsets

2020-03-20 Thread Deucher, Alexander
[AMD Public Use] Yes, something like that. Alex From: Kuehling, Felix Sent: Friday, March 20, 2020 10:47 AM To: Deucher, Alexander ; Sierra Guiza, Alejandro (Alex) ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 1/4] drm/amdgpu: add stride to calculate

Re: [PATCH 1/4] drm/amdgpu: add stride to calculate oss ring offsets

2020-03-20 Thread Deucher, Alexander
SDMA instancing since it seems to mainly affect IH RB instances? Alex From: Kuehling, Felix Sent: Friday, March 20, 2020 10:20 AM To: Deucher, Alexander ; Sierra Guiza, Alejandro (Alex) ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 1/4] drm/amdgpu: add

Re: [PATCH 3/3] drm/amdgpu: Add documentation for unique_id

2020-03-20 Thread Deucher, Alexander
[AMD Public Use] Series is: Reviewed-by: Alex Deucher From: amd-gfx on behalf of Kent Russell Sent: Friday, March 20, 2020 9:24 AM To: amd-gfx@lists.freedesktop.org Cc: Russell, Kent Subject: [PATCH 3/3] drm/amdgpu: Add documentation for unique_id Add the

Re: [PATCH 1/4] drm/amdgpu: add stride to calculate oss ring offsets

2020-03-20 Thread Deucher, Alexander
[AMD Public Use] This seems kind of complicated and error prone. I didn't realize the extent to the changes required. I think it would be better to either add arcturus specific versions of these functions or just go with your original approach and add a new arcturus_ih.c. If you go with the

Re: [PATCH 2/8] drm/amdgpu: create new files for arcturus ih

2020-03-18 Thread Deucher, Alexander
[AMD Public Use] if we have been using vega10_ih all along for arcturus, presumably the register map is close enough. I'd suggest either adding whatever new stuff you need to vega10_ih.c or navi10_ih.c. No need to add a completely new one for a small change like this. Alex

Re: [PATCH ] amd/powerplay: arcturus baco reset disable all features

2020-03-18 Thread Deucher, Alexander
[AMD Public Use] Reviewed-by: Alex Deucher From: amd-gfx on behalf of Clements, John Sent: Wednesday, March 18, 2020 10:11 AM To: amd-gfx@lists.freedesktop.org ; Zhang, Hawking Subject: [PATCH ] amd/powerplay: arcturus baco reset disable all features [AMD

Re: [PATCH] drm/amdgpu/swsmu: clean up unused header in swsmu

2020-03-12 Thread Deucher, Alexander
[AMD Public Use] Reviewed-by: Alex Deucher From: Wang, Kevin(Yang) Sent: Thursday, March 12, 2020 5:50 AM To: amd-gfx@lists.freedesktop.org Cc: Feng, Kenneth ; Deucher, Alexander ; Wang, Kevin(Yang) Subject: [PATCH] drm/amdgpu/swsmu: clean up unused header

Re: [PATCH] drm/amdgpu: reenable runtime pm on navi12

2020-03-11 Thread Deucher, Alexander
[AMD Public Use] Reviewed-by: Alex Deucher From: Quan, Evan Sent: Wednesday, March 11, 2020 6:56 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Quan, Evan Subject: [PATCH] drm/amdgpu: reenable runtime pm on navi12 The runtime pm is verified

Re: [PATCH] drm/amdgpu: add fbdev suspend/resume on gpu reset

2020-03-11 Thread Deucher, Alexander
[AMD Public Use] Reviewed-by: Alex Deucher From: amd-gfx on behalf of Evan Quan Sent: Wednesday, March 11, 2020 4:18 AM To: amd-gfx@lists.freedesktop.org Cc: Quan, Evan Subject: [PATCH] drm/amdgpu: add fbdev suspend/resume on gpu reset This can fix the

Re: [PATCH 1/2] drm/amdgpu/display: fix pci revision id fetching

2020-03-05 Thread Deucher, Alexander
[AMD Public Use] Is this for the series, or just this patch? Thanks! Alex From: Xu, Feifei Sent: Thursday, March 5, 2020 12:24 AM To: Alex Deucher ; amd-gfx list Cc: Deucher, Alexander ; Tawfik, Aly Subject: RE: [PATCH 1/2] drm/amdgpu/display: fix pci

Re: [PATCH] drm/amdgpu: Wrap clflush_cache_range with x86 ifdef

2020-03-04 Thread Deucher, Alexander
[AMD Public Use] Reviewed-by: Alex Deucher From: Andrey Grodzovsky Sent: Wednesday, March 4, 2020 1:08 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Grodzovsky, Andrey Subject: [PATCH] drm/amdgpu: Wrap clflush_cache_range with x86 ifdef

Re: [PATCH] drm/amd/powerplay: honor the BACO setting from VBIOS

2020-03-04 Thread Deucher, Alexander
[AMD Public Use] Acked-by: Alex Deucher From: amd-gfx on behalf of Evan Quan Sent: Wednesday, March 4, 2020 3:18 AM To: amd-gfx@lists.freedesktop.org Cc: Quan, Evan Subject: [PATCH] drm/amd/powerplay: honor the BACO setting from VBIOS Should not enable BACO

Re: [PATCH] drm/amdgpu/sriov: Use VF-accessible register for gpu_clock_count

2020-03-04 Thread Deucher, Alexander
[AMD Public Use] Acked-by: Alex Deucher From: Zhao, Jiange Sent: Wednesday, March 4, 2020 12:39 AM To: amd-gfx@lists.freedesktop.org Cc: Deng, Emily ; Liu, Monk ; Deucher, Alexander ; Zhao, Jiange Subject: [PATCH] drm/amdgpu/sriov: Use VF-accessible register

Re: [PATCH] drm/amdgpu/sriov: skip programing some regs with new L1 policy

2020-03-03 Thread Deucher, Alexander
[AMD Public Use] Acked-by: Alex Deucher From: amd-gfx on behalf of Zhou, Tiecheng Sent: Tuesday, March 3, 2020 6:04 AM To: Zhou, Tiecheng ; amd-gfx@lists.freedesktop.org Subject: RE: [PATCH] drm/amdgpu/sriov: skip programing some regs with new L1 policy

Re: [PATCH 4/4] drm/amdgpu: add reset_ras_error_count function for HDP

2020-03-02 Thread Deucher, Alexander
[AMD Public Use] Series is: Reviewed-by: Alex Deucher From: Hawking Zhang Sent: Monday, March 2, 2020 5:33 AM To: amd-gfx@lists.freedesktop.org ; Clements, John ; Li, Dennis ; Chen, Guchun ; Zhou1, Tao ; Deucher, Alexander Cc: Zhang, Hawking Subject: [PATCH

Re: [PATCH 1/2] Revert "drm/amdgpu: add sysfs interface to set arbitrary sclk value for navi14"

2020-02-28 Thread Deucher, Alexander
[AMD Public Use] Please also revert this fix: https://cgit.freedesktop.org/~agd5f/linux/commit/?h=amd-staging-drm-next=4e261b86437af7481364a5239c62cc3c5ef0ee38 Alex From: amd-gfx on behalf of Quan, Evan Sent: Thursday, February 27, 2020 10:37 PM To: Gui, Jack

Re: [PATCH] drm/amdgpu/sriov: Use VF-accessible register for gpu_clock_count

2020-02-28 Thread Deucher, Alexander
From: Deucher, Alexander Sent: Thursday, February 27, 2020 10:23 PM To: Zhao, Jiange ; amd-gfx@lists.freedesktop.org Cc: Deng, Emily ; Liu, Monk Subject: Re: [PATCH] drm/amdgpu/sriov: Use VF-accessible register for gpu_clock_count [AMD Public Use] Is there any reason

Re: [PATCH] drm/amdgpu: stop disable the scheduler during HW fini

2020-02-27 Thread Deucher, Alexander
[AMD Public Use] Looks good to me. Reviewed-by: Alex Deucher From: Christian König Sent: Thursday, February 27, 2020 9:50 AM To: Das, Nirmoy ; amd-gfx@lists.freedesktop.org ; Deucher, Alexander Subject: Re: [PATCH] drm/amdgpu: stop disable the scheduler during

Re: [PATCH] drm/amdgpu/sriov: Use VF-accessible register for gpu_clock_count

2020-02-27 Thread Deucher, Alexander
[AMD Public Use] Is there any reason to not just use this for bare metal as well? Alex From: amd-gfx on behalf of jianzh Sent: Thursday, February 27, 2020 6:21 AM To: amd-gfx@lists.freedesktop.org Cc: Deng, Emily ; Zhao, Jiange ; Liu, Monk Subject: [PATCH]

Re: [PATCH 2/2] drm/amdkfd: Make get_tile_config() generic

2020-02-26 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] Series is: Reviewed-by: Alex Deucher From: amd-gfx on behalf of Yong Zhao Sent: Wednesday, February 26, 2020 12:58 PM To: amd-gfx@lists.freedesktop.org Cc: Zhao, Yong Subject: [PATCH 2/2] drm/amdkfd: Make

Re: linux-next: Tree for Feb 26 (gpu/drm/amd/amdgpu/)

2020-02-26 Thread Deucher, Alexander
I'll push it out today. Thanks! Alex From: Kuehling, Felix Sent: Wednesday, February 26, 2020 12:49 PM To: Pan, Xinhui ; Deucher, Alexander Cc: amd-gfx@lists.freedesktop.org Subject: RE: linux-next: Tree for Feb 26 (gpu/drm/amd/amdgpu/) [AMD Official Use

Re: [PATCH 1/2] drm/amdgpu/powerplay: Refactor SMU message handling for safety

2020-02-26 Thread Deucher, Alexander
[AMD Public Use] That's fine we can take care of testing other platforms. Thanks, Alex From: amd-gfx on behalf of Matt Coffin Sent: Tuesday, February 25, 2020 7:03 PM To: Alex Deucher Cc: Das, Nirmoy ; amd-gfx list Subject: Re: [PATCH 1/2]

Re: [PATCH] SWDEV-220585 - Navi12 L1 policy GC regs WAR #1

2020-02-25 Thread Deucher, Alexander
[AMD Public Use] Please fix up the patch title. E.g., drm/amdgpu: Don't write GCVM_L2_CNTL* regs on navi12 VF With that fixed, patch is: Reviewed-by: Alex deuc...@amd.com> From: amd-gfx on behalf of Rohit Khaire Sent: Friday, February 21, 2020 3:24 PM To:

Re: [PATCH 6/6] drm/amdkfd: Delete unnecessary unmap queue package submissions

2020-02-25 Thread Deucher, Alexander
[AMD Public Use] Series is: Acked-by: Alex Deucher From: amd-gfx on behalf of Yong Zhao Sent: Monday, February 24, 2020 5:18 PM To: amd-gfx@lists.freedesktop.org Cc: Zhao, Yong Subject: [PATCH 6/6] drm/amdkfd: Delete unnecessary unmap queue package

Re: 回复: [PATCH] drm/amd/amdgpu: disable GFXOFF around debugfs access to MMIO

2020-02-21 Thread Deucher, Alexander
From: Christian König Sent: Friday, February 21, 2020 10:43 AM To: Deucher, Alexander ; Huang, Ray ; Liu, Monk Cc: StDenis, Tom ; Alex Deucher ; amd-gfx list Subject: Re: 回复: [PATCH] drm/amd/amdgpu: disable GFXOFF around debugfs access to MMIO Do we have a way to disable GFXOFF

Re: 回复: [PATCH] drm/amd/amdgpu: disable GFXOFF around debugfs access to MMIO

2020-02-21 Thread Deucher, Alexander
[AMD Public Use] If we are trying to debug a reproducible hang, probably best to just to disable gfxoff before messing with it to remove that as a factor. Otherwise, the method included in this patch is the proper way to disable/enable GFXOFF dynamically. Alex

Re: [PATCH] drm/amdgpu: Add a chunk ID for spm trace

2020-02-21 Thread Deucher, Alexander
[AMD Public Use] We already have the RESERVE_VMID ioctl interface, can't we just use that internally in the kernel to update the rlc register via the ring when we schedule the relevant IB? E.g., add a new ring callback to set SPM state and then set it to the reserved vmid before we schedule

Re: [PATCH] drm/amdgpu: add is_raven_kicker judgement for raven1

2020-02-14 Thread Deucher, Alexander
[AMD Public Use] Reviewed-by: Alex Deucher From: amd-gfx on behalf of Changfeng.Zhu Sent: Thursday, February 13, 2020 11:03 PM To: Huang, Ray ; amd-gfx@lists.freedesktop.org Cc: Zhu, Changfeng Subject: [PATCH] drm/amdgpu: add is_raven_kicker judgement for

Re: [PATCH libdrm 0/4] amdgpu: use amdgpu_cs_submit_raw2 for amdgpu tests

2020-02-11 Thread Deucher, Alexander
Yes, correct. Alex From: Huang, Ray Sent: Tuesday, February 11, 2020 9:35 AM To: Deucher, Alexander ; Christian König ; amd-gfx@lists.freedesktop.org Cc: Pelloux-prayer, Pierre-eric ; Olsak, Marek ; Liu, Aaron ; Tuikov, Luben ; Koenig, Christian Subject: RE

Re: [PATCH libdrm 0/4] amdgpu: use amdgpu_cs_submit_raw2 for amdgpu tests

2020-02-11 Thread Deucher, Alexander
, Luben ; Deucher, Alexander ; Koenig, Christian Subject: Re: [PATCH libdrm 0/4] amdgpu: use amdgpu_cs_submit_raw2 for amdgpu tests Looks good on first glance, but Marek and/or Pierre can probably better judge than me. Christian. Am 11.02.20 um 12:22 schrieb Huang Rui: > So

Re: [PATCH] drm/amd/powerplay: always refetch the enabled features status on dpm enablement

2020-02-11 Thread Deucher, Alexander
[AMD Public Use] Acked-by: Alex Deucher From: amd-gfx on behalf of Evan Quan Sent: Tuesday, February 11, 2020 12:41 AM To: amd-gfx@lists.freedesktop.org Cc: Quan, Evan Subject: [PATCH] drm/amd/powerplay: always refetch the enabled features status on dpm

Re: [PATCH] drm/amdgpu/sriov set driver_table address in VF

2020-02-07 Thread Deucher, Alexander
[AMD Public Use] Acked-by: Alex Deucher From: amd-gfx on behalf of Jack Zhang Sent: Friday, February 7, 2020 4:51 AM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Jack (Jian) Subject: [PATCH] drm/amdgpu/sriov set driver_table address in VF With the recent

Re: Asking for Direction

2020-01-31 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] Please make sure your kernel has this patch: commit 46203a508f64b4bfa150a9d25eab1dc891e7e650 Author: Alex Deucher Date: Tue Oct 29 17:14:15 2019 -0400 drm/amdgpu/gmc10: properly set BANK_SELECT and FRAGMENT_SIZE These were not

Re: [PATCH 0/5] HDCP SRM interface

2020-01-22 Thread Deucher, Alexander
[AMD Public Use] If you resend the patch set, it might be good to include the script in the series for reference as well. Alex From: amd-gfx on behalf of Harry Wentland Sent: Wednesday, January 22, 2020 2:27 PM To: Lakha, Bhawanpreet ; Alex Deucher Cc:

RE: [PATCH 0/2] Adjust AMD GPU ATS quirks

2020-01-15 Thread Deucher, Alexander
[AMD Public Use] > -Original Message- > From: Bjorn Helgaas > Sent: Tuesday, January 14, 2020 6:42 PM > To: Alex Deucher > Cc: amd-gfx@lists.freedesktop.org; linux-...@vger.kernel.org; Deucher, > Alexander > Subject: Re: [PATCH 0/2] Adjust AMD GPU ATS quirks >

Re: [PATCH] drm/amdkfd: Fix a compiling warning

2020-01-13 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] FWIW: https://patchwork.freedesktop.org/patch/347923/ Alex From: amd-gfx on behalf of Yong Zhao Sent: Friday, January 10, 2020 7:40 PM To: amd-gfx@lists.freedesktop.org Cc: Zhao, Yong Subject: [PATCH]

RE: [PATCH 2/2] drm/amdgpu: enable S/G display for renoir

2020-01-07 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] > -Original Message- > From: Liu, Aaron > Sent: Tuesday, January 7, 2020 9:48 PM > To: Alex Deucher ; amd- > g...@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: RE: [PATCH 2/2] drm/amdgpu: enable S

RE: [PATCH 2/2] drm/amdgpu: avoid unnecessary SMC firmware reloading

2019-12-28 Thread Deucher, Alexander
[AMD Public Use] > -Original Message- > From: Quan, Evan > Sent: Thursday, December 26, 2019 3:11 AM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Quan, Evan > > Subject: [PATCH 2/2] drm/amdgpu: avoid unnecessary SMC firmware > reloading >

RE: [PATCH 1/2] drm/amdgpu: handle mp1 state properly on suspend or device removal

2019-12-28 Thread Deucher, Alexander
[AMD Public Use] > -Original Message- > From: Quan, Evan > Sent: Thursday, December 26, 2019 3:11 AM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Quan, Evan > > Subject: [PATCH 1/2] drm/amdgpu: handle mp1 state properly on suspend or > device re

RE: [PATCH] drm/amdgpu: simplify padding calculations (v3)

2019-12-18 Thread Deucher, Alexander
> -Original Message- > From: Tuikov, Luben > Sent: Wednesday, December 18, 2019 6:17 PM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Koenig, Christian > > Subject: Re: [PATCH] drm/amdgpu: simplify padding calculations (v3) > > This patch

Re: [PATCH 3/5] drm/amdgpu/smu: add metrics table lock for navi

2019-12-17 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] yeah, they need some fixes. Alex From: Pelloux-prayer, Pierre-eric Sent: Tuesday, December 17, 2019 1:56 PM To: Alex Deucher ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: Re: [PATCH 3/5

Re: [PATCH] drm/amdgpu: move umc offset to one new header file for Arcturus

2019-12-17 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Alex Deucher From: Chen, Guchun Sent: Tuesday, December 17, 2019 4:08 AM To: Clements, John ; Zhang, Hawking ; Deucher, Alexander ; amd-gfx@lists.freedesktop.org Cc: Chen, Guchun Subject

Re: [PATCH] drm/amdgpu: Add CU info print log

2019-12-13 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Alex Deucher From: amd-gfx on behalf of Yong Zhao Sent: Wednesday, December 11, 2019 6:09 PM To: amd-gfx@lists.freedesktop.org Cc: Zhao, Yong Subject: [PATCH] drm/amdgpu: Add CU info print

Re: [PATCH] drm/amdgpu: enable gfxoff for raven1 refresh

2019-12-13 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] Acked-by: Alex Deucher From: Zhu, Changfeng Sent: Thursday, December 12, 2019 10:24 PM To: amd-gfx@lists.freedesktop.org ; Liang, Prike ; Liu, Aaron ; Huang, Ray ; Huang, Shimmer ; Deucher, Alexander Cc

Re: [PATCH] drm/amdgpu: drop useless BACO arg in amdgpu_ras_reset_gpu

2019-12-13 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Alex Deucher From: Chen, Guchun Sent: Friday, December 13, 2019 3:53 AM To: Zhang, Hawking ; Ma, Le ; Zhou1, Tao ; Deucher, Alexander ; amd-gfx@lists.freedesktop.org Cc: Chen, Guchun Subject

RE: [PATCH] drm/amd/display: fix undefined struct member reference

2019-12-10 Thread Deucher, Alexander
> -Original Message- > From: Kazlauskas, Nicholas > Sent: Tuesday, December 10, 2019 3:56 PM > To: Liu, Zhan ; Arnd Bergmann ; > Wentland, Harry ; Li, Sun peng (Leo) > ; Deucher, Alexander > ; Koenig, Christian > ; Zhou, David(ChunMing) > ; David Airlie ;

Re: [PATCH 2/2] drm/amdgpu: fix JPEG instance checking when ctx init

2019-12-09 Thread Deucher, Alexander
forgot to add RB for the series. Alex From: amd-gfx on behalf of Deucher, Alexander Sent: Monday, December 9, 2019 4:45 PM To: Liu, Leo ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 2/2] drm/amdgpu: fix JPEG instance checking when ctx init [AMD

Re: [PATCH 2/2] drm/amdgpu: fix JPEG instance checking when ctx init

2019-12-09 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Alex Deucher From: amd-gfx on behalf of Leo Liu Sent: Monday, December 9, 2019 4:10 PM To: amd-gfx@lists.freedesktop.org Cc: Liu, Leo Subject: [PATCH 2/2] drm/amdgpu: fix JPEG instance

RE: [PATCH] drm/amdgpu: Fix BACO entry failure in NAVI10.

2019-12-05 Thread Deucher, Alexander
> -Original Message- > From: Andrey Grodzovsky > Sent: Thursday, December 5, 2019 2:30 PM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Grodzovsky, > Andrey > Subject: [PATCH] drm/amdgpu: Fix BACO entry failure in NAVI10. > > BACO feature mu

Re: [RFC 0/7] UVD support for SI in amdgpu

2019-12-05 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] You could enable UVD support on amdgpu using the original firmware from radeon, but you'd have to adjust the memory map on the GPU for SI to match radeon. So updated firmware is not a requirement per se, it's just needed to keep the memory

Re: [PATCH v4] drm/scheduler: Avoid accessing freed bad job.

2019-12-03 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] Cherry pick whatever dependencies you need or pick the older version of the patch. Either way works. Alex From: Grodzovsky, Andrey Sent: Tuesday, December 3, 2019 2:57 PM To: Deucher, Alexander ; Deng, Emily

Re: [PATCH v4] drm/scheduler: Avoid accessing freed bad job.

2019-12-03 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] Please go ahead an apply whatever version is necessary for amd-staging-drm-next. Alex From: Grodzovsky, Andrey Sent: Tuesday, December 3, 2019 2:10 PM To: Deng, Emily ; Deucher, Alexander Cc: dri-de

RE: [PATCH 3/3] drm/amdgpu: load np fw prior before loading the TAs

2019-12-02 Thread Deucher, Alexander
> -Original Message- > From: Hawking Zhang > Sent: Monday, December 2, 2019 1:04 AM > To: amd-gfx@lists.freedesktop.org; Min, Frank ; > Clements, John ; Deucher, Alexander > > Cc: Zhang, Hawking > Subject: [PATCH 3/3] drm/amdgpu: load np fw prior before loading t

RE: [PATCH 2/3] drm/amdgpu: unload asd in psp hw de-init phase

2019-12-02 Thread Deucher, Alexander
> -Original Message- > From: Hawking Zhang > Sent: Monday, December 2, 2019 1:04 AM > To: amd-gfx@lists.freedesktop.org; Min, Frank ; > Clements, John ; Deucher, Alexander > > Cc: Zhang, Hawking > Subject: [PATCH 2/3] drm/amdgpu: unload asd in psp hw

RE: [PATCH 1/3] drm/amdgpu: drop asd shared memory

2019-12-02 Thread Deucher, Alexander
> -Original Message- > From: Hawking Zhang > Sent: Monday, December 2, 2019 1:04 AM > To: amd-gfx@lists.freedesktop.org; Min, Frank ; > Clements, John ; Deucher, Alexander > > Cc: Zhang, Hawking > Subject: [PATCH 1/3] drm/amdgpu: drop asd shared memor

Re: [PATCH] drm/amd/display: Get NV14 specific ip params as needed

2019-11-26 Thread Deucher, Alexander
Acked-by: Alex Deucher From: amd-gfx on behalf of Zhan Liu Sent: Tuesday, November 26, 2019 4:32 PM To: amd-gfx@lists.freedesktop.org ; Wu, Hersen ; Siqueira, Rodrigo Cc: Liu, Zhan Subject: [PATCH] drm/amd/display: Get NV14 specific ip params as needed

Re: [PATCH v4] drm/scheduler: Avoid accessing freed bad job.

2019-11-26 Thread Deucher, Alexander
@lists.freedesktop.org ; Koenig, Christian ; steven.pr...@arm.com ; Deucher, Alexander Subject: Re: [PATCH v4] drm/scheduler: Avoid accessing freed bad job. Christian asked to submit it to drm-misc instead of our drm-next to avoid later conflicts with Steven's patch which he mentioned

RE: [PATCH v2 0/7] PCI: Prefer pcie_capability_read_word()

2019-11-21 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx On Behalf Of > Bjorn Helgaas > Sent: Thursday, November 21, 2019 9:02 AM > To: linux-...@vger.kernel.org > Cc: Zhou, David(ChunMing) ; Frederick Lawler > ; Dave Airlie ; linux- > ker...@vger.kernel.org; dri-de...@lists.freedesktop.org; Bjorn Helgaas >

Re: [PATCH] drm/amd: Fix Kconfig indentation

2019-11-21 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: Krzysztof Kozlowski Sent: Thursday, November 21, 2019 8:29 AM To: linux-ker...@vger.kernel.org Cc: Krzysztof Kozlowski ; Deucher, Alexander ; Koenig, Christian ; Zhou, David(ChunMing) ; David Airlie ; Daniel Vetter ; amd-gfx

Re: [PATCH 2/2] drm/amd/amdgpu/sriov skip RLCG s/r list for arcturus VF.

2019-11-21 Thread Deucher, Alexander
You can have my RB on the first patch if you fix the compiler warnings. Alex From: amd-gfx on behalf of Zhang, Jack (Jian) Sent: Thursday, November 21, 2019 10:58 AM To: Alex Deucher Cc: amd-gfx list Subject: Re: [PATCH 2/2] drm/amd/amdgpu/sriov skip RLCG s/r

<    2   3   4   5   6   7   8   9   10   11   >