On 2/10/24 15:17, Maíra Canal wrote:
On 1/30/24 12:03, Vignesh Raman wrote:
Uprev IGT and add amd, v3d, vc4 and vgem specific
tests to testlist. Have testlist.txt per driver
and include a base testlist so that the driver
specific tests will run only on those hardware.
Signed-off-by: Vignesh
On 1/30/24 12:03, Vignesh Raman wrote:
Uprev IGT and add amd, v3d, vc4 and vgem specific
tests to testlist. Have testlist.txt per driver
and include a base testlist so that the driver
specific tests will run only on those hardware.
Signed-off-by: Vignesh Raman
---
v3:
- New patch in series
struct kunit_suite *suite)
+{
+ kunit_info(suite, "Testing DRM exec manager\n");
Isn't this already clear by the name of the test?
Best Regards,
- Maíra Canal
+ return 0;
+}
+
+static struct kunit_case drm_exec_tests[] = {
+ KUNIT_CASE(drm_exec_sanit
drivers return EINVAL in the case of
a bad modifier and it wouldn't change the current behavior of i915 and amdgpu.
[1]
https://lore.kernel.org/dri-devel/20230103125322.855089-1-mca...@igalia.com/T/
Best Regards,
- Maíra Canal
.
Thanks for the feedback!
Best Regards,
- Maíra Canal
framebuffer_check() perform the framebuffer
validation.
Reviewed-by: Zack Rusin
Signed-off-by: Maíra Canal
---
drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 18 --
1 file changed, 18 deletions(-)
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
index
-1-mca...@igalia.com/T/
- Don't remove check from i915 driver (Ville Syrjälä).
- Don't unexport drm_any_plane_has_format().
v2 -> v3:
https://lore.kernel.org/dri-devel/20230113112743.188486-1-mca...@igalia.com/T/
- Check if r->modifier[0] != 0 (Ville Syrjälä).
---
Best Regards,
- Maíra Canal
Ma
the framebuffer validation.
Reviewed-by: Simon Ser
Signed-off-by: Maíra Canal
---
drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
index b22471b3bd63
-by: Maíra Canal
---
Documentation/gpu/todo.rst| 9 -
drivers/gpu/drm/drm_framebuffer.c | 8
2 files changed, 12 insertions(+), 5 deletions(-)
diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst
index 1f8a5ebe188e..3a79c26c5cc7 100644
--- a/Documentation/gpu
framebuffer_check() perform the framebuffer
validation.
Reviewed-by: Zack Rusin
Signed-off-by: Maíra Canal
---
drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 18 --
1 file changed, 18 deletions(-)
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
index
the framebuffer validation.
Reviewed-by: Simon Ser
Signed-off-by: Maíra Canal
---
drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
index b22471b3bd63
-by: Maíra Canal
---
Documentation/gpu/todo.rst| 9 -
drivers/gpu/drm/drm_framebuffer.c | 8
2 files changed, 12 insertions(+), 5 deletions(-)
diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst
index 1f8a5ebe188e..3a79c26c5cc7 100644
--- a/Documentation/gpu
-1-mca...@igalia.com/T/
- Don't remove check from i915 driver (Ville Syrjälä)
- Don't unexport drm_any_plane_has_format().
---
Best Regards,
- Maíra Canal
Maíra Canal (3):
drm/framebuffer: Check for valid formats
drm/amdgpu: Remove redundant framebuffer format check
drm/vmwgfx: Remove red
Hi Tom
On 9/19/22 14:27, Tom Rix wrote:
> There are several copies of CalculateRemoteSurfaceFlipDelay.
> Reduce to one instance.
>
> Signed-off-by: Tom Rix
Reviewed-by: Maíra Canal
Just a minor comment below.
> ---
> .../dc/dml/dcn20/display_mode_vba_20.c| 4 +-
&
Hi Tom,
On 9/18/22 23:37, Tom Rix wrote:
> There are several copies of CalculateTwait.
> Reduce to one instance and change local variable name to match common usage.
>
> Signed-off-by: Tom Rix
Reviewed-by: Maíra Canal
Although, it would be nice to put this function on the
displa
lay;
> - double Line_length;
> - double Output_lines_last_notclamped;
> - double WritebackVInit;
> -
> - WritebackVInit = (WritebackVRatio + WritebackVTaps + 1) / 2;
> - Line_length = dml_max((double) WritebackDestinationWidth,
> - d
ke to see this
expand to all display_mode_vba files, but so far this is great to
unbreak the build.
To the whole series:
Tested-by: Maíra Canal
Best Regards,
- Maíra Canal
> ---
>
> This is just commit ab2ac59c32db ("drm/amd/display: Reduce number of
> arguments of dml31's
Explain how to run the KUnit tests present in the AMDGPU's Display
Core and clarify which architectures and tools can be used to run
the tests. Moreover, explains how to add new tests to the existing
tests.
Signed-off-by: Maíra Canal
---
.../gpu/amdgpu/display/display-test.rst | 88
Add unit test to the SubVP feature in order to avoid possible
regressions and assure the code robustness.
Signed-off-by: Maíra Canal
---
drivers/gpu/drm/amd/display/Kconfig | 13 +
drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c | 4 +
.../gpu/drm/amd/display/tests/.kunitconfig
From: Magali Lemes
This commit adds unit tests to the functions dcn20_cap_soc_clocks and
dcn21_update_bw_bounding_box from dcn20/dcn20_fpu.
Signed-off-by: Magali Lemes
Signed-off-by: Maíra Canal
---
drivers/gpu/drm/amd/display/tests/Makefile| 3 +-
.../tests/dc/dml/dcn20
to the codebase.
Signed-off-by: Maíra Canal
---
.../dc/dml/dcn20/display_mode_vba_20.c| 4 +
.../dc/dml/dcn20/display_mode_vba_20_test.c | 888 ++
2 files changed, 892 insertions(+)
create mode 100644
drivers/gpu/drm/amd/display/tests/dc/dml/dcn20
to the codebase.
Signed-off-by: Maíra Canal
---
drivers/gpu/drm/amd/display/tests/Makefile| 5 +
.../tests/dc/dml/display_mode_vba_test.c | 741 ++
2 files changed, 746 insertions(+)
create mode 100644
drivers/gpu/drm/amd/display/tests/dc/dml/display_mode_vba_test.c
diff --git
From: Isabella Basso
This adds tests to the bit encoding format verification functions on the
file. They're meant to be simpler so as to provide a proof of concept on
testing DML code.
Signed-off-by: Isabella Basso
Signed-off-by: Maíra Canal
---
drivers/gpu/drm/amd/display/Kconfig
=drivers/gpu/drm/amd/display/tests/
Co-developed-by: Magali Lemes
Signed-off-by: Magali Lemes
Co-developed-by: Tales Aparecida
Signed-off-by: Tales Aparecida
Signed-off-by: Maíra Canal
---
drivers/gpu/drm/amd/display/Kconfig | 12 +
.../drm/amd/display/dc/dml/calcs/bw_fixed.c | 3
-by: Maíra Canal
---
drivers/gpu/drm/amd/display/Kconfig | 13 +
drivers/gpu/drm/amd/display/Makefile | 2 +-
.../gpu/drm/amd/display/tests/.kunitconfig| 6 +
drivers/gpu/drm/amd/display/tests/Makefile| 12 +
.../display/tests/dc/basics/fixpt31_32_test.c | 232
top.org/isinyaaa/linux/-/tree/for-amd-mixed
Thanks in advance for your time taking a look and sending any feedback!
Best regards,
Isabella Basso, Magali Lemes, Maíra Canal, and Tales Aparecida
[1]
https://summerofcode.withgoogle.com/programs/2022/organizations/xorg-foundation
[2] htt
Hi Nathan,
I have built-tested the whole series with clang 14.0.5 (Fedora
14.0.5-1.fc36), using:
$ make -kj"$(nproc)" ARCH=x86_64 LLVM=1 mrproper allmodconfig
drivers/gpu/drm/amd/amdgpu/
Great to see this patchset coming for DML!
To the whole series:
Tested-by: Maíra Canal
Be
Add unit test to the SubVP feature in order to avoid possible
regressions and assure the code robustness.
Signed-off-by: Maíra Canal
---
drivers/gpu/drm/amd/display/Kconfig | 13 +
drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c | 4 +
.../gpu/drm/amd/display/tests/.kunitconfig
Explain how to run the KUnit tests present in the AMDGPU's Display
Core and clarify which architectures and tools can be used to run
the tests. Moreover, explains how to add new tests to the existing
tests.
Signed-off-by: Maíra Canal
---
.../gpu/amdgpu/display/display-test.rst | 88
From: Magali Lemes
This commit adds unit tests to the functions dcn20_cap_soc_clocks and
dcn21_update_bw_bounding_box from dcn20/dcn20_fpu.
Signed-off-by: Magali Lemes
Signed-off-by: Maíra Canal
---
drivers/gpu/drm/amd/display/tests/Makefile| 3 +-
.../tests/dc/dml/dcn20
to the codebase.
Signed-off-by: Maíra Canal
---
.../dc/dml/dcn20/display_mode_vba_20.c| 4 +
.../dc/dml/dcn20/display_mode_vba_20_test.c | 888 ++
2 files changed, 892 insertions(+)
create mode 100644
drivers/gpu/drm/amd/display/tests/dc/dml/dcn20
to the codebase.
Signed-off-by: Maíra Canal
---
drivers/gpu/drm/amd/display/tests/Makefile| 5 +
.../tests/dc/dml/display_mode_vba_test.c | 741 ++
2 files changed, 746 insertions(+)
create mode 100644
drivers/gpu/drm/amd/display/tests/dc/dml/display_mode_vba_test.c
diff --git
From: Isabella Basso
This adds tests to the bit encoding format verification functions on the
file. They're meant to be simpler so as to provide a proof of concept on
testing DML code.
Signed-off-by: Isabella Basso
Signed-off-by: Maíra Canal
---
drivers/gpu/drm/amd/display/Kconfig
=drivers/gpu/drm/amd/display/tests/
Co-developed-by: Magali Lemes
Signed-off-by: Magali Lemes
Co-developed-by: Tales Aparecida
Signed-off-by: Tales Aparecida
Signed-off-by: Maíra Canal
---
drivers/gpu/drm/amd/display/Kconfig | 12 +
.../drm/amd/display/dc/dml/calcs/bw_fixed.c | 3
-by: Maíra Canal
---
drivers/gpu/drm/amd/display/Kconfig | 13 +
drivers/gpu/drm/amd/display/Makefile | 2 +-
.../gpu/drm/amd/display/tests/.kunitconfig| 6 +
drivers/gpu/drm/amd/display/tests/Makefile| 12 +
.../display/tests/dc/basics/fixpt31_32_test.c | 232
OOM error handling logic on non-UML")
commit e5857d396f35 ("kunit: flatten kunit_suite*** to kunit_suite** in
.kunit_test_suites")
commit 94681e289bf5 ("kunit: executor: Fix a memory leak on failure in
kunit_filter_tests")
Thanks in advance for your time taking a look and sending any
argument to && or ||
drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_32.c:
3680:8-55: duplicated argument to && or ||
Signed-off-by: Bernard Zhao
Also, it would be nice to have a changelog between the versions.
Other than those small nits,
Reviewed-by: Maíra Cana
On 8/17/22 17:57, Mikhail Gavrilov wrote:
> On Wed, Aug 17, 2022 at 11:43 PM Maíra Canal wrote:
>>
>> Hi Mikhail,
>>
>> Looks like 45ecaea738830b9d521c93520c8f201359dcbd95 ("drm/sched: Partial
>> revert of 'drm/sched: Keep s_fence->parent pointer'
eSupportAndSystemConfigurationFull(struct display_mode_lib
*mode_lib)
^
1 error generated.
Best Regards,
- Maíra Canal
>
> UseMinimumDCFCLK() is eating away at
> dml30_ModeSupportAndSystemConfigurationFull()'s stack space, so use a
> pointer to struct vba_vars_st instead of passing lots
'
[-Wmissing-prototypes]
Therefore, include the missing header on the file and turn global functions
that are not used outside of the file into static functions.
Fixes: 5d945cbcd4b1 ("drm/amd/display: Create a file dedicated to planes")
Reported-by: kernel test robot
Signed-off-by: M
the use-after-free still happens.
Best Regards,
- Maíra Canal
[ 297.834779] [ cut here ]
[ 297.834818] refcount_t: underflow; use-after-free.
[ 297.834831] WARNING: CPU: 30 PID: 2377 at lib/refcount.c:28
refcount_warn_saturate+0xba/0x110
[ 297.834838] Modules linke
fore, remove the mutex_unlock from the amdgpu_cs_vm_handling
function, so that amdgpu_cs_submit and amdgpu_cs_parser_fini can handle
the unlock.
Fixes: 90af0ca047f3 ("drm/amdgpu: Protect the amdgpu_bo_list list with a mutex
v2")
Reported-by: Mikhail Gavrilov
Signed-off-by: Maíra Canal
---
Thanks
ext/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Fixes: 90af0ca047f3 ("drm/amdgpu: Protect the amdgpu_bo_list list with a
mutex v2")
Reported-by: Mikhail Gavrilov
Signed-off-by: Maíra Canal
---
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 9 +++--
1 file changed, 3 insertions(+)
On 8/11/22 04:37, David Gow wrote:
On Thu, Aug 11, 2022 at 8:41 AM Tales Aparecida
wrote:
From: Maíra Canal
Add unit test to the SubVP feature in order to avoid possible
regressions and assure the code robustness.
Signed-off-by: Maíra Canal
Signed-off-by: Tales Aparecida
---
FYI
nly run
under a particular architecture.
[1]
https://docs.kernel.org/dev-tools/kunit/usage.html#writing-tests-for-other-architectures
Signed-off-by: Maíra Canal
---
drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 6 +++---
drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 2 +-
drivers/gpu/dr
the current scope of the AMD Display code, I don't believe
it is viable to test on the exposed functions.
Best Regards,
- Maíra Canal
Instead black box testing and/or exposing tests as a separate module
(e.g. for the fixed point calculations for example) is probably the way
to go.
Just my
The XFCEnabled parameter from the CalculatePrefetchSchedule function is
not used and is only mentioned in a couple of comments. Therefore,
remove the argument and the comments.
Signed-off-by: Maíra Canal
---
.../dc/dml/dcn21/display_mode_vba_21.c| 21 +++
1 file changed
*optc,
> - double vtotal_avg)
> -{
> - DC_FP_START();
> - optc3_fpu_set_vrr_m_const(optc, vtotal_avg);
The function optc3_fpu_set_vrr_m_const is only used here, so by deleting
it, the function optc3_fpu_set_vrr_m_const is declared but not used.
Couldn't it be dropped also
the struct vba_vars_st.
Signed-off-by: Maíra Canal
---
drivers/gpu/drm/amd/display/dc/dml/display_mode_vba.h | 10 --
1 file changed, 10 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dml/display_mode_vba.h
b/drivers/gpu/drm/amd/display/dc/dml/display_mode_vba.h
index 5eaedc3bf2c8
-by: Maíra Canal
---
.../amd/display/dc/dml/dcn32/display_mode_vba_32.c | 1 -
.../gpu/drm/amd/display/dc/dml/display_mode_vba.c | 13 ++---
.../gpu/drm/amd/display/dc/dml/display_mode_vba.h | 6 --
3 files changed, 2 insertions(+), 18 deletions(-)
diff --git a/drivers/gpu/drm/amd
The TFinalxFill variable from the struct vba_vars_st is only used
on assignments, so its value is not used on code. So,
remove the TFinalxFill entry from the struct vba_vars_st.
Signed-off-by: Maíra Canal
---
drivers/gpu/drm/amd/display/dc/dml/dcn20/display_mode_vba_20.c | 3 ---
.../gpu/drm
The MaximumDCCCompressionYSurface variable from the struct vba_vars_st is
only used on assignments, so its value is not used on code. So,
remove the MaximumDCCCompressionYSurface entry from the struct vba_vars_st.
Signed-off-by: Maíra Canal
---
.../amd/display/dc/dml/dcn21/display_mode_vba_21.c
The WritebackAllowFCLKChangeEndPosition variable from the struct
vba_vars_st is only used on assignments, so its value is not used on
code. So, remove the WritebackAllowFCLKChangeEndPosition entry
from the struct vba_vars_st.
Signed-off-by: Maíra Canal
---
.../gpu/drm/amd/display/dc/dml/dcn32
The NumberOfDP2p0Support variable from the struct vba_vars_st is
only used on assignments, so its value is not used on code. So,
remove the NumberOfDP2p0Support entry from the struct vba_vars_st.
Signed-off-by: Maíra Canal
---
drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_32.c | 2
The MPCCombineEnable variable from the struct vba_vars_st is only
used on assignments, so its value is not used on code. So, remove
the MPCCombineEnable entry from the struct vba_vars_st.
Signed-off-by: Maíra Canal
---
drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c | 1
The ModeIsSupported variable from the struct vba_vars_st is only used on
assignments, so its value is not used on code. So, remove the
ModeIsSupported entry from the struct vba_vars_st.
Signed-off-by: Maíra Canal
---
drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c | 1 -
drivers
The ImmediateFlipSupportedSurface variable from the struct
vba_vars_st is only used on assignments, so its value is not used
on code. So, remove the ImmediateFlipSupportedSurface entry from the struct
vba_vars_st.
Signed-off-by: Maíra Canal
---
.../gpu/drm/amd/display/dc/dml/dcn32
The SwathWidthCSingleDPP variable from the struct vba_vars_st is only
used on assignments, so its value is not used on code. So, remove the
SwathWidthCSingleDPP entry from the struct vba_vars_st.
Signed-off-by: Maíra Canal
---
drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c | 2
the struct vba_vars_st.
Signed-off-by: Maíra Canal
---
.../dc/dml/dcn20/display_mode_vba_20.c| 38 ---
.../dc/dml/dcn20/display_mode_vba_20v2.c | 38 ---
.../dc/dml/dcn21/display_mode_vba_21.c| 38 ---
.../drm/amd/display/dc/dml
The variables VStartupMargin and FirstMainPlane from the struct
vba_vars_st are only used on assignments, so there values are not used
on code. So, remove the variables entries from the struct vba_vars_st.
Signed-off-by: Maíra Canal
---
.../display/dc/dml/dcn20/display_mode_vba_20.c | 14
The AllowDRAMSelfRefreshDuringVBlank variable from the struct vba_vars_st
is only used on assignments, so its value is not used on code. So, remove
it the AllowDRAMSelfRefreshDuringVBlank entry from the struct vba_vars_st.
Signed-off-by: Maíra Canal
---
drivers/gpu/drm/amd/display/dc/dml/dcn20
The DSCCLK_calculated variable from the struct vba_vars_st is
only used on assignments, so its value is not used on code. Moreover,
its getter function is not used also. So, remove the DSCCLK_calculated
entry from the struct vba_vars_st.
Signed-off-by: Maíra Canal
---
.../dc/dml/dcn20
vba_vars_st.
Signed-off-by: Maíra Canal
---
.../gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_32.c | 3 ---
drivers/gpu/drm/amd/display/dc/dml/display_mode_vba.c| 2 --
drivers/gpu/drm/amd/display/dc/dml/display_mode_vba.h| 5 -
3 files changed, 10 deletions(-)
diff
The NonUrgentLatencyTolerance variable from the struct vba_vars_st is
only used on assignments, so its value is not used on code. Moreover,
its getter function is not used also. So, remove the
NonUrgentLatencyTolerance entry from the struct vba_vars_st.
Signed-off-by: Maíra Canal
---
.../gpu
to the code.
I only removed variables that were only assigned but never used or variables
that were never even mentioned.
Best Regards,
- Maíra Canal
[1]
https://lore.kernel.org/amd-gfx/20220630215316.1078841-1-mairaca...@riseup.net/T/#u
Maíra Canal (16):
drm/amd/display: Remove
All references to struct freesync_context were removed, so remove the
struct freesync_context itself and its entry on struct dc_stream_state.
Signed-off-by: Maíra Canal
---
drivers/gpu/drm/amd/display/dc/dc_stream.h | 8
1 file changed, 8 deletions(-)
diff --git a/drivers/gpu/drm/amd
Hi Magali
On 7/25/22 15:15, Magali Lemes wrote:
> As "dcn3_15_soc" and "dcn3_16_soc" are of type "struct
> _vcs_dpi_soc_bounding_box_st", change their types accordingly.
>
> Signed-off-by: Magali Lemes
> ---
Great catch! To the whole series:
Rev
Hi Siqueira,
On 7/22/22 17:11, Rodrigo Siqueira Jordao wrote:
> Hi Maira,
>
> First of all, thanks a lot for this patch. This change is really helpful
> for reducing the stack size. I just have few comments inline.
Thank you for the feedback!
>
> On 2022-07-21 14:36,
Based on the dml30_CalculateWriteBackDISPCLK, it separates the
DISPCLK calculations on three variables, making no functional changes, in order
to make it more readable and better express that three values are being compared
on dml_max.
Signed-off-by: Maíra Canal
Reviewed-by: André Almeida
-by: Maíra Canal
---
v1 -> v2:
- Replace "enum" to "enum entries" (André Almeida).
---
.../drm/amd/display/dc/dml/dcn20/dcn20_fpu.c | 3 +--
.../dc/dml/dcn20/display_rq_dlg_calc_20.c | 5 +
.../dc/dml/dcn20/display_rq_dlg_calc_20.h | 5
The functions dml30_CalculateWriteBackDISPCLK and
dml31_CalculateWriteBackDISPCLK are identical. Therefor, to avoid code
duplication, replace dml31_CalculateWriteBackDISPCLK by
dml30_CalculateWriteBackDISPCLK
Signed-off-by: Maíra Canal
---
v1 -> v2:
- Describe changes in imperative mood (An
As the enum entries dm_sw_gfx7_2d_thin_gl and dm_sw_gfx7_2d_thin_l_vp
are not used on the codebase, drop those entries from enum
dm_swizzle_mode.
Signed-off-by: Maíra Canal
---
v1 -> v2:
- Replace "enum" to "enum entries" (André Almeida).
- Describe changes in imperat
On 7/21/22 10:31, André Almeida wrote:
> Às 15:22 de 20/07/22, Maíra Canal escreveu:
>> As the enum dm_sw_gfx7_2d_thin_gl and dm_sw_gfx7_2d_thin_l_vp are not
>> used on the codebase, this commit drops those entries from enum
>> dm_swizzle_mode.
>>
0_clk_mgr.h"
>
> +// For DML FPU code
> +#include "dml/dcn20/dcn20_fpu.h"
> +#include "dml/dcn301/dcn301_fpu.h"
> +
I guess the "dml/dcn301/dcn301_fpu.h" header is not needed, as you only
use dcn21_clk_mgr_set_bw_params_wm_table and th
Based on the dml30_CalculateWriteBackDISPCLK, it separates the
DISPCLK calculations on three variables, making no functional changes, in order
to make it more readable and better express that three values are being compared
on dml_max.
Signed-off-by: Maíra Canal
Reviewed-by: André Almeida
-off-by: Maíra Canal
---
.../drm/amd/display/dc/dml/dcn20/dcn20_fpu.c | 3 +--
.../dc/dml/dcn20/display_rq_dlg_calc_20.c | 5 +
.../dc/dml/dcn20/display_rq_dlg_calc_20.h | 5 +
.../dc/dml/dcn20/display_rq_dlg_calc_20v2.c | 5 +
.../dc/dml/dcn20/display_rq_dlg_calc_20v2.h
The functions dml30_CalculateWriteBackDISPCLK and
dml31_CalculateWriteBackDISPCLK are identical. Therefor, to avoid
code duplication, dml31_CalculateWriteBackDISPCLK is removed and
replaced by dml30_CalculateWriteBackDISPCLK.
Signed-off-by: Maíra Canal
---
.../dc/dml/dcn31/display_mode_vba_31.c
As the enum dm_sw_gfx7_2d_thin_gl and dm_sw_gfx7_2d_thin_l_vp are not
used on the codebase, this commit drops those entries from enum
dm_swizzle_mode.
Signed-off-by: Maíra Canal
---
.../dc/dml/dcn20/display_mode_vba_20.c| 26 +-
.../dc/dml/dcn20/display_mode_vba_20v2.c
48 bytes
> [-Werror=frame-larger-than=]
> 3799 | } // ModeSupportAndSystemConfigurationFull
> | ^
>
> Signed-off-by: Alex Deucher
> Cc: Stephen Rothwell
> ---
Reviewed-by: Maíra Canal
I believe dcn20 could also receive the same treatment, as I'm still
getting a similar warning on displ
On 7/18/22 16:02, Alex Deucher wrote:
> On Thu, Jul 14, 2022 at 12:46 PM Maíra Canal wrote:
>>
>> The parameters WritebackPixelFormat and WritebackVRatio are removed as
>> they are not used on the function dml30_CalculateWriteBackDISPCLK.
>
> Maybe this is done for
Based on the dml30_CalculateWriteBackDISPCLK, it separates the
DISPCLK calculations on three variables, making no functional changes, in order
to make it more readable and better express that three values are being compared
on dml_max.
Signed-off-by: Maíra Canal
---
.../drm/amd/display/dc/dml
The functions dml30_CalculateWriteBackDISPCLK and
dml31_CalculateWriteBackDISPCLK are identical. Therefor, to avoid
code duplication, dml31_CalculateWriteBackDISPCLK is removed and
replaced by dml30_CalculateWriteBackDISPCLK.
Signed-off-by: Maíra Canal
---
.../dc/dml/dcn31/display_mode_vba_31.c
The parameters WritebackPixelFormat and WritebackVRatio are removed as
they are not used on the function dml30_CalculateWriteBackDISPCLK.
Signed-off-by: Maíra Canal
---
drivers/gpu/drm/amd/display/dc/dml/dcn30/dcn30_fpu.c| 2 --
.../gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c
/amd/amdgpu/../display/dc/dml/dcn30/display_mode_vba_30.c:3043:10:
warning: variable 'MaxUsedBW' set but not used [-Wunused-but-set-variable]
double MaxUsedBW = 0;
^
1 warning generated.
Signed-off-by: Maíra Canal
---
.../dc/dml/dcn30/display_mode_vba_30.c
dynamic_range_ycbcr = 1; /*bt709*/
^
3 warnings generated.
Signed-off-by: Maíra Canal
---
.../drm/amd/display/dc/dcn10/dcn10_stream_encoder.c| 10 --
1 file changed, 10 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_stream_encoder.c
b/drivers/gpu/drm/amd/display
-variable]
uint32_t value0 = 0;
^
1 warning generated.
Signed-off-by: Maíra Canal
---
drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c
b/drivers/gpu/drm
]
unsigned int dppclk_delay_subtotal;
^
2 warnings generated.
Signed-off-by: Maíra Canal
---
.../dc/dml/dcn31/display_rq_dlg_calc_31.c | 19 ---
1 file changed, 19 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn31/display_rq_dlg_calc_31.c
b
-variable]
static const unsigned int NumberOfStates = DC__VOLTAGE_STATES;
^
1 warning generated.
Signed-off-by: Maíra Canal
---
drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_32.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc
unit
void dml32_CalculatedoublePipeDPPCLKAndSCLThroughput(
^
static
1 warning generated.
Signed-off-by: Maíra Canal
---
.../dc/dml/dcn32/display_mode_vba_util_32.c | 54 ---
1 file changed, 54 deletions(-)
diff --git
a/drivers/gpu/drm/amd/display/dc/dml/dcn32
dce110_clk_src *clk_src;
^
1 warning generated.
Signed-off-by: Maíra Canal
---
drivers/gpu/drm/amd/display/dc/dce/dce_clock_source.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_clock_source.c
b/drivers/gpu/drm/amd/display/dc
Turn previously global function into a static function as it is not used
outside the file.
Signed-off-by: Maíra Canal
---
drivers/gpu/drm/amd/display/dc/dml/display_mode_vba.c | 2 +-
drivers/gpu/drm/amd/display/dc/dml/display_mode_vba.h | 1 -
2 files changed, 1 insertion(+), 2 deletions
On the dce_v6_0 and dce_v8_0 hpd tear down callback, the tmp variable
should be written into the control register instead of 0.
Fixes: b00861b9 ("drm/amd/amdgpu: port of DCE v6 to new headers (v3)")
Fixes: 2285b91c ("drm/amdgpu/dce8: simplify hpd code")
Signed-off-by: Maíra
As the enum dm_sw_gfx7_2d_thin_gl and dm_sw_gfx7_2d_thin_l_vp are not
used on the codebase, this commit drops those entries from enum
dm_swizzle_mode.
Signed-off-by: Maíra Canal
---
.../dc/dml/dcn20/display_mode_vba_20.c| 26 +-
.../dc/dml/dcn20/display_mode_vba_20v2.c
07
[3]
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=34ad61514c4c3657df21a058f9961c3bb2f84ff2
[4]
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=d3f2a14b8906df913cb04a706367b012db94a6e8
Best Regards,
- Maíra Canal
> Could you provi
Some variables from the struct vba_vars_st are not referenced in any
other place on the codebase. As they are not used, this commit removes
those variables.
Signed-off-by: Maíra Canal
---
Unused variables from structs are not warned by compilers, so they are a bit
harder to find. In order
and used across dcn30 and dcn31.
Signed-off-by: Maíra Canal
---
.../dc/dml/dcn30/display_mode_vba_30.c| 21 +---
.../dc/dml/dcn30/display_mode_vba_30.h| 11 ++
.../dc/dml/dcn30/display_rq_dlg_calc_30.c | 93 +--
.../dc/dml/dcn31/display_mode_vba_31.c| 106
The function Calculate256BBlockSizes always returns true, regardless of
the parameters. As any file checks the return of the function, this
commit changes the return value to void.
Signed-off-by: Maíra Canal
---
drivers/gpu/drm/amd/display/dc/dml/display_mode_vba.c | 3 +--
drivers/gpu/drm/amd
d be nice to have a small changelog here,
describing what has changed between the v1 and v2 versions of the patch.
Also, you can mark the patch as v2 with git send-email by adding the
flag -v2. More on the canonical patch format can be seen in [1].
[1]
https://docs.kernel.org/process/submitting-p
On 6/17/22 04:55, David Gow wrote:
> On Fri, Jun 17, 2022 at 6:41 AM Maíra Canal wrote:
>>
>> Hi David,
>>
>> Thank you for your feedback!
>>
>> On 6/16/22 11:39, David Gow wrote:
>>> On Wed, Jun 8, 2022 at 9:08 AM Maíra Canal wrote:
&g
Hi David,
Thank you for your feedback!
On 6/16/22 11:39, David Gow wrote:
> On Wed, Jun 8, 2022 at 9:08 AM Maíra Canal wrote:
>>
>> As kunit_test_suites() defines itself as an init_module(), it conflicts with
>> the existing one at amdgpu_drv. So, if we use kunit_te
1 - 100 of 117 matches
Mail list logo
