Re: [Architecture] Modification of the gadget generation wizard's extension structure

2016-06-12 Thread Tanya Madurapperuma
Hi Sajith, Thank you for your reply. Please find my responses inline. On Mon, Jun 13, 2016 at 1:26 AM, SajithAR Ariyarathna wrote: > Hi Tanya, > > I like to express few suggestions regarding the gadget structure. > > *Generated gadget structure* >> >> └── test_gadget >> ├── conf.json >>

Re: [Architecture] Modification of the gadget generation wizard's extension structure

2016-06-12 Thread SajithAR Ariyarathna
Hi Tanya, I like to express few suggestions regarding the gadget structure. *Generated gadget structure* > > └── test_gadget > ├── conf.json > ├── gadget-controller.jag > ├── gadget.json > ├── index.png > ├── index.xml > ├── libs > │ └── vendorName_version > │

Re: [Architecture] Modification of the gadget generation wizard's extension structure

2016-06-09 Thread Sinthuja Ragendran
Hi Manu, On Wed, Jun 8, 2016 at 8:40 PM, Manuranga Perera wrote: > 1) We had a chat about how we can use gadget parameters instead of >>> generation, have you guys considered that approach? >>> >>> We have cases like database credentials which should not be shown to the >> user and should not be

Re: [Architecture] Modification of the gadget generation wizard's extension structure

2016-06-08 Thread Tanya Madurapperuma
On Thu, Jun 9, 2016 at 1:10 AM, Manuranga Perera wrote: > 1) We had a chat about how we can use gadget parameters instead of >>> generation, have you guys considered that approach? >>> >>> We have cases like database credentials which should not be shown to the >> user and should not be editable

Re: [Architecture] Modification of the gadget generation wizard's extension structure

2016-06-08 Thread Manuranga Perera
> > 1) We had a chat about how we can use gadget parameters instead of >> generation, have you guys considered that approach? >> >> We have cases like database credentials which should not be shown to the > user and should not be editable from the gadget properties. Further we also > need a model t

Re: [Architecture] Modification of the gadget generation wizard's extension structure

2016-06-08 Thread Sriskandarajah Suhothayan
On Wed, Jun 8, 2016 at 3:31 PM, Manuranga Perera wrote: > Hi Tanya, Sinthuja, > > 1) We had a chat about how we can use gadget parameters instead of > generation, have you guys considered that approach? > > We have cases like database credentials which should not be shown to the user and should n

Re: [Architecture] Modification of the gadget generation wizard's extension structure

2016-06-08 Thread Manuranga Perera
Hi Tanya, Sinthuja, 1) We had a chat about how we can use gadget parameters instead of generation, have you guys considered that approach? Edit/ Re-generate function is not supported yet. 2) The issues is, with this model it will be harder to support that even in the future. At least we should s

Re: [Architecture] Modification of the gadget generation wizard's extension structure

2016-06-08 Thread Tanya Madurapperuma
@ Manu : Edit/ Re-generate function is not supported yet. The initial plan was to have a gadget generation tool which is similar to what was there in DAS but with extension points to plug providers and chart templates. @ Jerad : Please see my inline comments. On Wed, Jun 8, 2016 at 10:04 AM, Jerad

Re: [Architecture] Modification of the gadget generation wizard's extension structure

2016-06-07 Thread Dakshika Jayathilaka
Hi All, Ideally, we need to provide an option to re-edit once they generated. AFAIK we don't have that option yet. Regards, *Dakshika Jayathilaka* PMC Member & Committer of Apache Stratos Associate Technical Lead WSO2, Inc. lean.enterprise.middleware 0771100911 On Tue, Jun 7, 2016 at 11:34 PM,

Re: [Architecture] Modification of the gadget generation wizard's extension structure

2016-06-07 Thread Manuranga Perera
How would a user modify or regenerate with slight change? ___ Architecture mailing list Architecture@wso2.org https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture

Re: [Architecture] Modification of the gadget generation wizard's extension structure

2016-06-07 Thread Tanya Madurapperuma
Hi Manu, On Tue, Jun 7, 2016 at 8:05 PM, Manuranga Perera wrote: > Hi Tanya, > > 1) Are we really generating gadgets, though the wizard or generating > JSONs? (I personally don't like the former, as we have discussed before) > We are generating the gadget not JSONs. > > 2) If we are generating,

Re: [Architecture] Modification of the gadget generation wizard's extension structure

2016-06-07 Thread Manuranga Perera
Hi Tanya, 1) Are we really generating gadgets, though the wizard or generating JSONs? (I personally don't like the former, as we have discussed before) 2) If we are generating, which files are dynamic generated Vs. which files are copies? I think it should be possible to figure out by looking at

Re: [Architecture] Modification of the gadget generation wizard's extension structure

2016-06-07 Thread Tanya Madurapperuma
Hi all, Thank you for your inputs. @ Dakshika : Based on your input following modifications were made. *Chart template structure* └── line-chart ├── api.js ├── config.json ├── chart-libs │ └── vendorName_version │ └── js_css_images_etc_as_same_as_vendor_ships ├──

Re: [Architecture] Modification of the gadget generation wizard's extension structure

2016-06-07 Thread Dakshika Jayathilaka
Hi All, IMO it's better if we can maintain third-party libraries as a separate entity. Usually, most of the third party libs have their own dependencies (ex: some CSS files refer images/ fonts ). If we place them separately it's hard to identify relevant dependency at a glance. At the same time,

Re: [Architecture] Modification of the gadget generation wizard's extension structure

2016-06-07 Thread Sriskandarajah Suhothayan
Gadget generation API is orthogonal to the usage API and we are not changing the usage API, hence gadget created via old generation tools will still work. Regards Suho On Tue, Jun 7, 2016 at 3:34 PM, Rajith Vitharana wrote: > Hi Tanya, > > On Tue, Jun 7, 2016 at 3:21 PM, Tanya Madurapperuma >

Re: [Architecture] Modification of the gadget generation wizard's extension structure

2016-06-07 Thread Rajith Vitharana
Hi Tanya, On Tue, Jun 7, 2016 at 3:21 PM, Tanya Madurapperuma wrote: > Hi Rajith, > > We have not done any GA release, not even an Alpha release of the product > with this, but a component repo release. > Still if this is a API change to a component which we already released to public, I feel we

Re: [Architecture] Modification of the gadget generation wizard's extension structure

2016-06-07 Thread Tanya Madurapperuma
Hi Rajith, We have not done any GA release, not even an Alpha release of the product with this, but a component repo release. Thanks, Tanya On Tue, Jun 7, 2016 at 3:17 PM, Rajith Vitharana wrote: > Hi Tanya, > > On Tue, Jun 7, 2016 at 3:11 PM, Tanya Madurapperuma > wrote: > >> Hi all, >> >> D

Re: [Architecture] Modification of the gadget generation wizard's extension structure

2016-06-07 Thread Rajith Vitharana
Hi Tanya, On Tue, Jun 7, 2016 at 3:11 PM, Tanya Madurapperuma wrote: > Hi all, > > During an offline discussion with Jerad following modification were > suggested regarding the directory structure of the extension model. All > these changes are subjected to js and css file locations. > > *Chart

[Architecture] Modification of the gadget generation wizard's extension structure

2016-06-07 Thread Tanya Madurapperuma
Hi all, During an offline discussion with Jerad following modification were suggested regarding the directory structure of the extension model. All these changes are subjected to js and css file locations. *Chart template structure* |── line-chart │ ├── css │ │ └── line-chart.css │