[Architecture] OpenAPI 3.0 support for API Manager 2.2.0

2018-01-08 Thread Thilini Shanika
Hi All, We are planning to provide OpenAPI 3.0 specification support for API Manager 2.2.0 [1]. We did a background research on what's new in OpenAPI and the feasibility of providing OpenAPI 3.0 support over APIM 2.2.0. As per the current architecture of APIM, it is feasible to support OpenAPI 3.0

Re: [Architecture] OpenAPI 3.0 support for API Manager 2.2.0

2018-01-08 Thread Bhathiya Jayasekara
Hi Thilini, Another thing we need to think about is whether we should let API developers decide which swagger version they need in their new APIs (if yes, how), or should we always use swagger 3 for new APIs. I prefer the first option unless we have any technical barriers supporting that. Thanks

Re: [Architecture] OpenAPI 3.0 support for API Manager 2.2.0

2018-01-08 Thread Chamila Adhikarinayake
Hi Thilini, How does the Rest API handle this? for example, create api[1] needs swagger payload. Do you plan to provide both version support or just v3? There are some other Rest apis in the publisher rest api working with the swagger definition[2]. You might have to provide both version support w

Re: [Architecture] OpenAPI 3.0 support for API Manager 2.2.0

2018-01-08 Thread Lakmal Warusawithana
Hi Thilini, Shall we add this discussion into issue [1] itself. It will be easy to external party to get involve. On Mon, Jan 8, 2018 at 2:28 PM, Thilini Shanika wrote: > Hi All, > > We are planning to provide OpenAPI 3.0 specification support for API > Manager 2.2.0 [1]. We did a background r

Re: [Architecture] OpenAPI 3.0 support for API Manager 2.2.0

2018-01-08 Thread Thilini Shanika
@Bhathiya, Our initial plan was to provide an advanced option for developers to decide the version(Whether in Swagger 2.0 or OpenAPI 3.0) of the generating swagger definition, but later we decided to stick to OpenAPI 3.0 for newly creating APIs to avoid some complexities in supporting both versio

Re: [Architecture] OpenAPI 3.0 support for API Manager 2.2.0

2018-01-09 Thread Harsha Kumara
On Tue, Jan 9, 2018 at 10:57 AM, Thilini Shanika wrote: > @Bhathiya, > > Our initial plan was to provide an advanced option for developers to > decide the version(Whether in Swagger 2.0 or OpenAPI 3.0) of the > generating swagger definition, but later we decided to stick to OpenAPI 3.0 > for new

Re: [Architecture] OpenAPI 3.0 support for API Manager 2.2.0

2018-01-09 Thread roshan wijesena
Folks, Do we have a significant difference between swagger and openAPI? According to the https://swagger.io/blog/difference-between-swagger-and-openapi/, swagger is a tool and openAPI is the spec it self. Do we need to concern about swagger definition vs openAPI definition, rather versions of it?

Re: [Architecture] OpenAPI 3.0 support for API Manager 2.2.0

2018-01-09 Thread Bhathiya Jayasekara
Hi Roshan, On Wed, Jan 10, 2018 at 4:55 AM, roshan wijesena wrote: > Folks, > > Do we have a significant difference between swagger and openAPI? According > to the https://swagger.io/blog/difference-between-swagger-and-openapi/, > swagger is a tool and openAPI is the spec it self. > > Do we need

Re: [Architecture] OpenAPI 3.0 support for API Manager 2.2.0

2018-01-09 Thread Thilini Shanika
@Harsha In this case will our swagger console in store compatible with multiple swagger versions? How would be the compatibility of swagger library across multiple versions that we currently used in the product? Yes, it is compatible. We have upgraded Swagger UI to 3.x version, which is having su

Re: [Architecture] OpenAPI 3.0 support for API Manager 2.2.0

2018-01-24 Thread Thilini Shanika
Hi All, We have been supporting client side SDK generation via API Store and API Store REST APIs, for swagger 2.0 based definitions. But currently, we are unable to support this particular feature fo OAS 3 based APIs, since the swagger codegen 3.x version, which is having OAS 3.0.0 support, is not

Re: [Architecture] OpenAPI 3.0 support for API Manager 2.2.0

2018-01-24 Thread Nuwan Dias
If someone creates an API from the UI, the default swagger doc will be in version 3 right? Can a developer switch back to a 2.0 based definition if so? On Thu, 25 Jan 2018 at 9:45 am, Thilini Shanika wrote: > Hi All, > > We have been supporting client side SDK generation via API Store and API >

Re: [Architecture] OpenAPI 3.0 support for API Manager 2.2.0

2018-01-24 Thread Malintha Amarasinghe
Hi Nuwan, On Thu, Jan 25, 2018 at 11:07 AM, Nuwan Dias wrote: > If someone creates an API from the UI, the default swagger doc will be in > version 3 right? > SDK generation will need to be disabled for spec 3 APIs. If we make spec 3 default will it be a problem for first time users? > > On

Re: [Architecture] OpenAPI 3.0 support for API Manager 2.2.0

2018-01-24 Thread Thilini Shanika
If someone creates an API from the UI, the default swagger doc will be in version 3 right? Can a developer switch back to a 2.0 based definition if so? As per the current implementation, the default version of the generation swagger doc is a version 3.0.0 supported doc. But the publisher user can

Re: [Architecture] OpenAPI 3.0 support for API Manager 2.2.0

2018-01-24 Thread Nuwan Dias
My concern is on the folks who aren’t even aware of the oas version being used. When someone is creating an api on the UI, they’ll feel as if the SDK generation has vanished (if we disable it for v3 ones). Therefore it’ll be better to make v2 the default and provide a warning on the UI regarding SD

Re: [Architecture] OpenAPI 3.0 support for API Manager 2.2.0

2018-01-25 Thread Sanjeewa Malalgoda
By looking at current swagger code get base class and other implementations i do not think they can simply update it to work with OAPI 3.0.0. I think they will need to rewrite code-gen module. So we will have to wait till that implementation complete. So i think SDK generation page should clearly s