Re: [asterisk-dev] [Code Review] 3079: udptl: Dead code elimination. ast_udptl_bridge not used.

2013-12-19 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3079/#review10461 --- Ship it! Ship It! - opticron On Dec. 18, 2013, 6:21 p.m.,

Re: [asterisk-dev] [Code Review] 3079: udptl: Dead code elimination. ast_udptl_bridge not used.

2013-12-19 Thread Matt Jordan
On Dec. 19, 2013, 9:10 a.m., opticron wrote: Ship It! Well, hold on. Don't Ship It! just yet. :-) The fact that this isn't called in Asterisk 1.8 doesn't mean it shouldn't be called - it just means someone, at some point in time, fixed the glitch. If we aren't calling this function, then

Re: [asterisk-dev] [Code Review] 3079: udptl: Dead code elimination. ast_udptl_bridge not used.

2013-12-19 Thread Joshua Colp
On Dec. 19, 2013, 3:10 p.m., opticron wrote: Ship It! Matt Jordan wrote: Well, hold on. Don't Ship It! just yet. :-) The fact that this isn't called in Asterisk 1.8 doesn't mean it shouldn't be called - it just means someone, at some point in time, fixed the glitch. If

Re: [asterisk-dev] [Code Review] 3056: testsuite: dialplan stress test to find memory allocation problems (valgrind)

2013-12-19 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3056/#review10462 --- There are several red blobs in generate-dialplan.sh.

Re: [asterisk-dev] [Code Review] 3078: astdb: crash in sqlite3 during shutdown

2013-12-19 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3078/ --- (Updated Dec. 19, 2013, 10:43 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3072: Voicemail: Remove mailbox identifier format (box@context) assumptions in the system.

2013-12-19 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3072/ --- (Updated Dec. 19, 2013, 4:57 p.m.) Status -- This change has been

[asterisk-dev] Bug on Broadcasting DTMF to confbridge users?

2013-12-19 Thread Jason Ostrom
Hi, Trying to properly broadcast / relay DTMF digits to other confbridge users, but does not appear to work. Goal is to have a conference user be able to receive the DTMF, so it has the effect of being 'broadcasted.' My configuration appears to be correct, so wondering if this is a bug in

Re: [asterisk-dev] [Code Review] 3076: res_fax.c: fax detection caused crash on voice frame with no dsp

2013-12-19 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3076/ --- (Updated Dec. 19, 2013, 11:24 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3079: udptl: Dead code elimination. ast_udptl_bridge not used.

2013-12-19 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3079/ --- (Updated Dec. 19, 2013, 5:26 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3069: Fix deadlock experienced during multi-party PJSIP transfer through masquerade rework

2013-12-19 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3069/ --- (Updated Dec. 19, 2013, 6:20 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3061: External MWI core support with AMI using it.

2013-12-19 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3061/ --- (Updated Dec. 19, 2013, 6:49 p.m.) Review request for Asterisk

[asterisk-dev] [Code Review] 3082: say: correct time for polish

2013-12-19 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3082/ --- Review request for Asterisk Developers. Bugs: ASTERISK-22856

[asterisk-dev] [Code Review] 3081: security_events: log events with descriptive names

2013-12-19 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3081/ --- Review request for Asterisk Developers. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 3081: security_events: log events with descriptive names

2013-12-19 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3081/ --- (Updated Dec. 19, 2013, 1:13 p.m.) Review request for Asterisk

[asterisk-dev] [Code Review] 3083: funcs: REPLACE() can call strcpy on overlapping memory

2013-12-19 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3083/ --- Review request for Asterisk Developers. Bugs: ASTERISK-22910

Re: [asterisk-dev] [Code Review] 3082: say: correct time for polish

2013-12-19 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3082/ --- (Updated Dec. 19, 2013, 2:04 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3081: security_events: log events with descriptive names

2013-12-19 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3081/ --- (Updated Dec. 19, 2013, 2:06 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3081: security_events: log events with descriptive names

2013-12-19 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3081/#review10465 --- Ship it! Ship It! - Matt Jordan On Dec. 19, 2013, 2:06

Re: [asterisk-dev] [Code Review] 3082: say: correct time for polish

2013-12-19 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3082/#review10466 --- Ship it! Ship It! - Matt Jordan On Dec. 19, 2013, 2:04

Re: [asterisk-dev] [Code Review] 3081: security_events: log events with descriptive names

2013-12-19 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3081/ --- (Updated Dec. 19, 2013, 2:49 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3081: security_events: log events with descriptive names

2013-12-19 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3081/ --- (Updated Dec. 19, 2013, 2:49 p.m.) Review request for Asterisk

[asterisk-dev] [Code Review] 3084: testsuite: Insure core waitfullybooted command has completed succesfully

2013-12-19 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3084/ --- Review request for Asterisk Developers. Repository: testsuite

[asterisk-dev] DAHDI-Linux 2.8.0.1 and dahdi-linux-complete-2.8.0.1+2.8.0 Now Available

2013-12-19 Thread Asterisk Development Team
The Asterisk Development Team has announced the releases of: DAHDI-Linux-v2.8.0.1 dahdi-linux-complete-2.8.0.1+2.8.0 This release is available for immediate download at: http://downloads.asterisk.org/pub/telephony/dahdi-linux http://downloads.asterisk.org/pub/telephony/dahdi-linux-complete

Re: [asterisk-dev] [Code Review] 3082: say: correct time for polish

2013-12-19 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3082/ --- (Updated Dec. 19, 2013, 3:28 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3061: External MWI core support with AMI using it.

2013-12-19 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3061/#review10468 --- /trunk/res/res_sorcery_astdb.c

Re: [asterisk-dev] [Code Review] 3061: External MWI core support with AMI using it.

2013-12-19 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3061/#review10467 --- A few general mentions: 1) I think External should be dropped

[asterisk-dev] [Code Review] 3086: pjsip.conf.sample update: improve documentation of pjsip endpoints behind NAT and update for snake case change

2013-12-19 Thread rnewton
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3086/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23004

Re: [asterisk-dev] [Code Review] 3086: pjsip.conf.sample update: improve documentation of pjsip endpoints behind NAT and update for snake case change

2013-12-19 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3086/#review10469 --- branches/12/configs/pjsip.conf.sample

Re: [asterisk-dev] [Code Review] 3061: External MWI core support with AMI using it.

2013-12-19 Thread rmudgett
On Dec. 10, 2013, 2:20 p.m., Joshua Colp wrote: /trunk/res/res_sorcery_astdb.c, lines 228-236 https://reviewboard.asterisk.org/r/3061/diff/1/?file=49246#file49246line228 I'll explain why I disagree with this change. While you gain full regex functionality it comes at a

Re: [asterisk-dev] [Code Review] 3043: pjsip: CLI commands

2013-12-19 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3043/ --- (Updated Dec. 19, 2013, 8:04 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3043: pjsip: CLI commands

2013-12-19 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3043/#review10472 --- I think the latest diff is missing

Re: [asterisk-dev] [Code Review] 3061: External MWI core support with AMI using it.

2013-12-19 Thread rmudgett
On Dec. 19, 2013, 11:49 p.m., Mark Michelson wrote: A few general mentions: 1) I think External should be dropped from all of the MWI action names. 2) I don't see any use for the CLI commands. The whole purpose of external MWI is that it's being used externally, not by someone with

Re: [asterisk-dev] [Code Review] 3043: pjsip: CLI commands

2013-12-19 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3043/ --- (Updated Dec. 19, 2013, 9:24 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3061: External MWI core support with AMI using it.

2013-12-19 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3061/ --- (Updated Dec. 20, 2013, 4:29 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3061: External MWI core support with AMI using it.

2013-12-19 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3061/ --- (Updated Dec. 20, 2013, 4:37 a.m.) Review request for Asterisk

[asterisk-dev] confbridge DTMF

2013-12-19 Thread Chandrakant Solanki
Hello All, I am using ConfBridge application using Asterisk 11.5.1. I would like to know is there any way to detect DTMF, without configuring menu in confbridge.conf. If yes, then how it could be, please help me. I would like to do thing like, user entered conference number and he is into the