Re: [asterisk-dev] [Code Review] 3235: config: Add file size and nanosecond resolution fields to the cached modified config file information.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3235/#review10897 --- Ship it! /branches/1.8/main/config.c

Re: [asterisk-dev] [Code Review] 3161: res_sorcery_astdb.c: Fix regex handling and keep simple prefix matching performance.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3161/#review10898 --- /trunk/res/res_sorcery_astdb.c

Re: [asterisk-dev] [Code Review] 3235: config: Add file size and nanosecond resolution fields to the cached modified config file information.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3235/#review10899 --- Ship it! Ship It! - Mark Michelson On Feb. 17, 2014, 9:57 p

Re: [asterisk-dev] [Code Review] 3161: res_sorcery_astdb.c: Fix regex handling and keep simple prefix matching performance.

> On Feb. 18, 2014, 2:35 p.m., opticron wrote: > > /trunk/res/res_sorcery_astdb.c, lines 237-243 > > > > > > This could also be a regex character class such as \d or \s which is > > too complicated for prefix match

Re: [asterisk-dev] [Code Review] 3161: res_sorcery_astdb.c: Fix regex handling and keep simple prefix matching performance.

> On Feb. 18, 2014, 8:35 a.m., opticron wrote: > > /trunk/res/res_sorcery_astdb.c, lines 237-243 > > > > > > This could also be a regex character class such as \d or \s which is > > too complicated for prefix match

Re: [asterisk-dev] [Code Review] 3161: res_sorcery_astdb.c: Fix regex handling and keep simple prefix matching performance.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3161/#review10903 --- Ship it! Ship It! - opticron On Feb. 17, 2014, 7:18 p.m., r

Re: [asterisk-dev] [Code Review] 3234: media_formats: Initial channel driver conversion and application conversion

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3234/#review10901 --- Finished with page 1, though I had to look ahead to page 3 to b

Re: [asterisk-dev] [Code Review] 3235: config: Add file size and nanosecond resolution fields to the cached modified config file information.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3235/ --- (Updated Feb. 18, 2014, 10:55 a.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3235: config: Add file size and nanosecond resolution fields to the cached modified config file information.

> On Feb. 18, 2014, 2:27 a.m., wdoekes wrote: > > /branches/1.8/main/config.c, line 1095 > > > > > > IMHO, the constants (digits) look nicer on the RHS of the comparison. I prefer seeing comparisons as if the valu

Re: [asterisk-dev] [Code Review] 3234: media_formats: Initial channel driver conversion and application conversion

> On Feb. 18, 2014, 10:34 a.m., Mark Michelson wrote: > > /team/file/media_formats-impl/apps/app_meetme.c, lines 4318-4322 > > > > > > This doesn't seem to be doing the same thing as it used to. It used to > > set

Re: [asterisk-dev] [Code Review] 3234: media_formats: Initial channel driver conversion and application conversion

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3234/#review10906 --- /team/file/media_formats-impl/main/frame.c

[asterisk-dev] [Code Review] 3236: chan_sip: do not send empty Route header

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3236/ --- Review request for Asterisk Developers and wdoekes. Bugs: ASTERISK-23306