[asterisk-dev] [Code Review] 3605: DEBUG messages in sdp_crypto.c display despite a DEBUG level of zero

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3605/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23246 https://i

Re: [asterisk-dev] [Code Review] 3601: accountcode: Slightly change accountcode propagation.

> On June 10, 2014, 5:13 p.m., Scott Griepentrog wrote: > > /branches/12/main/bridge_channel.c, lines 602-610 > > > > > > I'm not understanding the need for this to be split out with separate > > join/leave handlin

Re: [asterisk-dev] [Code Review] 3595: app_queue: delayed state event can trigger leavewhenempty ringing too early

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3595/#review12122 --- /branches/1.8/apps/app_queue.c

Re: [asterisk-dev] [Code Review] 3604: Add presence information to core show hints

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3604/ --- (Updated June 10, 2014, 5:31 p.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 3604: Add presence information to core show hints

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3604/#review12121 --- Ship it! Ship It! - Matt Jordan On June 10, 2014, 5:19 p.m.

Re: [asterisk-dev] [Code Review] 3604: Add presence information to core show hints

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3604/ --- (Updated June 10, 2014, 5:19 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3604: Add presence information to core show hints

> On June 10, 2014, 4:43 p.m., Mark Michelson wrote: > > /trunk/main/pbx.c, lines 7387-7388 > > > > > > Any particular reason this line got changed? The intent was to un-indent both the header and content. Since

Re: [asterisk-dev] [Code Review] 3601: accountcode: Slightly change accountcode propagation.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3601/#review12119 --- /branches/12/main/bridge_channel.c

Re: [asterisk-dev] [Code Review] 3604: Add presence information to core show hints

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3604/#review12118 --- /trunk/main/pbx.c

Re: [asterisk-dev] [Code Review] 3600: testsuite: SIPNotify + PJSIPNotify behavioral tests

> On June 10, 2014, 1:48 p.m., opticron wrote: > > The code in AMISendTest.py looks generic enough that it could be used for > > all 5 tests with the NOTIFY-generating AMI commands and SIPp scenarios > > defined in YAML. I agree with this. Other than that, the tests look like they do what was

Re: [asterisk-dev] [Code Review] 3598: res_pjsip_pubsub: Persist subscriptions using sorcery and recreate them upon startup.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3598/#review12112 --- Ship it! This is pretty sly stuff going on here. Nicely done.

Re: [asterisk-dev] [Code Review] 3602: media_formats: Update main/config_options and tests/test_config

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3602/ --- (Updated June 10, 2014, 3:10 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3602: media_formats: Update main/config_options and tests/test_config

> On June 10, 2014, 11:01 a.m., Joshua Colp wrote: > > /team/group/media_formats-reviewed/tests/test_config.c, lines 911-917 > > > > > > Might as well go ahead and add this back in. It can be constructed > > using

Re: [asterisk-dev] [Code Review] 3602: media_formats: Update main/config_options and tests/test_config

> On June 10, 2014, 7:01 a.m., Joshua Colp wrote: > > /team/group/media_formats-reviewed/tests/test_config.c, lines 911-917 > > > > > > Might as well go ahead and add this back in. It can be constructed > > using a

Re: [asterisk-dev] [Code Review] 3603: func_jitterbuffer: fix errors and leaks caused by certain masquerade's

> On June 10, 2014, 7:22 a.m., Joshua Colp wrote: > > /branches/11/main/channel.c, line 7113 > > > > > > This change is hazardous. It makes it so that some file descriptors on > > the "original" channel which were

Re: [asterisk-dev] [Code Review] 3587: chan_pjsip: PJSIPNotify - strip content-length headers, add documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3587/ --- (Updated June 10, 2014, 10:46 a.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 3604: Add presence information to core show hints

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3604/ --- (Updated June 10, 2014, 10:36 a.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3591: application_name support in cdr_pgsql and res_config_pgsql

> On June 8, 2014, 11:38 a.m., wdoekes wrote: > > I don't see the CHANGES file edits. > > > > And I now see why this module is in extended support. I added a couple of > > remarks about issues that were already there before you came. > > > > I don't really know, exactly where and what I suppos

Re: [asterisk-dev] [Code Review] 3595: app_queue: delayed state event can trigger leavewhenempty ringing too early

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3595/ --- (Updated June 10, 2014, 9:43 a.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3593: astobj2: Additional refactoring to push impl specific code down into the impls.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3593/ --- (Updated June 10, 2014, 8:42 a.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3595: app_queue: delayed state event can trigger leavewhenempty ringing too early

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3595/ --- (Updated June 10, 2014, 9:34 a.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3598: res_pjsip_pubsub: Persist subscriptions using sorcery and recreate them upon startup.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3598/ --- (Updated June 10, 2014, 2:12 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3600: testsuite: SIPNotify + PJSIPNotify behavioral tests

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3600/#review12110 --- The code in AMISendTest.py looks generic enough that it could b

Re: [asterisk-dev] [Code Review] 3598: res_pjsip_pubsub: Persist subscriptions using sorcery and recreate them upon startup.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3598/#review12111 --- This currently has an issue due to module load order which I'm

Re: [asterisk-dev] [Code Review] 3598: res_pjsip_pubsub: Persist subscriptions using sorcery and recreate them upon startup.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3598/ --- (Updated June 10, 2014, 1:21 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3560: Testsuite: Add PJSIP nominal attended transfer tests

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3560/ --- (Updated June 10, 2014, 8:01 a.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3604: Add presence information to core show hints

> On June 9, 2014, 7:23 p.m., Corey Farrell wrote: > > /trunk/main/pbx.c, lines 7403-7404 > > > > > > If we are going to have two lines per hint I think it needs to be > > consistent. This way the eye's can easil

Re: [asterisk-dev] [Code Review] 3603: func_jitterbuffer: fix errors and leaks caused by certain masquerade's

> On June 10, 2014, 6:22 a.m., Joshua Colp wrote: > > /branches/11/main/channel.c, line 7113 > > > > > > This change is hazardous. It makes it so that some file descriptors on > > the "original" channel which were

Re: [asterisk-dev] [Code Review] 3603: func_jitterbuffer: fix errors and leaks caused by certain masquerade's

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3603/#review12107 --- /branches/11/main/channel.c

Re: [asterisk-dev] [Code Review] 3602: media_formats: Update main/config_options and tests/test_config

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3602/#review12106 --- /team/group/media_formats-reviewed/tests/test_config.c

Re: [asterisk-dev] ari-py websocket connection issue

Thanks Matthew, I tested this out and it fixed the error. For posterity (and google's) sake, I created a fresh virtualenv and ran: $ pip install requests==2.0.1 $ pip install websocket-client==0.12.0 $ pip install git+https://github.com/asterisk/ari-py.git Then example.py ran fine. On Mon, Jun

Re: [asterisk-dev] [Code Review] 3591: application_name support in cdr_pgsql and res_config_pgsql

> On June 8, 2014, 11:38 a.m., wdoekes wrote: > > /trunk/cdr/cdr_pgsql.c, lines 199-200 > > > > > > If you add an assertion here that: > > > > conn == NULL > > > > you will notice that memory lea

Re: [asterisk-dev] [Code Review] 3591: application_name support in cdr_pgsql and res_config_pgsql

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3591/ --- (Updated June 10, 2014, 7:24 a.m.) Review request for Asterisk Developers.