Re: [asterisk-dev] Proposed removal of deprecated modules in Asterisk 13 (cdr_sqlite, chan_gtalk, chan_jingle, res_jabber, chan_h323, app_readfile, app_dahdibarge, app_setcallerid, app_saycountpl)

2014-07-01 Thread Olle E. Johansson
On 30 Jun 2014, at 16:24, Walter Doekes walter+asterisk-...@osso.nl wrote: On 29-06-14 00:50, Matthew Jordan wrote: * app_readfile/app_dahdibarge/app_setcallerid/app_saycountpl - deprecated in Asterisk 1.8. While less important than the other previously listed modules, having been deprecated

Re: [asterisk-dev] Proposed removal of deprecated modules in Asterisk 13 (cdr_sqlite, chan_gtalk, chan_jingle, res_jabber, chan_h323, app_readfile, app_dahdibarge, app_setcallerid, app_saycountpl)

2014-07-01 Thread Matthew Jordan
On Tue, Jul 1, 2014 at 2:25 AM, Olle E. Johansson o...@edvina.net wrote: On 30 Jun 2014, at 16:24, Walter Doekes walter+asterisk-...@osso.nl wrote: On 29-06-14 00:50, Matthew Jordan wrote: * app_readfile/app_dahdibarge/app_setcallerid/app_saycountpl - deprecated in Asterisk 1.8. While

Re: [asterisk-dev] Proposed removal of deprecated modules in Asterisk 13 (cdr_sqlite, chan_gtalk, chan_jingle, res_jabber, chan_h323, app_readfile, app_dahdibarge, app_setcallerid, app_saycountpl)

2014-07-01 Thread Walter Doekes
On 01-07-14 09:25, Olle E. Johansson wrote: - SetMusicOnHold - WaitMusicOnHold What are the replacements for the musiconhold functions? SetMusicOnHold: Use Set(CHANNEL(musicclass)=...) instead !!! == SetMusicOnHold(myclass) == Set(CHANNEL(musicclass)=myclass) WaitMusicOnHold:

Re: [asterisk-dev] Proposed removal of deprecated modules in Asterisk 13 (cdr_sqlite, chan_gtalk, chan_jingle, res_jabber, chan_h323, app_readfile, app_dahdibarge, app_setcallerid, app_saycountpl)

2014-07-01 Thread Olle E. Johansson
On 01 Jul 2014, at 13:19, Matthew Jordan mjor...@digium.com wrote: On Tue, Jul 1, 2014 at 2:25 AM, Olle E. Johansson o...@edvina.net wrote: On 30 Jun 2014, at 16:24, Walter Doekes walter+asterisk-...@osso.nl wrote: On 29-06-14 00:50, Matthew Jordan wrote: *

Re: [asterisk-dev] Proposed removal of deprecated modules in Asterisk 13 (cdr_sqlite, chan_gtalk, chan_jingle, res_jabber, chan_h323, app_readfile, app_dahdibarge, app_setcallerid, app_saycountpl)

2014-07-01 Thread Olle E. Johansson
On 01 Jul 2014, at 13:28, Walter Doekes walter+asterisk-...@osso.nl wrote: in chan_sip: - username (=defaultuser) Username actually has multiple functions, which is why I separated one of them to defaultuser. username should remain the authentication username or be replaced by authuser=

Re: [asterisk-dev] [Code Review] 3690: CEL: Fix incorrect/missing extra field information

2014-07-01 Thread Matt Jordan
On June 30, 2014, 5:54 p.m., Matt Jordan wrote: branches/12/main/causes.c, lines 19-24 https://reviewboard.asterisk.org/r/3690/diff/3/?file=61383#file61383line19 Since this is specific to sip, I'd place it in something that calls that out. Maybe sip_causes? opticron wrote:

Re: [asterisk-dev] Proposed removal of deprecated modules in Asterisk 13 (cdr_sqlite, chan_gtalk, chan_jingle, res_jabber, chan_h323, app_readfile, app_dahdibarge, app_setcallerid, app_saycountpl)

2014-07-01 Thread Matthew Jordan
On Tue, Jul 1, 2014 at 6:51 AM, Olle E. Johansson o...@edvina.net wrote: On 01 Jul 2014, at 13:19, Matthew Jordan mjor...@digium.com wrote: On Tue, Jul 1, 2014 at 2:25 AM, Olle E. Johansson o...@edvina.net wrote: On 30 Jun 2014, at 16:24, Walter Doekes walter+asterisk-...@osso.nl wrote:

[asterisk-dev] [Code Review] 3692: ARI: Improvements To Documentation

2014-07-01 Thread Samuel Galarneau
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3692/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23975

Re: [asterisk-dev] [Code Review] 3687: media format improvements: Update packetization handling; improve rtp_engine's ast_rtp_codecs handling

2014-07-01 Thread Matt Jordan
On June 30, 2014, 7:15 p.m., Corey Farrell wrote: /team/group/media_formats-reviewed-trunk/formats/format_h263.c, line 52 https://reviewboard.asterisk.org/r/3687/diff/3/?file=61622#file61622line52 I meant for this to be in frame.h, this value seems to be used in many files of

Re: [asterisk-dev] [Code Review] 3690: CEL: Fix incorrect/missing extra field information

2014-07-01 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3690/ --- (Updated July 1, 2014, 11:13 a.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3687: media format improvements: Update packetization handling; improve rtp_engine's ast_rtp_codecs handling

2014-07-01 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3687/ --- (Updated July 1, 2014, 11:19 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3692: ARI: Improvements To Documentation

2014-07-01 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3692/#review12406 --- Ship it! Ship It! - opticron On July 1, 2014, 11:12 a.m.,

[asterisk-dev] [Code Review] 3693: A test of the Authenticate application to ensure that it fails properly.

2014-07-01 Thread Tyler Austin Cambron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3693/ --- Review request for Asterisk Developers. Bugs: SWP-7080

Re: [asterisk-dev] [Code Review] 3687: media format improvements: Update packetization handling; improve rtp_engine's ast_rtp_codecs handling

2014-07-01 Thread Corey Farrell
On June 30, 2014, 8:15 p.m., Corey Farrell wrote: /team/group/media_formats-reviewed-trunk/main/astobj2.c, lines 502-506 https://reviewboard.asterisk.org/r/3687/diff/3/?file=61629#file61629line502 If you feel this won't interfere with re-merging trunk we can go ahead. I'd prefer

Re: [asterisk-dev] [Code Review] 3687: media format improvements: Update packetization handling; improve rtp_engine's ast_rtp_codecs handling

2014-07-01 Thread Corey Farrell
On July 1, 2014, 1:14 p.m., Corey Farrell wrote: /team/group/media_formats-reviewed-trunk/main/rtp_engine.c, lines 704-708 https://reviewboard.asterisk.org/r/3687/diff/3/?file=61632#file61632line704 We need to remove from the vector. Also why not ao2_cleanup? A related thought,

Re: [asterisk-dev] [Code Review] 3687: media format improvements: Update packetization handling; improve rtp_engine's ast_rtp_codecs handling

2014-07-01 Thread Matt Jordan
On July 1, 2014, 12:14 p.m., Corey Farrell wrote: /team/group/media_formats-reviewed-trunk/main/rtp_engine.c, lines 578-581 https://reviewboard.asterisk.org/r/3687/diff/3/?file=61632#file61632line578 Do we need the temp variable or can we just ao2_cleanup(AST_VECTOR_GET())?

Re: [asterisk-dev] [Code Review] 3691: HTTP: Add persistent connection support.

2014-07-01 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3691/#review12407 --- /branches/12/include/asterisk/http.h

Re: [asterisk-dev] [Code Review] 3687: media format improvements: Update packetization handling; improve rtp_engine's ast_rtp_codecs handling

2014-07-01 Thread Matt Jordan
On July 1, 2014, 12:14 p.m., Corey Farrell wrote: /team/group/media_formats-reviewed-trunk/main/rtp_engine.c, lines 704-708 https://reviewboard.asterisk.org/r/3687/diff/3/?file=61632#file61632line704 We need to remove from the vector. Also why not ao2_cleanup? Corey Farrell

Re: [asterisk-dev] [Code Review] 3687: media format improvements: Update packetization handling; improve rtp_engine's ast_rtp_codecs handling

2014-07-01 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3687/ --- (Updated July 1, 2014, 12:43 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3687: media format improvements: Update packetization handling; improve rtp_engine's ast_rtp_codecs handling

2014-07-01 Thread Corey Farrell
On July 1, 2014, 1:14 p.m., Corey Farrell wrote: /team/group/media_formats-reviewed-trunk/main/rtp_engine.c, lines 704-708 https://reviewboard.asterisk.org/r/3687/diff/3/?file=61632#file61632line704 We need to remove from the vector. Also why not ao2_cleanup? Corey Farrell

Re: [asterisk-dev] [Code Review] 3687: media format improvements: Update packetization handling; improve rtp_engine's ast_rtp_codecs handling

2014-07-01 Thread Corey Farrell
On July 1, 2014, 1:14 p.m., Corey Farrell wrote: /team/group/media_formats-reviewed-trunk/main/rtp_engine.c, lines 704-708 https://reviewboard.asterisk.org/r/3687/diff/3/?file=61632#file61632line704 We need to remove from the vector. Also why not ao2_cleanup? Corey Farrell

Re: [asterisk-dev] [Code Review] 3687: media format improvements: Update packetization handling; improve rtp_engine's ast_rtp_codecs handling

2014-07-01 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3687/#review12415 --- Ship it!

Re: [asterisk-dev] [Code Review] 3650: pbx_config: Add manager command equivalents to 'dialplan add extension' and 'dialplan remove extension' CLI commands

2014-07-01 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3650/#review12417 --- This new functionality appears to be pbx backend independent.

Re: [asterisk-dev] [Code Review] 3660: testsuite: A rather comprehensive set of tests for DialplanAdd/RemoveExtension AMI commands

2014-07-01 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3660/#review12418 ---

Re: [asterisk-dev] [Code Review] 3650: pbx_config: Add manager command equivalents to 'dialplan add extension' and 'dialplan remove extension' CLI commands

2014-07-01 Thread Corey Farrell
On July 1, 2014, 2:27 p.m., opticron wrote: This new functionality appears to be pbx backend independent. It probably shouldn't live in pbx_config. Unless you consider cli: dialplan save. That CLI command would write changes made by these AMI commands (due to matching registrar). -

Re: [asterisk-dev] [Code Review] 3650: pbx_config: Add manager command equivalents to 'dialplan add extension' and 'dialplan remove extension' CLI commands

2014-07-01 Thread opticron
On July 1, 2014, 1:27 p.m., opticron wrote: This new functionality appears to be pbx backend independent. It probably shouldn't live in pbx_config. Corey Farrell wrote: Unless you consider cli: dialplan save. That CLI command would write changes made by these AMI commands (due

Re: [asterisk-dev] [Code Review] 3650: pbx_config: Add manager command equivalents to 'dialplan add extension' and 'dialplan remove extension' CLI commands

2014-07-01 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3650/#review12422 --- Ship it! Ship It! - opticron On June 27, 2014, 3 p.m.,

Re: [asterisk-dev] [Code Review] 3687: media format improvements: Update packetization handling; improve rtp_engine's ast_rtp_codecs handling

2014-07-01 Thread Matt Jordan
On July 1, 2014, 12:14 p.m., Corey Farrell wrote: /team/group/media_formats-reviewed-trunk/main/rtp_engine.c, lines 704-708 https://reviewboard.asterisk.org/r/3687/diff/3/?file=61632#file61632line704 We need to remove from the vector. Also why not ao2_cleanup? Corey Farrell

Re: [asterisk-dev] [Code Review] 3687: media format improvements: Update packetization handling; improve rtp_engine's ast_rtp_codecs handling

2014-07-01 Thread Matt Jordan
On July 1, 2014, 12:55 p.m., Corey Farrell wrote: /team/group/media_formats-reviewed-trunk/main/rtp_engine.c, line 595 https://reviewboard.asterisk.org/r/3687/diff/4-5/?file=61681#file61681line595 Would be nice to BUGBUG this procedure so we can audit callers, make them check

Re: [asterisk-dev] [Code Review] 3496: testsuite: add valgrind support

2014-07-01 Thread Samuel Galarneau
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3496/#review12419 --- /asterisk/trunk/lib/python/asterisk/asterisk.py

Re: [asterisk-dev] [Code Review] 3687: media format improvements: Update packetization handling; improve rtp_engine's ast_rtp_codecs handling

2014-07-01 Thread Corey Farrell
On July 1, 2014, 1:55 p.m., Corey Farrell wrote: /team/group/media_formats-reviewed-trunk/main/rtp_engine.c, line 595 https://reviewboard.asterisk.org/r/3687/diff/4-5/?file=61681#file61681line595 Would be nice to BUGBUG this procedure so we can audit callers, make them check

Re: [asterisk-dev] Proposed removal of deprecated modules in Asterisk 13 (cdr_sqlite, chan_gtalk, chan_jingle, res_jabber, chan_h323, app_readfile, app_dahdibarge, app_setcallerid, app_saycountpl)

2014-07-01 Thread Corey Farrell
Some more candidates for removal and the revision they were deprecated: DBDel application - r30241 MailboxExists application - r43659 (the replacement was deprecated/replaced almost 3 years ago) voicemail.conf options maxmessage / minmessage - r49075 ImportVar application - r76703

Re: [asterisk-dev] [Code Review] 3688: bamboo: provide bt / bt full for all threads on core dump

2014-07-01 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3688/ --- (Updated July 1, 2014, 3:48 p.m.) Status -- This change has been

[asterisk-dev] [Code Review] 3699: RLS: Inbound SUBSCRIBE handling

2014-07-01 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3699/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23868

[asterisk-dev] [Code Review] 3698: Remove deprecated modules and options (Round #1)

2014-07-01 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3698/ --- Review request for Asterisk Developers. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 3687: media format improvements: Update packetization handling; improve rtp_engine's ast_rtp_codecs handling

2014-07-01 Thread Matt Jordan
On July 1, 2014, 12:55 p.m., Corey Farrell wrote: /team/group/media_formats-reviewed-trunk/main/rtp_engine.c, line 595 https://reviewboard.asterisk.org/r/3687/diff/4-5/?file=61681#file61681line595 Would be nice to BUGBUG this procedure so we can audit callers, make them check

Re: [asterisk-dev] [Code Review] 3687: media format improvements: Update packetization handling; improve rtp_engine's ast_rtp_codecs handling

2014-07-01 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3687/ --- (Updated July 1, 2014, 8:15 p.m.) Status -- This change has been

Re: [asterisk-dev] Proposed removal of deprecated modules in Asterisk 13 (cdr_sqlite, chan_gtalk, chan_jingle, res_jabber, chan_h323, app_readfile, app_dahdibarge, app_setcallerid, app_saycountpl)

2014-07-01 Thread Matthew Jordan
On Tue, Jul 1, 2014 at 3:42 PM, Corey Farrell g...@cfware.com wrote: Some more candidates for removal and the revision they were deprecated: DBDel application - r30241 MailboxExists application - r43659 (the replacement was deprecated/replaced almost 3 years ago) voicemail.conf options

Re: [asterisk-dev] [Code Review] 3691: HTTP: Add persistent connection support.

2014-07-01 Thread rmudgett
On July 1, 2014, 12:34 p.m., opticron wrote: /branches/12/include/asterisk/http.h, lines 84-88 https://reviewboard.asterisk.org/r/3691/diff/1/?file=61640#file61640line84 The actual meaning of the integer return value should be detailed here now that it is being used. Updated the

Re: [asterisk-dev] [Code Review] 3691: HTTP: Add persistent connection support.

2014-07-01 Thread rmudgett
On July 1, 2014, 11:39 a.m., Matt Jordan wrote: /branches/12/main/http.c, lines 1658-1661 https://reviewboard.asterisk.org/r/3691/diff/1/?file=61642#file61642line1658 I may be missing something, but if httpd_process_request returns non-zero, that looks like it will break the

Re: [asterisk-dev] [Code Review] 3691: HTTP: Add persistent connection support.

2014-07-01 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3691/ --- (Updated July 1, 2014, 9:31 p.m.) Review request for Asterisk Developers.

[asterisk-dev] [Code Review] 3689: Media format improvements: the great renaming + some cleanup

2014-07-01 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3689/ --- Review request for Asterisk Developers. Repository: Asterisk