On 30 Jun 2014, at 16:24, Walter Doekes walter+asterisk-...@osso.nl wrote:
On 29-06-14 00:50, Matthew Jordan wrote:
* app_readfile/app_dahdibarge/app_setcallerid/app_saycountpl -
deprecated in Asterisk 1.8. While less important than the other
previously listed modules, having been deprecated
On Tue, Jul 1, 2014 at 2:25 AM, Olle E. Johansson o...@edvina.net wrote:
On 30 Jun 2014, at 16:24, Walter Doekes walter+asterisk-...@osso.nl
wrote:
On 29-06-14 00:50, Matthew Jordan wrote:
* app_readfile/app_dahdibarge/app_setcallerid/app_saycountpl -
deprecated in Asterisk 1.8. While
On 01-07-14 09:25, Olle E. Johansson wrote:
- SetMusicOnHold
- WaitMusicOnHold
What are the replacements for the musiconhold functions?
SetMusicOnHold:
Use Set(CHANNEL(musicclass)=...) instead !!!
==
SetMusicOnHold(myclass) ==
Set(CHANNEL(musicclass)=myclass)
WaitMusicOnHold:
On 01 Jul 2014, at 13:19, Matthew Jordan mjor...@digium.com wrote:
On Tue, Jul 1, 2014 at 2:25 AM, Olle E. Johansson o...@edvina.net wrote:
On 30 Jun 2014, at 16:24, Walter Doekes walter+asterisk-...@osso.nl wrote:
On 29-06-14 00:50, Matthew Jordan wrote:
*
On 01 Jul 2014, at 13:28, Walter Doekes walter+asterisk-...@osso.nl wrote:
in chan_sip:
- username (=defaultuser)
Username actually has multiple functions, which is why I separated one of
them
to defaultuser. username should remain the authentication username or be
replaced
by authuser=
On June 30, 2014, 5:54 p.m., Matt Jordan wrote:
branches/12/main/causes.c, lines 19-24
https://reviewboard.asterisk.org/r/3690/diff/3/?file=61383#file61383line19
Since this is specific to sip, I'd place it in something that calls
that out. Maybe sip_causes?
opticron wrote:
On Tue, Jul 1, 2014 at 6:51 AM, Olle E. Johansson o...@edvina.net wrote:
On 01 Jul 2014, at 13:19, Matthew Jordan mjor...@digium.com wrote:
On Tue, Jul 1, 2014 at 2:25 AM, Olle E. Johansson o...@edvina.net wrote:
On 30 Jun 2014, at 16:24, Walter Doekes walter+asterisk-...@osso.nl
wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3692/
---
Review request for Asterisk Developers.
Bugs: ASTERISK-23975
On June 30, 2014, 7:15 p.m., Corey Farrell wrote:
/team/group/media_formats-reviewed-trunk/formats/format_h263.c, line 52
https://reviewboard.asterisk.org/r/3687/diff/3/?file=61622#file61622line52
I meant for this to be in frame.h, this value seems to be used in many
files of
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3690/
---
(Updated July 1, 2014, 11:13 a.m.)
Review request for Asterisk Developers
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3687/
---
(Updated July 1, 2014, 11:19 a.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3692/#review12406
---
Ship it!
Ship It!
- opticron
On July 1, 2014, 11:12 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3693/
---
Review request for Asterisk Developers.
Bugs: SWP-7080
On June 30, 2014, 8:15 p.m., Corey Farrell wrote:
/team/group/media_formats-reviewed-trunk/main/astobj2.c, lines 502-506
https://reviewboard.asterisk.org/r/3687/diff/3/?file=61629#file61629line502
If you feel this won't interfere with re-merging trunk we can go ahead.
I'd prefer
On July 1, 2014, 1:14 p.m., Corey Farrell wrote:
/team/group/media_formats-reviewed-trunk/main/rtp_engine.c, lines 704-708
https://reviewboard.asterisk.org/r/3687/diff/3/?file=61632#file61632line704
We need to remove from the vector. Also why not ao2_cleanup?
A related thought,
On July 1, 2014, 12:14 p.m., Corey Farrell wrote:
/team/group/media_formats-reviewed-trunk/main/rtp_engine.c, lines 578-581
https://reviewboard.asterisk.org/r/3687/diff/3/?file=61632#file61632line578
Do we need the temp variable or can we just
ao2_cleanup(AST_VECTOR_GET())?
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3691/#review12407
---
/branches/12/include/asterisk/http.h
On July 1, 2014, 12:14 p.m., Corey Farrell wrote:
/team/group/media_formats-reviewed-trunk/main/rtp_engine.c, lines 704-708
https://reviewboard.asterisk.org/r/3687/diff/3/?file=61632#file61632line704
We need to remove from the vector. Also why not ao2_cleanup?
Corey Farrell
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3687/
---
(Updated July 1, 2014, 12:43 p.m.)
Review request for Asterisk
On July 1, 2014, 1:14 p.m., Corey Farrell wrote:
/team/group/media_formats-reviewed-trunk/main/rtp_engine.c, lines 704-708
https://reviewboard.asterisk.org/r/3687/diff/3/?file=61632#file61632line704
We need to remove from the vector. Also why not ao2_cleanup?
Corey Farrell
On July 1, 2014, 1:14 p.m., Corey Farrell wrote:
/team/group/media_formats-reviewed-trunk/main/rtp_engine.c, lines 704-708
https://reviewboard.asterisk.org/r/3687/diff/3/?file=61632#file61632line704
We need to remove from the vector. Also why not ao2_cleanup?
Corey Farrell
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3687/#review12415
---
Ship it!
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3650/#review12417
---
This new functionality appears to be pbx backend independent.
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3660/#review12418
---
On July 1, 2014, 2:27 p.m., opticron wrote:
This new functionality appears to be pbx backend independent. It probably
shouldn't live in pbx_config.
Unless you consider cli: dialplan save. That CLI command would write changes
made by these AMI commands (due to matching registrar).
-
On July 1, 2014, 1:27 p.m., opticron wrote:
This new functionality appears to be pbx backend independent. It probably
shouldn't live in pbx_config.
Corey Farrell wrote:
Unless you consider cli: dialplan save. That CLI command would write
changes made by these AMI commands (due
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3650/#review12422
---
Ship it!
Ship It!
- opticron
On June 27, 2014, 3 p.m.,
On July 1, 2014, 12:14 p.m., Corey Farrell wrote:
/team/group/media_formats-reviewed-trunk/main/rtp_engine.c, lines 704-708
https://reviewboard.asterisk.org/r/3687/diff/3/?file=61632#file61632line704
We need to remove from the vector. Also why not ao2_cleanup?
Corey Farrell
On July 1, 2014, 12:55 p.m., Corey Farrell wrote:
/team/group/media_formats-reviewed-trunk/main/rtp_engine.c, line 595
https://reviewboard.asterisk.org/r/3687/diff/4-5/?file=61681#file61681line595
Would be nice to BUGBUG this procedure so we can audit callers, make
them check
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3496/#review12419
---
/asterisk/trunk/lib/python/asterisk/asterisk.py
On July 1, 2014, 1:55 p.m., Corey Farrell wrote:
/team/group/media_formats-reviewed-trunk/main/rtp_engine.c, line 595
https://reviewboard.asterisk.org/r/3687/diff/4-5/?file=61681#file61681line595
Would be nice to BUGBUG this procedure so we can audit callers, make
them check
Some more candidates for removal and the revision they were deprecated:
DBDel application - r30241
MailboxExists application - r43659 (the replacement was
deprecated/replaced almost 3 years ago)
voicemail.conf options maxmessage / minmessage - r49075
ImportVar application - r76703
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3688/
---
(Updated July 1, 2014, 3:48 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3699/
---
Review request for Asterisk Developers.
Bugs: ASTERISK-23868
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3698/
---
Review request for Asterisk Developers.
Repository: Asterisk
On July 1, 2014, 12:55 p.m., Corey Farrell wrote:
/team/group/media_formats-reviewed-trunk/main/rtp_engine.c, line 595
https://reviewboard.asterisk.org/r/3687/diff/4-5/?file=61681#file61681line595
Would be nice to BUGBUG this procedure so we can audit callers, make
them check
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3687/
---
(Updated July 1, 2014, 8:15 p.m.)
Status
--
This change has been
On Tue, Jul 1, 2014 at 3:42 PM, Corey Farrell g...@cfware.com wrote:
Some more candidates for removal and the revision they were deprecated:
DBDel application - r30241
MailboxExists application - r43659 (the replacement was
deprecated/replaced almost 3 years ago)
voicemail.conf options
On July 1, 2014, 12:34 p.m., opticron wrote:
/branches/12/include/asterisk/http.h, lines 84-88
https://reviewboard.asterisk.org/r/3691/diff/1/?file=61640#file61640line84
The actual meaning of the integer return value should be detailed here
now that it is being used.
Updated the
On July 1, 2014, 11:39 a.m., Matt Jordan wrote:
/branches/12/main/http.c, lines 1658-1661
https://reviewboard.asterisk.org/r/3691/diff/1/?file=61642#file61642line1658
I may be missing something, but if httpd_process_request returns
non-zero, that looks like it will break the
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3691/
---
(Updated July 1, 2014, 9:31 p.m.)
Review request for Asterisk Developers.
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3689/
---
Review request for Asterisk Developers.
Repository: Asterisk
42 matches
Mail list logo