Re: [asterisk-dev] [Code Review] 4056: chan_sip: Fix so asterisk won't send reINVITE after a BYE.

2014-10-09 Thread wdoekes
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4056/ --- (Updated Oct. 9, 2014, 9:39 a.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4052: chan_sip: Failure to receive ACK to SIP re-INVITE results in dialog leak.

2014-10-09 Thread wdoekes
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4052/ --- (Updated Oct. 9, 2014, 9:38 a.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] Asterisk ARI improper usage pattern for channels REST API

2014-10-09 Thread Nir Simionovich
Forgive me father for I have sinned, it has been over 25 years since I've used GWBasic/Basica - please spare thy humble servant from doom, as I repent my sins and go back in time 25 years :-) Now seriously, this may work nicely for classic dialplan, but for AEL that's a no go - don't even want to

Re: [asterisk-dev] [Code Review] 4052: chan_sip: Failure to receive ACK to SIP re-INVITE results in dialog leak.

2014-10-09 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4052/#review13470 --- Ship it! Ship It! - Matt Jordan On Oct. 9, 2014, 4:38

Re: [asterisk-dev] [Code Review] 4051: testsuite: chan_sip: Test dialog leak reported in ASTERISK-20784.

2014-10-09 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4051/#review13471 ---

Re: [asterisk-dev] [Code Review] 4051: testsuite: chan_sip: Test dialog leak reported in ASTERISK-20784.

2014-10-09 Thread wdoekes
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4051/ --- (Updated Oct. 9, 2014, 1:49 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4051: testsuite: chan_sip: Test dialog leak reported in ASTERISK-20784.

2014-10-09 Thread wdoekes
On Oct. 9, 2014, 12:12 p.m., Matt Jordan wrote: /asterisk/trunk/tests/channels/SIP/no_ack_dialog_cleanup/run-test, line 42 https://reviewboard.asterisk.org/r/4051/diff/2/?file=67875#file67875line42 nitpick: As this is a global, it should be LOGGER, not logger. (Yes, I'm

[asterisk-dev] [Code Review] 4062: PJSIP: Enforce module load dependencies

2014-10-09 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4062/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24312

Re: [asterisk-dev] [Code Review] 4051: testsuite: chan_sip: Test dialog leak reported in ASTERISK-20784.

2014-10-09 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4051/#review13474 --- Ship it! Ship It! - Matt Jordan On Oct. 9, 2014, 8:49

Re: [asterisk-dev] [Code Review] 4051: testsuite: chan_sip: Test dialog leak reported in ASTERISK-20784.

2014-10-09 Thread Matt Jordan
On Oct. 9, 2014, 7:12 a.m., Matt Jordan wrote: /asterisk/trunk/tests/channels/SIP/no_ack_dialog_cleanup/run-test, line 42 https://reviewboard.asterisk.org/r/4051/diff/2/?file=67875#file67875line42 nitpick: As this is a global, it should be LOGGER, not logger. (Yes, I'm

[asterisk-dev] [Code Review] 4064: makefile: Relax badshell tilde test to allow for ~ in middle of DESTDIR.

2014-10-09 Thread wdoekes
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4064/ --- Review request for Asterisk Developers. Bugs: ASTERISK-13797

Re: [asterisk-dev] Asterisk ARI improper usage pattern for channels REST API

2014-10-09 Thread Scott Griepentrog
If you want to add the label option, my first thought would be to recommend you look at the implementation of ​app GoTo() for the api to lookup/specify a label. Then you would need to modify the channels.json in rest_api/api-docs to specify the new/different parameters to the rest methods, do a

Re: [asterisk-dev] [Code Review] 4039: res_rtp_asterisk: Crash if no candidates received for component

2014-10-09 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4039/ --- (Updated Oct. 9, 2014, 10:44 a.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4039: res_rtp_asterisk: Crash if no candidates received for component

2014-10-09 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4039/#review13475 --- Ship it! Ship It! - Joshua Colp On Oct. 9, 2014, 3:44

Re: [asterisk-dev] [Code Review] 4061: testsuite: Initial test for res_phoneprov

2014-10-09 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4061/#review13476 --- Ship it! Both of these findings are minor, and I don't think

Re: [asterisk-dev] [Code Review] 4048: res_fax: Fix fax handler module reference leak

2014-10-09 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4048/#review13477 --- Ship it! Ship It! - Matt Jordan On Oct. 6, 2014, 11:49

[asterisk-dev] [Code Review] 4065: testsuite: Initial test for res_pjsip_phoneprov_provider

2014-10-09 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4065/ --- Review request for Asterisk Developers. Repository: testsuite

Re: [asterisk-dev] [Code Review] 4061: testsuite: Initial test for res_phoneprov

2014-10-09 Thread George Joseph
On Oct. 9, 2014, 11:02 a.m., Matt Jordan wrote: asterisk/trunk/tests/phoneprov/res_phoneprov/run-test, lines 49-50 https://reviewboard.asterisk.org/r/4061/diff/1/?file=67886#file67886line49 You may want to use a LOGGER.error() here before re-raising the exception.

[asterisk-dev] [Code Review] 4066: stasis_channels.c: Resolve unfinished Dials when doing masquerades (Part 2)

2014-10-09 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4066/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24237 and

Re: [asterisk-dev] [Code Review] 3970: res_phoneprov: Refactor phoneprov to allow pluggable config providers.

2014-10-09 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3970/ --- (Updated Oct. 9, 2014, 12:41 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4057: bridge: Every time a bridge lies during the smart bridge operation I cry

2014-10-09 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4057/#review13480 --- /branches/12/main/bridge.c

Re: [asterisk-dev] [Code Review] 4057: bridge: Every time a bridge lies during the smart bridge operation I cry

2014-10-09 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4057/ --- (Updated Oct. 9, 2014, 6:16 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4065: testsuite: Initial test for res_pjsip_phoneprov_provider

2014-10-09 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4065/ --- (Updated Oct. 9, 2014, 1:27 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4049: res_fax: Fix reference leak caused by gateway sessions being added to faxregistry.container twice

2014-10-09 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4049/#review13482 --- Ship it! Ship It! - opticron On Oct. 7, 2014, 2:04 p.m.,

Re: [asterisk-dev] [Code Review] 4057: bridge: Every time a bridge lies during the smart bridge operation I cry

2014-10-09 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4057/#review13481 --- Ship it! Comment nit. Now if I can convince people to use

Re: [asterisk-dev] [Code Review] 4065: testsuite: Initial test for res_pjsip_phoneprov_provider

2014-10-09 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4065/ --- (Updated Oct. 9, 2014, 12:52 p.m.) Review request for Asterisk Developers

[asterisk-dev] [Code Review] 4067: CallerID: Fix parsing regression

2014-10-09 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4067/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24406

Re: [asterisk-dev] [Code Review] 4067: CallerID: Fix parsing regression

2014-10-09 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4067/#review13483 --- branches/1.8/main/callerid.c

Re: [asterisk-dev] [Code Review] 4065: testsuite: Initial test for res_pjsip_phoneprov_provider

2014-10-09 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4065/ --- (Updated Oct. 9, 2014, 2:25 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4067: CallerID: Fix parsing regression

2014-10-09 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4067/ --- (Updated Oct. 9, 2014, 2:37 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4067: CallerID: Fix parsing regression

2014-10-09 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4067/#review13485 --- Ship it! Ship It! - rmudgett On Oct. 9, 2014, 2:37 p.m.,

Re: [asterisk-dev] [Code Review] 4065: testsuite: Initial test for res_pjsip_phoneprov_provider

2014-10-09 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4065/#review13486 --- Ship it! Ship It! - Matt Jordan On Oct. 9, 2014, 2:25

Re: [asterisk-dev] [Code Review] 3976: New module: res_pjsip_phoneprov_provider provides the integration between res_pjsip and res_phoneprov.

2014-10-09 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3976/ --- (Updated Oct. 9, 2014, 3:34 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4038: Testsuite: Process REF_DEBUG logs, fail any test that leaks

2014-10-09 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4038/#review13484 --- /asterisk/trunk/runtests.py

Re: [asterisk-dev] [Code Review] 4065: testsuite: Initial test for res_pjsip_phoneprov_provider

2014-10-09 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4065/ --- (Updated Oct. 9, 2014, 3:59 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4055: testsuite: chan_sip: Test unscheduling reINVITE after call hangup.

2014-10-09 Thread wdoekes
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4055/ --- (Updated Oct. 9, 2014, 9:16 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4039: res_rtp_asterisk: Crash if no candidates received for component

2014-10-09 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4039/ --- (Updated Oct. 9, 2014, 4:26 p.m.) Status -- This change has been