Re: [asterisk-dev] Asterisk 14 - Remote URI Playback

Den 2014-11-05 08:45, BJ Weschke skrev: As for the timestamps for deciding whether the local cache is dirty, I don't think we should try to reinvent the wheel here. We should stick what's already well established for stuff like this and use the entity tag (Etag) response header stored and then

Re: [asterisk-dev] [Code Review] 4148: res_pjsip_multihomed: Provide logging during startup for an indication of what is going on

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4148/ --- (Updated Nov. 5, 2014, 6:17 a.m.) Status -- This change has been mark

Re: [asterisk-dev] [Code Review] 4149: main/file.c: fix possible extra ast_module_unref to format modules

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4149/#review13683 --- Ship it! Ship It! - Joshua Colp On Nov. 4, 2014, 11:11 p.m.

Re: [asterisk-dev] [Code Review] 4093: Codec Format Is Not Included in the SDP Media Attributes When SLIN48 Codec Is Used

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4093/#review13684 --- /tags/12.4.0/main/rtp_engine.c

Re: [asterisk-dev] [Code Review] 3603: func_jitterbuffer: fix audio failure caused by certain masquerade's

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3603/#review13685 --- Was the behavior for this ever brought up on the -dev list? I d

Re: [asterisk-dev] [Code Review] 4053: res_pjsip_history: A debugging module for busy systems

> On Oct. 16, 2014, 9:44 p.m., Mark Michelson wrote: > > /trunk/res/res_pjsip_history.c, lines 44-47 > > > > > > I wonder if the code could be simplified by instead of saving rdata and > > tdata, saving a pjsip_msg

Re: [asterisk-dev] [Code Review] 4053: res_pjsip_history: A debugging module for busy systems

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4053/#review13687 --- /trunk/res/res_pjsip_history.c

Re: [asterisk-dev] [Code Review] 4101: Channel Originate/Continue via ARI support for labels in dialplan is incomplete

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4101/#review13688 --- /trunk/res/ari/resource_channels.c

Re: [asterisk-dev] [Code Review] 3867: [chan_sip] Default DTLS settings to use if peer misses own settings

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3867/#review13689 --- Ship it! I'm fine with putting this in after looking at how it

Re: [asterisk-dev] [Code Review] 4101: Channel Originate/Continue via ARI support for labels in dialplan is incomplete

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4101/ --- (Updated Nov. 5, 2014, 2:16 p.m.) Review request for Asterisk Developers.

[asterisk-dev] Asterisk 1.8.32.0-rc1 Created

Hey all - As you may know, the last bug fix release of Asterisk 1.8 is scheduled to be 1.8.32.0 [1]. Two days ago, we made the first release candidate of that release [2]. That means that, barring a blocker for release (that is, a really, really, REALLY bad bug/regression), bug fixes should no lon

Re: [asterisk-dev] [Code Review] 4123: app_agent_pool: Make agent alert interruptable by DTMF.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4123/#review13676 --- /branches/12/main/bridge_channel.c

Re: [asterisk-dev] [Code Review] 4101: Channel Originate/Continue via ARI support for labels in dialplan is incomplete

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4101/#review13690 --- Matt brought it up that this is actually a backwards incompatib

Re: [asterisk-dev] [Code Review] 4102: testsuite: add secure websocket test

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4102/#review13691 --- This needs certificate stuff and configuration so the HTTPS ser

Re: [asterisk-dev] [Code Review] 3603: func_jitterbuffer: fix audio failure caused by certain masquerade's

> On Nov. 5, 2014, 7:55 a.m., Joshua Colp wrote: > > Was the behavior for this ever brought up on the -dev list? I don't > > remember it so I don't think so. Before accepting the behavior you've done > > I'd really like us to talk about it there amongst everyone. I really think > > it's the re

Re: [asterisk-dev] [Code Review] 3603: func_jitterbuffer: fix audio failure caused by certain masquerade's

> On Nov. 5, 2014, 12:55 p.m., Joshua Colp wrote: > > Was the behavior for this ever brought up on the -dev list? I don't > > remember it so I don't think so. Before accepting the behavior you've done > > I'd really like us to talk about it there amongst everyone. I really think > > it's the r

Re: [asterisk-dev] func_jitterbuffer handling of masquerades

Corey Farrell wrote: The change I am proposing is that we always have an active JB after masquerade if either side had one before the masquerade. So in scenario 1 and 2 listed above this would cause the only active jitterbuffer to remain active after a masquerade. For situations where both

Re: [asterisk-dev] [Code Review] 4123: app_agent_pool: Make agent alert interruptable by DTMF.

> On Nov. 5, 2014, 11:24 a.m., Mark Michelson wrote: > > /branches/12/main/bridge_channel.c, lines 2155-2160 > > > > > > It's probably worth printing a warning message if this case occurs. > > Told to write someth

Re: [asterisk-dev] [Code Review] 4139: stun: fix size of attribute string to match rfc

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4139/#review13696 --- Ship it! Ship It! - Joshua Colp On Oct. 31, 2014, 8:29 p.m.

Re: [asterisk-dev] [Code Review] 4123: app_agent_pool: Make agent alert interruptable by DTMF.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4123/ --- (Updated Nov. 5, 2014, 1:01 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4123: app_agent_pool: Make agent alert interruptable by DTMF.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4123/#review13697 --- Ship it! Ship It! - Mark Michelson On Nov. 5, 2014, 7:01 p.