Re: [asterisk-dev] [Code Review] 4188: segfault when playing back voicemail under high concurrency with an IMAP backend

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4188/#review13790 --- From

Re: [asterisk-dev] [Code Review] 4090: testsuite: add basic valgrind support

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4090/#review13791 --- Ship it! Please discard my findings, they are minor. I'd

Re: [asterisk-dev] [Code Review] 4186: stringfields: Fix regression from fix for unintentional memory retention and another issue exposed by the fix

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4186/ --- (Updated Nov. 18, 2014, 9:25 a.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4090: testsuite: add basic valgrind support

On Nov. 18, 2014, 8:18 a.m., Corey Farrell wrote: Please discard my findings, they are minor. I'd like to see this committed ASAP so further improvements can be made against it. I like your idea of adding an option to pass valgrind options, but it needs to first be set to write logs to

Re: [asterisk-dev] [Code Review] 4090: testsuite: add basic valgrind support

On Oct. 16, 2014, 5:58 p.m., Kevin Harwell wrote: /asterisk/trunk/runtests.py, lines 461-462 https://reviewboard.asterisk.org/r/4090/diff/1/?file=68379#file68379line461 Not a huge fan of using an environment variable for this (could probably be convinced otherwise though). Maybe

Re: [asterisk-dev] [Code Review] 4090: testsuite: add basic valgrind support

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4090/ --- (Updated Nov. 18, 2014, 9:49 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4090: testsuite: add basic valgrind support

On Nov. 18, 2014, 9:18 a.m., Corey Farrell wrote: Please discard my findings, they are minor. I'd like to see this committed ASAP so further improvements can be made against it. Scott Griepentrog wrote: I like your idea of adding an option to pass valgrind options, but it needs

Re: [asterisk-dev] [Code Review] 3496: testsuite: add valgrind support

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3496/ --- (Updated Nov. 18, 2014, 9:53 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4090: testsuite: add basic valgrind support

On Nov. 18, 2014, 8:18 a.m., Corey Farrell wrote: Please discard my findings, they are minor. I'd like to see this committed ASAP so further improvements can be made against it. Scott Griepentrog wrote: I like your idea of adding an option to pass valgrind options, but it needs

Re: [asterisk-dev] [Code Review] 4168: Testsuite: transferdialattempts test

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4168/#review13795 --- Ship it! - Matt Jordan On Nov. 17, 2014, 1:48 p.m., Mark

Re: [asterisk-dev] [Code Review] 4187: res_pjsip_refer: Ensure Refer-To is NULL terminated and parse it as a URI

On Nov. 18, 2014, 4:44 p.m., Matt Jordan wrote: /branches/12/res/res_pjsip_refer.c, lines 876-884 https://reviewboard.asterisk.org/r/4187/diff/1/?file=69002#file69002line876 Why is it safe to modify the refer_to-hvalue.ptr directly? I would have thought we'd have to allocate a

Re: [asterisk-dev] [Code Review] 4187: res_pjsip_refer: Ensure Refer-To is NULL terminated and parse it as a URI

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4187/#review13797 --- /branches/12/res/res_pjsip_refer.c

Re: [asterisk-dev] [Code Review] 4187: res_pjsip_refer: Ensure Refer-To is NULL terminated and parse it as a URI

On Nov. 18, 2014, 10:44 a.m., Matt Jordan wrote: /branches/12/res/res_pjsip_refer.c, lines 876-884 https://reviewboard.asterisk.org/r/4187/diff/1/?file=69002#file69002line876 Why is it safe to modify the refer_to-hvalue.ptr directly? I would have thought we'd have to allocate a

Re: [asterisk-dev] [Code Review] 4187: res_pjsip_refer: Ensure Refer-To is NULL terminated and parse it as a URI

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4187/#review13800 --- Ship it! Ship It! - Matt Jordan On Nov. 16, 2014, 5:36

[asterisk-dev] [Code Review] 4190: res_pjsip_config_wizard: Allow streamlined configuration of common pjsip scenarios

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4190/ --- Review request for Asterisk Developers, Joshua Colp and Mark Michelson.

Re: [asterisk-dev] [Code Review] 4172: Testsuite: tests for res_pjsip_config_wizard

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4172/ --- (Updated Nov. 18, 2014, 10:40 a.m.) Review request for Asterisk

[asterisk-dev] [Code Review] 4192: Update channel Stasis topics during a masquerade

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4192/ --- Review request for Asterisk Developers and opticron. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 4186: stringfields: Fix regression from fix for unintentional memory retention and another issue exposed by the fix

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4186/#review13803 --- What you have found shows that the problem is in v12+ and not

Re: [asterisk-dev] [Code Review] 4186: stringfields: Fix regression from fix for unintentional memory retention and another issue exposed by the fix

On Nov. 18, 2014, 1:19 p.m., rmudgett wrote: What you have found shows that the problem is in v12+ and not v1.8+ I had thought that the call to __ast_string_field_ptr_grow was a problem in 1.8/11 based on thinking that 'AST_STRING_FIELD_ALLOCATION(*ptr) += grow;' would modify the __p__,

Re: [asterisk-dev] [Code Review] 4186: stringfields: Fix regression from fix for unintentional memory retention caused by ast_string_fields_copy

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4186/ --- (Updated Nov. 18, 2014, 1:33 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4186: stringfields: Fix regression from fix for unintentional memory retention caused by ast_string_fields_copy

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4186/ --- (Updated Nov. 18, 2014, 1:36 p.m.) Review request for Asterisk Developers

[asterisk-dev] [Code Review] 4193: Stasis: allow for subscriptions to dictate message delivery on a threadpool for certain situations

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4193/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24533

Re: [asterisk-dev] [Code Review] 4186: stringfields: Fix regression from fix for unintentional memory retention caused by ast_string_fields_copy

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4186/#review13806 --- Ship it! Ship It! - rmudgett On Nov. 18, 2014, 12:36 p.m.,

Re: [asterisk-dev] [Code Review] 3603: func_jitterbuffer: fix audio failure caused by certain masquerade's

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3603/#review13807 --- /branches/11/funcs/func_jitterbuffer.c

Re: [asterisk-dev] [Code Review] 4194: ast_str: Fix improper member access to struct ast_str members.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4194/#review13809 --- Ship it! Ship It! - Corey Farrell On Nov. 18, 2014, 3:03

Re: [asterisk-dev] [Code Review] 4090: testsuite: add basic valgrind support

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4090/#review13810 --- Got a small problem with this... When runtests.py checks to

Re: [asterisk-dev] [Code Review] 4185: sorcery: Make ast_sorcery_is_object_field_registered handle field names that are regexes.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4185/ --- (Updated Nov. 18, 2014, 2:18 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4145: testsuite: update pretty_print script for recent runtests.py changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4145/#review13811 --- Ship it! Ship It! - Matt Jordan On Nov. 16, 2014, 7:38

Re: [asterisk-dev] [Code Review] 4172: Testsuite: tests for res_pjsip_config_wizard

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4172/#review13812 --- Ship it! - Matt Jordan On Nov. 18, 2014, 11:40 a.m., George

Re: [asterisk-dev] [Code Review] 4192: Update channel Stasis topics during a masquerade

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4192/ --- (Updated Nov. 18, 2014, 10:04 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4178: res_pjsip_outbound_publish: stack overflow when using non-default sorcery wizard

On Nov. 15, 2014, 9:22 a.m., Matt Jordan wrote: branches/13/res/res_pjsip_outbound_publish.c, lines 274-275 https://reviewboard.asterisk.org/r/4178/diff/1/?file=68968#file68968line274 I don't really like the pattern that we have here. We technically have two destructor