[asterisk-dev] automated response

2015-02-10 Thread Joseph Shi
I will not be in the office till Feb 24, but I will be checking my email periodically. -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit:

Re: [asterisk-dev] [Code Review] 4413: Testsuite: Simulate phones and control from YAML.

2015-02-10 Thread jbigelow
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4413/ --- (Updated Feb. 11, 2015, 12:32 a.m.) Review request for Asterisk Developers

[asterisk-dev] [Code Review] 4413: Testsuite: Simulate phones and control from YAML.

2015-02-10 Thread jbigelow
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4413/ --- Review request for Asterisk Developers. Repository: testsuite Descriptio

Re: [asterisk-dev] [Code Review] 4383: res_pjsip_config_wizard: Add ability to auto-create hints.

2015-02-10 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4383/ --- (Updated Feb. 10, 2015, 5:16 p.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 4383: res_pjsip_config_wizard: Add ability to auto-create hints.

2015-02-10 Thread George Joseph
> On Feb. 10, 2015, 11:50 a.m., Joshua Colp wrote: > > branches/13/res/res_pjsip_config_wizard.c, lines 427-430 > > > > > > App and data could still be empty after this. > > rmudgett wrote: > Not to mention tha

Re: [asterisk-dev] [Code Review] 4412: res_http_websocket: websocket write timeout fails to fully disconnect underlying socket

2015-02-10 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4412/#review14437 --- Ship it! branches/13/res/ari/ari_websockets.c

Re: [asterisk-dev] [Code Review] 4399: HTTP: Stop accepting requests on final system shutdown.

2015-02-10 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4399/#review14439 --- Ship it! Ship It! - Mark Michelson On Feb. 5, 2015, 9:58 p.

Re: [asterisk-dev] [Code Review] 4412: res_http_websocket: websocket write timeout fails to fully disconnect underlying socket

2015-02-10 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4412/#review14438 --- branches/13/res/res_http_websocket.c

Re: [asterisk-dev] [Code Review] 4383: res_pjsip_config_wizard: Add ability to auto-create hints.

2015-02-10 Thread rmudgett
> On Feb. 10, 2015, 12:50 p.m., Joshua Colp wrote: > > branches/13/res/res_pjsip_config_wizard.c, lines 427-430 > > > > > > App and data could still be empty after this. Not to mention that data is not NULL checked

Re: [asterisk-dev] [Code Review] 4383: res_pjsip_config_wizard: Add ability to auto-create hints.

2015-02-10 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4383/#review14435 --- Ship it! branches/13/res/res_pjsip_config_wizard.c

Re: [asterisk-dev] [Code Review] 4409: res_pjsip: dtls_handler causes Asterisk to crash

2015-02-10 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4409/#review14434 --- Ship it! Ship It! - Joshua Colp On Feb. 7, 2015, 12:25 a.m.

[asterisk-dev] [Code Review] 4412: res_http_websocket: websocket write timeout fails to fully disconnect underlying socket

2015-02-10 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4412/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24701 https://i

Re: [asterisk-dev] [Code Review] 4411: testsuite: fix a number of tests where Asterisk does not shutdown gracefully

2015-02-10 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4411/#review14433 --- Ship it! The only caveat here is that you may want to watch au

Re: [asterisk-dev] [Code Review] 4408: Testsuite: Add external bridging tests for Stasis (two channel) interactions

2015-02-10 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4408/#review14432 --- Ship it! Excellent test descriptions! - Mark Michelson On F