Corey Farrell has posted comments on this change.
Change subject: .gitignore: Ignore tarballs (*.gz)
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.asterisk.org/86
To unsubscribe, visit https://gerrit.asterisk.
Corey Farrell has posted comments on this change.
Change subject: PEP8 fixes
..
Patch Set 2: -Code-Review
It appears that it's not this change that is broken, it's my computer.
--
To view, visit https://gerrit.asterisk.org/40
Corey Farrell has posted comments on this change.
Change subject: PEP8 fixes
..
Patch Set 2: Code-Review-1
Still working out an issue.
--
To view, visit https://gerrit.asterisk.org/40
To unsubscribe, visit https://gerrit.aste
Corey Farrell has posted comments on this change.
Change subject: git migration: Remove support for file versions
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.asterisk.org/60
To unsubscribe, visit https://ger
Corey Farrell has posted comments on this change.
Change subject: git migration: Remove support for file versions
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.asterisk.org/61
To unsubscribe, visit https://ger
Corey Farrell has uploaded a new change for review.
https://gerrit.asterisk.org/74
Change subject: AMI: Fix improper handling of lines that are exactly 1025 bytes
long.
..
AMI: Fix improper handling of lines that are exactly
Corey Farrell has posted comments on this change.
Change subject: Optional API: Fix handling of sources that are both provider
and user.
..
Patch Set 1:
This was previously posted for review at
https://reviewboard.asterisk.or
Corey Farrell has uploaded a new change for review.
https://gerrit.asterisk.org/73
Change subject: Optional API: Fix handling of sources that are both provider
and user.
..
Optional API: Fix handling of sources that are both
Corey Farrell has uploaded a new change for review.
https://gerrit.asterisk.org/72
Change subject: res_monitor: Add dependency on func_periodic_hook.
..
res_monitor: Add dependency on func_periodic_hook.
OPTIONAL_API has cond
Corey Farrell has posted comments on this change.
Change subject: git migration: Remove support for file versions
..
Patch Set 2: Code-Review-1
(1 comment)
Missed one spot where we should conditionally return Asterisk Version.
Corey Farrell has posted comments on this change.
Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro
..
Patch Set 5: Code-Review+1
Used grep, found a few tests that were still using parameters with the new
Hello George Joseph,
I'd like you to reexamine a change. Please visit
https://gerrit.asterisk.org/58
to look at the new patch set (#5).
Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro
..
git migrat
Corey Farrell has posted comments on this change.
Change subject: PEP8 fixes
..
Patch Set 2:
(2 comments)
The PJSIP tests no longer fail. I have a full run of the testsuite going now,
so far no issues.
https://gerrit.asteri
Hello Matt Jordan, George Joseph,
I'd like you to reexamine a change. Please visit
https://gerrit.asterisk.org/40
to look at the new patch set (#2).
Change subject: PEP8 fixes
..
PEP8 fixes
* Add tox.ini for pep8 to set
Corey Farrell has posted comments on this change.
Change subject: git migration: Remove support for file versions
..
Patch Set 1: -Code-Review
(1 comment)
https://gerrit.asterisk.org/#/c/61/1/main/asterisk.c
File main/asterisk
Corey Farrell has posted comments on this change.
Change subject: git migration: Remove support for file versions
..
Patch Set 1:
(1 comment)
https://gerrit.asterisk.org/#/c/61/1/main/asterisk.c
File main/asterisk.c:
Line 390
Corey Farrell has posted comments on this change.
Change subject: git migration: Remove support for file versions
..
Patch Set 1: Code-Review+1
(1 comment)
So I'm a bit indifferent about the finding against main/asterisk.c, up
Corey Farrell has posted comments on this change.
Change subject: git migration: Remove support for file versions
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.asterisk.org/60
To unsubscribe, visit https://ger
Corey Farrell has posted comments on this change.
Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.asterisk.org/58
To unsubscribe, visit htt
Corey Farrell has uploaded a new change for review.
https://gerrit.asterisk.org/57
Change subject: main/editline: Add .gitignore.
..
main/editline: Add .gitignore.
This patch adds a .gitignore for main/editline to ignore all
Corey Farrell has uploaded a new change for review.
https://gerrit.asterisk.org/56
Change subject: astobj2: Add support for weakproxy objects.
..
astobj2: Add support for weakproxy objects.
This implements "weak" references.
Corey Farrell has posted comments on this change.
Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro
..
Patch Set 3: Code-Review-1
(9 comments)
https://gerrit.asterisk.org/#/c/54/3//COMMIT_MSG
Commit Messa
Corey Farrell has posted comments on this change.
Change subject: .gitignore: Ignore tarballs (*.gz)
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.asterisk.org/55
To unsubscribe, visit https://gerrit.asterisk.
Corey Farrell has posted comments on this change.
Change subject: sounds: Add a .gitignore file for downloaded sound tarballs
..
Patch Set 1: Code-Review-1
Any reason we can't just add to the root .gitignore:
*.gz
This way if
Corey Farrell has posted comments on this change.
Change subject: Add .gitignore and .gitreview files
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.asterisk.org/42
To unsubscribe, visit https://gerrit.asterisk
Corey Farrell has posted comments on this change.
Change subject: Add .gitignore and .gitreview files
..
Patch Set 1:
(2 comments)
Couple minor things then this is good to go.
https://gerrit.asterisk.org/#/c/42/1/.gitignore
F
Hello Anonymous Coward #119,
I'd like you to reexamine a change. Please visit
https://gerrit.asterisk.org/35
to look at the new patch set (#3).
Change subject: res_phoneprov_pjsip: Disconnect HTTP before stopping Asterisk.
...
Hello Anonymous Coward #119,
I'd like you to reexamine a change. Please visit
https://gerrit.asterisk.org/35
to look at the new patch set (#2).
Change subject: res_phoneprov_pjsip: Disconnect HTTP before stopping Asterisk.
...
Corey Farrell has uploaded a new change for review.
https://gerrit.asterisk.org/35
Change subject: res_phoneprov_pjsip: Disconnect HTTP before stopping Asterisk.
..
res_phoneprov_pjsip: Disconnect HTTP before stopping Asterisk
Corey Farrell has posted comments on this change.
Change subject: non_stasis_bridge_to_stasis_bridge: Update regex for ami events
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.asterisk.org/25
To unsubscribe, v
Corey Farrell has uploaded a new change for review.
https://gerrit.asterisk.org/27
Change subject: Enable support for directory containing custom tests.
..
Enable support for directory containing custom tests.
This change ena
Corey Farrell has posted comments on this change.
Change subject: non_stasis_bridge_to_stasis_bridge: Update regex for ami events
..
Patch Set 2: Code-Review-1
(2 comments)
Couple nit-picks about a comment / commit message. O
Hello Ashley Sanders,
I'd like you to reexamine a change. Please visit
https://gerrit.asterisk.org/15
to look at the new patch set (#4).
Change subject: Memory Debugging Improvements
..
Memory Debugging Improvements
* En
Corey Farrell has posted comments on this change.
Change subject: Add SIP attended transfer for Asterisk 11.
..
Patch Set 1:
This is nearly identical to the test for 12+, couldn't they be combined with
attended_transfer.py usi
Corey Farrell has uploaded a new patch set (#3).
Change subject: Memory Debugging Improvements
..
Memory Debugging Improvements
* Enable XML output from valgrind.
* Display and save a summary of valgrind errors and leaks.
* Enab
Corey Farrell has posted comments on this change.
Change subject: Memory Debugging Improvements
..
Patch Set 2:
(2 comments)
https://gerrit.asterisk.org/#/c/15/2/contrib/valgrind/text-summary.xsl
File contrib/valgrind/text-sum
Corey Farrell has uploaded a new patch set (#2).
Change subject: Memory Debugging Improvements
..
Memory Debugging Improvements
* Enable XML output from valgrind.
* Display and save a summary of valgrind errors and leaks.
* Enab
Corey Farrell has uploaded a new change for review.
https://gerrit.asterisk.org/15
Change subject: Memory Debugging Improvements
..
Memory Debugging Improvements
* Enable XML output from valgrind.
* Display and save a summary
Corey Farrell has uploaded a new change for review.
https://gerrit.asterisk.org/12
Change subject: Ignore JIRA uploads with license #2.
..
Ignore JIRA uploads with license #2.
License #2 is used for files that are not patches
Corey Farrell has uploaded a new change for review.
https://gerrit.asterisk.org/11
Change subject: Fixes related to testsuite GIT migration.
..
Fixes related to testsuite GIT migration.
* Add /logs to the root .gitignore.
* M
Hello Michael L. Young,
I'd like you to reexamine a change. Please visit
https://gerrit.asterisk.org/6
to look at the new patch set (#6).
Change subject: Update commit_msg.py output format.
..
Update commit_msg.py output
Corey Farrell has posted comments on this change.
Change subject: Add .gitignore files
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.asterisk.org/8
To unsubscribe, visit https://gerrit.asterisk.org/settings
G
Corey Farrell has posted comments on this change.
Change subject: Add a .gitreview file for the testsuite
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.asterisk.org/7
To unsubscribe, visit https://gerrit.aster
Corey Farrell has posted comments on this change.
Change subject: Add .gitignore files
..
Patch Set 1: Code-Review+1
(3 comments)
Looks pretty good to me. Up to you if you want to address the comments I've
made or just let i
Corey Farrell has uploaded a new patch set (#5).
Change subject: Update commit_msg.py output format.
..
Update commit_msg.py output format.
* Produce new syntax for linking to JIRA tickets.
* Retreive license number for patches
Corey Farrell has posted comments on this change.
Change subject: Update commit_msg.py output format.
..
Patch Set 5:
I actually had changed the wrong "Patch:\n" line. The first one is for the
interface when it asks which pat
Hello Michael L. Young,
I'd like you to reexamine a change. Please visit
https://gerrit.asterisk.org/6
to look at the new patch set (#5).
Change subject: Update commit_msg.py output format.
..
Update commit_msg.py output
Corey Farrell has posted comments on this change.
Change subject: Update commit_msg.py output format.
..
Patch Set 4:
Note this also makes a slight change to make the exception handling for license
retrieval easier to read.
-
Hello Michael L. Young,
I'd like you to reexamine a change. Please visit
https://gerrit.asterisk.org/6
to look at the new patch set (#4).
Change subject: Update commit_msg.py output format.
..
Update commit_msg.py output
Hello Michael L. Young,
I'd like you to reexamine a change. Please visit
https://gerrit.asterisk.org/6
to look at the new patch set (#3).
Change subject: Update commit_msg.py output format.
..
Update commit_msg.py output
Corey Farrell has uploaded a new patch set (#2).
Change subject: Update commit_msg.py output format.
..
Update commit_msg.py output format.
* Produce new syntax for linking to JIRA tickets.
* Retreive license number for patches
Corey Farrell has uploaded a new change for review.
https://gerrit.asterisk.org/6
Change subject: Update commit_msg.py output format.
..
Update commit_msg.py output format.
* Produce new syntax for linking to JIRA tickets.
*
Corey Farrell has posted comments on this change.
Change subject: Add a .gitignore
..
Patch Set 1: Code-Review-1
Missing all the ignores from subdirs:
addons/starpy
asttest/asttest
asttest/tools/mkstring
asttest/lib/lua/*_lua.h
Corey Farrell has posted comments on this change.
Change subject: .gitignore: Add a .gitignore file that mirrors the previous
svn:ignore
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.asterisk.org/2
To unsubsc
Corey Farrell has posted comments on this change.
Change subject: .gitignore: Add a .gitignore file that mirrors the previous
svn:ignore
..
Patch Set 1: Code-Review-1
Looks like this is missing ignores from subdirectories:
dig
55 matches
Mail list logo
