[asterisk-dev] [Code Review] 3200: pjsip_cli: Memory leak in ast_sip_cli_print_sorcery_objectset

2014-02-07 Thread George Joseph
2 calls before the error and success returns. Diffs - branches/12/res/res_pjsip/pjsip_cli.c 407750 Diff: https://reviewboard.asterisk.org/r/3200/diff/ Testing --- Thanks, George Joseph -- _ -- Bandwidth and

Re: [asterisk-dev] [Code Review] 3184: Create sorcery instance registry

2014-02-06 Thread George Joseph
y/ - open END/main/sorcery/ - open Time: <1ms Result: PASS START /main/sorcery/ - wizard_registration END/main/sorcery/ - wizard_registration Time: <1ms Result: PASS 43 Test(s) Executed 43 Passed 0 Failed Thanks, George Joseph -- _

Re: [asterisk-dev] [Code Review] 3184: Create sorcery instance registry

2014-02-06 Thread George Joseph
eve_multiple_all Time: <1ms Result: PASS [snip] START /main/sorcery/ - open END/main/sorcery/ - open Time: <1ms Result: PASS START /main/sorcery/ - wizard_registration END/main/sorcery/ - wizard_registration Time: <1ms Result: PASS 43 Test(s) Executed 43 Pass

Re: [asterisk-dev] [Code Review] 3184: Create sorcery instance registry

2014-02-06 Thread George Joseph
n/sorcery/ - open END/main/sorcery/ - open Time: <1ms Result: PASS START /main/sorcery/ - wizard_registration END/main/sorcery/ - wizard_registration Time: <1ms Result: PASS 43 Test(s) Executed 43 Pass

Re: [asterisk-dev] [Code Review] 3184: Create sorcery instance registry

2014-02-06 Thread George Joseph
ART /main/sorcery/ - open END/main/sorcery/ - open Time: <1ms Result: PASS START /main/sorcery/ - wizard_registration END/main/sorcery/ - wizard_registration Time: <1ms Result: PASS 43 Test(s) Executed 43 Pass

Re: [asterisk-dev] [Code Review] 3104: PJSIP CLI Part 2

2014-02-06 Thread George Joseph
/config_domain_aliases.c 406802 branches/12/res/res_pjsip/config_auth.c 406802 branches/12/include/asterisk/res_pjsip_cli.h 406802 branches/12/include/asterisk/res_pjsip.h 406802 Diff: https://reviewboard.asterisk.org/r/3104/diff/ Testing --- Thanks, George Joseph

Re: [asterisk-dev] [Code Review] 3184: Create sorcery instance registry

2014-02-06 Thread George Joseph
. > > Only the owner of the sorcery object should open/create it which will add > > it to the instances container. Everyone else will search the instances > > container for the object to get a reference. > > George Joseph wrote: > There's no concept of we

Re: [asterisk-dev] [Code Review] 3184: Create sorcery instance registry

2014-02-06 Thread George Joseph
iew10799 --- On Feb. 6, 2014, 1:07 p.m., George Joseph wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.or

Re: [asterisk-dev] [Code Review] 3184: Create sorcery instance registry

2014-02-06 Thread George Joseph
p] START /main/sorcery/ - open END/main/sorcery/ - open Time: <1ms Result: PASS START /main/sorcery/ - wizard_registration END/main/sorcery/ - wizard_registration Time: <1ms Result: PASS 43 Test(s) Executed 43 Pass

Re: [asterisk-dev] [Code Review] 3184: Create sorcery instance registry

2014-02-06 Thread George Joseph
tps://reviewboard.asterisk.org/r/3184/#review10802 ------- On Feb. 6, 2014, 12:55 p.m., George Joseph wrote: > > --- > This is an automatically generated e-mail.

Re: [asterisk-dev] [Code Review] 3184: Create sorcery instance registry

2014-02-06 Thread George Joseph
me: <1ms Result: PASS [snip] START /main/sorcery/ - open END/main/sorcery/ - open Time: <1ms Result: PASS START /main/sorcery/ - wizard_registration END/main/sorcery/ - wizard_registration Time: <1ms Result: PASS 43 Test(s) Executed 43 Pass

Re: [asterisk-dev] [Code Review] 3184: Create sorcery instance registry

2014-02-06 Thread George Joseph
astructure. Made sure that config_system was properly marked as 'not reloadable' and that it was maintaining it's original values when res_pjsip was reloaded. Thanks, George Joseph -- _ -- Bandwidth and Colocation P

Re: [asterisk-dev] [Code Review] 3143: pjsip_configuration: in ast_sip_auth_array_init, change assert(auths->names == NULL) to ast_sip_auth_array_destroy(auths)

2014-02-06 Thread George Joseph
names and if not null, calls ast_sip_auth_array_destroy before initializing the array with the new values. Diffs - branches/12/res/res_pjsip/pjsip_configuration.c 405922 Diff: https://reviewboard.asterisk.org/r/3143/diff/ Testing --- Thanks, G

Re: [asterisk-dev] [Code Review] 3184: Create sorcery instance registry

2014-02-05 Thread George Joseph
it's original values when res_pjsip was reloaded. Thanks, George Joseph -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

[asterisk-dev] [Code Review] 3184: Create sorcery instance registry

2014-02-05 Thread George Joseph
it's original values when res_pjsip was reloaded. Thanks, George Joseph -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http:/

Re: [asterisk-dev] [Code Review] 3136: cli: pjsip show endpoint shows allow/disallow codecs the same

2014-02-03 Thread George Joseph
. - George Joseph On Feb. 3, 2014, 1:18 p.m., Scott Griepentrog wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asteris

[asterisk-dev] Proposal for PJSIP TOS/COS and DSCP

2014-02-03 Thread George Joseph
As I was playing around with TOS/COS in pjsip last week I noticed some inconsistencies that I'd like to correct... There's a 'tos' parameter on the transport object but not only does it actually set DSCP instead of TOS, it sets it in pjproject only and therefore for signalling only. There are tos

Re: [asterisk-dev] [Code Review] 3104: PJSIP CLI Part 2

2014-01-28 Thread George Joseph
branches/12/res/res_pjsip/config_domain_aliases.c 406802 branches/12/res/res_pjsip/config_auth.c 406802 branches/12/include/asterisk/res_pjsip_cli.h 406802 branches/12/include/asterisk/res_pjsip.h 406802 Diff: https://reviewboard.asterisk.org/r/3104/diff/ Testing --- Thanks, George

Re: [asterisk-dev] [Code Review] 3136: cli: pjsip show endpoint shows allow/disallow codecs the same

2014-01-21 Thread George Joseph
> On Jan. 17, 2014, 4:46 p.m., George Joseph wrote: > > Not sure this is a good idea. First, I wouldn't hardcode a test for > > "disallow" in the generic ast_sip_cli_print_sorcery_objset and given the > > meaning of "disallow", the "!"

[asterisk-dev] [Code Review] 3143: pjsip_configuration: in ast_sip_auth_array_init, change assert(auths->names == NULL) to ast_sip_auth_array_destroy(auths)

2014-01-20 Thread George Joseph
e new values. Diffs - branches/12/res/res_pjsip/pjsip_configuration.c 405922 Diff: https://reviewboard.asterisk.org/r/3143/diff/ Testing --- Thanks, George Joseph -- _ -- Bandwidth and Colocation Provided by ht

Re: [asterisk-dev] [Code Review] 3136: cli: pjsip show endpoint shows allow/disallow codecs the same

2014-01-20 Thread George Joseph
> On Jan. 17, 2014, 4:46 p.m., George Joseph wrote: > > Not sure this is a good idea. First, I wouldn't hardcode a test for > > "disallow" in the generic ast_sip_cli_print_sorcery_objset and given the > > meaning of "disallow", the "!"

Re: [asterisk-dev] [Code Review] 3136: cli: pjsip show endpoint shows allow/disallow codecs the same

2014-01-20 Thread George Joseph
> On Jan. 17, 2014, 4:46 p.m., George Joseph wrote: > > Not sure this is a good idea. First, I wouldn't hardcode a test for > > "disallow" in the generic ast_sip_cli_print_sorcery_objset and given the > > meaning of "disallow", the "!"

Re: [asterisk-dev] [Code Review] 3136: cli: pjsip show endpoint shows allow/disallow codecs the same

2014-01-17 Thread George Joseph
ode a test for "disallow" in the generic ast_sip_cli_print_sorcery_objset and given the meaning of "disallow", the "!" doesn't really make sense. It actually negates the disallow. :) - George Joseph On Jan. 17,

Re: [asterisk-dev] [Code Review] 3104: PJSIP CLI Part 2

2014-01-16 Thread George Joseph
/config_domain_aliases.c 405643 branches/12/res/res_pjsip/config_auth.c 405643 branches/12/include/asterisk/res_pjsip_cli.h 405643 branches/12/include/asterisk/res_pjsip.h 405643 Diff: https://reviewboard.asterisk.org/r/3104/diff/ Testing --- Thanks, George Joseph

Re: [asterisk-dev] [Code Review] 3104: PJSIP CLI Part 2

2014-01-16 Thread George Joseph
; > > > > Same comments as with previous s_containers. There's now a failure check and possible early exit later on. - George --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.a

Re: [asterisk-dev] [Code Review] 3104: PJSIP CLI Part 2

2014-01-16 Thread George Joseph
wboard.asterisk.org/r/3104/#review10597 ------- On Jan. 6, 2014, 2:49 p.m., George Joseph wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: [asterisk-dev] [Code Review] 3104: PJSIP CLI Part 2

2014-01-16 Thread George Joseph
why ipv6 wasn't working I was tinkering here. It is a little easier to read now. - George --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3104/#review10595 ---

Re: [asterisk-dev] [Code Review] 3043: pjsip: CLI commands

2014-01-16 Thread George Joseph
sting --- I've gone through all the combinations of actions and objects and made sure at least the correct objects are returned, there are no segfaults, errors, etc. I *think* the formatting is correct but I'll need some feedback. Thanks,

Re: [asterisk-dev] [Code Review] 3075: Add support for Lua 5.2

2014-01-08 Thread George Joseph
Fedora 20 respectively. Thanks, George Joseph -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo

[asterisk-dev] [Code Review] 3104: PJSIP CLI Part 2

2014-01-06 Thread George Joseph
branches/12/res/res_pjsip/config_auth.c 405000 branches/12/include/asterisk/res_pjsip_cli.h 405000 branches/12/include/asterisk/res_pjsip.h 405000 Diff: https://reviewboard.asterisk.org/r/3104/diff/ Testing --- Thanks, George Joseph

Re: [asterisk-dev] [Code Review] 3062: a systemd service

2014-01-01 Thread George Joseph
On Wed, Jan 1, 2014 at 4:31 PM, Oron Peled wrote: > > On Wednesday 01 January 2014 10:23:01 Tzafrir Cohen wrote: > > I looked into running Asterisk as non-root. But I can't find a way > > to get systemd to generate /var/run/asterisk as a writable directory to > > the service. > > I think systemd

Re: [asterisk-dev] [Code Review] 3062: a systemd service

2014-01-01 Thread George Joseph
> On Jan. 1, 2014, 9:43 a.m., George Joseph wrote: > > One other thing to consider... Unless /etc/asterisk is the working directory (which it shouldn't be), the LUA_PATH is going to need to be set or asterisk won't resolve lua script locations correctly. I

Re: [asterisk-dev] [Code Review] 3062: a systemd service

2014-01-01 Thread George Joseph
use the following which mimic some of the safe_asterisk settings... Nice=0 UMask=0002 LimitCORE=infinity LimitNOFILE=4096 Restart=always RestartSec=4 - George Joseph On Dec. 24, 2013, 9:49 a.m., Tz

Re: [asterisk-dev] Additional release checksums?

2013-12-22 Thread George Joseph
ngth. > > > On 22 December 2013 16:11, George Joseph wrote: > >> The *sum tools will test all lines in a checksum file and will return 0 >> if any match or 1 if none match. >> >> md5sum --quiet -c xxx.asc < xxx.tar.gz >> sha1sum --quiet -c xxx.asc <

Re: [asterisk-dev] Additional release checksums?

2013-12-22 Thread George Joseph
The *sum tools will test all lines in a checksum file and will return 0 if any match or 1 if none match. md5sum --quiet -c xxx.asc < xxx.tar.gz sha1sum --quiet -c xxx.asc < xxx.tar.gz sha256sum --quiet -c xxx.asc < xxx.tar.gz where xxx.asc is ecb9ac329728d0b2b947d4b2fba85b53b00dbf81737fc6db7e5e34

Re: [asterisk-dev] [Code Review] 3043: pjsip: CLI commands

2013-12-20 Thread George Joseph
g outside the scope of the cli. - George --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3043/#review10482 --- On Dec. 19, 20

Re: [asterisk-dev] [Code Review] 3043: pjsip: CLI commands

2013-12-19 Thread George Joseph
t but I'll need some feedback. Thanks, George Joseph -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/m

Re: [asterisk-dev] [Code Review] 3043: pjsip: CLI commands

2013-12-19 Thread George Joseph
7;ve gone through all the combinations of actions and objects and made sure at least the correct objects are returned, there are no segfaults, errors, etc. I *think* the formatting is correct but I'll need some feed

Re: [asterisk-dev] [Code Review] 3074: Fix old regression where config.c unescapes semicolons in embedded values in extensions.conf.

2013-12-17 Thread George Joseph
ecial > > meaning in config files. > > > > I'm not sure we want to go crazy here, but ideally we would have a way to > > re-write out a '\' when we write out the config. > > George Joseph wrote: > Hmmm. So the client would write a correctly e

Re: [asterisk-dev] [Code Review] 3074: Fix old regression where config.c unescapes semicolons in embedded values in extensions.conf.

2013-12-17 Thread George Joseph
rg/r/3074/diff/ Testing --- This patch has been in my production systems since July 2012. Thanks, George Joseph -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list

[asterisk-dev] [Code Review] 3075: Add support for Lua 5.2

2013-12-17 Thread George Joseph
branches/1.8/configure 404041 Diff: https://reviewboard.asterisk.org/r/3075/diff/ Testing --- Tested configure, compile and basic lua run time with both lua 5.1 and lua 5.2 on Fedora 19 and Fedora 20 respectively. Thanks, George Joseph

Re: [asterisk-dev] [Code Review] 3074: Fix old regression where config.c unescapes semicolons in embedded values in extensions.conf.

2013-12-17 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3074/#review10429 --- On Dec. 16, 2013, 6:18 p.m., George Joseph w

[asterisk-dev] [Code Review] 3074: Fix old regression where config.c unescapes semicolons in embedded values in extensions.conf.

2013-12-16 Thread George Joseph
nce July 2012. Thanks, George Joseph -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] PJSIP CLI and AMI organization thoughts

2013-12-09 Thread George Joseph
On Mon, Dec 9, 2013 at 10:15 AM, Kevin Harwell wrote: > On Mon, 2013-12-09 at 09:17 -0700, George Joseph wrote: > > > > If Asterisk were completely OO we could create object factories, > > interfaces and implementation classes that hide all of that. > > Unfo

Re: [asterisk-dev] PJSIP CLI and AMI organization thoughts

2013-12-09 Thread George Joseph
On Mon, Dec 9, 2013 at 8:49 AM, Kevin Harwell wrote: > On Sat, 2013-12-07 at 09:20 -0700, George Joseph wrote: > > > > > > It would be nice if endpoint stored all its object relationships the > > same way but it doesn't. It stores its related aors as a comma >

Re: [asterisk-dev] PJSIP CLI and AMI organization thoughts

2013-12-07 Thread George Joseph
On Fri, Dec 6, 2013 at 11:53 PM, Kevin Harwell wrote: > On Fri, Dec 6, 2013 at 11:27 PM, George Joseph < > george.jos...@fairview5.com> wrote: > >> >> On Fri, Dec 6, 2013 at 10:09 PM, Kevin Harwell wrote: >> >>> On Fri, Dec 6, 2013 at 7:09 PM, Georg

Re: [asterisk-dev] PJSIP CLI and AMI organization thoughts

2013-12-06 Thread George Joseph
On Fri, Dec 6, 2013 at 10:09 PM, Kevin Harwell wrote: > On Fri, Dec 6, 2013 at 7:09 PM, George Joseph > wrote: > >> On Fri, Dec 6, 2013 at 4:52 PM, Kevin Harwell wrote: >> >>> On Fri, 2013-12-06 at 14:21 -0700, George Joseph wrote: >>> >>> >

Re: [asterisk-dev] PJSIP CLI and AMI organization thoughts

2013-12-06 Thread George Joseph
On Fri, Dec 6, 2013 at 4:52 PM, Kevin Harwell wrote: > On Fri, 2013-12-06 at 14:21 -0700, George Joseph wrote: > > This continues a conversation kharwell, mjordan and I were having on > > irc this morning concerning the implementation of the cli output > > formatting. >

[asterisk-dev] PJSIP CLI and AMI organization thoughts

2013-12-06 Thread George Joseph
This continues a conversation kharwell, mjordan and I were having on irc this morning concerning the implementation of the cli output formatting. Basically, I'm thinking that while we should absolutely re-use the underlying plumbing ( we don't need 2 versions of ast_sip_for_each_contact, for insta

Re: [asterisk-dev] [Code Review] 3043: pjsip: CLI commands

2013-12-05 Thread George Joseph
fig.h 403390 Diff: https://reviewboard.asterisk.org/r/3043/diff/ Testing --- Thanks, George Joseph -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRI

Re: [asterisk-dev] [Code Review] 3043: pjsip: CLI commands

2013-12-05 Thread George Joseph
iff: https://reviewboard.asterisk.org/r/3043/diff/ Testing --- Thanks, George Joseph -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visi

Re: [asterisk-dev] [Code Review] 3043: pjsip: CLI commands

2013-12-04 Thread George Joseph
03390 Diff: https://reviewboard.asterisk.org/r/3043/diff/ Testing --- Thanks, George Joseph -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update op

[asterisk-dev] [Code Review] 3043: pjsip: CLI commands

2013-12-04 Thread George Joseph
https://reviewboard.asterisk.org/r/3043/diff/ Testing --- Thanks, George Joseph -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit:

Re: [asterisk-dev] [Code Review] 2959: pjsip: AMI commands and events

2013-11-21 Thread George Joseph
On Thu, Nov 21, 2013 at 7:25 AM, Joshua Colp wrote: > George Joseph wrote: > >> Just FYI... I've got a whole bunch of pjsip cli stuff waiting on this >> patch to be committed. Any chance of this happening this week? >> > > It'll get reviewed today and

<    4   5   6   7   8   9