Re: [asterisk-dev] [Code Review] 3356: Logic error in callerid checksum processing

2014-03-17 Thread rmeyerriecks
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3356/ --- (Updated March 17, 2014, 4:14 p.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 3356: Logic error in callerid checksum processing

2014-03-17 Thread rmeyerriecks
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3356/ --- (Updated March 17, 2014, 8:12 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3356: Logic error in callerid checksum processing

2014-03-14 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3356/#review11216 --- Ship it! Ship It! - rmudgett On March 14, 2014, 3:47 p.m.,

Re: [asterisk-dev] [Code Review] 3356: Logic error in callerid checksum processing

2014-03-14 Thread rmeyerriecks
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3356/ --- (Updated March 14, 2014, 8:47 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3356: Logic error in callerid checksum processing

2014-03-14 Thread Scott Griepentrog
> On March 14, 2014, 1:18 p.m., rmudgett wrote: > > /branches/1.8/main/callerid.c, line 624 > > > > > > I would be surprised if this worked for calls that the checksum was not > > zero. > > > > I think the

Re: [asterisk-dev] [Code Review] 3356: Logic error in callerid checksum processing

2014-03-14 Thread rmeyerriecks
> On March 14, 2014, 6:18 p.m., rmudgett wrote: > > /branches/1.8/main/callerid.c, line 624 > > > > > > I would be surprised if this worked for calls that the checksum was not > > zero. > > > > I think the

Re: [asterisk-dev] [Code Review] 3356: Logic error in callerid checksum processing

2014-03-14 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3356/#review11208 --- /branches/1.8/main/callerid.c

Re: [asterisk-dev] [Code Review] 3356: Logic error in callerid checksum processing

2014-03-14 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3356/#review11206 --- Ship it! Ship It! - Scott Griepentrog On March 14, 2014, 12

[asterisk-dev] [Code Review] 3356: Logic error in callerid checksum processing

2014-03-14 Thread rmeyerriecks
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3356/ --- Review request for Asterisk Developers. Bugs: asterisk-23488 https://i