Re: [asterisk-dev] [Code Review] 4090: testsuite: add basic valgrind support

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4090/#review13810 --- Got a small problem with this... When runtests.py checks to s

Re: [asterisk-dev] [Code Review] 4090: testsuite: add basic valgrind support

> On Nov. 18, 2014, 8:18 a.m., Corey Farrell wrote: > > Please discard my findings, they are minor. I'd like to see this committed > > ASAP so further improvements can be made against it. > > Scott Griepentrog wrote: > I like your idea of adding an option to pass valgrind options, but it

Re: [asterisk-dev] [Code Review] 4090: testsuite: add basic valgrind support

> On Nov. 18, 2014, 9:18 a.m., Corey Farrell wrote: > > Please discard my findings, they are minor. I'd like to see this committed > > ASAP so further improvements can be made against it. > > Scott Griepentrog wrote: > I like your idea of adding an option to pass valgrind options, but it

Re: [asterisk-dev] [Code Review] 4090: testsuite: add basic valgrind support

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4090/ --- (Updated Nov. 18, 2014, 9:49 a.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 4090: testsuite: add basic valgrind support

> On Oct. 16, 2014, 5:58 p.m., Kevin Harwell wrote: > > /asterisk/trunk/runtests.py, lines 461-462 > > > > > > Not a huge fan of using an environment variable for this (could > > probably be convinced otherwise tho

Re: [asterisk-dev] [Code Review] 4090: testsuite: add basic valgrind support

> On Nov. 18, 2014, 8:18 a.m., Corey Farrell wrote: > > Please discard my findings, they are minor. I'd like to see this committed > > ASAP so further improvements can be made against it. I like your idea of adding an option to pass valgrind options, but it needs to first be set to write logs

Re: [asterisk-dev] [Code Review] 4090: testsuite: add basic valgrind support

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4090/#review13791 --- Ship it! Please discard my findings, they are minor. I'd like

Re: [asterisk-dev] [Code Review] 4090: testsuite: add basic valgrind support

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4090/#review13573 --- /asterisk/trunk/lib/python/asterisk/asterisk.py

Re: [asterisk-dev] [Code Review] 4090: testsuite: add basic valgrind support

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4090/#review13561 --- /asterisk/trunk/lib/python/asterisk/asterisk.py

[asterisk-dev] [Code Review] 4090: testsuite: add basic valgrind support

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4090/ --- Review request for Asterisk Developers. Repository: testsuite Descriptio