Re: [RFC] treewide: cleanup unreachable breaks

On Mon, 2020-10-19 at 12:42 -0700, Nick Desaulniers wrote: > On Sat, Oct 17, 2020 at 10:43 PM Greg KH wrote: > > On Sat, Oct 17, 2020 at 09:09:28AM -0700, t...@redhat.com wrote: > > > From: Tom Rix > > > > > > This is a upcoming change to clean up a new warning treewide. > > > I am wondering if

Re: [PATCH] wireless: remove unneeded break

On Mon, 2020-10-19 at 10:54 -0500, Gustavo A. R. Silva wrote: > On 10/19/20 10:21, Joe Perches wrote: > > On Mon, 2020-10-19 at 17:14 +0200, Christian Lamparter wrote: > > > On 19/10/2020 17:05, t...@redhat.com wrote: > > > > From: Tom Rix > > > > >

Re: [PATCH] wireless: remove unneeded break

On Mon, 2020-10-19 at 17:14 +0200, Christian Lamparter wrote: > On 19/10/2020 17:05, t...@redhat.com wrote: > > From: Tom Rix > > > > A break is not needed if it is preceded by a return or goto > > > > Signed-off-by: Tom Rix > > diff --git a/drivers/net/wireless/intersil/p54/eeprom.c > >

Re: [Ocfs2-devel] [RFC] treewide: cleanup unreachable breaks

On Sun, 2020-10-18 at 19:59 +0100, Matthew Wilcox wrote: > On Sat, Oct 17, 2020 at 09:09:28AM -0700, t...@redhat.com wrote: > > clang has a number of useful, new warnings see > >

Re: [Cocci] [RFC] treewide: cleanup unreachable breaks

On Sat, 2020-10-17 at 20:21 +0200, Julia Lawall wrote: > On Sat, 17 Oct 2020, Joe Perches wrote: > > On Sat, 2020-10-17 at 09:09 -0700, t...@redhat.com wrote: > > > From: Tom Rix > > > > > > This is a upcoming change to clean up a new warning treewide. >

Re: [RFC] treewide: cleanup unreachable breaks

On Sat, 2020-10-17 at 09:09 -0700, t...@redhat.com wrote: > From: Tom Rix > > This is a upcoming change to clean up a new warning treewide. > I am wondering if the change could be one mega patch (see below) or > normal patch per file about 100 patches or somewhere half way by collecting > early

[PATCH -next 000/491] treewide: use fallthrough;

ough.commit_msg") or die "$0: can't create temporary file: $!\n"; print $fh <https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git@perches.com/ EOF ; close $fh; `git commit -s -a -F cvt_fallthrough.commit_msg`; } Joe Perches (491): MELLANOX ETHERNET INNOV

Re: [PATCH v4 5/7] lib/hexdump.c: Allow multiple groups to be separated by lines '|'

On Tue, 2019-06-25 at 13:17 +1000, Alastair D'Silva wrote: > From: Alastair D'Silva > > With the wider display format, it can become hard to identify how many > bytes into the line you are looking at. > > The patch adds new flags to hex_dump_to_buffer() and print_hex_dump() to > print vertical

Re: [PATCH v4 4/7] lib/hexdump.c: Replace ascii bool in hex_dump_to_buffer with flags

On Tue, 2019-06-25 at 15:06 +1000, Alastair D'Silva wrote: > The change actions Jani's suggestion: > https://lkml.org/lkml/2019/6/20/343 I suggest not changing any of the existing uses of hex_dump_to_buffer and only use hex_dump_to_buffer_ext when necessary for your extended use cases.

Re: [PATCH v4 4/7] lib/hexdump.c: Replace ascii bool in hex_dump_to_buffer with flags

On Tue, 2019-06-25 at 15:06 +1000, Alastair D'Silva wrote: > On Mon, 2019-06-24 at 22:01 -0700, Joe Perches wrote: > > On Tue, 2019-06-25 at 13:17 +1000, Alastair D'Silva wrote: > > > From: Alastair D'Silva > > > > > > In order to support additional

Re: [PATCH v4 0/7] Hexdump Enhancements

On Tue, 2019-06-25 at 13:17 +1000, Alastair D'Silva wrote: > From: Alastair D'Silva > > Apologies for the large CC list, it's a heads up for those responsible > for subsystems where a prototype change in generic code causes a change > in those subsystems. [] > The default behaviour of hexdump is

Re: [PATCH v4 4/7] lib/hexdump.c: Replace ascii bool in hex_dump_to_buffer with flags

On Tue, 2019-06-25 at 13:17 +1000, Alastair D'Silva wrote: > From: Alastair D'Silva > > In order to support additional features, rename hex_dump_to_buffer to > hex_dump_to_buffer_ext, and replace the ascii bool parameter with flags. [] > diff --git a/drivers/gpu/drm/i915/intel_engine_cs.c >

Re: [PATCH v3 0/7] Hexdump Enhancements

On Thu, 2019-06-20 at 11:14 +1000, Alastair D'Silva wrote: > On Wed, 2019-06-19 at 17:35 -0700, Joe Perches wrote: > > On Thu, 2019-06-20 at 09:15 +1000, Alastair D'Silva wrote: > > > On Wed, 2019-06-19 at 09:31 -0700, Joe Perches wrote: > > > > On Mon, 2019-06-17 at

Re: [PATCH v3 0/7] Hexdump Enhancements

On Thu, 2019-06-20 at 09:15 +1000, Alastair D'Silva wrote: > On Wed, 2019-06-19 at 09:31 -0700, Joe Perches wrote: > > On Mon, 2019-06-17 at 12:04 +1000, Alastair D'Silva wrote: > > > From: Alastair D'Silva > > > > > > Apologies for the large CC list, it's a

Re: [PATCH v2] mac80211: remove warning message

On Tue, 2019-05-14 at 11:12 +0200, Johannes Berg wrote: > On Tue, 2019-05-14 at 17:10 +0800, Yibo Zhao wrote: > > On 2019-05-14 17:05, Johannes Berg wrote: > > > On Tue, 2019-05-14 at 17:01 +0800, Yibo Zhao wrote: > > > > In multiple SSID cases, it takes time to prepare every AP interface > > > >

Re: [PATCH] ath10k_htt_rx_amsdu_allowed(): use ath10k_dbg()

On Wed, 2017-07-19 at 17:37 +0200, Gabriel C wrote: > Each time we get disconencted from AP we get flooded with messages > like: > > ... > ath10k_pci :03:00.0: no channel configured; ignoring frame(s)! > > ath10k_warn: 155 callbacks suppressed

Re: [PATCH v2] ath10k: Remove return statement from a void function

On Wed, 2017-02-22 at 20:54 +0100, Arend Van Spriel wrote: > > On 21-2-2017 11:28, Marcin Rokicki wrote: > > The empty 'return;' statement in a void function should be > > used to return from somewhere else than the end. > > > > Signed-off-by: Marcin Rokicki > > --- >

Re: [PATCH] ath10k: Modify macros to fix style issues

(fyi Marcin, the reason this isn't getting on the list is because your 3 tries have all included text and html) On Wed, 2017-02-22 at 14:31 +0100, Marcin Rokicki wrote: > > > > Here is an alternate style used a few times in the kernel > > > > Maybe it'd be nicer to change the macros to

Re: [PATCH] ath10k: Modify macros to fix style issues

On Wed, 2017-02-22 at 09:15 +0100, Marcin Rokicki wrote: > Both macros are used internally to convert incomming parameters > to strings in a switch case statement. > > Current implementation gives following output from checkpatch.pl: > - ERROR: Macros with complex values should be enclosed in

Re: [PATCH 1/3] ath10k: remove ath10k_vif_to_arvif()

On Thu, 2017-02-09 at 23:14 -0800, Adrian Chadd wrote: > If there > were accessors for the skb data / len fields (like we do for mbufs) > then porting the code would've involved about 5,000 less changed > lines. What generic mechanisms would you suggest to make porting easier between bsd and

Re: [PATCH 2/3] ath10k: use dma_zalloc_coherent()

On Tue, 2017-01-24 at 05:18 +, Valo, Kalle wrote: > Joe Perches <j...@perches.com> writes: > > > On Mon, 2017-01-23 at 15:04 +, Srinivas Kandagatla wrote: > > > use dma_zalloc_coherent() instead of dma_alloc_coherent and memset(). > > > > [] >

Re: [PATCH 2/3] ath10k: use dma_zalloc_coherent()

On Mon, 2017-01-23 at 15:04 +, Srinivas Kandagatla wrote: > use dma_zalloc_coherent() instead of dma_alloc_coherent and memset(). [] > diff --git a/drivers/net/wireless/ath/ath10k/pci.c > b/drivers/net/wireless/ath/ath10k/pci.c [] > @@ -896,7 +896,7 @@ static int

[PATCH] ath10k: Spelling and miscellaneous neatening

Correct some trivial comment typos. Remove unnecessary parentheses in a long line. Convert a return; before the end of a void function definition to just ; Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/wireless/ath/ath10k/ce.c| 2 +- drivers/net/wireless/ath/

Re: [PATCH] ath10k: hide kernel addresses from logs using %pK format specifier

On Thu, 2016-08-04 at 19:21 +0530, c_mke...@qti.qualcomm.com wrote: > From: Maharaja Kennadyrajan > > With the %pK format specifier we hide the kernel addresses > with the help of kptr_restrict sysctl. > In this patch, %p is changed to %pK in the driver code. > > The

Re: [PATCH v2 1/5] ath10k: fix checkpatch warnings related to spaces

On Wed, 2016-04-13 at 14:13 +0300, Kalle Valo wrote: > Fix checkpatch warnings about use of spaces with operators: > spaces preferred around that '*' (ctx:VxV) > This has been recently added to checkpatch. Trivia: That's not a particularly recent change. > diff --git

Re: [PATCH] ath10k: Fix return value for btcoex and peer stats debugfs

On Tue, 2016-04-05 at 20:58 +0530, Mohammed Shafi Shajakhan wrote: > From: Mohammed Shafi Shajakhan > > Return value is incorrect for btcoex and peer stats debugfs > 'write' entries if the user provides a value that matches with > the already available debugfs entry,

[PATCH] ath: change logging functions to return void

The return values are not used by callers of these functions so change the functions to return void. Other miscellanea: o add __printf verification to wil6210 logging functions No format/argument mismatches found Signed-off-by: Joe Perches j...@perches.com --- This change is associated

Re: [PATCH] ath10k: fix wmi service bitmap debug

On Sat, 2014-08-02 at 09:39 +0300, Kalle Valo wrote: Michal Kazior michal.kaz...@tieto.com writes: The 10.x and main firmware branches have conflicting WMI service bitmap definitions. This also fixes WMI services parsing on big-endian hosts and changes debugfs output to be more human