Re: [ath5k-devel] [PATCH 00/62] drivers/net: Use static const

2010-11-23 Thread David Miller
From: Joe Perches j...@perches.com Date: Mon, 22 Nov 2010 14:40:05 -0800 I'll see who picks up or acks what and send a pull request to you for the remainder of these patches mid December or so. Thanks. Do you want micro patches or a single patch? You can group them by directory or similar

[ath5k-devel] [PATCH 03/30] ath5k: Stop PCU on reset

2010-11-23 Thread Nick Kossifidis
* Stop PCU receive logic (DRU) durring reset We need to be sure pcu is not active when trying to stop rx dma right now this is done on ath5k_reset (base.c) but later we are going to clean it up. Signed-off-by: Nick Kossifidis mickfl...@gmail.com --- drivers/net/wireless/ath/ath5k/reset.c |

[ath5k-devel] [PATCH 02/30] ath5k: Add new function to stop rx/tx DMA

2010-11-23 Thread Nick Kossifidis
* Add a new function to stop rx/tx dma and use in when reset starts Signed-off-by: Nick Kossifidis mickfl...@gmail.com --- drivers/net/wireless/ath/ath5k/ath5k.h |3 +- drivers/net/wireless/ath/ath5k/dma.c | 52 ++-- drivers/net/wireless/ath/ath5k/reset.c |

[ath5k-devel] [PATCH 05/30] ath5k: Debug DMA timeouts

2010-11-23 Thread Nick Kossifidis
* Increase timeouts on ath5k_hw_stop_tx_dma and also wait for tx queue to stop before checking for pending frames * Add a new debug level to debug dma start/stop Signed-off-by: Nick Kossifidis mickfl...@gmail.com --- drivers/net/wireless/ath/ath5k/debug.c |1 +

[ath5k-devel] [PATCH 06/30] ath5k: Use DCU early termination correctly

2010-11-23 Thread Nick Kossifidis
* DCU early termination should be used to quickly flush QCU according to docs so don't enable it for all queues, enable it only when stopping each queue and disable it when we are done. Signed-off-by: Nick Kossifidis mickfl...@gmail.com --- drivers/net/wireless/ath/ath5k/dma.c | 14

[ath5k-devel] [PATCH 04/30] ath5k: Use new dma_stop function on base.c

2010-11-23 Thread Nick Kossifidis
* Since we stop rx/tx dma and pcu durring reset there is no need to call ath5k_hw_stop_rx/tx_dma before, also there is no need to call them durring stop_locked since we can use ath5k_hw_dma_stop for both. Signed-off-by: Nick Kossifidis mickfl...@gmail.com ---

[ath5k-devel] [PATCH 07/30] ath5k: Check RXE when setting RXDP

2010-11-23 Thread Nick Kossifidis
* Make sure we are not trying to set RXDP while RX is active, for now ignore the return value. Signed-off-by: Nick Kossifidis mickfl...@gmail.com --- drivers/net/wireless/ath/ath5k/ath5k.h |2 +- drivers/net/wireless/ath/ath5k/dma.c | 11 +-- 2 files changed, 10 insertions(+),

[ath5k-devel] [PATCH 08/30] ath5k: Use new function to stop beacon queue

2010-11-23 Thread Nick Kossifidis
* Since we only use ath5k_hw_stop_tx_dma to stop the beacon queue, introduce a new function ath5k_hw_stop_beacon_queue so that we can use that instead and have better control. In the future we can add more beacon queue specific stuff there (maybe tweak beacon timers or something), for now

[ath5k-devel] [PATCH 11/30] ath5k: Small cleanup on tweak_initvals

2010-11-23 Thread Nick Kossifidis
* Now that we properly set rx/tx latencies for AR5311 remove that old buggy part of code left inside ath5k_hw_tweak_initval_settings that was never executed (you can't have an RF5112 radio on a mac older than AR5212). Also use a magic value for 5311 PHY_SCAL value. Signed-off-by: Nick

[ath5k-devel] [PATCH 13/30] ath5k: Move tx retries setting outside reset_tx_queue

2010-11-23 Thread Nick Kossifidis
* Move setting of tx retry limits on a separate function (we 'll clean up this AR5210 mess later) Signed-off-by: Nick Kossifidis mickfl...@gmail.com --- drivers/net/wireless/ath/ath5k/qcu.c | 92 - 1 files changed, 56 insertions(+), 36 deletions(-) diff

[ath5k-devel] [PATCH 15/30] ath5k: Extend rate_duration

2010-11-23 Thread Nick Kossifidis
* Extend ieee80211_generic_frame_duration to support the various bwmodes. * Better document what's going on with ack bitrates and update write_rate_duration to support the standard ack bitrates (when we don't set the high bit). * Get rid of set_ack_bitrate_high and introduce a flag on

[ath5k-devel] [PATCH 16/30] ath5k: Set all IFS intervals, not just slot time

2010-11-23 Thread Nick Kossifidis
* Replace set_slot_time with set_ifs_intervals that also sets the various inter-frame space intervals based on current bwmode. * Clean up AR5210 mess from reset_tx_queue, AR5210 only has one data queue and we set IFS intervals for that queue on set_ifs_intervals so there is nothing left to

Re: [ath5k-devel] [PATCH 12/30] ath5k: Increase PHY settling parameters for turo mode

2010-11-23 Thread Luis R. Rodriguez
On Tue, Nov 23, 2010 at 11:04:43AM -0800, Nick Kossifidis wrote: Are you willing to deal with *all* bug reports for this? Luis ___ ath5k-devel mailing list ath5k-devel@lists.ath5k.org https://lists.ath5k.org/mailman/listinfo/ath5k-devel

[ath5k-devel] [PATCH 18/30] ath5k: Always set IFS intervals on reset

2010-11-23 Thread Nick Kossifidis
* Make sure we always set IFS timings even if no coverage class is set. If we don't we'll miss the needed changes for different bwmodes. Signed-off-by: Nick Kossifidis mickfl...@gmail.com --- drivers/net/wireless/ath/ath5k/ath5k.h |1 + drivers/net/wireless/ath/ath5k/pcu.c |2 +-

[ath5k-devel] [PATCH 19/30] ath5k: Tweak power detector delays on RF5111/RF5112

2010-11-23 Thread Nick Kossifidis
* Tweak power detector delays on AR5111/AR5112 when using half/quarter modes. Signed-off-by: Nick Kossifidis mickfl...@gmail.com --- drivers/net/wireless/ath/ath5k/phy.c | 32 ++-- 1 files changed, 30 insertions(+), 2 deletions(-) diff --git

[ath5k-devel] [PATCH 26/30] ath5k: Skip tx power setting on AR5210 for now

2010-11-23 Thread Nick Kossifidis
* Don't return -EINVAL when trying to set tx power on RF5110 because AR5210 reset will fail. We need to add support for RF5110 and AR5210 eeprom in the future but for now just skip it. Signed-off-by: Nick Kossifidis mickfl...@gmail.com --- drivers/net/wireless/ath/ath5k/phy.c |3 +++ 1

[ath5k-devel] [PATCH 28/30] ath5k: Cleanup turbo channel flags

2010-11-23 Thread Nick Kossifidis
* Clean up CHANNEL_T(URBO), use AR5K_BWMODE_40MHZ instead Signed-off-by: Nick Kossifidis mickfl...@gmail.com --- drivers/net/wireless/ath/ath5k/ath5k.h |9 + drivers/net/wireless/ath/ath5k/base.c |5 - drivers/net/wireless/ath/ath5k/phy.c | 22 --

[ath5k-devel] [PATCH 30/30] ath5k: Set turbo bit on rf bank 2

2010-11-23 Thread Nick Kossifidis
* A diff between rfbuffer settings of turbo and non-turbo modes indicates there is a bit on bank 2 related to turbo operation (it's set on turbo modes). This bit is present on all radios except RF5413 that seems to have a completely different bank 2. Also since 2317 has the same rf-registers

Re: [ath5k-devel] [PATCH 12/30] ath5k: Increase PHY settling parameters for turo mode

2010-11-23 Thread Nick Kossifidis
2010/11/23 Luis R. Rodriguez lrodrig...@atheros.com: On Tue, Nov 23, 2010 at 11:04:43AM -0800, Nick Kossifidis wrote: Are you willing to deal with *all* bug reports for this?  Luis I don't enable 5/10/40MHz operation anywhere for now, it's just there for testing/debug. I tested it and it

Re: [ath5k-devel] [PATCH 14/30] ath5k: Extend get_default_sifs/slot_time

2010-11-23 Thread Jonathan Guerin
On Wed, Nov 24, 2010 at 5:09 AM, Nick Kossifidis mickfl...@gmail.com wrote:  * Extend get_default_sifs/slot_time to include timings for turbo  half and quarter rate modes.  * AR5210 code for now uses timings already on core clock units  instead of usecs so rename them (we 'll clean it up

Re: [ath5k-devel] [PATCH 12/30] ath5k: Increase PHY settling parameters for turo mode

2010-11-23 Thread Bruno Randolf
On Wed November 24 2010 05:11:57 Nick Kossifidis wrote: 2010/11/23 Luis R. Rodriguez lrodrig...@atheros.com: On Tue, Nov 23, 2010 at 11:04:43AM -0800, Nick Kossifidis wrote: Are you willing to deal with *all* bug reports for this? Luis I don't enable 5/10/40MHz operation anywhere

Re: [ath5k-devel] [PATCH 14/30] ath5k: Extend get_default_sifs/slot_time

2010-11-23 Thread Jonathan Guerin
On Wed, Nov 24, 2010 at 11:04 AM, Nick Kossifidis mickfl...@gmail.com wrote: 2010/11/24 Nick Kossifidis mickfl...@gmail.com: 2010/11/24 Jonathan Guerin jonat...@guerin.id.au: On Wed, Nov 24, 2010 at 5:09 AM, Nick Kossifidis mickfl...@gmail.com wrote:  * Extend get_default_sifs/slot_time to

Re: [ath5k-devel] [PATCH 14/30] ath5k: Extend get_default_sifs/slot_time

2010-11-23 Thread Jonathan Guerin
On Wed, Nov 24, 2010 at 11:35 AM, Jonathan Guerin jonat...@guerin.id.au wrote: On Wed, Nov 24, 2010 at 11:04 AM, Nick Kossifidis mickfl...@gmail.com wrote: 2010/11/24 Nick Kossifidis mickfl...@gmail.com: 2010/11/24 Jonathan Guerin jonat...@guerin.id.au: On Wed, Nov 24, 2010 at 5:09 AM, Nick