Re: [ath5k-devel] [PATCH v2 13/20] cfg80211: Add nl80211 antenna configuration

2010-06-06 Thread Bruno Randolf
On Saturday 05 June 2010 06:21:45 you wrote: > I don't think the API is defined clean enough yet and can yield > inconsistant interpretations. I'd like to see this clarified on > the documentation for both legacy and 802.11n. If the plan is > to support only legacy right now then I think the API ca

Re: [ath5k-devel] [PATCH v2 13/20] cfg80211: Add nl80211 antenna configuration

2010-06-04 Thread Luis R. Rodriguez
On Fri, Jun 4, 2010 at 2:21 PM, Luis R. Rodriguez wrote: > On Fri, Jun 04, 2010 at 12:30:09PM -0700, John W. Linville wrote: >> On Wed, May 19, 2010 at 10:31:48AM +0900, Bruno Randolf wrote: >> > Allow setting TX and RX antenna configuration via nl80211/cfg80211. >> > >> > The antenna configuratio

Re: [ath5k-devel] [PATCH v2 13/20] cfg80211: Add nl80211 antenna configuration

2010-06-04 Thread Luis R. Rodriguez
On Fri, Jun 04, 2010 at 12:30:09PM -0700, John W. Linville wrote: > On Wed, May 19, 2010 at 10:31:48AM +0900, Bruno Randolf wrote: > > Allow setting TX and RX antenna configuration via nl80211/cfg80211. > > > > The antenna configuration is defined as a bitmap of allowed antennas. This > > bitmap i

Re: [ath5k-devel] [PATCH v2 13/20] cfg80211: Add nl80211 antenna configuration

2010-06-04 Thread John W. Linville
On Wed, May 19, 2010 at 10:31:48AM +0900, Bruno Randolf wrote: > Allow setting TX and RX antenna configuration via nl80211/cfg80211. > > The antenna configuration is defined as a bitmap of allowed antennas. This > bitmap is 8 bit at the moment, each bit representing one antenna. If multiple > ante

Re: [ath5k-devel] [PATCH v2 13/20] cfg80211: Add nl80211 antenna configuration

2010-05-24 Thread RHS Linux User
Hi, One other *important* case: on port A a low noise preamp and a receive antenna. on port B a power amplifier and a seperate antenna In this way transmit noise is ( mostly ) kept out of the low noise receive channel. warm regards, wiz On Mon, 24 May 2010, Bruno Randolf wrote:

Re: [ath5k-devel] [PATCH v2 13/20] cfg80211: Add nl80211 antenna configuration

2010-05-23 Thread Bruno Randolf
On Saturday 22 May 2010 02:11:02 Luis R. Rodriguez wrote: > > > For legacy, keep it simple, use 3 settings, fixed_a, fixed_b, > > > diversity, for all devices. > > > > did you not understand my examples why i think it makes sense to use a > > bitmask for "legacy"? i think they are perfectly valid

Re: [ath5k-devel] [PATCH v2 13/20] cfg80211: Add nl80211 antenna configuration

2010-05-21 Thread Luis R. Rodriguez
On Fri, May 21, 2010 at 12:10 PM, Felix Fietkau wrote: > On 2010-05-21 7:11 PM, Luis R. Rodriguez wrote: >> On Thu, May 20, 2010 at 06:59:33PM -0700, Bruno Randolf wrote: >>> so from my point of view this is not very different from what we can support >>> with the API i suggested. for RX it seems

Re: [ath5k-devel] [PATCH v2 13/20] cfg80211: Add nl80211 antenna configuration

2010-05-21 Thread Felix Fietkau
On 2010-05-21 7:11 PM, Luis R. Rodriguez wrote: > On Thu, May 20, 2010 at 06:59:33PM -0700, Bruno Randolf wrote: >> so from my point of view this is not very different from what we can support >> with the API i suggested. for RX it seems to be 100% equivalent. > > Well I agree, the API *supports

Re: [ath5k-devel] [PATCH v2 13/20] cfg80211: Add nl80211 antenna configuration

2010-05-21 Thread Luis R. Rodriguez
On Thu, May 20, 2010 at 06:59:33PM -0700, Bruno Randolf wrote: > On Friday 21 May 2010 07:05:48 Luis R. Rodriguez wrote: > > For legacy, keep it simple, use 3 settings, fixed_a, fixed_b, > > diversity, for all devices. > > did you not understand my examples why i think it makes sense to use a > b

Re: [ath5k-devel] [PATCH v2 13/20] cfg80211: Add nl80211 antenna configuration

2010-05-20 Thread Sam Ng
Rodriguez Sent: Thursday, May 20, 2010 3:06 PM To: Bruno Randolf; David Quan; Sam Ng Cc: ath5k-devel@lists.ath5k.org; linux-wirel...@vger.kernel.org; linvi...@tuxdriver.com Subject: Re: [ath5k-devel] [PATCH v2 13/20] cfg80211: Add nl80211 antenna configuration On Wed, May 19, 2010 at 11:43

Re: [ath5k-devel] [PATCH v2 13/20] cfg80211: Add nl80211 antenna configuration

2010-05-20 Thread David Quan
Sent: Wednesday, May 19, 2010 11:44 PM To: Bruno Randolf; David Quan Cc: ath5k-devel@lists.ath5k.org; linux-wirel...@vger.kernel.org; linvi...@tuxdriver.com Subject: Re: [ath5k-devel] [PATCH v2 13/20] cfg80211: Add nl80211 antenna configuration On Wed, May 19, 2010 at 10:36 PM, Bruno Randolf wrote

Re: [ath5k-devel] [PATCH v2 13/20] cfg80211: Add nl80211 antenna configuration

2010-05-20 Thread Bruno Randolf
On Friday 21 May 2010 07:05:48 Luis R. Rodriguez wrote: > For legacy, keep it simple, use 3 settings, fixed_a, fixed_b, > diversity, for all devices. did you not understand my examples why i think it makes sense to use a bitmask for "legacy"? i think they are perfectly valid use-cases. do i need

Re: [ath5k-devel] [PATCH v2 13/20] cfg80211: Add nl80211 antenna configuration

2010-05-20 Thread Luis R. Rodriguez
Just for clarification, these e-mails are on a public mailing list. On Thu, May 20, 2010 at 03:14:01PM -0700, Sam Ng wrote: > Just to be accurate, we do have pre-lln devices that support > more than 1 antenna ie. slow/fast diversity Right, this is the typical fixed anntena a, fixed anntena b, or

Re: [ath5k-devel] [PATCH v2 13/20] cfg80211: Add nl80211 antenna configuration

2010-05-20 Thread Luis R. Rodriguez
On Wed, May 19, 2010 at 11:43 PM, Luis R. Rodriguez wrote: > On Wed, May 19, 2010 at 10:36 PM, Bruno Randolf wrote: >> On Thursday 20 May 2010 14:17:19 you wrote: >>> None of the legacy 802.11 drivers we support have more than 2 >>> antennas, I am also not aware of any. >> >> i have heard of some

Re: [ath5k-devel] [PATCH v2 13/20] cfg80211: Add nl80211 antenna configuration

2010-05-19 Thread Luis R. Rodriguez
On Wed, May 19, 2010 at 10:36 PM, Bruno Randolf wrote: > On Thursday 20 May 2010 14:17:19 you wrote: >> None of the legacy 802.11 drivers we support have more than 2 >> antennas, I am also not aware of any. > > i have heard of some solutions based on atheros chipsets with more than 2 > antennas ("

Re: [ath5k-devel] [PATCH v2 13/20] cfg80211: Add nl80211 antenna configuration

2010-05-19 Thread Bruno Randolf
On Thursday 20 May 2010 14:17:19 you wrote: > None of the legacy 802.11 drivers we support have more than 2 > antennas, I am also not aware of any. i have heard of some solutions based on atheros chipsets with more than 2 antennas ("pre-11n RangeMax", "large phased array switch"). please check i

Re: [ath5k-devel] [PATCH v2 13/20] cfg80211: Add nl80211 antenna configuration

2010-05-19 Thread Luis R. Rodriguez
>> > that's not very clear. can you give me an example? >> >> iw dev wlan0 set_tx_antenna 4 > > so you want to transmit on antenna 3. if the card has 3 antennas - > why not? None of the legacy 802.11 drivers we support have more than 2 antennas, I am also not aware of any. >> > what if there is a

Re: [ath5k-devel] [PATCH v2 13/20] cfg80211: Add nl80211 antenna configuration

2010-05-19 Thread Bruno Randolf
On Thursday 20 May 2010 10:26:29 you wrote: > >> > > > + * @NL80211_ATTR_ANTENNA_TX: Bitmap of antennas to use for > >> > > > transmitting. + * @NL80211_ATTR_ANTENNA_RX: Bitmap of antennas to > >> > > > use for receiving. > >> > > > >> > > This gets the job done, but that's it. The API defined all

Re: [ath5k-devel] [PATCH v2 13/20] cfg80211: Add nl80211 antenna configuration

2010-05-19 Thread Luis R. Rodriguez
On Wed, May 19, 2010 at 6:12 PM, Bruno Randolf wrote: > On Thursday 20 May 2010 09:51:43 Luis R. Rodriguez wrote: >> On Wed, May 19, 2010 at 05:35:40PM -0700, Bruno Randolf wrote: >> > On Thursday 20 May 2010 02:07:25 you wrote: >> > > On Tue, May 18, 2010 at 6:31 PM, Bruno Randolf wrote: >> > >

Re: [ath5k-devel] [PATCH v2 13/20] cfg80211: Add nl80211 antenna configuration

2010-05-19 Thread Bruno Randolf
On Thursday 20 May 2010 09:51:43 Luis R. Rodriguez wrote: > On Wed, May 19, 2010 at 05:35:40PM -0700, Bruno Randolf wrote: > > On Thursday 20 May 2010 02:07:25 you wrote: > > > On Tue, May 18, 2010 at 6:31 PM, Bruno Randolf wrote: > > > > + * @NL80211_ATTR_ANTENNA_TX: Bitmap of antennas to use for

Re: [ath5k-devel] [PATCH v2 13/20] cfg80211: Add nl80211 antenna configuration

2010-05-19 Thread Luis R. Rodriguez
On Wed, May 19, 2010 at 05:35:40PM -0700, Bruno Randolf wrote: > On Thursday 20 May 2010 02:07:25 you wrote: > > On Tue, May 18, 2010 at 6:31 PM, Bruno Randolf wrote: > > > + * @NL80211_ATTR_ANTENNA_TX: Bitmap of antennas to use for transmitting. > > > + * @NL80211_ATTR_ANTENNA_RX: Bitmap of anten

Re: [ath5k-devel] [PATCH v2 13/20] cfg80211: Add nl80211 antenna configuration

2010-05-19 Thread Bruno Randolf
On Thursday 20 May 2010 02:07:25 you wrote: > On Tue, May 18, 2010 at 6:31 PM, Bruno Randolf wrote: > > + * @NL80211_ATTR_ANTENNA_TX: Bitmap of antennas to use for transmitting. > > + * @NL80211_ATTR_ANTENNA_RX: Bitmap of antennas to use for receiving. > > This gets the job done, but that's it. Th

Re: [ath5k-devel] [PATCH v2 13/20] cfg80211: Add nl80211 antenna configuration

2010-05-19 Thread Luis R. Rodriguez
On Tue, May 18, 2010 at 6:31 PM, Bruno Randolf wrote: > + * @NL80211_ATTR_ANTENNA_TX: Bitmap of antennas to use for transmitting. > + * @NL80211_ATTR_ANTENNA_RX: Bitmap of antennas to use for receiving. This gets the job done, but that's it. The API defined allows for a hugely loose implementati

[ath5k-devel] [PATCH v2 13/20] cfg80211: Add nl80211 antenna configuration

2010-05-18 Thread Bruno Randolf
Allow setting TX and RX antenna configuration via nl80211/cfg80211. The antenna configuration is defined as a bitmap of allowed antennas. This bitmap is 8 bit at the moment, each bit representing one antenna. If multiple antennas are selected, the driver may use diversity for receive and transmit.