Re: [ath5k-devel] [PATCH v3] ath5k: disable ASPM

2010-07-28 Thread Luis R. Rodriguez
On Wed, Jul 28, 2010 at 4:48 PM, Maxim Levitsky wrote: > On Tue, 2010-07-27 at 08:57 -0700, Luis R. Rodriguez wrote: >> On Tue, Jul 27, 2010 at 2:35 AM, Maxim Levitsky >> wrote: >> > On Mon, 2010-07-26 at 23:50 +0100, Matthew Garrett wrote: >> >> On Mon, Jul 26, 2010 at 03:43:04PM -0700, Luis R.

Re: [ath5k-devel] [PATCH v3] ath5k: disable ASPM

2010-07-28 Thread Maxim Levitsky
On Tue, 2010-07-27 at 08:57 -0700, Luis R. Rodriguez wrote: > On Tue, Jul 27, 2010 at 2:35 AM, Maxim Levitsky > wrote: > > On Mon, 2010-07-26 at 23:50 +0100, Matthew Garrett wrote: > >> On Mon, Jul 26, 2010 at 03:43:04PM -0700, Luis R. Rodriguez wrote: > >> > >> > I see.. thanks Mathew... in tha

Re: [ath5k-devel] [PATCH v3] ath5k: disable ASPM

2010-07-27 Thread Luis R. Rodriguez
On Tue, Jul 27, 2010 at 2:35 AM, Maxim Levitsky wrote: > On Mon, 2010-07-26 at 23:50 +0100, Matthew Garrett wrote: >> On Mon, Jul 26, 2010 at 03:43:04PM -0700, Luis R. Rodriguez wrote: >> >> > I see.. thanks Mathew... in that case since L1 works on all devices we >> > could just force enable L1 fo

Re: [ath5k-devel] [PATCH v3] ath5k: disable ASPM

2010-07-27 Thread Maxim Levitsky
On Mon, 2010-07-26 at 23:50 +0100, Matthew Garrett wrote: > On Mon, Jul 26, 2010 at 03:43:04PM -0700, Luis R. Rodriguez wrote: > > > I see.. thanks Mathew... in that case since L1 works on all devices we > > could just force enable L1 for all PCIE devices. What do you think? > > Works for me. >

Re: [ath5k-devel] [PATCH v3] ath5k: disable ASPM

2010-07-26 Thread Luis R. Rodriguez
On Mon, Jul 26, 2010 at 01:13:22PM -0700, Luis R. Rodriguez wrote: > On Sat, Jun 19, 2010 at 08:32:44AM -0700, Maxim Levitsky wrote: > > On Sat, 2010-06-19 at 16:02 +0300, Maxim Levitsky wrote: > > > On Sat, 2010-06-19 at 08:38 -0400, Bob Copeland wrote: > > > > On Sat, Jun 19, 2010 at 10:49:34AM

Re: [ath5k-devel] [PATCH v3] ath5k: disable ASPM

2010-07-26 Thread Matthew Garrett
On Mon, Jul 26, 2010 at 03:43:04PM -0700, Luis R. Rodriguez wrote: > I see.. thanks Mathew... in that case since L1 works on all devices we > could just force enable L1 for all PCIE devices. What do you think? Works for me. -- Matthew Garrett | mj...@srcf.ucam.org __

Re: [ath5k-devel] [PATCH v3] ath5k: disable ASPM

2010-07-26 Thread Luis R. Rodriguez
On Mon, Jul 26, 2010 at 3:33 PM, Matthew Garrett wrote: > On Mon, Jul 26, 2010 at 03:31:28PM -0700, Luis R. Rodriguez wrote: >> On Mon, Jul 26, 2010 at 3:29 PM, Matthew Garrett wrote: >> > On Mon, Jul 26, 2010 at 03:26:37PM -0700, Luis R. Rodriguez wrote: >> > >> >> What I meant was that the PCI

Re: [ath5k-devel] [PATCH v3] ath5k: disable ASPM

2010-07-26 Thread Matthew Garrett
On Mon, Jul 26, 2010 at 03:31:28PM -0700, Luis R. Rodriguez wrote: > On Mon, Jul 26, 2010 at 3:29 PM, Matthew Garrett wrote: > > On Mon, Jul 26, 2010 at 03:26:37PM -0700, Luis R. Rodriguez wrote: > > > >> What I meant was that the PCI config space would already have L1 > >> enabled if L1 worked, s

Re: [ath5k-devel] [PATCH v3] ath5k: disable ASPM

2010-07-26 Thread Luis R. Rodriguez
On Mon, Jul 26, 2010 at 3:29 PM, Matthew Garrett wrote: > On Mon, Jul 26, 2010 at 03:26:37PM -0700, Luis R. Rodriguez wrote: > >> What I meant was that the PCI config space would already have L1 >> enabled if L1 worked, so I don't see why we would need to nitpick out >> specifics here. All Atheros

Re: [ath5k-devel] [PATCH v3] ath5k: disable ASPM

2010-07-26 Thread Luis R. Rodriguez
On Mon, Jul 26, 2010 at 3:24 PM, Matthew Garrett wrote: > On Mon, Jul 26, 2010 at 03:20:23PM -0700, Luis R. Rodriguez wrote: >> On Mon, Jul 26, 2010 at 2:14 PM, Matthew Garrett wrote: >> > On Mon, Jul 26, 2010 at 02:06:51PM -0700, Luis R. Rodriguez wrote: >> > >> >> No, ASPM must be enabled by th

Re: [ath5k-devel] [PATCH v3] ath5k: disable ASPM

2010-07-26 Thread Matthew Garrett
On Mon, Jul 26, 2010 at 03:26:37PM -0700, Luis R. Rodriguez wrote: > What I meant was that the PCI config space would already have L1 > enabled if L1 worked, so I don't see why we would need to nitpick out > specifics here. All Atheros PCIE chips should work with L1. The advise > given is to disab

Re: [ath5k-devel] [PATCH v3] ath5k: disable ASPM

2010-07-26 Thread Luis R. Rodriguez
On Mon, Jul 26, 2010 at 3:21 PM, Matthew Garrett wrote: > On Mon, Jul 26, 2010 at 03:15:32PM -0700, Luis R. Rodriguez wrote: >> On Mon, Jul 26, 2010 at 2:25 PM, Matthew Garrett wrote: >> > This may need to be done on a chip by chip basis. Take a look at >> > http://www.atheros.cz/inffile.php?inf=

Re: [ath5k-devel] [PATCH v3] ath5k: disable ASPM

2010-07-26 Thread Matthew Garrett
On Mon, Jul 26, 2010 at 03:20:23PM -0700, Luis R. Rodriguez wrote: > On Mon, Jul 26, 2010 at 2:14 PM, Matthew Garrett wrote: > > On Mon, Jul 26, 2010 at 02:06:51PM -0700, Luis R. Rodriguez wrote: > > > >> No, ASPM must be enabled by the Systems Integrator through the BIOS, there > >> are > >> oth

Re: [ath5k-devel] [PATCH v3] ath5k: disable ASPM

2010-07-26 Thread Luis R. Rodriguez
On Mon, Jul 26, 2010 at 2:25 PM, Matthew Garrett wrote: > On Tue, Jul 27, 2010 at 12:17:13AM +0300, Maxim Levitsky wrote: > >> However, it is possible, (and that what I asked you) that some ath5k >> devices aren't 'pre 1.1 pcie devices' so linux won't disable ASPM L0s >> for them. >> So indeed for

Re: [ath5k-devel] [PATCH v3] ath5k: disable ASPM

2010-07-26 Thread Matthew Garrett
On Mon, Jul 26, 2010 at 03:15:32PM -0700, Luis R. Rodriguez wrote: > On Mon, Jul 26, 2010 at 2:25 PM, Matthew Garrett wrote: > > This may need to be done on a chip by chip basis. Take a look at > > http://www.atheros.cz/inffile.php?inf=68&bit=32&atheros=AR5002G&system=4 > > and some of the other i

Re: [ath5k-devel] [PATCH v3] ath5k: disable ASPM

2010-07-26 Thread Luis R. Rodriguez
On Mon, Jul 26, 2010 at 2:14 PM, Matthew Garrett wrote: > On Mon, Jul 26, 2010 at 02:06:51PM -0700, Luis R. Rodriguez wrote: > >> No, ASPM must be enabled by the Systems Integrator through the BIOS, there >> are >> other settings that have to be taken care of like modifying some PCI >> entrance

Re: [ath5k-devel] [PATCH v3] ath5k: disable ASPM

2010-07-26 Thread Luis R. Rodriguez
On Mon, Jul 26, 2010 at 2:17 PM, Maxim Levitsky wrote: > On Mon, 2010-07-26 at 14:06 -0700, Luis R. Rodriguez wrote: >> On Mon, Jul 26, 2010 at 01:49:22PM -0700, Maxim Levitsky wrote: >> > On Mon, 2010-07-26 at 13:13 -0700, Luis R. Rodriguez wrote: >> > > On Sat, Jun 19, 2010 at 08:32:44AM -0700,

Re: [ath5k-devel] [PATCH v3] ath5k: disable ASPM

2010-07-26 Thread Matthew Garrett
On Mon, Jul 26, 2010 at 02:06:51PM -0700, Luis R. Rodriguez wrote: > No, ASPM must be enabled by the Systems Integrator through the BIOS, there are > other settings that have to be taken care of like modifying some PCI entrance > and > exit latency timers, the number of FTS packets we send to exi

Re: [ath5k-devel] [PATCH v3] ath5k: disable ASPM

2010-07-26 Thread Matthew Garrett
On Tue, Jul 27, 2010 at 12:17:13AM +0300, Maxim Levitsky wrote: > However, it is possible, (and that what I asked you) that some ath5k > devices aren't 'pre 1.1 pcie devices' so linux won't disable ASPM L0s > for them. > So indeed for 'good feeling' it is ok to disable L0s from ath5k > explicitly,

Re: [ath5k-devel] [PATCH v3] ath5k: disable ASPM

2010-07-26 Thread Maxim Levitsky
On Mon, 2010-07-26 at 14:06 -0700, Luis R. Rodriguez wrote: > On Mon, Jul 26, 2010 at 01:49:22PM -0700, Maxim Levitsky wrote: > > On Mon, 2010-07-26 at 13:13 -0700, Luis R. Rodriguez wrote: > > > On Sat, Jun 19, 2010 at 08:32:44AM -0700, Maxim Levitsky wrote: > > > > On Sat, 2010-06-19 at 16:02 +

Re: [ath5k-devel] [PATCH v3] ath5k: disable ASPM

2010-07-26 Thread Luis R. Rodriguez
On Mon, Jul 26, 2010 at 01:49:22PM -0700, Maxim Levitsky wrote: > On Mon, 2010-07-26 at 13:13 -0700, Luis R. Rodriguez wrote: > > On Sat, Jun 19, 2010 at 08:32:44AM -0700, Maxim Levitsky wrote: > > > On Sat, 2010-06-19 at 16:02 +0300, Maxim Levitsky wrote: > > > > On Sat, 2010-06-19 at 08:38 -040

Re: [ath5k-devel] [PATCH v3] ath5k: disable ASPM

2010-07-26 Thread Maxim Levitsky
On Mon, 2010-07-26 at 13:13 -0700, Luis R. Rodriguez wrote: > On Sat, Jun 19, 2010 at 08:32:44AM -0700, Maxim Levitsky wrote: > > On Sat, 2010-06-19 at 16:02 +0300, Maxim Levitsky wrote: > > > On Sat, 2010-06-19 at 08:38 -0400, Bob Copeland wrote: > > > > On Sat, Jun 19, 2010 at 10:49:34AM +0300

Re: [ath5k-devel] [PATCH v3] ath5k: disable ASPM

2010-07-26 Thread Luis R. Rodriguez
On Sat, Jun 19, 2010 at 08:32:44AM -0700, Maxim Levitsky wrote: > On Sat, 2010-06-19 at 16:02 +0300, Maxim Levitsky wrote: > > On Sat, 2010-06-19 at 08:38 -0400, Bob Copeland wrote: > > > On Sat, Jun 19, 2010 at 10:49:34AM +0300, Maxim Levitsky wrote: > > > > How this patch? > > > > > > Looks fi

[ath5k-devel] [PATCH v3] ath5k: disable ASPM

2010-06-19 Thread Maxim Levitsky
On Sat, 2010-06-19 at 16:02 +0300, Maxim Levitsky wrote: > On Sat, 2010-06-19 at 08:38 -0400, Bob Copeland wrote: > > On Sat, Jun 19, 2010 at 10:49:34AM +0300, Maxim Levitsky wrote: > > > How this patch? > > > > Looks fine to me. Some nitpicking below but feel free to add my > > > > Acked-by: