* Stefano Lattarini wrote on Sun, Aug 08, 2010 at 06:06:04PM CEST:
At Sunday 08 August 2010, Ralf Wildenhues wrote:
No. You save a fork with
foo ()
{
...
foo_result=bar
}
foo ARG...
test $foo_result = ...
Yes, but how do you get foo_result in our case?
At Sunday 08 August 2010, Ralf Wildenhues wrote:
Pardon my ignorance, but what do you mean by a fake merge?
When you merge a branch A into B, then it can happen that git sees
no conflicts, but in reality things break anyway. This can easily
happen when, say, A renames a variable, B adds
* Stefano Lattarini wrote on Sun, Aug 08, 2010 at 01:29:19PM CEST:
At Sunday 08 August 2010, Ralf Wildenhues wrote:
Except this would have been caught by make check already, so it
doesn't count as an argument in favor of that patch, right? ;-)
But make check is slooow on my machine, so when
* Stefano Lattarini wrote on Tue, Jun 22, 2010 at 06:48:00PM CEST:
Yet another testsuite-tweaking patch.
* tests/depcomp.test: Do not create useless dummy source files.
Add a trailing `:' command.
* tests/depcomp2.test: Use `unset' on the CFLAG variable to ensure
it's not in in the
* Stefano Lattarini wrote on Sun, Aug 08, 2010 at 12:53:21PM CEST:
At Sunday 08 August 2010, Ralf Wildenhues wrote:
Also, regenerating the tree with Autoconf 2.67 and committing that
separately is preapproved for maint.
Couldn't this cause problems when later merging to master? If yes,
Hello Stefano,
* Stefano Lattarini wrote on Wed, Jul 14, 2010 at 03:26:04PM CEST:
* tests/condd.test: Add trailing `:' command. Typofix in
comment. Prefer fgrep over grep.
* tests/condhook.test: Make sure target `install-data-hook' is
not called by `make install', but that data files are
* Stefano Lattarini wrote on Thu, Aug 05, 2010 at 01:54:20PM CEST:
Ping on this? It seems to me that most issues with this patch had
already been solved, so it's probably a pity to let it bitrotting
here...
Well, I'd prefer the extract_dependencies script approach which
would be more correct
At Sunday 08 August 2010, Ralf Wildenhues wrote:
* Stefano Lattarini wrote on Sun, Aug 08, 2010 at 06:22:00PM CEST:
Exactly! So:
foo() { foo_result=`sed ...`; }
foo; bar=$foo_result;
instead of:
foo() { sed ...; }
bar=`foo`
Where is the significant improvement?
Two
* Stefano Lattarini wrote on Sun, Jun 27, 2010 at 04:48:03PM CEST:
Another testsuite-tweaking patch. This time, the changes should be
small and simple.
Minor improvements for tests `acloca*.test'.
This is not ok. Let's just drop everything from it except for the
changes I've copied below.
I'm seeing a presumably new failure on Cygwin that I don't remember
seeing before. The gist is the following: transform2.test tries
something like
install bla.exe .../inst/bin/foo.exe
install script.sh .../inst/bin/foo
and the second one fails (to overwrite the foo.exe). Does anybody
* Stefano Lattarini wrote on Wed, Jul 14, 2010 at 01:36:57PM CEST:
* tests/all.test: Run aclocal only once. Minor cosmetic changes.
Move checks that several *-local's in a single rule work ...
This sentence does not make sense to me. Maybe a missing word?
* tests/manylocal.test: ... in this
* Stefano Lattarini wrote on Wed, Jul 14, 2010 at 03:41:14PM CEST:
* tests/subobjname.test: Add trailing `:' command.
* tests/subobj.test: Make grepping of `Makefile.in' stricter.
Escape literal dots in grep regexps.
* tests/subobj2.test: Add trailing `:' command. Do not use the
unportable
* Stefano Lattarini wrote on Wed, Jul 14, 2010 at 01:16:28PM CEST:
Remove a couple of obsoleted tests.
* tests/fpinstall.test: Removed.
* tests/fpinst2.test: Likewise.
OK for maint, but only if you also update tests/Makefile.{am,in}
to avoid subsequent testsuite failure. ;-)
Cheers,
Hello Ralf.
I just want state explicitly that I'll wait until tomorrow
(or even the day after) to merge and push the patches we have
reviewed this afternoon, since the time for today is almost out,
and I don't want to do a push without proper testing.
Regards,
Stefano
On Sat, Aug 7, 2010 at 09:03, Ralf Wildenhues ralf.wildenh...@gmx.de wrote:
Darn, we need another name: 'archive' is likely too common when automake
is going to put all files with that name in the distribution of each
package using Automake. No need to send another patch, but any other
good
At Sunday 08 August 2010, Ralf Wildenhues wrote:
foo=`extract_makefile_deps tgt2 Makefile`; echo x$foox
More or less, yes. I'd avoid the command substitution fork by
letting extract_makefile_deps set some variable instead of
printing.
So the we'd have move the comamnd
At Sunday 08 August 2010, Ralf Wildenhues wrote:
* Stefano Lattarini wrote on Sun, Aug 08, 2010 at 05:35:57PM CEST:
I'm just saying that when we'll write the `extract_makefile_deps'
function, it shouldn't bother with preserving tabs and
backslashes;
Well, it should deal with them
At Sunday 08 August 2010, Ralf Wildenhues wrote:
* Stefano Lattarini wrote on Sun, Aug 08, 2010 at 05:09:03PM CEST:
At Sunday 08 August 2010, Ralf Wildenhues wrote:
tgt1 tgt2 \
tgt3 : dep1 dep2 \
dep3 \
dep4
Posix is perfectly clear
At Sunday 08 August 2010, Ralf Wildenhues wrote:
* Stefano Lattarini wrote on Wed, Jul 14, 2010 at 01:16:28PM CEST:
Remove a couple of obsoleted tests.
* tests/fpinstall.test: Removed.
* tests/fpinst2.test: Likewise.
OK for maint, but only if you also update tests/Makefile.{am,in}
to
* Stefano Lattarini wrote on Sun, Aug 08, 2010 at 12:44:32PM CEST:
At Sunday 08 August 2010, Ralf Wildenhues wrote:
-$FGREP 'generic/a.$(OBJEXT)' Makefile.in
+grep '^generic/a\.\$(OBJEXT):' Makefile.in
Some day I'll add initial and trailing space to the target names of
all generated
* Stefano Lattarini wrote on Sun, Aug 08, 2010 at 07:17:49PM CEST:
I just want state explicitly that I'll wait until tomorrow
(or even the day after) to merge and push the patches we have
reviewed this afternoon, since the time for today is almost out,
and I don't want to do a push without
At Sunday 08 August 2010, Ralf Wildenhues wrote:
Well, I'd prefer the extract_dependencies script approach
I like the idea, too, but as I said I'd prefer to leave for a
later patch.
That's fine of course. Just leave the corresponding code unchanged
then.
I'll revert it, and add back
* Stefano Lattarini wrote on Sun, Aug 08, 2010 at 04:38:08PM CEST:
At Sunday 08 August 2010, Ralf Wildenhues wrote:
* Stefano Lattarini wrote on Thu, Aug 05, 2010 at 01:54:20PM CEST:
Ping on this? It seems to me that most issues with this patch
had already been solved, so it's probably a
At Sunday 08 August 2010, Ralf Wildenhues wrote:
* Stefano Lattarini wrote on Thu, Aug 05, 2010 at 01:54:20PM CEST:
Ping on this? It seems to me that most issues with this patch
had already been solved, so it's probably a pity to let it
bitrotting here...
Well, I'd prefer the
* Stefano Lattarini wrote on Sun, Aug 08, 2010 at 04:06:32PM CEST:
At Sunday 08 August 2010, Ralf Wildenhues wrote:
ok with it if you also add more meaningful descriptions to the
tests, say, the PR descriptions.
I'd love to do that (maybe as a separate patch to be applied *before*
this
At Sunday 08 August 2010, Ralf Wildenhues wrote:
* Stefano Lattarini wrote on Wed, Jul 14, 2010 at 02:19:20PM CEST:
* tests/asm.test: Use configure.in stub generated by ./defs,
and avoid obsoleted autoconf constructs. Make grepping of
Automake stderr stricter. Do not create useless source
At Sunday 08 August 2010, Ralf Wildenhues wrote:
Hi Stefano,
* Stefano Lattarini wrote on Sun, Jun 27, 2010 at 06:14:41PM CEST:
More testsuite tweakings. But this patch also contains some
real improvements and useful extensions IMO.
OK with nits below addressed. If I'm appearing too
* Stefano Lattarini wrote on Sun, Aug 08, 2010 at 05:48:58PM CEST:
At Sunday 08 August 2010, Ralf Wildenhues wrote:
* Stefano Lattarini wrote on Sun, Aug 08, 2010 at 05:35:57PM CEST:
foo=`extract_makefile_deps tgt2 Makefile`; echo x$foox
More or less, yes. I'd avoid the command
* Stefano Lattarini wrote on Sun, Aug 08, 2010 at 05:35:57PM CEST:
I'm just saying that when we'll write the `extract_makefile_deps'
function, it shouldn't bother with preserving tabs and backslashes;
Well, it should deal with them correctly, yes.
on the other hand, it should actively
At Sunday 08 August 2010, Ralf Wildenhues wrote:
Well, if it helps you, there is no need to maintain a linear
history in the maint branch. You can also just merge your (fixed)
patches from the branches where you have them, that is fine with
me as well. No need to rebase or cherry-pick the
* Stefano Lattarini wrote on Wed, Jul 14, 2010 at 02:19:20PM CEST:
* tests/asm.test: Use configure.in stub generated by ./defs,
and avoid obsoleted autoconf constructs. Make grepping of
Automake stderr stricter. Do not create useless source file.
Improve verbose messages. Minor cosmetic
* Stefano Lattarini wrote on Sun, Aug 08, 2010 at 01:04:14PM CEST:
At Sunday 08 August 2010, Ralf Wildenhues wrote:
* Stefano Lattarini wrote on Wed, Jul 14, 2010 at 01:16:28PM CEST:
Remove a couple of obsoleted tests.
* tests/fpinstall.test: Removed.
* tests/fpinst2.test:
* Stefano Lattarini wrote on Sun, Aug 08, 2010 at 12:53:21PM CEST:
At Sunday 08 August 2010, Ralf Wildenhues wrote:
Fine with me. If you have all your patches in branches
Yes, a branch for every patch (series).
or otherwise ordered, you can also just wait until I'm done
reviewing and
At Sunday 08 August 2010, Ralf Wildenhues wrote:
* Stefano Lattarini wrote on Sun, Aug 08, 2010 at 12:09:52PM CEST:
I squashed the following into the first patch:
It's OK for you?
Sure.
(BTW, if my understanding is correct, this would make a nice
addition to HACKING, too).
At Sunday 08 August 2010, Ralf Wildenhues wrote:
Except this would have been caught by make check already, so it
doesn't count as an argument in favor of that patch, right? ;-)
But make check is slooow on my machine, so when I change just a
couple of test script I re-test them doing:
$ cd
Hi Stefano,
* Stefano Lattarini wrote on Sun, Jun 27, 2010 at 06:14:41PM CEST:
More testsuite tweakings. But this patch also contains some real
improvements and useful extensions IMO.
OK with nits below addressed. If I'm appearing too grumpy, then I'm
sorry about that, so let me tell you
* Stefano Lattarini wrote on Sun, Aug 08, 2010 at 06:22:00PM CEST:
Exactly! So:
foo() { foo_result=`sed ...`; }
foo; bar=$foo_result;
instead of:
foo() { sed ...; }
bar=`foo`
Where is the significant improvement?
Two forks vs. one: the latter still forks right before exec'ing sed.
* Stefano Lattarini wrote on Wed, Jul 14, 2010 at 03:35:11PM CEST:
Modernize, improve and extend tests `pr*.test'.
* tests/pr2.test: Add trailing `:' command.
* tests/pr229.test: Likewise.
* tests/pr401.test: Likewise.
* tests/pr401b.test: Likewise.
* tests/pr401c.test: Likewise.
*
* Stefano Lattarini wrote on Wed, Jul 14, 2010 at 01:45:34PM CEST:
* tests/ar.test: Add trailing `:' command.
* tests/ar2.test: Likewise, and make grepping of generated
Makefile.in stricter.
OK for maint, thanks!
Ralf
[ the gnu list server seems down ATM; expect delays ]
Hi Stefano,
* Stefano Lattarini wrote on Wed, Jul 28, 2010 at 11:07:20AM CEST:
At Wednesday 28 July 2010, Ralf Wildenhues wrote:
But even then, when developing Automake you will need to be extra
careful to never let autoconf be invoked
Den 2010-08-07 08:03 skrev Ralf Wildenhues:
Darn, we need another name: 'archive' is likely too common when automake
is going to put all files with that name in the distribution of each
package using Automake. No need to send another patch, but any other
good suggestions that fit in with the
* Stefano Lattarini wrote on Sun, Aug 08, 2010 at 03:11:13PM CEST:
At Sunday 08 August 2010, Ralf Wildenhues wrote:
and I'm sorry there is such a high review delay.
Well, I assume this is not done on purpose (right? ;-), so don't worry.
That depends on how you interpret it, I guess.
* Ralf Wildenhues wrote on Sat, Aug 07, 2010 at 08:03:56AM CEST:
Darn, we need another name: 'archive' is likely too common when automake
is going to put all files with that name in the distribution of each
package using Automake. No need to send another patch, but any other
good suggestions
Here's the deal: At least two patch sets have been posted to Automake
mailing lists during the last year in order to improve Vala support in
Automake. We cannot take either because the authors couldn't complete
copyright assignments for reasons not further relevant to this message.
So here's a
44 matches
Mail list logo
