Re: [OpenJDK 2D-Dev] [9] Review Request: JDK-8029455 JLightweightFrame: support scaled painting

PS. I'll be pushing the FX part of the fix today. So we should consider the current interface frozen for now. Yes, please! -- Kevin Anthony Petrov wrote: On 5/23/2014 3:12 PM, Anton V. Tarasov wrote: On 23.05.2014 14:47, Anthony Petrov wrote: 1. The host bounds are not related to the /co

Re: [9] Review request for 8028617: Dvorak keyboard mapping not honored when ctrl key pressed

> On Fri, 23 May 2014 19:14:24 +0400, anton nashatyrev > said: AN> Hello, AN> could you please review the following fix: AN> fix: http://cr.openjdk.java.net/~anashaty/8028617/9/webrev.00/ AN> AN> bug: https://bugs.openj

Re: [9] Review request for 8028617: Dvorak keyboard mapping not honored when ctrl key pressed

On 5/23/2014 8:04 PM, anton nashatyrev wrote: could you please point me to the i18n tests you have mentioned? test/java/awt/im ...? In both open and closed repos. from non-English I'd tested only Russian locale. Do you have in mind some special cases for other locales? No, RU isn

Re: [9] Review request for 8028617: Dvorak keyboard mapping not honored when ctrl key pressed

Will be better to investigate it now, if it is not urgent. On 5/23/14 7:56 PM, Petr Pchelko wrote: Thanks for the clarifications, the fix looks good to me. I believe that at least in most cases this workaround will be skipped after the fix, however for some keys it might be still actual. I'm

Re: [9] Review request for 8028617: Dvorak keyboard mapping not honored when ctrl key pressed

Anthony, could you please point me to the i18n tests you have mentioned? from non-English I'd tested only Russian locale. Do you have in mind some special cases for other locales? Thanks! Anton. On 23.05.2014 19:44, Anthony Petrov wrote: Thanks for confirming that. I'm OK with the f

Re: [9] Review request for 8028617: Dvorak keyboard mapping not honored when ctrl key pressed

Thanks for the clarifications, the fix looks good to me. > I believe that at least in most cases this workaround will be skipped after > the fix, however for some keys it might be still actual. I'm not sure here… Could you please file a new P4 bug to investigate this? Thank you. With best regard

Re: [9] Review request for 8028617: Dvorak keyboard mapping not honored when ctrl key pressed

I believe that at least in most cases this workaround will be skipped after the fix, however for some keys it might be still actual. I'm not sure here... On 23.05.2014 19:40, Petr Pchelko wrote: No, we are using the workaround now: the character is calculated from the keyboard scan-code (

Re: [9] Review request for 8028617: Dvorak keyboard mapping not honored when ctrl key pressed

Thanks for confirming that. I'm OK with the fix then. However, I also suggest to run some i18n tests and also try some non-English keyboard layouts (DE, FR, JP, etc.) with special characters and dead keys to ensure they aren't broken. -- best regards, Anthony On 5/23/2014 7:39 PM, anton nash

Re: [9] Review request for 8028617: Dvorak keyboard mapping not honored when ctrl key pressed

>No, we are using the workaround now: the character is calculated from the > keyboard scan-code (which is also received in the NSEvent) when the > NSEvent::characters is empty. Thus we are still getting the right character > in the querty layout, but having a problem with others (e.g. when t

Re: [9] Review request for 8028617: Dvorak keyboard mapping not honored when ctrl key pressed

Anthony, yes, the CapsLock works for me as well. Thanks! Anton On 23.05.2014 19:35, Anthony Petrov wrote: Hi Anton, If you activate the CAPS LOCK mode and type some characters, will those be presented as capital letters in Swing/AWT's text fields and text areas after your fix? (see [1]

Re: [9] Review request for 8028617: Dvorak keyboard mapping not honored when ctrl key pressed

Hi Anton, If you activate the CAPS LOCK mode and type some characters, will those be presented as capital letters in Swing/AWT's text fields and text areas after your fix? (see [1] for a related FX bug) [1] https://javafx-jira.kenai.com/browse/RT-16616 -- best regards, Anthony On 5/23/2014

Re: [9] Review request for 8028617: Dvorak keyboard mapping not honored when ctrl key pressed

Hello Petr, yes, I've run java/awt/event/KeyEvent tests from both open/closed parts: there were a number of fails on a clean build, but no new fails found with a fixed version (even one of them became 'passed'). I couldn't invent any automatic regression tests since the problem is repr

Re: Request for review, JDK-8009883, REGRESSION: test/closed/javax/swing/AbstractButton/4246045/bug4246045.java fails

Hello, Peter. Looks good to me too. With best regards. Petr. On May 23, 2014, at 7:14 PM, Pete Brunet wrote: > Thanks Alexandr. > > So far Alexandr is the only reviewer of this. I'd like one more. > > Thanks, Pete > > On 5/23/14 5:34 AM, Alexander Scherbatiy wrote: >> On 5/22/2014 9:59 PM,

Re: [9] Review Request: 8031485 [macosx] Combo box consuming escape key events

Hi, Petr. The fix looks good. On 5/14/14 6:13 PM, Petr Pchelko wrote: Hello, Please review the fix for the issue: https://bugs.openjdk.java.net/browse/JDK-8031485 The fix is available at: http://cr.openjdk.java.net/~pchelko/9/8031485/webrev.00/ We should not consume the ESC if the popup is not

Re: [9] Review request for 8028617: Dvorak keyboard mapping not honored when ctrl key pressed

Hello, Anton. Did you run all the KeyEvent-related regression tests? May be we could right a regression test for this one? From your evaluation I have an impression that Ctrl+Key combination is now broken in normal layout too? Is this correct? Thank you. With best regards. Petr. On May 23, 201

Re: [OpenJDK 2D-Dev] [9] Review Request: JDK-8029455 JLightweightFrame: support scaled painting

On 5/23/2014 6:51 PM, Kevin Rushforth wrote: PS. I'll be pushing the FX part of the fix today. So we should consider the current interface frozen for now. Yes, please! Here it is: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/9f221ab57e22 -- best regards, Anthony -- Kevin Anthony Pe

Re: [9] Review Request: 8043610 Sorting columns in JFileChooser fails with AppContext NPE

The fix looks good for me. Thanks, Alexandr. On 5/22/2014 5:43 PM, Petr Pchelko wrote: Hello, AWT Team. Please review the fix for the issue: https://bugs.openjdk.java.net/browse/JDK-8043610 The fix is available at: http://cr.openjdk.java.net/~pchelko/9/8043610/webrev/ The problem is th

Re: Request for review, JDK-8009883, REGRESSION: test/closed/javax/swing/AbstractButton/4246045/bug4246045.java fails

Thanks Alexandr. So far Alexandr is the only reviewer of this. I'd like one more. Thanks, Pete On 5/23/14 5:34 AM, Alexander Scherbatiy wrote: > On 5/22/2014 9:59 PM, Pete Brunet wrote: >> I'd like one more reviewer of this fix. >> >> Also I removed the @Deprecated and will deal with this in a

[9] Review request for 8028617: Dvorak keyboard mapping not honored when ctrl key pressed

Hello, could you please review the following fix: fix: http://cr.openjdk.java.net/~anashaty/8028617/9/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-8028617 Problem: Dvorak keyboard mapping not honored when Ctrl ke

Re: [OpenJDK 2D-Dev] RFR: Allow using the system libjpeg

* Andrew Hughes [2014-05-22 16:10]: > - Original Message - > > On 2014-05-22 02:49, Omair Majid wrote: > > > Would you mind if I did this as a separate patch? I will need to fix > > > other libraries too (libzip, and libgif). > > > > > Ok, I thought the other ones were already in this for

Re: [9] Review request for 8040291 [macosx] Http-Images are not fully loaded when using ImageIcon

Hi, Alexander. The fix looks good. On 5/21/14 6:00 PM, Petr Pchelko wrote: Hello, Alexander. The fix looks good. With best regards. Petr. On 21 мая 2014 г., at 17:47, Alexander Scherbatiy wrote: Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8040291/webrev.03/ -

Re: [9] Review Request: 8043393 NullPointerException and no event received when clipboard data flavor changes

Hello, Anthony. > By "delivered incorrectly", what do you mean exactly? I’ve started to describe you the situation when I realized that the problem is more general, not the corner case as I’ve thought initially. So the fix is incorrect and I need to take a complicated path here. Sorry for the ti

Re: [9] Review Request: 8043393 NullPointerException and no event received when clipboard data flavor changes

Hi Petr, On 5/22/2014 7:42 PM, Petr Pchelko wrote: Please review a yet another AppContext fix: https://bugs.openjdk.java.net/browse/JDK-8043393 The fix is available here: http://cr.openjdk.java.net/~pchelko/9/8043393/webrev/ checkChange method is called on a Toolkit thread, but we are trying to

Re: [OpenJDK 2D-Dev] [9] Review Request: JDK-8029455 JLightweightFrame: support scaled painting

Ok, good! Anton. On 23.05.2014 15:18, Anthony Petrov wrote: On 5/23/2014 3:12 PM, Anton V. Tarasov wrote: On 23.05.2014 14:47, Anthony Petrov wrote: 1. The host bounds are not related to the /content/. Hence, adding this method to the LightweightContent interface would look inconsistent from

Re: [OpenJDK 2D-Dev] [9] Review Request: JDK-8029455 JLightweightFrame: support scaled painting

On 5/23/2014 3:12 PM, Anton V. Tarasov wrote: On 23.05.2014 14:47, Anthony Petrov wrote: 1. The host bounds are not related to the /content/. Hence, adding this method to the LightweightContent interface would look inconsistent from API perspective. It's not strictly about content (the name of

Re: [9] Review Request: 8043610 Sorting columns in JFileChooser fails with AppContext NPE

The fix looks good to me. -- best regards, Anthony On 5/22/2014 5:43 PM, Petr Pchelko wrote: Hello, AWT Team. Please review the fix for the issue: https://bugs.openjdk.java.net/browse/JDK-8043610 The fix is available at: http://cr.openjdk.java.net/~pchelko/9/8043610/webrev/ The problem is tha

Re: [OpenJDK 2D-Dev] [9] Review Request: JDK-8029455 JLightweightFrame: support scaled painting

On 23.05.2014 14:47, Anthony Petrov wrote: Hi Anton, I disagree, and here's my arguments: 1. The host bounds are not related to the /content/. Hence, adding this method to the LightweightContent interface would look inconsistent from API perspective. It's not strictly about content (the name

Re: [OpenJDK 2D-Dev] [9] Review Request: JDK-8029455 JLightweightFrame: support scaled painting

Hi Anton, I disagree, and here's my arguments: 1. The host bounds are not related to the /content/. Hence, adding this method to the LightweightContent interface would look inconsistent from API perspective. 2. Given the requirement to keep backward compatibility, the default implementation

Re: [7u] Review request for 7160604: Using non-opaque windows - popups are initially not painted correctly

The backport looks good for me. Thanks, Alexandr. On 5/23/2014 2:33 PM, Anton Litvinov wrote: Hello Sergey and Alexander, On "jdk7u-dev" e-mail alias my request to push this backport was rejected and I was obligated to pass the regular code review. Could you please review this back po

Re: Request for review, JDK-8009883, REGRESSION: test/closed/javax/swing/AbstractButton/4246045/bug4246045.java fails

On 5/22/2014 9:59 PM, Pete Brunet wrote: I'd like one more reviewer of this fix. Also I removed the @Deprecated and will deal with this in a following JBS issue. http://cr.openjdk.java.net/~ptbrunet/JDK-8009883/webrev.04/ The fix looks good for me. Thanks, Alexandr. Pete On 5/21/1

[7u] Review request for 7160604: Using non-opaque windows - popups are initially not painted correctly

Hello Sergey and Alexander, On "jdk7u-dev" e-mail alias my request to push this backport was rejected and I was obligated to pass the regular code review. Could you please review this back port to JDK 7 of the fix previously reviewed by you for JDK 8. Bug: https://bugs.openjdk.java.net/brows

Re: [OpenJDK 2D-Dev] [9] Review Request: JDK-8029455 JLightweightFrame: support scaled painting

Hi Sergey, Thanks for the update. I'm fine with the fix, except one thing. (I'm sorry that I didn't say that earlier). My concern is that we have the LightweightContent iface which is used to communicate to the client app. And so the method LightweightFrame.getHostBounds() is better to be