Re: RfR JDK-8055831 Open Source Java Access Bridge

2015-03-24 Thread Pete Brunet
Here's the latest patch: http://cr.openjdk.java.net/~ptbrunet/JDK-8055831/webrev.01/ The changes are: - restructured the native libraries from one directory to several directories on a per DLL/EXE basis - that impacted jdk/make/lib/Lib-jdk.accessibility.gmk - removed the source for the Ferret and

Re: RfR JDK-8055831 Open Source Java Access Bridge

2015-03-24 Thread Pete Brunet
Hi Sergey, That's pretty much the case. I just went through the code and found these differences: - merged in JDK-8055173 (merge jawt.dll into javaaccessbridge.dll) which was recently pushed. - removed some dead code - cleaned up up comments/documentation - cleaned up some code indentation issues

Re: RfR JDK-8055831 Open Source Java Access Bridge

2015-03-24 Thread Sergey Bylokhov
Hi,Pete. Do I understand correctly that the code itself were not changed except files location? 21.03.15 7:33, Pete Brunet wrote: Please review the following patch which will add the code of the Java Access Bridge (JAB) and related Java Accessibility Utilities to OpenJDK. This code is used by

Re: RfR JDK-8055831 Open Source Java Access Bridge

2015-03-24 Thread Erik Joelsson
Actually, I just noticed that we are indeed setting -def: to the linker. Please leave the .def files in the patch. /Erik On 2015-03-24 15:55, Erik Joelsson wrote: On 2015-03-24 14:08, Magnus Ihse Bursie wrote: JavaAccessBridge.DEF is pretty empty. I'll see if the build will work without

Re: [9] Review request for 8075244 [macosx] The fix for JDK-8043869 should be reworked

2015-03-24 Thread Anton Tarasov
Looks good to me. Regards Anton. On 24/03/15 14:38, Alexander Scherbatiy wrote: Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8075244/webrev.03/ The test is updated. Thanks, Alexandr. On 3/24/2015 2:19 PM, Sergey Bylokhov wrote: Hi, Alexander. It would be g

Re: RfR JDK-8055831 Open Source Java Access Bridge

2015-03-24 Thread Erik Joelsson
On 2015-03-24 14:08, Magnus Ihse Bursie wrote: JavaAccessBridge.DEF is pretty empty. I'll see if the build will work without it. WinAccessBridge.DEF seems like it might be needed. What do you think? Is it accessed by the compiler? Unless it is given as input to the compiler or linker co

Re: RfR JDK-8055831 Open Source Java Access Bridge

2015-03-24 Thread Magnus Ihse Bursie
On 2015-03-23 18:31, Pete Brunet wrote: Hi Erik, I tried the restructuring about 2 weeks ago and the build failed trying to find an h file in the common directory. I used two directories on the SRC := setting for SetupNativeCompilation but the build failed not finding an h file located in the s

Re: [9] Review request for 8075244 [macosx] The fix for JDK-8043869 should be reworked

2015-03-24 Thread Sergey Bylokhov
Hi, Alexander. The fix looks good to me. 24.03.15 14:38, Alexander Scherbatiy wrote: Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8075244/webrev.03/ The test is updated. Thanks, Alexandr. On 3/24/2015 2:19 PM, Sergey Bylokhov wrote: Hi, Alexander. It would

Re: [9] Review request for 8075244 [macosx] The fix for JDK-8043869 should be reworked

2015-03-24 Thread Alexander Scherbatiy
Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8075244/webrev.03/ The test is updated. Thanks, Alexandr. On 3/24/2015 2:19 PM, Sergey Bylokhov wrote: Hi, Alexander. It would be good to add robot.waitForIdle(); after call of frame.setVisible(true); 24.03.15 1

Re: [9] Review request for 8075244 [macosx] The fix for JDK-8043869 should be reworked

2015-03-24 Thread Sergey Bylokhov
Hi, Alexander. It would be good to add robot.waitForIdle(); after call of frame.setVisible(true); 24.03.15 13:58, Alexander Scherbatiy wrote: Hello, Could you review the same fix where the comment about running SWT in webstart is removed: http://cr.openjdk.java.net/~alexsch/8075244/we

[9] Review Request: 8074500 java.awt.Checkbox.setState() call causes ItemEvent to be filed

2015-03-24 Thread Sergey Bylokhov
Hello. Please review a small fix for jdk 9. According to specification of java.awt.Checkbox.setState() we should not post ItemEvent after a call to this method. And this case is violated on the osx. The new event is postponed in the same way as in LWCheckboxPeer.setCheckboxGroup() Bug: https:

Re: [9] Review request for 8075244 [macosx] The fix for JDK-8043869 should be reworked

2015-03-24 Thread Alexander Scherbatiy
Hello, Could you review the same fix where the comment about running SWT in webstart is removed: http://cr.openjdk.java.net/~alexsch/8075244/webrev.02/ Thanks, Alexandr. On 3/20/2015 1:34 AM, Anton Tarasov wrote: On 19/03/15 16:19, Alexander Scherbatiy wrote: On 3/19/2015 2:03 PM, A