Note that the test case in JDK-8069348 seems to work OK for a scaled
graphics (it actually fails only if I set the uiScale to 1 for some
reason), but Swing scrolling is completely broken. I dug down to the
call to D3D->StretchRect and it was returning D3DERR_INVALIDCALL and
simply not doing an
I ran SwingSet2 and JDK-8069348 immediately jumped out as being broken
to the point where SwingSet2 was not usable. We should definitely make
that a high priority to fix ASAP. There were a couple of other very
minor rendering issues, but they didn't really affect usability like
that bug...
Hi Alexandr,
One bug - we should be using LOGPIXELSY instead of X.
Otherwise, the changes look OK except for the one question/issue which I
don't know/remember the answer for:
How does this interact with per-monitor APIs? I believe LOGPIXELSX will
not change until the user logs off and back
Note that LOGPIXELSY is global and static between reboots so it doesn't
really matter which monitor is used to get the value.
Also, the issue is that the measurements are in pixels, so if we convert
them into a resolution independent measurement then the rest of the
scaling in the AWT/2D will
P.S.: The behavior with Mac OS X mission control should also be checked
which is definitely a manual job (it seems to be strange sometimes; not
sure if buggy). So the test instructions should be appended a bit...
On 11/16/2015 3:24 PM, Alexander Stepanov wrote:
Hello Sergey,
Thank you for the
Hello Sergey,
Thank you for the notes.
> Do you have some thoughts why this test cannot be converted to auto test?
The following parts of the test scenario:
- "Please try to drag both parent and child, do it fast several times
and check if no artifacts occur." (not very valuable part of the t
Hi, Alexander.
109 AffineTransform tx = ((Graphics2D) g).getTransform();
110 int sw = tx.isIdentity() ? w : (int) Math.round(w *
tx.getScaleX());
111 int sh = tx.isIdentity() ? h : (int) Math.round(h *
tx.getScaleY());
I think that it is not necessary that !isIdentit
Dear All,
Please review the fix for JDK9,
Bug: https://bugs.openjdk.java.net/browse/JDK-8060137
Webrev: http://cr.openjdk.java.net/~arapte/8060137/webrev.00/
Issue:
1. Type any character in TextArea or TextField
2. Call setText
Hello,
Could you review the updated fix:
http://cr.openjdk.java.net/~alexsch/8076545/webrev.02
- round is used instead of ceil
- inverted scales are used
Thanks,
Alexandr.
On 10/30/2015 10:40 PM, Jim Graham wrote:
In this case round may be better. ceil() is more for cases wh
Hi, Alexander.
- Note that MultiRes image can be created at runtime, it will be good
to cover this also.
- Do you have some thoughts why this test cannot be converted to auto
test? Probably some api can be added to jdk to simplify creation of such
tests? like already added "-Dsun.java2d.uiScal
10 matches
Mail list logo
