Re: Review Request For 8149636: TextField flicker & over scroll when selection scrolls beyond the bounds of TextField.

2016-03-03 Thread Semyon Sadetsky
Hi Ambarish, the first point is not valid. Please, ignore it. --Semyon On 3/1/2016 11:14 AM, Semyon Sadetsky wrote: Hi Ambarish, - The over scroll remains after the proposed fix. - The bug is a regression of 7092551 and should be labeled correspondingly. - An automatic test may and

Re: Review request for 6734341 : REGTEST fails: SelectionAutoscrollTest.html

2016-03-03 Thread Vikrant Agarwal
Hi Semyon, Although the execution time of the previous version was shorter, but it was also failing many times, the extra execution time got introduced after repacing mouseMove() from java.awt.Robot with mouseMove() from test.java.awt.regtesthelpers.Util , this performes the mouse movement a

Re: [9] RFR for 8150724: [TEST] HiDPI: create a test for multiresolution icons

2016-03-03 Thread Sergey Bylokhov
Hi, Alexander. I suggest to add these lines to the test instead of replace the old lines. The test will pass after the fix for 8151060. On 03.03.16 17:45, Alexander Stepanov wrote: Could you please review the updated version of the test? http://cr.openjdk.java.net/~avstepan/8150724/webrev.01

Re: Review-request for 8143227: Platform-Specific Desktop Features

2016-03-03 Thread Sergey Bylokhov
In general the fix looks fine to me. All other cases can be covered via separate CRs. On 03.03.16 18:31, Alexander Zvegintsev wrote: Hi, CCC is now in final state. For these raised questions I filed following issues: https://bugs.openjdk.java.net/browse/JDK-8151184 [macosx] window does not

Re: Review-request for 8143227: Platform-Specific Desktop Features

2016-03-03 Thread Alexander Zvegintsev
I think that this fine is at is. Regarding permissions I filed the JDK-8151190 issue: https://bugs.openjdk.java.net/browse/JDK-8151190 Revise permissions for java.awt.Desktop and java.awt.Taskbar -- Thanks, Alexander. On 02/24/2016 08:12 PM, Sergey Bylokhov wrote: Small question about

Re: Review-request for 8143227: Platform-Specific Desktop Features

2016-03-03 Thread Alexander Zvegintsev
Hi, CCC is now in final state. For these raised questions I filed following issues: https://bugs.openjdk.java.net/browse/JDK-8151184 [macosx] window does not receive normal window events indicating the window is hidden https://bugs.openjdk.java.net/browse/JDK-8151189 Possible getAppContext()

Re: [9] RFR for 8150724: [TEST] HiDPI: create a test for multiresolution icons

2016-03-03 Thread Alexander Stepanov
Could you please review the updated version of the test? http://cr.openjdk.java.net/~avstepan/8150724/webrev.01 Line 106 tabbedPane.addTab("", icon, p); was replaced with 109 tabbedPane.addTab("", p); 110 tabbedPane.setTabComponentAt(0, new JLabel(icon)); - in such a

Re: Review request for 6734341 : REGTEST fails: SelectionAutoscrollTest.html

2016-03-03 Thread Semyon Sadetsky
Hi, Vikrant, I ran the new test version on Windows. It's execution time is about 20 seconds while the previous version was instant. Is that expected? --Semyon On 2/26/2016 3:53 PM, Vikrant Agarwal wrote: Hi Sergey, I have updated the test to a standalone test. Updated Webrev:

Re: [9] Review request for JDK-8145174 HiDPI splash screen support on Linux

2016-03-03 Thread Sergey Bylokhov
In general it looks fine to me. I will try to patch my local ws and run some sanity test. On 03.03.16 8:51, Rajeev Chamyal wrote: Hello All, Please review the updated webrev. Added a free call for duplicate file name in splashscreen_sys.c :: SplashGetScaledImageName

Re: [9] Review request for JDK-8145173 HiDPI splash screen support on Windows

2016-03-03 Thread Sergey Bylokhov
In general it looks fine to me. I will try to patch my local ws and run some sanity test. On 03.03.16 8:50, Rajeev Chamyal wrote: Hello All, Please review the updated webrev. Added a free call for duplicate file name in splashscreen_sys.c :: SplashGetScaledImageName