Hi Ramesh,
The fix looks fine to me.
Regards,
Ambarish
From: Ramesh Gangadhar
Sent: Wednesday, May 04, 2016 8:27 PM
To: awt-dev@openjdk.java.net
Subject: FW: Review Request for 8027154: Test
java/awt/Mouse/GetMousePositionTest/GetMousePositionWithPopup.java fails
Why doesn't the test need now
@modules java.desktop/sun.awt
?
-phil.
On 5/11/16, 2:59 PM, Mandy Chung wrote:
On May 11, 2016, at 2:55 PM, Alexander
Scherbatiy wrote:
On 12/05/16 01:50, Phil Race wrote:
Alexander ... I am concurrently deleting GThreadHelper (see webrev I just sent
out)
whi
> On May 11, 2016, at 2:55 PM, Alexander Scherbatiy
> wrote:
>
> On 12/05/16 01:50, Phil Race wrote:
>> Alexander ... I am concurrently deleting GThreadHelper (see webrev I just
>> sent out)
>> which is covered by a separate bug so please revert that part of the fix.
>
> Sorry. Here is the u
On 12/05/16 01:50, Phil Race wrote:
Alexander ... I am concurrently deleting GThreadHelper (see webrev I
just sent out)
which is covered by a separate bug so please revert that part of the
fix.
Sorry. Here is the updated fix where only SoftCache is moved to the
java.desktop module and the
Alexander ... I am concurrently deleting GThreadHelper (see webrev I
just sent out)
which is covered by a separate bug so please revert that part of the fix.
-phil.
On 5/11/2016 2:43 PM, Alexander Scherbatiy wrote:
Hello,
Could you review the updated fix:
http://cr.openjdk.java.net/~alexs
Bug: http://cr.openjdk.java.net/~prr/8154546/
Webrev: http://cr.openjdk.java.net/~prr/8154546/
The options were move this or delete it.
There is some discussion in the bug report about GLIB versions
but the only client of it was FX and that no longer uses the class
as it supports only newer Linux
Hello,
Could you review the updated fix:
http://cr.openjdk.java.net/~alexsch/8154539/webrev.01
- The test/com/sun/jdi/ReferrersTest.java test is updated to use
sun.awt.SoftCache
- The sun.misc.GThreadHelper class is moved to the sun.awt package in
the java.desktop module
The jdk.uns
+1 assuming this is really the only use ..
You are updating the module-info and although there is one other class
in there used
by java.desktop that is OK I believe since it is only used from JNI.
Also I will be sending out a webrev for that one soon.
We should some day revisit whether this fu
On 11 May 2016, at 21:15, Mandy Chung wrote:
>
>> On May 11, 2016, at 1:07 PM, Alexander Scherbatiy
>> wrote:
>>
>>
>> Hello,
>>
>> Could you review the fix:
>> bug: https://bugs.openjdk.java.net/browse/JDK-8154539
>> webrev: http://cr.openjdk.java.net/~alexsch/8154539/webrev.00
>>
>> Thi
> On May 11, 2016, at 1:07 PM, Alexander Scherbatiy
> wrote:
>
>
> Hello,
>
> Could you review the fix:
> bug: https://bugs.openjdk.java.net/browse/JDK-8154539
> webrev: http://cr.openjdk.java.net/~alexsch/8154539/webrev.00
>
> This is a request from the jigsaw team to get rid of the depe
Hello,
Could you review the fix:
bug: https://bugs.openjdk.java.net/browse/JDK-8154539
webrev: http://cr.openjdk.java.net/~alexsch/8154539/webrev.00
This is a request from the jigsaw team to get rid of the dependency
to jdk.unsupported module from the java.desktop module.
The fix moves
Hi Sergey,
1. Dialog background color set to SystemColor.control.
2. WWindowPeer extends WPanelPeer, WPanelPeer Initialize() method is called
Before we initialize default properties like background/foreground in
WWindowPeer, hence getBackground/getForeground calls in WPanelPeer Initialize()
me
I cannot reproduce the problem with a build from Dmitry and with a clean
build with a patch for jdk8u-dev from Dmitry.
Thank you,
Denis.
On Thu, May 5, 2016 at 2:59 PM, Denis Fokin wrote:
> Hi AWT team,
>
> I used the next test to reproduce the problem
>
> = OwnedWindowTest.java =
13 matches
Mail list logo