Re: FW: Review Request for 8027154: Test java/awt/Mouse/GetMousePositionTest/GetMousePositionWithPopup.java fails

2016-05-11 Thread Ambarish Rapte
Hi Ramesh, The fix looks fine to me. Regards, Ambarish From: Ramesh Gangadhar Sent: Wednesday, May 04, 2016 8:27 PM To: awt-dev@openjdk.java.net Subject: FW: Review Request for 8027154: Test java/awt/Mouse/GetMousePositionTest/GetMousePositionWithPopup.java fails

Re: [9] Review request for 8154539 Examine the desktop module's use of sun.misc.SoftCache

2016-05-11 Thread Philip Race
Why doesn't the test need now @modules java.desktop/sun.awt ? -phil. On 5/11/16, 2:59 PM, Mandy Chung wrote: On May 11, 2016, at 2:55 PM, Alexander Scherbatiy wrote: On 12/05/16 01:50, Phil Race wrote: Alexander ... I am concurrently deleting GThreadHelper (see webrev I just sent out) whi

Re: [9] Review request for 8154539 Examine the desktop module's use of sun.misc.SoftCache

2016-05-11 Thread Mandy Chung
> On May 11, 2016, at 2:55 PM, Alexander Scherbatiy > wrote: > > On 12/05/16 01:50, Phil Race wrote: >> Alexander ... I am concurrently deleting GThreadHelper (see webrev I just >> sent out) >> which is covered by a separate bug so please revert that part of the fix. > > Sorry. Here is the u

Re: [9] Review request for 8154539 Examine the desktop module's use of sun.misc.SoftCache

2016-05-11 Thread Alexander Scherbatiy
On 12/05/16 01:50, Phil Race wrote: Alexander ... I am concurrently deleting GThreadHelper (see webrev I just sent out) which is covered by a separate bug so please revert that part of the fix. Sorry. Here is the updated fix where only SoftCache is moved to the java.desktop module and the

Re: [9] Review request for 8154539 Examine the desktop module's use of sun.misc.SoftCache

2016-05-11 Thread Phil Race
Alexander ... I am concurrently deleting GThreadHelper (see webrev I just sent out) which is covered by a separate bug so please revert that part of the fix. -phil. On 5/11/2016 2:43 PM, Alexander Scherbatiy wrote: Hello, Could you review the updated fix: http://cr.openjdk.java.net/~alexs

RFR: 8154546: Retire sun.misc.GThreadHelper

2016-05-11 Thread Phil Race
Bug: http://cr.openjdk.java.net/~prr/8154546/ Webrev: http://cr.openjdk.java.net/~prr/8154546/ The options were move this or delete it. There is some discussion in the bug report about GLIB versions but the only client of it was FX and that no longer uses the class as it supports only newer Linux

Re: [9] Review request for 8154539 Examine the desktop module's use of sun.misc.SoftCache

2016-05-11 Thread Alexander Scherbatiy
Hello, Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8154539/webrev.01 - The test/com/sun/jdi/ReferrersTest.java test is updated to use sun.awt.SoftCache - The sun.misc.GThreadHelper class is moved to the sun.awt package in the java.desktop module The jdk.uns

Re: [9] Review request for 8154539 Examine the desktop module's use of sun.misc.SoftCache

2016-05-11 Thread Phil Race
+1 assuming this is really the only use .. You are updating the module-info and although there is one other class in there used by java.desktop that is OK I believe since it is only used from JNI. Also I will be sending out a webrev for that one soon. We should some day revisit whether this fu

Re: [9] Review request for 8154539 Examine the desktop module's use of sun.misc.SoftCache

2016-05-11 Thread Chris Hegarty
On 11 May 2016, at 21:15, Mandy Chung wrote: > >> On May 11, 2016, at 1:07 PM, Alexander Scherbatiy >> wrote: >> >> >> Hello, >> >> Could you review the fix: >> bug: https://bugs.openjdk.java.net/browse/JDK-8154539 >> webrev: http://cr.openjdk.java.net/~alexsch/8154539/webrev.00 >> >> Thi

Re: [9] Review request for 8154539 Examine the desktop module's use of sun.misc.SoftCache

2016-05-11 Thread Mandy Chung
> On May 11, 2016, at 1:07 PM, Alexander Scherbatiy > wrote: > > > Hello, > > Could you review the fix: > bug: https://bugs.openjdk.java.net/browse/JDK-8154539 > webrev: http://cr.openjdk.java.net/~alexsch/8154539/webrev.00 > > This is a request from the jigsaw team to get rid of the depe

[9] Review request for 8154539 Examine the desktop module's use of sun.misc.SoftCache

2016-05-11 Thread Alexander Scherbatiy
Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8154539 webrev: http://cr.openjdk.java.net/~alexsch/8154539/webrev.00 This is a request from the jigsaw team to get rid of the dependency to jdk.unsupported module from the java.desktop module. The fix moves

Re: Review Request for 8057574 : inconsistent behavior for setBackground (Windows/Linux)

2016-05-11 Thread Prem Balakrishnan
Hi Sergey, 1. Dialog background color set to SystemColor.control. 2. WWindowPeer extends WPanelPeer, WPanelPeer Initialize() method is called Before we initialize default properties like background/foreground in WWindowPeer, hence getBackground/getForeground calls in WPanelPeer Initialize() me

Re: [9] Review request for 8080729: [macosx] java 7 and 8 JDialogs on multiscreen jump to parent frame on focus

2016-05-11 Thread Denis Fokin
I cannot reproduce the problem with a build from Dmitry and with a clean build with a patch for jdk8u-dev from Dmitry. Thank you, Denis. On Thu, May 5, 2016 at 2:59 PM, Denis Fokin wrote: > Hi AWT team, > > I used the next test to reproduce the problem > > = OwnedWindowTest.java =