Re: [9] Review Request JDK-8151787 Unify the HiDPI splash screen image naming convention

Hello Alexandr, Please review the updated webrev. http://cr.openjdk.java.net/~rchamyal/8151787/webrev.05/ Regards, Rajeev Chamyal -Original Message- From: Alexandr Scherbatiy Sent: 25 August 2016 22:07 To: Rajeev Chamyal; Philip Race Cc: awt-dev@openjdk.java.net; Sergey Bylokhov Subject

[9] Review request 8155083: On Windows, usage of USER_ATTENTION_WINDOW depends on state setting order

Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8155083/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8155083 With current implementation we are showing initially iconified window with SW_SHOWMINIMIZED flag, it activates the window, FlashWindowEx doesn't

Re: [9] Review Request JDK-8151787 Unify the HiDPI splash screen image naming convention

Hello Alexandr, As per the mail link the procedure is applicable for JEPs and small enhancements. http://mail.openjdk.java.net/pipermail/jdk9-dev/2016-June/004443.html But the issue under review is a bug. Regards, Rajeev Chamyal -Original Message- From: Alexandr Scherbatiy Sent: 25 Aug

Re: [9] Review Request JDK-8151787 Unify the HiDPI splash screen image naming convention

Hi Rajeev, You need to follow the following procedure for issues which require CCC request: http://mail.openjdk.java.net/pipermail/jdk9-dev/2016-June/004443.html - add jdk9-fc-request label to the JBS issue - update the JBS issue to add a comment whose first line is "FC Extension Request" -

Re: [9] Review Request JDK-8151787 Unify the HiDPI splash screen image naming convention

On 8/22/2016 2:13 PM, Rajeev Chamyal wrote: Hello Phil, Thanks for the review, Please review updated webrev. http://cr.openjdk.java.net/~rchamyal/8151787/webrev.04/ Updated files: src/java.base/share/classes/sun/launcher/resources/launcher.properties src/java.desktop/macosx/native/libsplashscree

Re: Review Request for 8160056: TextField.setText breaks the contract of EOL

The fix looks good to me. Thanks, Alexandr. On 8/16/2016 1:16 PM, Ambarish Rapte wrote: Hi, Please review the change for JDK9, Bug: https://bugs.openjdk.java.net/browse/JDK-8160056 Webrev: http://cr.openjdk.java.net/~arapte/8160056/webrev.00/

Re: [9] Review Request JDK-8151787 Unify the HiDPI splash screen image naming convention

Hello Phil, Please review the updated webrev. http://cr.openjdk.java.net/~rchamyal/8151787/webrev.04/ Regards, Rajeev Chamyal -Original Message- From: Rajeev Chamyal Sent: 22 August 2016 16:44 To: Philip Race Cc: awt-dev@openjdk.java.net; Sergey Bylokhov; Alexander Scherbatiy Subject: R

Re: [9] Review request for 8050478: [macosx] Cursor not updating correctly after closing a modal dialog

Hi Sergey, I have updated the fix based on your suggestion, (i.e. add a new method). Please find a new version here: http://cr.openjdk.java.net/~dmarkov/8050478/webrev.01/ Thanks, Dmitry > On 24 Aug 2016, at 18:27, Sergey Bylokhov wrot