Re: RFR:8168316: Suppress deprecation warnings for Applet classes in java.desktop

2016-10-20 Thread Sergey Bylokhov
On 20.10.16 1:14, Philip Race wrote: Well maybe but this isn't about adding deprecations it is just about of getting rid of warnings for uses of APIs that are already deprecated. I though that if the code marked as deprecated is used inside deprecated method then this warning is not occurred,

AWT cleanup?

2016-10-20 Thread Chris
While working on SkinJob, I ran IntelliJ's Code Inspector tool over OpenJDK AWT, and I found lots of room for improvement, much of which could be automated. Unused imports and weird indentation are the order of the day. Raw types are often used in place of generics, leading to a lot of unnecessary

SkinJob: AWT on Android

2016-10-20 Thread Chris
Hi all, I've started work on Project SkinJob ( https://github.com/RedstoneValley/skinjob), an Android implementation of AWT that wraps the Android graphics APIs and is forked from OpenJDK AWT. (Because the Android APIs are as high-level as AWT, SkinJob won't need any native code or more than a

Re: [9] Review request for 8154434: Open the request focus methods of the java.awt.Component which accept FocusEvent.Cause

2016-10-20 Thread Anton Tarasov
Hi all, The changes look fine to me. On 4/26/2016 3:49 PM, Philip Race wrote: > In applications one may need to know the reason why focus is requested I do not mean why should apps want to *know* the cause. I am asking why apps should be able to *specify* the cause as proposed by this

Re: [9] RFR for 8159454: [TEST_BUG] javax/swing/ToolTipManager/7123767/bug7123767.java: number of checked graphics configurations should be limited

2016-10-20 Thread Yuri Nesterenko
+1 -yan On 10/20/2016 01:35 PM, Alexander Stepanov wrote: Hello Sergey, Please see the updated webrev: http://cr.openjdk.java.net/~avstepan/8159454/webrev.01/ Thanks, Alexander P.S.: there is no guarantee that CONFIGS does not contain repeating GCs, but hopefully this is not very important.

Re: [9] RFR for 8159454: [TEST_BUG] javax/swing/ToolTipManager/7123767/bug7123767.java: number of checked graphics configurations should be limited

2016-10-20 Thread Alexander Stepanov
Thanks! On 10/20/2016 1:58 PM, Sergey Bylokhov wrote: Loos fine. On 20.10.16 13:35, Alexander Stepanov wrote: Hello Sergey, Please see the updated webrev: http://cr.openjdk.java.net/~avstepan/8159454/webrev.01/ Thanks, Alexander P.S.: there is no guarantee that CONFIGS does not contain

Re: [9] RFR for 8159454: [TEST_BUG] javax/swing/ToolTipManager/7123767/bug7123767.java: number of checked graphics configurations should be limited

2016-10-20 Thread Sergey Bylokhov
Loos fine. On 20.10.16 13:35, Alexander Stepanov wrote: Hello Sergey, Please see the updated webrev: http://cr.openjdk.java.net/~avstepan/8159454/webrev.01/ Thanks, Alexander P.S.: there is no guarantee that CONFIGS does not contain repeating GCs, but hopefully this is not very important.

Re: [9] RFR for 8159454: [TEST_BUG] javax/swing/ToolTipManager/7123767/bug7123767.java: number of checked graphics configurations should be limited

2016-10-20 Thread Alexander Stepanov
Hello Sergey, Please see the updated webrev: http://cr.openjdk.java.net/~avstepan/8159454/webrev.01/ Thanks, Alexander P.S.: there is no guarantee that CONFIGS does not contain repeating GCs, but hopefully this is not very important. On 10/19/2016 7:43 PM, Sergey Bylokhov wrote: Hi,

Review Request : JDK-8168292 [TestBug]Test java/awt/TrayIcon/DragEventSource/DragEventSource.java fails on OS X

2016-10-20 Thread Prem Balakrishnan
Hi, Please review the patch. Test Bug: https://bugs.openjdk.java.net/browse/JDK-8168292 Webrev: http://cr.openjdk.java.net/~pkbalakr/8168292/webrev.00/ Compilation error: Can't find library\: ../../../regtesthelpers Fix: updated the library path Regards, Prem

Re: [9] Review Request: 8143077 Deprecate InputEvent._MASK in favor of InputEvent._DOWN_MASK

2016-10-20 Thread Semyon Sadetsky
On 19.10.2016 17:43, Sergey Bylokhov wrote: On 19.10.16 9:58, Semyon Sadetsky wrote: On 17.10.16 21:47, Semyon Sadetsky wrote: It can be replaced if it will be used in pair with getModifiersEx(). The old getModifiers() is also deprecated. And javadoc for getModifiersEx() describes what and

Re: [9] Review request for 8163101: dual-screen issue with JMenu, JPopupMenu

2016-10-20 Thread Semyon Sadetsky
On 19.10.2016 18:26, Sergey Bylokhov wrote: On 17.10.16 10:35, Semyon Sadetsky wrote: It should not be closed as not a bug, the location of the popus should be recalculated based on the GC size. As I already explain to you it should be a separate bug. GC is assumed to be changed when window