On 17/10/2017 04:48, Pankaj Bansal wrote:
I can see that XDragSourceContextPeer.java also contains ScaleUp and ScaleDown
functions, but I don't see them being called from anywhere. So have not made
changes in the same.
Looks like XDragSourceContextPeer.scaleUp() is unused, but scaleDown()
is
This class which is concrete - not abstract - would have been better
called "BasicMultiResolutionImage"
I do think I have issues with the documentation on this class and some
aspects of
its behaviour that should be documented and implemented, but I don't
think we should
try to make it somethi
Hi Semyon,
On 06/10/2017 21:33, Semyon Sadetsky wrote:
Hi Alexey,
On 10/06/2017 11:42 AM, Alexey Ivanov wrote:
Hi Semyon, Sergey,
On 30/09/2017 00:08, Semyon Sadetsky wrote:
On 9/29/2017 3:15 PM, Sergey Bylokhov wrote:
On 9/29/17 12:39, Semyon Sadetsky wrote:
Why 128 pixels? Windows shell u
Hi Sergey, Semyon,
On 12/10/2017 21:39, Sergey Bylokhov wrote:
On 06/10/2017 17:16, Semyon Sadetsky wrote:
The maximum icon which we used before you fix is 32pixel's icon(yes
it is a large icon), and 128 is a size of this icon on 4k monitor(
The windows can return a 128pixel's icon on 4k monit
Hi Ajit,
Thank you for the information. I ran SwingSet under GTK2. No issues found.
--Semyon
On 10/16/2017 09:41 PM, Ajit Ghaisas wrote:
Hi Semyon,
I had attempted this fix some time back and had run into some regression
for SwingSet2.
There was a crash while using SwingSet2 with G
Hi Sergey,
On 10/16/2017 04:45 PM, Sergey Bylokhov wrote:
Hi, Semyon.
A few notes:> I ran OGL tests and found a typo. Below the update
webrev> http://cr.openjdk.java.net/~ssadetsky/8074824/webrev.01/
- What is a typo? It seems the v0 and v1 are identical.
It's in line 516 of the OGLPaints.c
Hi Sergey,
Yes, similar changes have to be made in XToolkit also. What happens in XToolkit
is that after the int overflow, when garbage width and height is passed to
XCreateWindow, it handles it properly at its own end. So the test passes
without any fix also. But the into overflow should not h
Thank you Sergey and Alex,
I will update @bugid in the test before push.
Regards,
Manajit
> On 17-Oct-2017, at 2:37 PM, Alexander Zvegintsev
> wrote:
>
> +1
>
> Thanks,
> Alexander.
>
> On 17/10/2017 03:12, Sergey Bylokhov wrote:
>> Looks fine.
>> Please update the @bugid in the test befor
+1
Thanks,
Alexander.
On 17/10/2017 03:12, Sergey Bylokhov wrote:
Looks fine.
Please update the @bugid in the test before the push.
On 16/10/2017 06:38, Manajit Halder wrote:
Hi All,
Kindly review the fix for JDK10.
Bug:
https://bugs.openjdk.java.net/browse/JDK-8163265
Webrev:
http://cr.op
