Looks good to me.
-Pankaj
-Original Message-
From: Sergey Bylokhov
Sent: Thursday, November 29, 2018 3:26 AM
To: Krishna Addepalli; Alexey Ivanov; awt-dev
Subject: Re: [12]RFR: JDK-8213048: Invalid use of HTML5 in java.awt
files
Looks fine.
> Perhaps, addressing them in separate bug i
Not something we want to do if there's any way out of it.
can we just disable PNG_SET_OPTION_SUPPORTED in
pnglibconfig.h which is something that is "generated" and not part of
the png source ?
I don't see anything that is important enabled by that option.
-phil.
On 11/28/18, 3:38 PM, Erik J
Looks ok to me if we are fine with making changes to libpng source. I
thought this was usually not something we wanted to do with upstream
sources.
/Erik
On 2018-11-28 15:11, Sergey Bylokhov wrote:
Hello.
Please review the fix for jdk 12.
Bug: https://bugs.openjdk.java.net/browse/JDK-8212680
Not a review yet but the Solaris folks reported such a problem in Feb 2017
and the theory then was that they had zlib-ng, not regular zlib :
http://log.irc.tymoon.eu/freenode/thcrap?around=2016-11-29T02:13:40&types=mnaot
There, it recently introduced a function named inflateValidate(), and
Hi, Matthias.
Do we need the null check in the fix, if "yes" then probably
the same check should be added before this line as well?
465 env->ReleaseLongArrayElements(formats, saveFormats, 0);
On 28/11/2018 00:33, Baesken, Matthias wrote:
Hello, please review this small fix.
It adds a mi
Hello.
Please review the fix for jdk 12.
Bug: https://bugs.openjdk.java.net/browse/JDK-8212680
Webrev: http://cr.openjdk.java.net/~serb/8212680/webrev.00
On Solaris we faced the bug which was fixed in macOS already:
https://bugs.openjdk.java.net/browse/JDK-8196803
The problem is that there is
+1
On 26/11/2018 02:56, Alexey Ivanov wrote:
Hi Dmitry,
The fix looks fine to me.
Regards,
Alexey
On 26/11/2018 10:38, Dmitry Markov wrote:
Hello,
Could you review a fix for jdk12, please?
bug: https://bugs.openjdk.java.net/browse/JDK-8213583
webrev: http://cr.openjdk.java.net/~dmarkov/821
Looks fine.
Perhaps, addressing them in separate bug is better
Yes, it will be good to fix it.
--
Best regards, Sergey.
Hi, Dmitry.
Can you please clarify why the invisible children affect this behavior?
Is it possible that some of the invisible child(which we skip after the fix)
will have visible child window?
On 22/11/2018 06:43, Dmitry Markov wrote:
Hi Sergey,
I am sorry, but the problem is not related to p
Hi Alexey, Sergey,
Thanks for your suggestions. I have removed the tag and also removed the
style header from DesktopProperties.html.
I have removed the commented out lines and empty tags as well from
Modality.html, but have not changed anything else as suggested by Alexey.
Perhaps, addressing
Hello, please review this small fix.
It adds a missing ReleaseLongArrayElements to
void AwtDragSource::LoadCache(jlongArray formats)
in an early special "pseudo return" (leave function via throw) case.
Webrev/bug :
http://cr.openjdk.java.net/~mbaesken/webrevs/8214380.0/
https://bugs.o
11 matches
Mail list logo
