EA8 build of Project Lanai (Java 2D Metal rendering pipeline for macOS) is now posted

2020-12-16 Thread Philip Race
The EA 8 build of Project Lanai [1] was posted today at https://jdk.java.net/lanai/ EA 8 Build 17-lanai+1-2 (2020/12/12) Please do give it a try (-Dsun.java2d.metal=true) and let us know of issues. One particular request : To anyone who has a mac still running 10.12 - we don't expect Metal t

Re: RFR: 8256109: Create implementation for NSAccessibilityButton protocol [v2]

2020-12-16 Thread Pankaj Bansal
On Wed, 16 Dec 2020 18:03:19 GMT, Alexander Zuev wrote: >> Creating a native peer for pushbutton accessibility role on Max OS X. >> The process of choosing of what peer to initialize is clunky so >> might be addressed in the future. > > Alexander Zuev has updated the pull request incrementally wi

Re: [jdk16] RFR: 8255880: UI of Swing components is not redrawn after their internal state changed

2020-12-16 Thread Anton Litvinov
On Wed, 16 Dec 2020 19:46:57 GMT, Phil Race wrote: >> Hello, >> >> This is a review request for straight back port of the fix for the bug >> JDK-8255880 from JDK 17 to JDK 16, which is currently in RDP 1 phase. The >> fix was tested and the regression test was executed on MS Windows OS, Linux

[jdk16] Integrated: 8255880: UI of Swing components is not redrawn after their internal state changed

2020-12-16 Thread Anton Litvinov
On Wed, 16 Dec 2020 19:37:23 GMT, Anton Litvinov wrote: > Hello, > > This is a review request for straight back port of the fix for the bug > JDK-8255880 from JDK 17 to JDK 16, which is currently in RDP 1 phase. The fix > was tested and the regression test was executed on MS Windows OS, Linux

Re: [jdk16] RFR: 8255880: UI of Swing components is not redrawn after their internal state changed

2020-12-16 Thread Phil Race
On Wed, 16 Dec 2020 19:37:23 GMT, Anton Litvinov wrote: > Hello, > > This is a review request for straight back port of the fix for the bug > JDK-8255880 from JDK 17 to JDK 16, which is currently in RDP 1 phase. The fix > was tested and the regression test was executed on MS Windows OS, Linux

[jdk16] RFR: 8255880: UI of Swing components is not redrawn after their internal state changed

2020-12-16 Thread Anton Litvinov
Hello, This is a review request for straight back port of the fix for the bug JDK-8255880 from JDK 17 to JDK 16, which is currently in RDP 1 phase. The fix was tested and the regression test was executed on MS Windows OS, Linux OS, macOS. Thank you, Anton - Commit messages: - Ba

Re: RFR: 8254850: Update terminology in java.awt.GridBagLayout source code comments [v2]

2020-12-16 Thread Phil Race
> This is part of an effort in the JDK to replace archaic/non-inclusive words > with more neutral terms. > See JDK-8253315 for details. > > This updates a few comments in GridBagLayout to use the terms parent and > child which are > sufficiently descriptive and consistent with lots of other usa

Re: RFR: 8254850: Update terminology in java.awt.GridBagLayout source code comments [v2]

2020-12-16 Thread Phil Race
On Tue, 15 Dec 2020 19:10:45 GMT, Kevin Rushforth wrote: >> Phil Race has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8254850: Update terminology in java.awt.GridBagLayout source code comments > > src/java.desktop/share/classes/java/awt/

Re: RFR: 8256109: Create implementation for NSAccessibilityButton protocol [v2]

2020-12-16 Thread Phil Race
On Wed, 16 Dec 2020 18:03:19 GMT, Alexander Zuev wrote: >> Creating a native peer for pushbutton accessibility role on Max OS X. >> The process of choosing of what peer to initialize is clunky so >> might be addressed in the future. > > Alexander Zuev has updated the pull request incrementally wi

Re: RFR: 8256109: Create implementation for NSAccessibilityButton protocol [v2]

2020-12-16 Thread Alexander Zuev
> Creating a native peer for pushbutton accessibility role on Max OS X. > The process of choosing of what peer to initialize is clunky so > might be addressed in the future. Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision: Moved the

Re: RFR: 8256109: Create implementation for NSAccessibilityButton protocol

2020-12-16 Thread Alexander Zuev
On Fri, 4 Dec 2020 02:49:07 GMT, Sergey Bylokhov wrote: > Maybe it is better to change the used file hierarchy? That probably a good idea. Uploading a new fix version. - PR: https://git.openjdk.java.net/jdk/pull/1549

Re: RFR: 8256109: Create implementation for NSAccessibilityButton protocol [v2]

2020-12-16 Thread Alexander Zuev
On Fri, 4 Dec 2020 02:51:19 GMT, Sergey Bylokhov wrote: >> Alexander Zuev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Moved the new components implementations to the separate files. >> Changed the iitialization procedure to a class

Re: RFR: 8258006: Replaces while cycles with iterator with enhanced for in java.desktop [v2]

2020-12-16 Thread Phil Race
On Tue, 15 Dec 2020 15:24:03 GMT, Andrey Turbanov wrote: >> There are few places in code where manual `while` loop is used with >> `Iterator` to iterate over `Collection`. >> Instead of manual `while` cycles it's preferred to use _enhanced-for_ cycle >> instead: it's less verbose, makes code e

Re: RFR: 8258006: Replaces while cycles with iterator with enhanced for in java.desktop

2020-12-16 Thread Andrey Turbanov
On Wed, 16 Dec 2020 14:59:45 GMT, Andrey Turbanov wrote: >> These tests more or less *never* fail so how are you sure it is not your >> changes ? >> And 8 beans tests failed and you made 3 changes in beans code so I'd like to >> see some evidence >> to show these failures are unrelated and an

Re: RFR: 8258006: Replaces while cycles with iterator with enhanced for in java.desktop

2020-12-16 Thread Andrey Turbanov
On Tue, 15 Dec 2020 21:14:08 GMT, Phil Race wrote: >> I've run `test-tier3`. 15 tests failed. Looks like they are not related to >> my changes: >> >> JT Harness : Tests that failed >> Tests are grouped by their final status message. >> Execution failed: `main' threw exception: TestF

Re: RFR: 8254024: Enhance native libs for AWT and Swing to work with GraalVM Native Image [v3]

2020-12-16 Thread Vojin Jovanovic
On Tue, 15 Dec 2020 21:20:16 GMT, Bob Vandette wrote: >> Andrii Rodionov has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains one commit: >> >> 8254024: Enhance native libs for AWT and Swing to work with GraalVM Native >> Image > >