Re: RFR: 8247370: Clean up unused printing code in awt_PrintJob.cpp

2021-03-18 Thread Prasanta Sadhukhan
On Thu, 18 Mar 2021 22:59:57 GMT, Phil Race wrote: > This removes a long time un-used code path. Maybe we should put noreg-cleanup in JBS. - Marked as reviewed by psadhukhan (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/3083

Re: RFR: 8247370: Clean up unused printing code in awt_PrintJob.cpp

2021-03-18 Thread Sergey Bylokhov
On Thu, 18 Mar 2021 22:59:57 GMT, Phil Race wrote: > This removes a long time un-used code path. Marked as reviewed by serb (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/3083

Re: Legacy Apple com.apple.eio.FileManager (in module java.desktop) removed at jdk 16?

2021-03-18 Thread Michael Hall
> On Mar 18, 2021, at 6:35 PM, Philip Race wrote: > > Many of the com.apple APIs were obsoleted in JDK 9 with > http://openjdk.java.net/jeps/272 > > We (you and I) even discussed this and the absence from there of FileManager > 3 1/2 years ago >

Re: Legacy Apple com.apple.eio.FileManager (in module java.desktop) removed at jdk 16?

2021-03-18 Thread Philip Race
Many of the com.apple APIs were obsoleted in JDK 9 with http://openjdk.java.net/jeps/272 We (you and I) even discussed this and the absence from there of FileManager 3 1/2 years ago https://mail.openjdk.java.net/pipermail/awt-dev/2017-September/013120.html It was left off that you wrote here

Re: Legacy Apple com.apple.eio.FileManager (in module java.desktop) removed at jdk 16?

2021-03-18 Thread Michael Hall
> On Mar 18, 2021, at 6:13 PM, Alan Snyder wrote: > > I use moveToTrash and revealInFinder, but only with JDK 8. In later JDKs I > use Desktop.moveToTrash and browseFileDirectory. > Desktop eliminated the need for some of the FileManager code. I use findFolder to try and determine

Re: Legacy Apple com.apple.eio.FileManager (in module java.desktop) removed at jdk 16?

2021-03-18 Thread Alan Snyder
I use moveToTrash and revealInFinder, but only with JDK 8. In later JDKs I use Desktop.moveToTrash and browseFileDirectory. > On Mar 18, 2021, at 2:20 PM, Michael Hall wrote: > > > >> On Mar 18, 2021, at 3:29 PM, Philip Race wrote: >> >> I think this is because of

RFR: 8247370: Clean up unused printing code in awt_PrintJob.cpp

2021-03-18 Thread Phil Race
This removes a long time un-used code path. - Commit messages: - 8247370: Clean up unused printing code in awt_PrintJob.cpp Changes: https://git.openjdk.java.net/jdk/pull/3083/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=3083=00 Issue:

Re: RFR: 8261785: Calling "main" method in anonymous nested class crashes the JVM [v3]

2021-03-18 Thread Sergey Bylokhov
On Wed, 17 Mar 2021 00:57:24 GMT, Henry Jen wrote: >> This patch ensure launcher won't crash JVM for the new static Methods from >> local/anonymous class on MacOS. >> >> As @dholmes-ora pointed out in the analysis, this is a MacOS specific bug >> when the launcher trying to grab class name to

Re: Legacy Apple com.apple.eio.FileManager (in module java.desktop) removed at jdk 16?

2021-03-18 Thread Michael Hall
> On Mar 18, 2021, at 3:29 PM, Philip Race wrote: > > I think this is because of https://bugs.openjdk.java.net/browse/JDK-8256299 > > JDK 16 release notes here : http://jdk.java.net/16/release-notes > I think I ran into a couple related issues. I had a check to see if default Toolkit

Re: Legacy Apple com.apple.eio.FileManager (in module java.desktop) removed at jdk 16?

2021-03-18 Thread Philip Race
I think this is because of https://bugs.openjdk.java.net/browse/JDK-8256299 JDK 16   release notes here : http://jdk.java.net/16/release-notes -phil On 3/18/21 1:07 PM, Michael Hall wrote: If I remember correctly this group ended up the keepers of this code. If that is not right please point

Legacy Apple com.apple.eio.FileManager (in module java.desktop) removed at jdk 16?

2021-03-18 Thread Michael Hall
If I remember correctly this group ended up the keepers of this code. If that is not right please point me to the correct group. I am getting… Exception in thread "main" java.lang.IllegalAccessError: class us.hall.osx.OSXApplication (in unnamed module @0x2a5ca609) cannot access class

Integrated: 8261352: Create implementation for component peer for all the components who should be ignored in a11y interactions

2021-03-18 Thread Alexander Zuev
On Mon, 15 Mar 2021 17:21:01 GMT, Alexander Zuev wrote: > Initial implementation > Moved the CAccessibility ignore list initialization to the new code > Some cleanup > Expose a new API - isAccessibilityElement instead of deprecated > accessibilityIsIgnored This pull request has now been

Integrated: 8263311: Watch registry changes for remote printers update instead of polling

2021-03-18 Thread Alexey Ivanov
On Wed, 10 Mar 2021 15:38:27 GMT, Alexey Ivanov wrote: > [JDK-8153732](https://bugs.openjdk.java.net/browse/JDK-8153732) implemented > polling for remote printers. > That bug description also mentions watching the registry for changes and > links to the article which describes the method yet

Re: RFR: 8262470: Printed GlyphVector outline with low DPI has bad quality on Windows [v2]

2021-03-18 Thread Alexander Scherbatiy
> Printing text using GlyphVector outline has bad quality on printers with low > DPI on Windows. > The GDI system used for text printing on Windows accepts only integer path > coordinates. > Rounding GlyphVector outline coordinates leads to distorted printed text. > > The issue had been

Re: RFR: 8262470: Printed GlyphVector outline with low DPI has bad quality on Windows [v2]

2021-03-18 Thread Alexander Scherbatiy
On Wed, 10 Mar 2021 09:31:32 GMT, Prasanta Sadhukhan wrote: >> Alexander Scherbatiy has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Use DASSERT to check SetGraphicsMode and WorldTransform results >> - Change setGraphicsMode() type