Re: [9] Review Request: 8132355 Incorrect guard block in HPkeysym.h, awt_Event.h

+1 On 27.07.2015 15:16, Alexander Zvegintsev wrote: Looks fine. Thanks, Alexander. On 07/27/2015 02:36 PM, Sergey Bylokhov wrote: Hello. Please review the fix for a typo in jdk9. The HPkeysym.h is from external library, so I have filed the bug in upstream too: https://bugs.freedesktop.org/s

Re: [8u-dev] Review request for 8130776: Remove EmbeddedFrame.requestFocusToEmbedder() method

Looks fine to me. Regards, Anton. On 23.07.2015 17:09, Alexey Ivanov wrote: Hello AWT team, Could you please review the backport of JDK-8130776 to jdk8u-dev: http://cr.openjdk.java.net/~aivanov/8130776/jdk8/webrev.00/ The patch from JDK9 does not apply cleanly because of different mechanism

Re: [9] Review Request: 8067093 Fix windows-specific deprecation warnings in the java.desktop module

Looks fine. Regards, Anton. On 22.07.2015 1:01, Sergey Bylokhov wrote: Hello. Please review the fix for jdk9. In the fix I replace the usage of the deprecated api in WListPeer. Most of the other cases in the bug description are related to getPeer(), which was already removed. The usage of de

Re: [9] Review request for 8130776: Remove EmbeddedFrame.requestFocusToEmbedder() method

Hi Alexey, Looks fine to me. Regards, Anton. On 21.07.2015 13:17, Alexey Ivanov wrote: Hello AWT team, Could you please review the following fix: bug: https://bugs.openjdk.java.net/browse/JDK-8130776 webrev: http://cr.openjdk.java.net/~aivanov/8130776/jdk9/webrev.00/ Description: Cle

Re: [9] Review Request: 8025492 Hand cursor does not use Windows' system cursor

Looks fine to me. Anton. On 09.06.2015 20:03, Sergey Bylokhov wrote: Hello. Please review the small fix for jdk9. The fix was contributed-by morvan.lemes...@gmail.com [1] For historical reasons jdk uses its own hand cursor(which is actually the same as a default win cursor) instead of native

Re: [9] Review Request: 7178683 [macosx] The default directory for open dialog is different for FileDialogOpenDirTest.html

Looks fine to me. Anton. On 09.06.2015 22:34, Sergey Bylokhov wrote: Hello. Please review the small fix for jdk9. The test was created for the JDK-4974135 and checks specific to xawt/mawt behavior. It is not applicable to the osx as well as windows. The test was moved to the open, but the dif

Re: [9] Review Request for 8022057: JFileChooser blocks EDT in Win32ShellFolder2.getIcon

seconds. I could not reproduce that. I made a guess that following MS recommendations can eliminate delays + I added Windows libraries icons. --Semyon On 6/1/2015 5:41 PM, Anton V. Tarasov wrote: Hi Semyon, The idea of the fix looks ok to me. On 28.05.2015 9:44, Semyon Sadetsky wrote: Hello

Re: [9] Review Request for 8017487: filechooser in Windows-Libraries folder: columns are mixed up

I looked through and found nothing bad (I'm not aware of the details of this Win32 API). Regards, Anton. On 01.06.2015 11:45, Semyon Sadetsky wrote: Hi Sergey, Not 100% sure that "Libraries" is not localized. So, I have excluded it: http://cr.openjdk.java.net/~ssadetsky/8017487/webrev.01/ -

Re: [9] Review Request for 8022057: JFileChooser blocks EDT in Win32ShellFolder2.getIcon

Hi Semyon, The idea of the fix looks ok to me. On 28.05.2015 9:44, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8022057 webrev: http://cr.openjdk.java.net/~ssadetsky/8022057/webrev.00/ The full story can be found in the jira's commen

Re: [9] Review Request: 8041654 OutOfMemoryError: RepainManager doesn't clean up cache of volatile images

Hi Sergey, The fix looks fine to me. However, I don't clearly understand what did you mean by these comments? 1689 // Empty non private constructor was added because access to this 1690 // class shouldn't be emulated by a synthetic accessor method. 1691 DisplayChangedHan

Re: [9] Review request for 8003399: JFileChooser gives wrong path to selected file when saving to Libraries folder on Windows 7

Hi Semyon, I'm fine with it, but don't you want to define a simple macro for this: +jfieldID field_guid = env->GetFieldID(cl, "guid", "Ljava/lang/String;"); +DASSERT(field_guid != NULL); +CHECK_NULL_RETURN(field_guid, NULL); To call it like: DEFINE_FIELD_ID(field_guid, cl, "guid",

Re: [9] Review Request: 8071306 GUI perfomance are very slow compared java 1.6.0_45

On 15.05.2015 1:57, Sergey Bylokhov wrote: Hi, Anton. + * Determines the bounds of a visible part of the component relative to its + * parents. Did you mean "to its parent"? Yep, new version: http://cr.openjdk.java.net/~serb/8071306/webrev.05/ Looks good to me. Regards, Anton.

Re: internal API usage: sun.awt.CausedFocusEvent

Hi Alan, Appropriate RFE is targeted to jdk9: https://bugs.openjdk.java.net/browse/JDK-8080395 Regards, Anton. On 13.05.2015 20:40, Alan Snyder wrote: I have been using sun.awt.CausedFocusEvent to implement special behavior in response to an explicit user-initiated focus traversal to a compo

Re: [9] Review Request: 8071306 GUI perfomance are very slow compared java 1.6.0_45

Hi Sergey, On 09.05.2015 3:41, Sergey Bylokhov wrote: Hi, Anton. On 08.05.15 12:23, Anton V. Tarasov wrote: 1314 /** 1315 * Determines the bounds which will be displayed on the screen. 1316 * 1317 * @return the visible part of bounds in the coordinate space of this comp

Re: [9] Review request for 8003399: JFileChooser gives wrong path to selected file when saving to Libraries folder on Windows 7

Hi Semyon, Some comments: - Please, correct the name to KnownfolderDefinition, or better KnownFolderDefinition: +static class KnownfolderDefenition { - Should JNI exceptions be asserted in Java_sun_awt_shell_Win32ShellFolder2_loadKnownFolders? Regards, Anton. On 07.05.2015 11:14, Semyo

Re: [9] Review Request: 8071306 GUI perfomance are very slow compared java 1.6.0_45

Hi Sergey, The perf improvment is great! I have some minor comments only: 1. 1314 /** 1315 * Determines the bounds which will be displayed on the screen. 1316 * 1317 * @return the visible part of bounds in the coordinate space of this comp 1318 */ 1319 private Recta

Re: [9] Review request for 8077982: GIFLIB upgrade

, Alexander. On 29/04/15 10:49, Anton V. Tarasov wrote: Hi Alexander, I've just checked a diff b/w the original gif lib sources and your updated sources. The only diff (except the bool and headers changes) is this: dgif_lib.c + /* Sanity check for corrupted file */ + if (Gi

Re: [9] Review request for 8077982: GIFLIB upgrade

Hi Alexander, I've just checked a diff b/w the original gif lib sources and your updated sources. The only diff (except the bool and headers changes) is this: dgif_lib.c + /* Sanity check for corrupted file */ + if (GifFile->ImageCount == 0) { + GifFile->Error = D_GIF_ERR_NO_I

Re: [9] Review Request: 8078115 Applets now require "modifyThread" permission to exit on windows

+1 (awesome bug : ) Thanks Anton. On 22.04.2015 16:03, Alexander Scherbatiy wrote: The fix looks good to me. Thanks, Alexandr. On 4/21/2015 6:22 PM, Alexander Zvegintsev wrote: Hello Sergey, the fix looks good to me. Thanks, Alexander. On 04/21/2015 05:49 PM, Sergey Bylokhov wrote

Re: [9] Review Request JDK-6980209: Make tracking SecondaryLoop.enter/exit methods easier

re was no enter() after that scheduler On 4/20/2015 2:17 AM, Sergey Bylokhov wrote: Hi Semyon, Why we call wakeupEDT in the exit method after the fix unconditionally? Please add a comment to the code to describe this briefly. On 01.04.15 14:50, Anton V. Tarasov wrote: Hi Semyon, This looks much c

Re: [9] Review Request: 4703110 java.awt.Canvas(GraphicaConfiguration): null reaction

+1 On 17.04.2015 15:07, Alexander Zvegintsev wrote: looks fine to me. Thanks, Alexander. On 04/16/2015 07:23 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 9. Small documentation update that java.awt.Canvas(GraphicaConfiguration) will not throw NPE if null is passed. ccc r

Re: [9] Review request for 7155957: closed/java/awt/MenuBar/MenuBarStress1/MenuBarStress1.java hangs on win 64 bit with jdk8

Hi Semyon, The fix looks fine to me. Please, add its description to JIRA as well. Regards, Anton. On 15.04.2015 17:38, Semyon Sadetsky wrote: Hello, Please review fix for JDK9. webrev: http://cr.openjdk.java.net/~ssadetsky/7155957/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-71559

Re: [9] Review Request: 8074757 Remove java.awt.Toolkit methods which return peer types

7/webrev.05 On 10.04.15 11:52, Anton V. Tarasov wrote: On 07.04.2015 17:28, Sergey Bylokhov wrote: On 03.04.15 20:14, Phil Race wrote: It does not need to be deprecated. It can be 'undeprecated' It was deprecated only because it was the public Toolkit method that is now gone .. Ok, I&

Re: [9] Review request for 7042645: Numerous api/java_awt jck tests fail - AWT Assertion Failure on fastdebug ri bundles b138 win7 x86

Hi Semyon, Looks fine to me. Regards, Anton. On 06.04.2015 15:11, Semyon Sadetsky wrote: Hello, Please review fix for JDK9. webrev: http://cr.openjdk.java.net/~ssadetsky/7042645/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-7042645 *ROOT CAUSE: The assertion fails message trigger

Re: [9] Review request for 8073453: Focus doesn't move when pressing Shift + Tab keys

Hi Dmitry, Well, the fix seems correct to me. I tried to thought of any possible regressions but nothing came to my mind (let's suppose this was really a mistake in the code). However, wouldn't you like to do the same for swing's SortingFocusTraversalPolicy? And also, include it into the test

Re: [9] Review Request JDK-6980209: Make tracking SecondaryLoop.enter/exit methods easier

Hi Semyon, This looks much clearer now. I'm fine with it! Thanks, Anton. On 01.04.2015 14:14, Semyon Sadetsky wrote: Hi Anton, the updated webrev: http://cr.openjdk.java.net/~ssadetsky/6980209/webrev.02/ --Semyon On 3/30/2015 6:29 PM, Anton V. Tarasov wrote: Hi Semyon, The new ve

Re: [9] Review Request JDK-6980209: Make tracking SecondaryLoop.enter/exit methods easier

Also, please put a space b/w "if" and brace at the line 177. Thanks, Anton. On 30.03.2015 16:07, Semyon Sadetsky wrote: Hi Anton, the code was changed according to our offline discussion: http://cr.openjdk.java.net/~alexsch/semyon-sadetsky/6980209/webrev.01/ added a test case for

Re: [9] Review Request: 8074763 Remove API references to java.awt.dnd.peer

, so we are at a good point to do this, but it will need to be done carefully. I expect that we will need at least 2 weeks to switch our Hudson build systems to build FX 9 with JDK 9 (we currently build with JDK 8), so we will need to coordinate this. -- Kevin Anton V. Tarasov wrote: Hi Sergey

Re: [9] Review request for 8071668: [macosx] Clipboard does not work with 3rd parties Clipboard Managers

Hi Anton, Currently JFXPanel calls "checkPasteboard" via reflection. I had filed JDK-8061315 to provide a public method instead. But with your fix it's not needed. So, I've closed JDK-8061315. Also, I will back out the related fix in JFXPanel: https://javafx-jira.kenai.com/browse/RT-38922 T

Re: [9] Review Request: 8074763 Remove API references to java.awt.dnd.peer

Will it be better? 18.03.15 8:27, Anton V. Tarasov wrote: Hi Sergey, The only dependency on JFX/interop is this method in DropTargetContext.java: 98 public void addNotify(final Object dtcp) throws IllegalArgumentException { Was that the reason why you left the parameter? Is it technically p

Re: [9] Review Request JDK-6980209: Make tracking SecondaryLoop.enter/exit methods easier

Hi Semyon, It would be fine if you describe the case when the enter/exit methods are not thread safe, that is the bug you're fixing. It's always helpful to track all the essential details in the bug report. AFAICS, the case is this: a) "enter" is called on non-dispatch thread b) the thread sc

Re: [9] Review request for 8074481: [macosx] Menu items are appearing on top of other windows

Ok, great! Thanks, Anton. On 19.03.2015 14:09, Anton Nashatyrev wrote: Hi Anton, thanks for review! I've run all [closed/]java/awt/Focus tests: no regressions were found Regards, Anton. On 19.03.2015 11:33, Anton V. Tarasov wrote: Hi Anton, I'm ok with the fix. Please, r

Re: [9] Review request for 8075244 [macosx] The fix for JDK-8043869 should be reworked

Hi Alexander, Sergey, I can't say exactly if this is ok to init AWT from that point, but even if it is, this seems to introduce new risks. At the same time, AFAICS, the root of the original focus problem is unknown. Is that the case? Should we try to understand it, instead? It is possible that

Re: [9] Review request for 8074481: [macosx] Menu items are appearing on top of other windows

Hi Anton, I'm ok with the fix. Please, run all the focus regression tests available. Thanks, Anton. On 18.03.2015 20:55, Anton Nashatyrev wrote: Hello, could you please review the following fix: fix: http://cr.openjdk.java.net/~anashaty/8074481/9/webrev.00/

Re: [9] Review Request: 8074763 Remove API references to java.awt.dnd.peer

Hi Sergey, The only dependency on JFX/interop is this method in DropTargetContext.java: 98 public void addNotify(final Object dtcp) throws IllegalArgumentException { Was that the reason why you left the parameter? Is it technically possible to retrieve the peer via the ComponentAccessor.ge

Re: [9] Review request for 7081580: Specification for MouseInfo.getNumberOfButtons() doesn't contain info about "awt.mouse.numButtons"

t/~alexsch/semyon-sadetsky/7081580/webrev.01/ --Semyon On 3/12/2015 1:42 PM, Anton V. Tarasov wrote: Hi Semyon, Sergey, I agree with that the modified javadoc is not good. 1. When you say something is done "by calling A.b()", it means I can write exactly "A.b()" in my

Re: [9] Review request for 7081580: Specification for MouseInfo.getNumberOfButtons() doesn't contain info about "awt.mouse.numButtons"

Hi Semyon, Sergey, I agree with that the modified javadoc is not good. 1. When you say something is done "by calling A.b()", it means I can write exactly "A.b()" in my code and this will do the job. However, that's not the case with Toolkit.getDesktopProperty() (it won't be compiled). In ord

Re: [9] Review Request: 8074668 [macosx] Mac 10.10: Application run with splash screen has focus issues

Hi Sergey, Looks good to me. Regards, Anton. On 12.03.2015 4:40, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 8/9. Lots of issues(hangs or focus lost) occurred after we call NSScreen.backingScaleFactor on a Appkit Thread in time of splash screen initialization. This is a regre

Re: [9] Review Request: 8043393 NullPointerException and no event received when clipboard data flavor changes

On 24.02.2015 19:10, Sergey Bylokhov wrote: On 24.02.2015 18:49, Anton V. Tarasov wrote: Hi Sergey, I suppose formatArrayAsDataFlavorSet() didn't produce any meaningful side effect currently not taken into account? Seems yes, other than some default initialization if it was not called b

Re: [9] Review Request: 8043393 NullPointerException and no event received when clipboard data flavor changes

Hi Sergey, I suppose formatArrayAsDataFlavorSet() didn't produce any meaningful side effect currently not taken into account? If so, I'm fine with the change. Regards, Anton. On 24.02.2015 15:20, Sergey Bylokhov wrote: Hello. Please review a fix for jdk 9. The NPE occurs, because we call get

Re: [9] Review request for 8056915: Focus lost in applet when browser window is minimized and restored

Hi Alexey, The fix looks fine to me. Regards, Anton. On 10.02.2015 14:45, Alexey Ivanov wrote: Hello AWT team, Could you please review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8056915 webrev: http://cr.openjdk.java.net/~aivanov/8056915/jdk9/webrev.00/ Description: After

Re: [9] Review request for 8072088: [PIT] NPE in DnD tests apparently because of the fix to JDK-8061636

Looks fine to me. Regards, Anton. On 02.02.2015 19:44, Alexander Zvegintsev wrote: Hello, please review the fix: http://cr.openjdk.java.net/~azvegint/jdk/9/8072088/00/ for the issue: https://bugs.openjdk.java.net/browse/JDK-8072088 Removed WeakReference nullification.

Re: [9] Review Request: 8062738 Test java/awt/datatransfer/MissedHtmlAndRtfBug/MissedHtmlAndRtfBug fails in Windows

Looks fine to me. Regards, Anton. On 02.02.2015 16:52, Sergey Bylokhov wrote: Hello. Please review a fix for jdk 9. Description: In the fix for JDK-8051449 was an incorrect assumption that String.replace() replaces only the first text occurrence, and it was changed to replaceAll(). Bug: http

Re: Review Request: 8069015 Re-examine Solaris/Linux java.desktop dependency on java.logging

Looks fine ot me. Regards Anton. On 22.01.2015 20:11, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 9. Additional information about the problem in https://bugs.openjdk.java.net/browse/JDK-6879044 "There are many classes using java.util.logging to log messages to enhance the diag

Re: [9] Review Request: 7185221 [macosx] Regtest should not throw exception if a suitable display mode found

Looks fine to me. Regards, Anton. On 21.01.2015 20:12, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 9. The test modify a supported list of DisplayModes and try to check that IllegalArgumentException will be thrown. But the problem occurs, when the test tries to change a support

Re: Review Request for 8065709: Deadlock in awt/logging apparently introduced by 8019623

t insist on implementing the 3rd version of the fix. Leaving it at Mikhail's descretion. Thanks. Thanks, Mikhail. On 1/20/2015 8:14 PM, Sergey Bylokhov wrote: On 20.01.2015 19:08, Anton V. Tarasov wrote: Hi Mikhail, Ok, you removed the new lock at least. Looks better now (no more

Re: Review Request for 8065709: Deadlock in awt/logging apparently introduced by 8019623

Could you please review a new version: http://cr.openjdk.java.net/~mcherkas/8065709/webrev.03/ ? Thanks, Mikhail. On 1/20/2015 8:14 PM, Sergey Bylokhov wrote: On 20.01.2015 19:08, Anton V. Tarasov wrote: Hi Mikhail, Ok, you removed the new lock at least. Looks better now (no more comm

Re: [9] Review request for 8068283: Mac OS Incompatibility between JDK 6 and 8 regarding input method handling

Looks fine! Thanks, Anton. On 20.01.2015 18:42, Anton Nashatyrev wrote: Hello Alexander, Anton could you please review the following fix: fix: http://cr.openjdk.java.net/~anashaty/8068283/9/webrev.00/ bug: https://bugs.openjd

Re: Review Request for 8065709: Deadlock in awt/logging apparently introduced by 8019623

19/01/15 19:15, mikhail cherkasov wrote: On 1/19/2015 5:59 PM, Anton V. Tarasov wrote: Hi Mikhail, It seems the problem is not limited to EventQueue only. Even if you solve it for EventQueue, the EventQueue ctor may cause a chain of calls where some other AWT class is first accessed and

Re: Review Request for 8065709: Deadlock in awt/logging apparently introduced by 8019623

Hi Mikhail, It seems the problem is not limited to EventQueue only. Even if you solve it for EventQueue, the EventQueue ctor may cause a chain of calls where some other AWT class is first accessed and initialized. What if it contains the same getLogger() call in a static block? If you agree w

Re: [9] Review Request: 6475361 Attempting to remove help menu from java.awt.MenuBar throws NullPointerException

Hi Sergey, Looks fine to me. Regards, Anton. On 12.01.2015 20:16, Sergey Bylokhov wrote: Hello. Please review a fix for jdk 9. All problems mentioned in the CR were fixed: - Menu.isHelpMenu will be changed to false when a menu is removed from the MenuBar. - MenuBar.helpMenu will be changed

Re: [9] Review request for 7155963: Deadlock in SystemFlavorMap.getFlavorsForNative and SunToolkit.awtLock

Hi Alexander, The fix looks fine for me. Regards Anton. On 11.12.2014 15:06, Alexander Zvegintsev wrote: Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/7155963/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-7155963 SunClipboard.checkChange() does not requ

Re: [9] Review Request: 8059998 Broken link in java.awt.event Interface KeyListener

Approved. Regards, Anton On 05.12.2014 12:05, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 9. The broken link was fixed. Bug: https://bugs.openjdk.java.net/browse/JDK-8059998 Webrev can be found at: http://cr.openjdk.java.net/~serb/8059998/webrev.00

Re: [7] Review Request for 8047961: [TESTBUG] closed/java/awt/Focus/ActivateFocusTest/ActivateFocusTest.html fails intermittently

und in jdk 1.4. I believe jdk4 and 7 has a lot of difference in focus system and due those changes the test became irrelevant. (It's not as different as 1.3 comparing to 1.7, taking into account the fact that focus had been drastically refactored in 1.4.) Thanks, Mikhail. On 11/17/2014 5

Re: [7] Review Request for 8047961: [TESTBUG] closed/java/awt/Focus/ActivateFocusTest/ActivateFocusTest.html fails intermittently

On 17.11.2014 17:38, Oleg Sukhodolsky wrote: On Mon, Nov 17, 2014 at 5:31 PM, Anton V. Tarasov wrote: On 17.11.2014 17:21, Oleg Sukhodolsky wrote: On Mon, Nov 17, 2014 at 4:34 PM, Anton V. Tarasov wrote: On 17.11.2014 15:01, Oleg Sukhodolsky wrote: Hi Anton, the bug was a regression

Re: [7] Review Request for 8047961: [TESTBUG] closed/java/awt/Focus/ActivateFocusTest/ActivateFocusTest.html fails intermittently

On 17.11.2014 17:21, Oleg Sukhodolsky wrote: On Mon, Nov 17, 2014 at 4:34 PM, Anton V. Tarasov wrote: On 17.11.2014 15:01, Oleg Sukhodolsky wrote: Hi Anton, the bug was a regression introduced in 1.4 (comparing with 1.3.1) this is why it was fixed and the test was written. Indeed the spec

Re: [7] Review Request for 8047961: [TESTBUG] closed/java/awt/Focus/ActivateFocusTest/ActivateFocusTest.html fails intermittently

you whole should make the final decision but I just do not see a reason to keep a test which doesn't test for the particular regression in regression tests suite. Regards, Oleg. On Mon, Nov 17, 2014 at 2:01 PM, Anton V. Tarasov wrote: Hi Oleg, Glad to hear from you :) On 14.11.2014 18:24

Re: [7] Review Request for 8047961: [TESTBUG] closed/java/awt/Focus/ActivateFocusTest/ActivateFocusTest.html fails intermittently

fter a couple of iterations. This could be a compromize. What do you think, Oleg, Mikhail? Thanks, Anton. [1] https://docs.oracle.com/javase/8/docs/api/javax/swing/JComponent.html#requestFocus-- Regards, Oleg. P.S. feel free to ask more questions if you need. On Fri, Nov 14, 2014 at 5:

Re: [7] Review Request for 8047961: [TESTBUG] closed/java/awt/Focus/ActivateFocusTest/ActivateFocusTest.html fails intermittently

Hi Mikhail, Looks fine for me. Thanks! This was an old one... Do you have any plans to fix it in 8/9 as well? Regards, Anton. On 14.11.2014 18:57, mikhail cherkasov wrote: Hello all, Could you please review a simple fix of closed test, the test was moved to open repo and requestFocus was re

Re: [7] Review Request for 8001633: Wrong alt processing during switching between windows.

Looks fine for me. Regards, Anton. On 13.11.2014 22:17, mikhail cherkasov wrote: Hello all, Could you please review a backport to jdk7 for the following bug: bug: https://bugs.openjdk.java.net/browse/JDK-8001633 Webrev: http://cr.openjdk.java.net/~mcherkas/8001633/jdk7/webrev.00/ review for j

[9] Review Request for JDK-8004148: NPE in sun.awt.SunToolkit.getWindowDeactivationTime

Hello, Please, review the fix. https://bugs.openjdk.java.net/browse/JDK-8004148 http://cr.openjdk.java.net/~ant/JDK-8004148/webrev.0 There's no a test case for the original issue. However, there's another test case which reproduces NPE with the same stack trace. The problem was fixed in jdk8 i

Re: [7u] Review request for 8061954: 7u76 - deployment warning dialogs do not work on Linux

On 07.11.2014 13:45, Anton Litvinov wrote: Hello Anton, Thank you for the response. I would just like to clarify one question. Did you approve this version of the fix? Yes, sure, I approved. Thanks, Anton. Thank you, Anton On 11/7/2014 10:48 AM, Anton V. Tarasov wrote: Hi Anton, On

Re: [7u] Review request for 8061954: 7u76 - deployment warning dialogs do not work on Linux

ublic client method (Window.isActive) on the toolkit thread (that is actually obvious from the stack...). And that's prohibited. The NPE thus was a side effect. So, the fix is correct as soon as it eliminates the client calls from the toolkit thread. Regards, Anton. Thank you, Anton

Re: [7u] Review request for 8061954: 7u76 - deployment warning dialogs do not work on Linux

Hi Anton, The fix looks fine for me (taking into account you've launched all the focus reg tests). However, I have a concern about the issue itself. As far as I know, any deploy warning dialog should belong to the deploy Thread Group which does have its own AppContext. The only TG which has nu

Re: Focus regression in Java8 caused by JDK-7160604

Hi Clemens, Sure, please file the issue. If you have an account in JIRA, please file it right there. Otherwise, tell us please the ID of the incident you will file and we'll accept it. Thanks! Anton. On 05.11.2014 22:46, Clemens Eisserer wrote: Hi Anton, I can't say exactly how the fix fo

Re: Focus regression in Java8 caused by JDK-7160604

Hi Clemens, I can't say exactly how the fix for JDK-7160604 could change the behavior like you described (this requires some more time to investigate). However, an obvious question comes to my mind - why don't you make your popup non-focusable? I suppose you manage navigation through the conten

Re: [7u-dev] Request for Approval and Review: 8057008: [TEST_BUG] Test java/awt/Focus/SortingFPT/JDK8048887.java fails with compilation error

Please, disregard my approval for the wrong webrev. Please, see the upcoming message. Anton. On 27.10.2014 18:44, Anton V. Tarasov wrote: Hi Srinivasan, The fix looks fine for me. Regards, Anton. On 01.09.2014 20:33, srinivasan raghavan wrote: Hello , Please review a fix for the issue

Re: [7u-dev] Request for Approval and Review: 8057008: [TEST_BUG] Test java/awt/Focus/SortingFPT/JDK8048887.java fails with compilation error

Looks fine. Regards, Anton. On 01.09.2014 20:42, srinivasan raghavan wrote: Hello , Apologies for giving wrong web-rev link i am updating with the new one The webrev is http://cr.openjdk.java.net/~kshefov/8057008/webrev.00/ -Thanks Srinivasan Raghavan On 9/1/2014 10:03 PM, srinivasan raghava

Re: [7u-dev] Request for Approval and Review: 8057008: [TEST_BUG] Test java/awt/Focus/SortingFPT/JDK8048887.java fails with compilation error

Hi Srinivasan, The fix looks fine for me. Regards, Anton. On 01.09.2014 20:33, srinivasan raghavan wrote: Hello , Please review a fix for the issue 8057008 [TEST_BUG] Test java/awt/Focus/SortingFPT/JDK8048887.java fails with compilation error Test bug fix https://bugs.openjdk.java.net/bro

Re: [9] Review request : 8062021 NPE in sun/lwawt/macosx/CPlatformWindow::toFront after JDK-8060146

Looks fine for me. Regards, Anton. On 24.10.2014 16:01, mikhail cherkasov wrote: Hello all, please review the fix http://cr.openjdk.java.net/~mcherkas/8062021/webrev.00/ bug: NPE in sun/lwawt/macosx/CPlatformWindow::toFront after JDK-8060146 https://bugs.openjdk.java.net/browse/JDK-8062021 C

Re: [9] Review request : 8038919, Requesting focus to a modeless dialog doesn't work on Safari

http://cr.openjdk.java.net/~mcherkas/8038919/webrev.04/ Thanks, Mikhail. On 10/8/2014 10:41 AM, Anton V. Tarasov wrote: Hi Mikhail, (sorry, I was away yesterday) On 07.10.2014 19:37, mikhail cherkasov wrote: Hi Anton, But anyway, I'll have to use "instanceof" to check t

[9] Review Request: 8061315 [JFXPanel, Mac] need an ability to check if Clipboard has been changed from outside of Swing/AWT

Hello, Please review a fix: https://bugs.openjdk.java.net/browse/JDK-8061315 http://cr.openjdk.java.net/~ant/JDK-8061315/webrev.0 The problem is originally reproducible with JFXPanel added to a Swing app. A text copied from an Fx text field can't be pasted to a Swing control. This is MacOS X o

Re: [9] Review request for JDK-8059590: ArrayIndexOutOfBoundsException occurs when Container with overridden getComponents() is deserialized

Looks fine for me. Thanks, Anton. On 16.10.2014 17:21, Alexey Ivanov wrote: Hello AWT Team, Could you please review the fix for the bug: bug: https://bugs.openjdk.java.net/browse/JDK-8059590 webrev: http://cr.openjdk.java.net/~aivanov/8059590/jdk9/webrev.00/ Problem description: If on

Re: [9] Review request : 8038919, Requesting focus to a modeless dialog doesn't work on Safari

It looks fine for me. Thanks! Anton. On 09.10.2014 19:46, mikhail cherkasov wrote: Hi Anton, Please review a new version: http://cr.openjdk.java.net/~mcherkas/8038919/webrev.04/ Thanks, Mikhail. On 10/8/2014 10:41 AM, Anton V. Tarasov wrote: Hi Mikhail, (sorry, I was away yesterday) On

Re: [9] Review request : 8038919, Requesting focus to a modeless dialog doesn't work on Safari

ve window may not have a null peer. Regards, Anton. Thanks, Mikhail. On 10/6/2014 12:56 PM, Anton V. Tarasov wrote: Hi Mikhail, Ok, thank you for the clarification. Still, let's make another attempt to avoid the "instanceof". In LWWindowPeer we have a good public

Re: [9] Review request : 8038919, Requesting focus to a modeless dialog doesn't work on Safari

o the problem occurs only when we call toFront on Windows and embedded frame is active, hence fix should be done in Window's toFront method. Thanks, Mikhail. On 10/3/2014 5:48 PM, Anton V. Tarasov wrote: Hi Mikhail, Can we get rid of that "instance of"? I think it makes sense to

Re: [9] Review request : 8038919, Requesting focus to a modeless dialog doesn't work on Safari

Hi Mikhail, Can we get rid of that "instance of"? I think it makes sense to create a new LWEmbeddedFramePeer class with toFront overriden. Then we can do all the verifications gracefully and call platformWindow.toFrontIgnoringOtherApps() (new method). I would also rename LWCToolkit.activateApp

Re: CFV: New AWT group member: Alexander Zvegintsev

Vote: YES On 03.09.2014 14:44, Artem Ananiev wrote: I hereby nominate Alexander Zvegintsev (OpenJDK user name: azvegint) to Membership in the AWT Group. Alexander is a member of AWT/Swing group at Oracle. He has contributed 20+ fixes to JDK9 so far, and JDK8/8u contribution is significant as

Re: Review request for 8047288: [macosx] Endless loop in EDT on Mac

() is called from the main thread or from EDT thread. So I think toolkit thread won't call this method. On 7/24/2014 2:02 PM, Anton V. Tarasov wrote: On 24.07.2014 13:48, artem malinko wrote: Hi Anton. Sorry, didn't understand you well. Do you mean we should check(and test) th

Re: Review request for 8047288: [macosx] Endless loop in EDT on Mac

setVisible() is called on EDT in case of an applet. That logic is triggered on the plugin side. Anton. On 7/24/2014 11:42 AM, Anton V. Tarasov wrote: Hi Artem, I'm Ok with the fix, provided that LWWindowPeer.setVisibleImpl() is called on EDT for applets (if I'm not mistaken). Otherw

Re: Review request for 8047288: [macosx] Endless loop in EDT on Mac

Hi Artem, I'm Ok with the fix, provided that LWWindowPeer.setVisibleImpl() is called on EDT for applets (if I'm not mistaken). Otherwise, we still have a client method (getTarget().isFocusableWindow()) called on the toolkit thread, which is generally no good. Regards, Anton. On 24.07.2014 10

Re: [7] Review request for 6993873: java/awt/Focus/FocusOwnerFrameOnClick/FocusOwnerFrameOnClick.java test indicates ".a frame wasn't focused on click" jdk7 issue on linux

Looks fine to me. Regards, Anton. On 02.07.2014 22:36, anton nashatyrev wrote: Hello, could you please review the following fix: fix: http://cr.openjdk.java.net/~anashaty/6993873/7/webrev.00/ bug: https://bugs.openjdk.java.net

Re: [9] Review request for 8046495: KeyEvent can not be accepted in quick mouse clicking

On 02.07.2014 19:28, anton nashatyrev wrote: Hello, Anton On 02.07.2014 18:13, Anton V. Tarasov wrote: On 02.07.2014 11:44, Petr Pchelko wrote: Hello, Anton. I'm not sure I have a detailed understanding of what's happening. Before your fix the timestamp of the event represente

Re: [9] Review request for 8046495: KeyEvent can not be accepted in quick mouse clicking

On 02.07.2014 11:44, Petr Pchelko wrote: Hello, Anton. I'm not sure I have a detailed understanding of what's happening. Before your fix the timestamp of the event represented the time when the event was created, and now it's the time when it's sent to java. This might be important if some ev

Re: [OpenJDK 2D-Dev] [9] Review Request: JDK-8029455 JLightweightFrame: support scaled painting

Ok, good! Anton. On 23.05.2014 15:18, Anthony Petrov wrote: On 5/23/2014 3:12 PM, Anton V. Tarasov wrote: On 23.05.2014 14:47, Anthony Petrov wrote: 1. The host bounds are not related to the /content/. Hence, adding this method to the LightweightContent interface would look inconsistent from

Re: [OpenJDK 2D-Dev] [9] Review Request: JDK-8029455 JLightweightFrame: support scaled painting

we don't modify the interface anymore. Ok, this is about a matter of taste. The 5th point sounds strong enough for me, so I'm fine with the current version. Thanks! Anton. -- best regards, Anthony On 5/23/2014 2:11 PM, Anton V. Tarasov wrote: Hi Sergey, Thanks for the update. I

Re: [OpenJDK 2D-Dev] [9] Review Request: JDK-8029455 JLightweightFrame: support scaled painting

/14 5:58 PM, Anton V. Tarasov wrote: On 22.05.2014 15:36, Sergey Bylokhov wrote: On 5/22/14 11:47 AM, Anton V. Tarasov wrote: Hi Sergey, On 22.05.2014 1:44, Sergey Bylokhov wrote: On 5/21/14 10:13 PM, Anthony Petrov wrote: Hi Sergey, The original fix provides some updates and clarifications to

Re: [OpenJDK 2D-Dev] [9] Review Request: JDK-8029455 JLightweightFrame: support scaled painting

On 22.05.2014 15:36, Sergey Bylokhov wrote: On 5/22/14 11:47 AM, Anton V. Tarasov wrote: Hi Sergey, On 22.05.2014 1:44, Sergey Bylokhov wrote: On 5/21/14 10:13 PM, Anthony Petrov wrote: Hi Sergey, The original fix provides some updates and clarifications to the javadoc for the

Re: [OpenJDK 2D-Dev] [9] Review Request: JDK-8029455 JLightweightFrame: support scaled painting

are JavaFX builds, and it works fine in all the cases. The current plan is to push this fix to JDK 9, and then back-port the changes to 8u20. -- best regards, Anthony On 2/21/2014 2:47 AM, Jim Graham wrote: Yes, approved. ...jim On 2/17/14 6:09 AM, Anton V. Tarasov wrote: Jim, so this i

Re: [9] Review Request: JDK-8032872: [macosx] Cannot select from JComboBox in a JWindow

Thanks, Dmitry! Looks great. Regards, Anton. On 05.03.2014 15:09, dmitry markov wrote: Anton, I updated the test. New version is located at http://cr.openjdk.java.net/~dmarkov/8032872/jdk9/webrev.03/ Thanks, Dmitry On 05/03/2014 13:13, Anton V. Tarasov wrote: Hi Dmitry, Actually, I

Re: [9] Review Request: JDK-8032872: [macosx] Cannot select from JComboBox in a JWindow

04/03/2014 19:49, Anton V. Tarasov wrote: Hi Dmitry, The fix looks fine for me, but I'm still voting for adding this case to java/awt/Window/Grab/GrabTest.java Thanks, Anton. On 04.03.2014 17:26, dmitry markov wrote: Hello, Could you review the updated fix, please? webrev: http://cr.open

Re: [9] Review Request: JDK-8032872: [macosx] Cannot select from JComboBox in a JWindow

ev.01/ - Fixed problem in changeFocusedWindow() - Added description for getOwnerFrameDialog() Thanks, Dmitry On 03/03/2014 20:19, Sergey Bylokhov wrote: On 3/3/14 6:15 PM, Anton V. Tarasov wrote: Hi all, The fix looks fine for me. The usage of getOwnerFrameDialog() in the mentioned cases i

Re: [9] Review Request: JDK-8032872: [macosx] Cannot select from JComboBox in a JWindow

Hi all, The fix looks fine for me. The usage of getOwnerFrameDialog() in the mentioned cases indeed seems incorrect. I've looked at the rest of the code and found yet another incorrect usage, in LWWindowPeer.changeFocusedWindow line 1265. Please, fix it the same way. All the other use cases of

Re: [OpenJDK 2D-Dev] [9] Review Request: JDK-8029455 JLightweightFrame: support scaled painting

utstanding issues... ...jim On 2/13/14 11:12 PM, Anton V. Tarasov wrote: On 14.02.2014 2:52, Jim Graham wrote: On 2/13/14 5:03 AM, Anton V. Tarasov wrote: Hi Jim, Please, look at the update: http://cr.openjdk.java.net/~ant/JDK-8029455/webrev.5 Here I'm correcting the rect after t

Re: [OpenJDK 2D-Dev] [9] Review Request: JDK-8029455 JLightweightFrame: support scaled painting

On 14.02.2014 2:52, Jim Graham wrote: On 2/13/14 5:03 AM, Anton V. Tarasov wrote: Hi Jim, Please, look at the update: http://cr.openjdk.java.net/~ant/JDK-8029455/webrev.5 Here I'm correcting the rect after the transform in SG2D: 2123 // In case of negative scale transform, re

Re: [OpenJDK 2D-Dev] [9] Review Request: JDK-8029455 JLightweightFrame: support scaled painting

lease, see below.) ...jim On 2/11/14 10:10 AM, Anton V. Tarasov wrote: Hi Jim, On 2/11/14 4:12 AM, Jim Graham wrote: Just out of curiosity, on a Mac there is support for @2x images where they get loaded and used (at half scale to preserve layout size) automatically for you. In that respect, the add

Re: [OpenJDK 2D-Dev] [9] Review Request: JDK-8029455 JLightweightFrame: support scaled painting

I just sticked to the type of the scale factor returned by SurfaceData.getDefaultScale() which was int. Thanks, Anton. ...jim On 2/10/14 3:37 PM, Jim Graham wrote: On 2/10/14 6:11 AM, Anton V. Tarasov wrote: On 2/3/14 6:36 AM, Anton V. Tarasov wrote: In SG2D, the drawHiDPII

Re: [OpenJDK 2D-Dev] [9] Review Request: JDK-8029455 JLightweightFrame: support scaled painting

Ok, I'll elaborate on it. Otherwise, I didn't spot any other issues... Glad to hear that :) On 2/3/14 6:36 AM, Anton V. Tarasov wrote: In SG2D, the drawHiDPIImage, for instance, makes a call to op.filter(img, null); where the img is expected to return its layout size. That&#

Re: [OpenJDK 2D-Dev] [9] Review Request: JDK-8029455 JLightweightFrame: support scaled painting

36 PM, Anton V. Tarasov wrote: Hi Jim, Please look at the updated version: http://cr.openjdk.java.net/~ant/JDK-8029455/webrev.4 On 01.02.2014 5:35, Jim Graham wrote: Hi Anton, On 1/31/14 6:37 AM, Anton V. Tarasov wrote: My understanding is that, unless the fix is absolutely irrelevant (whic I

Re: [OpenJDK 2D-Dev] [9] Review Request: JDK-8029455 JLightweightFrame: support scaled painting

Hi Jim, Please look at the updated version: http://cr.openjdk.java.net/~ant/JDK-8029455/webrev.4 On 01.02.2014 5:35, Jim Graham wrote: Hi Anton, On 1/31/14 6:37 AM, Anton V. Tarasov wrote: My understanding is that, unless the fix is absolutely irrelevant (whic I hope it isn't), we s

  1   2   3   >