Re: RFR: 8273375: Remove redundant 'new String' calls after concatenation in java.desktop

On Fri, 3 Sep 2021 07:53:21 GMT, Andrey Turbanov wrote: > Result of string concatenation is a newly created `String` object. There is > no need it wrap it in another `new String` call. > Such calls are confusing and produce warnings in IDE. Without them code is > easier to read. Link this PR

Re: RFR: 8272481: [macos] javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java fails [v4]

On Wed, 25 Aug 2021 17:32:46 GMT, Alexey Ushakov wrote: >> Update opacity only if the component is visible > > Alexey Ushakov has updated the pull request incrementally with one additional > commit since the last revision: > > 8272481: [macos] javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFr

Re: RFR: 8270312: Error: Not a test or directory containing tests: java/awt/print/PrinterJob/XparColor.java [v3]

On Fri, 6 Aug 2021 15:17:48 GMT, lawrence.andrews wrote: >> 1) This testcase was throwing error saying Error: Not a test or directory >> containing tests: java/awt/print/PrinterJob/XparColor.java >> 2) Added @test tag so that this testcase can be run >> 3) Since Applet is deprecated and its not

Re: RFR: 8272123: Problem list 4 jtreg tests which regularly fail on macos-aach64

On Mon, 9 Aug 2021 03:17:20 GMT, Phil Race wrote: > As per the bug comments, these tests fail too often on macOS arm. > This will be too noisy for CI. So I would like to problem list them for > mac-arm Marked as reviewed by jdv (Reviewer). - PR: https://git.openjdk.java.net/jdk/p

Re: RFR: 8270058: Use Objects.check{Index, FromIndexSize} for java.desktop [v4]

On Thu, 5 Aug 2021 03:25:49 GMT, Yi Yang wrote: >> After JDK-8265518(#3615), it's possible to replace all variants of >> checkIndex by >> Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in >> the whole JDK codebase. >> >> As Mandy suggested, I create this PR for changes

Re: RFR: 8270312: Error: Not a test or directory containing tests: java/awt/print/PrinterJob/XparColor.java

On Tue, 13 Jul 2021 14:57:30 GMT, lawrence.andrews wrote: > 1) This testcase was throwing error saying Error: Not a test or directory > containing tests: java/awt/print/PrinterJob/XparColor.java > 2) Added @test tag so that this testcase can be run > 3) Since Applet is deprecated and its not su

Re: RFR: 8271456: Avoid looking up standard charsets in "java.desktop" module

On Sun, 1 Aug 2021 07:07:21 GMT, Sergey Bylokhov wrote: > This is a request to clean up a desktop module as was done in JDK-8233884 for > "java.base" module. > > In many places standard charsets are looked up via their names, for example: > absolutePath.getBytes("UTF-8"); > > This could be don

Re: RFR: 8270058: Use Objects.check{Index, FromIndexSize} for java.desktop [v3]

On Fri, 30 Jul 2021 08:40:34 GMT, Pankaj Bansal wrote: >> src/java.desktop/share/classes/javax/swing/JTabbedPane.java line 1793: >> >>> 1791: >>> 1792: private void checkIndex(int index) { >>> 1793: Objects.checkIndex(index, pages.size()); >> >> I think we should not replace IOOBE

Re: RFR: 8270058: Use Objects.check{Index, FromIndexSize} for java.desktop [v3]

On Thu, 22 Jul 2021 06:29:13 GMT, Yi Yang wrote: >> After JDK-8265518(#3615), it's possible to replace all variants of >> checkIndex by >> Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in >> the whole JDK codebase. >> >> As Mandy suggested, I create this PR for change

Re: [jdk17] RFR: 8266079: Lanai: AlphaComposite shows differences on Metal compared to OpenGL [v3]

On Mon, 5 Jul 2021 15:51:46 GMT, Alexey Ushakov wrote: >> The latest version of this PR re-introduces >> [JDK-8243547](https://bugs.openjdk.java.net/browse/JDK-8243547) > >> The latest version of this PR re-introduces >> [JDK-8243547](https://bugs.openjdk.java.net/browse/JDK-8243547) > > Fixed

Re: [jdk17] RFR: 8266079: Lanai: AlphaComposite shows differences on Metal compared to OpenGL [v2]

On Wed, 23 Jun 2021 12:15:03 GMT, Alexey Ushakov wrote: >> Implemented blit via compute kernel > > Alexey Ushakov has refreshed the contents of this pull request, and previous > commits have been removed. The incremental views will show differences > compared to the previous content of the PR.

Re: [jdk17] RFR: 8266079: Lanai: AlphaComposite shows differences on Metal compared to OpenGL

On Tue, 15 Jun 2021 16:57:00 GMT, Alexey Ushakov wrote: > Implemented blit via compute kernel With this patch shaped windows with translucent/color background are showing only black background. In manual JCK shaped window test also this difference in behaviour is seen. This behaviour differen

Re: [jdk17] RFR: 8266079: Lanai: AlphaComposite shows differences on Metal compared to OpenGL

On Thu, 17 Jun 2021 07:06:24 GMT, Jayathirth D V wrote: >> Implemented blit via compute kernel > > src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLLayer.m line 136: > >> 134: NSUInteger w = computePipelineState.threadExecutionWidth; >> 135: >&g

Re: [jdk17] RFR: 8266079: Lanai: AlphaComposite shows differences on Metal compared to OpenGL

On Wed, 16 Jun 2021 11:57:01 GMT, Jayathirth D V wrote: >> @jayathirthrao @aghaisas please let me know if I can push this change into >> JDK17 repository > > @avu i have given all test run. I will get back to you once it is done. Automated jtreg/JCK test run is green. --

Re: [jdk17] RFR: 8266079: Lanai: AlphaComposite shows differences on Metal compared to OpenGL

On Tue, 15 Jun 2021 16:57:00 GMT, Alexey Ushakov wrote: > Implemented blit via compute kernel src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLLayer.m line 136: > 134: NSUInteger w = computePipelineState.threadExecutionWidth; > 135: > 136: // Workaround for some OS/d

Re: [jdk17] RFR: 8266079: Lanai: AlphaComposite shows differences on Metal compared to OpenGL

On Wed, 16 Jun 2021 10:34:50 GMT, Alexey Ushakov wrote: >> src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLLayer.m line 159: >> >>> 157: [computeEncoder endEncoding]; >>> 158: [cb commit]; >>> 159: #endif >> >> This is better than changing the background color, but s

Re: RFR: 8256465: [macos11] Java frame and dialog presented full screen freeze application [v7]

On Fri, 28 May 2021 13:54:36 GMT, Tejpal Rebari wrote: >> Hi All, >> Please review the following fix for jdk17. >> >> Issue : On MacOS 11 Java Frame and JDialog application is freezing in Full >> Screen when the System Preference -> General -> Prefer Tabs is set to "Full >> Screen". It is al

Integrated: 8226384: Implement a better logic to switch between OpenGL and Metal pipeline

On Tue, 4 May 2021 11:02:40 GMT, Jayathirth D V wrote: > We have many if else conditions to select OpenGL/Metal pipeline objects. > Apart from initialization phase we should not fetch these objects everytime > checking whether we are using OpenGL/Metal pipeline. This pull request has

Re: RFR: 8226384: Implement a better logic to switch between OpenGL and Metal pipeline [v2]

On Mon, 10 May 2021 10:14:40 GMT, Jayathirth D V wrote: >> You can add a new abstract method to the parent class: getRenderQueue(), and >> override it in subclasses to call MTLRenderQueue/OGL.getInstance(); In this >> way, you can push to the parent more methods by cal

Re: RFR: 8226384: Implement a better logic to switch between OpenGL and Metal pipeline [v2]

On Fri, 7 May 2021 19:44:31 GMT, Sergey Bylokhov wrote: >> In dispose() we call validate which internally calls corresponding >> RenderQueue's of OpenGL/Metal, thats why it is not moved to CFLayer. >> For other getters since initialization of peer was happening in individual >> subclasses(which

Re: RFR: 8226384: Implement a better logic to switch between OpenGL and Metal pipeline [v2]

On Wed, 5 May 2021 07:37:23 GMT, Jayathirth D V wrote: >> We have many if else conditions to select OpenGL/Metal pipeline objects. >> Apart from initialization phase we should not fetch these objects everytime >> checking whether we are using OpenGL/Metal pipeline. >

Re: RFR: 8226384: Implement a better logic to switch between OpenGL and Metal pipeline [v2]

> We have many if else conditions to select OpenGL/Metal pipeline objects. > Apart from initialization phase we should not fetch these objects everytime > checking whether we are using OpenGL/Metal pipeline. Jayathirth D V has updated the pull request incrementally with one additiona

Re: RFR: 8226384: Implement a better logic to switch between OpenGL and Metal pipeline [v2]

On Wed, 5 May 2021 02:34:52 GMT, Sergey Bylokhov wrote: >> Jayathirth D V has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Move peer and getters to CFLayer > > src/java.desktop/macosx/classes/sun/java2

Re: RFR: 8226384: Implement a better logic to switch between OpenGL and Metal pipeline

On Tue, 4 May 2021 17:51:24 GMT, Phil Race wrote: > LGTM. Is there anything not covered by this fix ? Hi Phil, We still have some if else checks in initialization paths like CPlatformView.initialize(), CPlatformEmbeddedFrame and static access of RenderQueue methods like LWCToolkit.sync(). Th

Re: RFR: 8226384: Implement a better logic to switch between OpenGL and Metal pipeline

On Tue, 4 May 2021 11:02:40 GMT, Jayathirth D V wrote: > We have many if else conditions to select OpenGL/Metal pipeline objects. > Apart from initialization phase we should not fetch these objects everytime > checking whether we are using OpenGL/Metal pipeline. jtreg/JCK all test run

RFR: 8226384: Implement a better logic to switch between OpenGL and Metal pipeline

We have many if else conditions to select OpenGL/Metal pipeline objects. Apart from initialization phase we should not fetch these objects everytime checking whether we are using OpenGL/Metal pipeline. - Commit messages: - 8226384: Implement a better logic to switch between OpenGL a

Re: RFR: 8198616: java/awt/Focus/6378278/InputVerifierTest.java fails on mac

On Thu, 29 Apr 2021 09:24:37 GMT, Prasanta Sadhukhan wrote: > This test was failing earlier in our nightly testing citing > "jjava.lang.RuntimeException: t2 is not a focus owner > > Updated test to > use swing components in EDT, > setAutoDelay for mouse events, > add a delay after frame is ma

Re: RFR: 8198616: java/awt/Focus/6378278/InputVerifierTest.java fails on mac

On Thu, 29 Apr 2021 09:24:37 GMT, Prasanta Sadhukhan wrote: > This test was failing earlier in our nightly testing citing > "jjava.lang.RuntimeException: t2 is not a focus owner > > Updated test to > use swing components in EDT, > setAutoDelay for mouse events, > add a delay after frame is ma

Re: RFR: 8198617: java/awt/Focus/6382144/EndlessLoopTest.java fails on mac

On Thu, 22 Apr 2021 06:08:05 GMT, Prasanta Sadhukhan wrote: > This test was failing earlier in our nightly testing citing > "java.lang.RuntimeException: java.awt.IllegalComponentStateException: > component must be showing on the screen to determine its location " > Updated test to > use swing

Re: RFR: 8196300: java/awt/TextArea/TextAreaScrolling/TextAreaScrolling.java times out

On Mon, 26 Apr 2021 08:49:11 GMT, Prasanta Sadhukhan wrote: > This test was timing out on windows during nightly testing possibly due to > samevm mode issue when it was problemlisted. > Modified test to increase the timing delay after frame is made visible, added > waitForIdle() at suitable pl

Integrated: 8163086: java/awt/Window/TranslucentJAppletTest/TranslucentJAppletTest.java fails

On Thu, 15 Apr 2021 08:03:27 GMT, Jayathirth D V wrote: > This bug is filed because of pixel color mismatch and i suspect it to be > related to wrong display color profile in macOS. > This test doesn't fail in local machine and in CI test machines in multiple > runs. >

Re: RFR: 8163086: java/awt/Window/TranslucentJAppletTest/TranslucentJAppletTest.java fails [v2]

ough it doesnt need any > User input. Modified the test to run as automated headful test and it runs > fine. > > I will file separate Verification task/bug to go through remaining manual > tests and check whether they can be made automated headful tests. Jayathirth D V has updated t

Re: RFR: 8233564: [TESTBUG] MouseComboBoxTest.java is failing [v2]

On Thu, 15 Apr 2021 09:04:59 GMT, Prasanta Sadhukhan wrote: >> Test was problemlisted due to it failing repeatedly on macos in automated >> nightly testing citing "java.awt.IllegalComponentStateException: component >> must be showing on the screen to determine its location " >> Added delay aft

Re: RFR: 8233564: [TESTBUG] MouseComboBoxTest.java is failing

On Tue, 13 Apr 2021 09:11:44 GMT, Prasanta Sadhukhan wrote: > Test was problemlisted due to it failing repeatedly on macos in automated > nightly testing citing "java.awt.IllegalComponentStateException: component > must be showing on the screen to determine its location " > Added delay after t

Re: RFR: 8233565: [TESTBUG] NullModalityDialogTest.java fails on MacOS

On Wed, 14 Apr 2021 10:38:03 GMT, Prasanta Sadhukhan wrote: > This test NullModalityDialogTest.java was failing repeatedly on macos in > automated testing citing "Tab navigation did not happen properly". > Modified to use invokeAndWait() instead of invokeLater and also use > setAutoDelay() wi

RFR: 8163086: java/awt/Window/TranslucentJAppletTest/TranslucentJAppletTest.java fails

This bug is filed because of pixel color mismatch and i suspect it to be related to wrong display color profile in macOS. This test doesn't fail in local machine and in CI test machines in multiple runs. Also this test was made to run in manual mode even though it doesnt need any User input. Mo

Re: RFR: 8258788: incorrect response to change in window insets [lanai] [v3]

On Sat, 10 Apr 2021 05:52:16 GMT, Jayathirth D V wrote: >> Alexey Ushakov has refreshed the contents of this pull request, and previous >> commits have been removed. The incremental views will show differences >> compared to the previous content of the PR. The pull request co

Re: RFR: 8258788: incorrect response to change in window insets [lanai] [v3]

On Fri, 9 Apr 2021 11:55:46 GMT, Alexey Ushakov wrote: >> Perform replaceSurfaceData on insets change > > Alexey Ushakov has refreshed the contents of this pull request, and previous > commits have been removed. The incremental views will show differences > compared to the previous content of t

Re: RFR: 8258788: incorrect response to change in window insets [lanai]

On Wed, 7 Apr 2021 23:04:04 GMT, Alexey Ushakov wrote: > Perform replaceSurfaceData on insets change @avu I am running CI tests, please wait until EOD for integration. - PR: https://git.openjdk.java.net/jdk/pull/3390

Re: RFR: 8258788: incorrect response to change in window insets [lanai]

On Tue, 6 Apr 2021 12:51:47 GMT, Alexey Ushakov wrote: > > @avu Test passes without fix also. > > @jayathirthrao Could you provide the details about your configuration along > > with parameters passed to jtreg ? @avu I am running test in 13 inch Macbook Early 2015 with integrated Intel Iris Gr

Re: RFR: 8258788: incorrect response to change in window insets [lanai]

On Tue, 6 Apr 2021 12:03:14 GMT, Jayathirth D V wrote: > > > Is it possible to automatically test it? > > > > > > Yes, just added the test. > > @avu Test passes without fix also. @aghaisas Please verify the regression test behavior from your en

Re: RFR: 8258788: incorrect response to change in window insets [lanai]

On Tue, 6 Apr 2021 12:03:14 GMT, Jayathirth D V wrote: >>> Is it possible to automatically test it? >> >> Yes, just added the test. > >> > Is it possible to automatically test it? >> >> Yes, just added the test. > > @avu Test passes wi

Re: RFR: 8258788: incorrect response to change in window insets [lanai]

On Fri, 2 Apr 2021 11:41:12 GMT, Alexey Ushakov wrote: > > Is it possible to automatically test it? > > Yes, just added the test. @avu Test passes without fix also. - PR: https://git.openjdk.java.net/jdk/pull/3308

Re: RFR: 8263928: Add JAWT test files for mac [v2]

On Mon, 22 Mar 2021 07:51:44 GMT, Prasanta Sadhukhan wrote: >> JAWT has testcase for windows and linux but no testcase is provided for mac. >> We need to have a JAWT based testcase for mac, in similar lines to windows >> and linux. > > Prasanta Sadhukhan has updated the pull request incremental

Re: RFR: 8260931: Implement JEP 382: New macOS Rendering Pipeline [v13]

On Thu, 11 Mar 2021 18:00:15 GMT, Ajit Ghaisas wrote: >> **Description :** >> This is the implementation of [JEP 382 : New macOS Rendering >> Pipeline](https://bugs.openjdk.java.net/browse/JDK-8238361) >> It implements a Java 2D internal rendering pipeline for macOS using the >> Apple Metal API

Re: RFR: 8260931: Implement JEP 382: New macOS Rendering Pipeline [v13]

> On 12-Mar-2021, at 10:30 AM, Sergey Bylokhov wrote: > > On Fri, 12 Mar 2021 00:09:54 GMT, Kevin Rushforth wrote: > >>> Ajit Ghaisas has updated the pull request with a new target base due to a >>> merge or a rebase. The incremental webrev excludes the unrelated changes >>> brought in by

Re: RFR: 8260931: Implement JEP 382: New macOS Rendering Pipeline [v13]

> On 12-Mar-2021, at 9:29 AM, Scott Palmer wrote: > > >> On Mar 11, 2021, at 9:53 PM, Sergey Bylokhov wrote: >> >> On Fri, 12 Mar 2021 02:29:04 GMT, Jayathirth D V wrote: >> >>>> src/java.desktop/macosx/classes/sun/java2d/metal/MTLSur

Re: RFR: 8260931: Implement JEP 382: New macOS Rendering Pipeline [v13]

On Fri, 12 Mar 2021 00:42:35 GMT, Sergey Bylokhov wrote: >> Ajit Ghaisas has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 47 additional >> commit

Re: RFR: 8260931: Implement JEP 382: New macOS Rendering Pipeline [v4]

On Thu, 11 Feb 2021 05:41:15 GMT, Ajit Ghaisas wrote: >> According to Xcode Instruments leak profile, there are 2 minor memory leaks >> in the Metal rendering pipeline: >> >> `#1 Malloc 80 Bytes 1 0x7fde0d4247b0 80 Byteslibjava.dylib >> getStringUTF8` >>0 libsystem_malloc

Re: RFR: 8260931: Implement JEP 382: New macOS Rendering Pipeline [v3]

On Mon, 8 Feb 2021 18:05:02 GMT, Gerard Ziemski wrote: >> Ajit Ghaisas has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Lanai PR#175 - 8261304 - aghaisas > > src/java.desktop/macosx/classes/sun/java2d/metal/MTLRenderQueue.java line 97: >

Re: RFR: 8260867: ProblemList java/awt/FullScreen/TranslucentWindow/TranslucentWindow.java on linux

On Mon, 1 Feb 2021 23:16:18 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList > java/awt/FullScreen/TranslucentWindow/TranslucentWindow.java on linux > in order to reduce the noise in the JDK17 CI. Marked as reviewed by jdv (Reviewer). - PR: https://git.openjdk.java.n

Re: RFR: 8259511: java/awt/Window/MainKeyWindowTest/TestMainKeyWindow.java failed with "RuntimeException: Test failed: 20 failure(s)" [v2]

On Mon, 18 Jan 2021 11:22:06 GMT, Sergey Bylokhov wrote: >> This test failed on the system where the wrong resolution was used(too >> small). Looks like that resolution was set by one of the tests and was not >> reset back because of a misconfigured automatic system reboot. I have >> checked t

Re: RFR: 8259511: java/awt/Window/MainKeyWindowTest/TestMainKeyWindow.java failed with "RuntimeException: Test failed: 20 failure(s)"

On Mon, 18 Jan 2021 04:05:27 GMT, Sergey Bylokhov wrote: >> Hi Sergey, >> >> I am trying to verify the fix in my mac, if i simply run the test without >> any change it is throwing error : "Use -nativepath to specify the location >> of native code". >> Do we need to change anything in the mac p

Re: RFR: 8259511: java/awt/Window/MainKeyWindowTest/TestMainKeyWindow.java failed with "RuntimeException: Test failed: 20 failure(s)"

On Sun, 17 Jan 2021 09:22:25 GMT, Sergey Bylokhov wrote: > This test failed on the system where the wrong resolution was used(too > small). Looks like that resolution was set by one of the tests and was not > reset back because of a misconfigured automatic system reboot. I have checked > that

Re: RFR: 8256201: java/awt/FullScreen/FullscreenWindowProps/FullscreenWindowProps.java failed

On Thu, 12 Nov 2020 08:46:36 GMT, Sergey Bylokhov wrote: > The new test added in JDK-8211999 hits a bug on Linux (in mach5 it is passed > on ubuntu 18.04 and failed on 20.04). The problem is that the bounds of the > fullscreen frame include insets of the frame additionally to the screen size. >

Re: RFR: 8241806: The sun/awt/shell/FileSystemViewMemoryLeak.java is unstable

On Thu, 29 Oct 2020 05:29:54 GMT, Sergey Bylokhov wrote: > The test may work up to 15 minutes on some systems. > The solution is to limit the time execution to 90 seconds. Marked as reviewed by jdv (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/923

Re: RFR: 8196087: java/awt/image/DrawImage/IncorrectUnmanagedImageRotatedClip.java fails

On Thu, 29 Oct 2020 04:12:53 GMT, Sergey Bylokhov wrote: > The test draws some specific pattern to the VolatileImage and to the > BufferedImage, and then compare pixels. > > The test uses the getSnapshot() method to get the pixels from VolatileImage, > and this method produces some interpolati

Re: RFR: 8255043: Incorrectly styled copyright text

On Tue, 20 Oct 2020 08:17:27 GMT, Sergey Bylokhov wrote: > In some files, the copyright text is styled as a JavaDoc comment. > Most of the affected files are tests, only one product file is affected: > src/java.sql/share/classes/javax/sql/package-info.java > > The chenge is trivial: > - /** >

Integrated: 8253739: java/awt/image/MultiResolutionImage/MultiResolutionImageObserverTest.java fails

On Thu, 1 Oct 2020 06:01:03 GMT, Jayathirth D V wrote: > Locally when i run this test i am seeing both the observers getting called > and flags are updated. > I suspect this to be an issue with less timeout which we are using for > verifying whether observer is getting called or &

Re: RFR: 8253739: java/awt/image/MultiResolutionImage/MultiResolutionImageObserverTest.java fails [v2]

sed timeout and verified > in CI pipeline there is no issue. Jayathirth D V has updated the pull request incrementally with one additional commit since the last revision: Made loaded memeber variable volatile - Changes: - all: https://git.openjdk.java.net/jdk/pull/450/fi

Re: RFR: 8253682: The AppletInitialFocusTest1.java is unstable

On Tue, 29 Sep 2020 10:03:05 GMT, Sergey Bylokhov wrote: > The test assumes that the code below will trigger the focus event on the > button2 immediately after setVisible(), but > the window can become visible really fast before button2.requestFocus(); is > called, so temporarily the button1 wi

RFR: 8253739: java/awt/image/MultiResolutionImage/MultiResolutionImageObserverTest.java fails

Locally when i run this test i am seeing both the observers getting called and flags are updated. I suspect this to be an issue with less timeout which we are using for verifying whether observer is getting called or not. Also i have increased sleep time. I have increased timeout and verified in

Re: RFR: 8251123: doclint warnings about missing javadoc tags and comments

On Fri, 25 Sep 2020 21:45:39 GMT, Sergey Bylokhov wrote: > We have a number of missing javadoc tags and comments in the desktop module. > Most of the missing comments are related to the serialized form. > > The fix: > - Adds missing comments to the non-static/non-transient fields(even > priva

Re: RFR: 8251123: doclint warnings about missing javadoc tags and comments

On Fri, 25 Sep 2020 21:45:39 GMT, Sergey Bylokhov wrote: > We have a number of missing javadoc tags and comments in the desktop module. > Most of the missing comments are related to the serialized form. > > The fix: > - Adds missing comments to the non-static/non-transient fields(even > priva

Re: RFR: 8251123: doclint warnings about missing javadoc tags and comments

On Fri, 25 Sep 2020 21:45:39 GMT, Sergey Bylokhov wrote: > We have a number of missing javadoc tags and comments in the desktop module. > Most of the missing comments are related to the serialized form. > > The fix: > - Adds missing comments to the non-static/non-transient fields(even > priva

Re: [OpenJDK 2D-Dev] PING: RFR: 8249215: JFrame::setVisible crashed with -Dfile.encoding=UTF-8

e? Thanks, Jay -Original Message- From: Yasumasa Suenaga Sent: Thursday, July 23, 2020 5:41 PM To: Jayathirth D v Cc: 2d-dev <2d-...@openjdk.java.net>; awt-dev@openjdk.java.net Subject: Re: [OpenJDK 2D-Dev] PING: RFR: 8249215: JFrame::setVisible crashed with -Dfile.encoding=UTF-8

Re: [OpenJDK 2D-Dev] PING: RFR: 8249215: JFrame::setVisible crashed with -Dfile.encoding=UTF-8

Hi, I tried reproducing the issue in my Windows 10 machine with UTF-8 encoding and test file mentioned in the bug, I don’t see any crash. Am I missing something? Also I think this should be in awt-dev so adding the mailing list. Thanks, Jay > On 20-Jul-2020, at 12:59 PM, Yasumasa Suenaga wrot

Re: [OpenJDK 2D-Dev] RFR: 8240654 : ZGC can cause severe UI application repaint issues

ce wrote: >>>>>> >>>>>> Can I get clarification here. >>>>>> >>>>>> > I do, and had to run with "-Dsun.java2d.uiScale=1" in order to see the >>>>>> > failure with LargeWindowPa

Re: [OpenJDK 2D-Dev] RFR: 8240654 : ZGC can cause severe UI application repaint issues

fix you needed the above >> property. >> If so we could just be looking at a similar anomaly as I saw with printing >> which uses a very large >> image - it reported failure but actually worked ! >> >> Also - for both of you - with the fix and witho

Re: [OpenJDK 2D-Dev] RFR: 8240654 : ZGC can cause severe UI application repaint issues

> On 11-Jun-2020, at 8:03 PM, Philip Race wrote: > > > > On 6/11/20, 1:57 AM, Jayathirth D v wrote: >> >> Hi Phil, >> >> I tried tested the fix in my Windows 10 machine with Intel integrated UHD >> Graphics 620. >> >> LargeW

Re: [OpenJDK 2D-Dev] RFR: 8240654 : ZGC can cause severe UI application repaint issues

you print before > saying whether it passes or not. FWIW, I verified that the printing test on > my system was hitting the fallback code with the patch, but it seemed to > print correctly even without the patch. > > -- Kevin > > > On 6/11/2020 1:58 AM, Jayathi

Re: [OpenJDK 2D-Dev] RFR: 8240654 : ZGC can cause severe UI application repaint issues

Typo : I tried tested -> I tried testing > On 11-Jun-2020, at 2:27 PM, Jayathirth D v wrote: > > Hi Phil, > > I tried tested the fix in my Windows 10 machine with Intel integrated UHD > Graphics 620. > > LargeWindowPaintTest.java passes with/without fix in my mac

Re: [OpenJDK 2D-Dev] RFR: 8240654 : ZGC can cause severe UI application repaint issues

Hi Phil, I tried tested the fix in my Windows 10 machine with Intel integrated UHD Graphics 620. LargeWindowPaintTest.java passes with/without fix in my machine. AlphaPrintTest.java without fix just opens up blank frame without any instructions and with fix it shows instructions for the test. I

RFR 8213129: java/awt/font/FontNames/LocaleFamilyNames.java times out in Win7

Hello All, Please review the following fix in JDK 15: Bug : https://bugs.openjdk.java.net/browse/JDK-8213129 Webrev : http://cr.openjdk.java.net/~jdv/8213129/webrev.00/ This test was probl

Re: RFR 8028701: java/awt/Focus/ShowFrameCheckForegroundTest/ShowFrameCheckForegroundTest.java fails

; start failing when run in nightly after removing from ProblemList. > > > -Pankaj > > > On 18/05/20 11:03 PM, Pankaj Bansal wrote: >> Is the test now passing continuously in our nightly? >> >> Regards, >> >> Pankaj >> >> >>

RFR 8028701: java/awt/Focus/ShowFrameCheckForegroundTest/ShowFrameCheckForegroundTest.java fails

Hello All, Please review the following fix in JDK 15: Bug : https://bugs.openjdk.java.net/browse/JDK-8028701 Webrev : http://cr.openjdk.java.net/~jdv/8028701/webrev.00/ This test was probl

Re: RFR: 8196019 java/awt/Window/Grab/GrabTest.java fails on Windows

Looks good to me. Thanks, Jay > On 07-Apr-2020, at 12:55 AM, Philip Race wrote: > > +1 > > -phil > > On 4/6/20, 5:20 AM, Sergey Bylokhov wrote: >> Hello. >> Please review the fix for jdk/client. >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8196019 >> Fix: http://cr.openjdk.java.net/~s

Re: RFR: 8241797 Add some tests to the problem list

Looks good to me. Thanks, Jay > On 30-Mar-2020, at 3:39 PM, Sergey Bylokhov > wrote: > > Hello. > Please review the fix for jdk/client. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8241797 > Fix: http://cr.openjdk.java.net/~serb/8241797/webrev.00 > > I have run the tests on a Windows pl

Re: RFR: 8240786 [TESTBUG] The test java/awt/Window/GetScreenLocation/GetScreenLocationTest.java fails on HiDPI screen

Looks good to me. Thanks, Jay > On 16-Mar-2020, at 10:09 AM, Sergey Bylokhov > wrote: > > Hello. > Please review the fix for jdk/client. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8240786 > Fix: http://cr.openjdk.java.net/~serb/8240786/webrev.00 > > The test tries to set the size of t

Re: [15] Review Request: 8233573 Toolkit.getScreenInsets(GraphicsConfiguration) may throw ClassCastException

+1. Thanks, Jay > On 10-Mar-2020, at 4:04 AM, Phil Race wrote: > > Looks fine. > > -phil > > On 3/9/20 3:14 PM, Sergey Bylokhov wrote: >> Any volunteers to review? =) >> >> On 12/19/19 9:15 pm, Sergey Bylokhov wrote: >>> Hello. >>> Please review the fix for JDK 15. >>> >>> Bug: https://bugs

Re: RFR: 8219578 No associated icon for the leaf node of Jtree

Change looks good to me. Thanks, Jay -Original Message- From: Philip Race Sent: Thursday, March 5, 2020 7:26 AM To: Sergey Bylokhov Cc: awt-dev@openjdk.java.net; 2d-dev <2d-...@openjdk.java.net>; swing-...@openjdk.java.net Subject: Re: RFR: 8219578 No associated icon for the leaf no

Re: [OpenJDK 2D-Dev] [14] RFR JDK-8235147: Release HDC from passiveDCList sooner

Hi Alexey, Change looks good to me. I think this change should be in awt-dev, so I have added the same for future reference. Thanks, Jay > On 24-Feb-2020, at 7:15 PM, Alexey Ivanov wrote: > > I'm still waiting for a second reviewer. > > Anyone? > Thank you in advance! > > > On 17/02/2020 1

Re: RFR: 8225126 Test SetBoundsPaintTest.html faild on Windows when desktop is scaled

Changes are fine. Thanks, Jay > On 03-Feb-2020, at 12:49 PM, Sergey Bylokhov > wrote: > > Hello. > Please review the fix for jdk/client. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8225126 > Fix: http://cr.openjdk.java.net/~serb/8225126/webrev.00 > > One more fix for the bug where we i

Re: [14] RFR JDK-8234184:[TESTBUG] java/awt/Mouse/EnterExitEvents/ModalDialogEnterExitEventsTest.java fails in Windows

webrev to just add robot.delay() for mouse entry into the frame: http://cr.openjdk.java.net/~jdv/8234184/webrev.04/ Thanks, Jay From: Prasanta Sadhukhan Sent: Friday, November 15, 2019 3:14 PM To: Jayathirth D V ; awt-dev@openjdk.java.net Subject: Re: [14] RFR JDK-8234184:[TESTBUG] java

Re: [14] RFR JDK-8234184:[TESTBUG] java/awt/Mouse/EnterExitEvents/ModalDialogEnterExitEventsTest.java fails in Windows

frame.dispose() EDT here is updated webrev: http://cr.openjdk.java.net/~jdv/8234184/webrev.03/ Thanks, Jay From: Prasanta Sadhukhan Sent: Friday, November 15, 2019 2:38 PM To: Jayathirth D V ; awt-dev@openjdk.java.net Subject: Re: [14] RFR JDK-8234184:[TESTBUG] java/awt/Mouse/EnterExitEvents

Re: [14] RFR JDK-8234184:[TESTBUG] java/awt/Mouse/EnterExitEvents/ModalDialogEnterExitEventsTest.java fails in Windows

updated webrev: http://cr.openjdk.java.net/~jdv/8234184/webrev.02/ Thanks, Jay From: Prasanta Sadhukhan Sent: Friday, November 15, 2019 1:19 PM To: Jayathirth D V ; awt-dev@openjdk.java.net Subject: Re: [14] RFR JDK-8234184:[TESTBUG] java/awt/Mouse/EnterExitEvents

Re: [14] RFR JDK-8234184:[TESTBUG] java/awt/Mouse/EnterExitEvents/ModalDialogEnterExitEventsTest.java fails in Windows

Sadhukhan Sent: Thursday, November 14, 2019 11:00 PM To: Jayathirth D V ; awt-dev@openjdk.java.net Subject: Re: [14] RFR JDK-8234184:[TESTBUG] java/awt/Mouse/EnterExitEvents/ModalDialogEnterExitEventsTest.java fails in Windows Probably we can call invokeAndWait() for createAndShowGUI instead

[14] RFR JDK-8234184:[TESTBUG] java/awt/Mouse/EnterExitEvents/ModalDialogEnterExitEventsTest.java fails in Windows

Hello All, Please review the following fix in JDK14: Bug : https://bugs.openjdk.java.net/browse/JDK-8234184 Webrev : http://cr.openjdk.java.net/~jdv/8234184/webrev.00/ Issue : We are disposing the frame even before we record Mouse Entry event. Solution : Added appropriate waits to r

Re: [14] RFR JDK-8233696:[TESTBUG]Some jtreg tests fail when CAPS_LOCK is ON

rm that all of them release these keys on all code paths. > > @Phil : Yes we should use equalsIgnoreCase() that would be more cleaner > approach. I will update the webrev. > > Thanks, > Jay > >> On 08-Nov-2019, at 2:27 AM, Sergey Bylokhov > <mailto:sergey.byl

Re: [14] RFR JDK-8233696:[TESTBUG]Some jtreg tests fail when CAPS_LOCK is ON

4:23 am, Jayathirth D V wrote: Solution : I tried many things like finding test cases where we might not be restoring the CAPS_LOCK state or using get/setLockingKeyState(). But they were not feasible solutions Why this solution does not work? so I am modifying the test cases which are

[14] RFR JDK-8233696:[TESTBUG]Some jtreg tests fail when CAPS_LOCK is ON

Hello All, Please review the following fix in JDK14: Bug : https://bugs.openjdk.java.net/browse/JDK-8233696 Webrev : http://cr.openjdk.java.net/~jdv/8233696/webrev.00/ Issue : State of CAPS_LOCK changes the way some of our jtreg tests behave. Solution : I tried many things like findin

Re: RFR: 8225105: java/awt/Focus/ShowFrameCheckForegroundTest/ShowFrameCheckForegroundTest.java fails in Windows 10

hirth D V; awt-dev@openjdk.java.net Subject: Re: RFR: 8225105: java/awt/Focus/ShowFrameCheckForegroundTest/ShowFrameCheckForegroundTest.java fails in Windows 10 Hi, Jay. Looks fine, please confirm that this test is green in mach5 after this fix. On 31/05/2019 01:51, Jayathirth D V wrote: > H

RFR: 8225105: java/awt/Focus/ShowFrameCheckForegroundTest/ShowFrameCheckForegroundTest.java fails in Windows 10

Hello All, Please review the following fix in JDK 13: Bug : https://bugs.openjdk.java.net/browse/JDK-8225105 Webrev : http://cr.openjdk.java.net/~jdv/8225105/webrev.00/ Cause : As test hits stage 2, if required component is not present in the foreground it fails. Looks like in slower

Re: [13] RFR JDK-8224821: java/awt/Focus/NoAutotransferToDisabledCompTest/NoAutotransferToDisabledCompTest.java fails linux-x64

+1 Thanks, Jay -Original Message- From: Prasanta Sadhukhan Sent: Tuesday, May 28, 2019 4:19 PM To: Jayathirth D V; awt-dev@openjdk.java.net Subject: Re: [13] RFR JDK-8224821: java/awt/Focus/NoAutotransferToDisabledCompTest/NoAutotransferToDisabledCompTest.java fails linux-x64 Thanks

Re: [13] RFR 8224830:test/jdk/java/awt/Focus/ModalExcludedWindowClickTest/ModalExcludedWindowClickTest.java fails on linux-x64

+1 Thanks, Jay -Original Message- From: Prasanta Sadhukhan Sent: Tuesday, May 28, 2019 4:16 PM To: Jayathirth D V; awt-dev@openjdk.java.net Subject: Re: [13] RFR 8224830:test/jdk/java/awt/Focus/ModalExcludedWindowClickTest/ModalExcludedWindowClickTest.java fails on linux-x64 Thanks

Re: [13] RFR 8224830:test/jdk/java/awt/Focus/ModalExcludedWindowClickTest/ModalExcludedWindowClickTest.java fails on linux-x64

Hi Prasanta, Changes are fine. Also its better to add delay between input events like Press & release. Or you can set auto delay on robot. Thanks, Jay -Original Message- From: Prasanta Sadhukhan Sent: Tuesday, May 28, 2019 2:46 PM To: awt-dev@openjdk.java.net Subject: Re: [13] RFR 82

Re: [13] RFR JDK-8224821: java/awt/Focus/NoAutotransferToDisabledCompTest/NoAutotransferToDisabledCompTest.java fails linux-x64

Hi Prasanta, We are already waiting for 2 secs in Util.focusComponent(), do we need the first delay of 2 secs just before that? Second robot.delay() is okay. Thanks, Jay -Original Message- From: Prasanta Sadhukhan Sent: Tuesday, May 28, 2019 2:47 PM To: awt-dev@openjdk.java.net Subject

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8176556: java/awt/dnd/ImageTransferTest/ImageTransferTest.java fails for JFIF

n or throw something like UnsupportedOperationException we can do it in separate bug. Please let me know I will raise separate bug for the same. Thanks, Jay -Original Message- From: Sergey Bylokhov Sent: Friday, November 09, 2018 12:41 AM To: Jayathirth D V; Philip Race; Brian Bu

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8176556: java/awt/dnd/ImageTransferTest/ImageTransferTest.java fails for JFIF

Hello All, I am replying to the last mail in this thread. >From the test case we can see that it is not strict about pixel data which was >transferred during DnD. It is just making sure we are able to do DnD for all >native image formats. In test case ImageTransferer. areImagesIdentical(

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8176556: java/awt/dnd/ImageTransferTest/ImageTransferTest.java fails for JFIF

Hello All, Forgot to update ProblemList. Please find updated webrev with ProblemList change also : http://cr.openjdk.java.net/~jdv/8176556/webrev.01/ Thanks, Jay From: Jayathirth D V Sent: Wednesday, November 07, 2018 3:42 PM To: 2d-dev; awt-dev@openjdk.java.net Subject

  1   2   >