Re: [13] Review request for JDK-8207938: At step6, Click Add button, case failed automatically.

s, TrayIcon is disposed and set to null when TrayIcon image is removed from the System tray. TrayIcon is re-initialized when TrayIcon image is added to System tray if it is null. > Regards > Prasanta > On 05-Feb-19 3:21 PM, Manajit Halder wrote: >> Hi All, >> >> Please re

[13] Review request for JDK-8207938: At step6, Click Add button, case failed automatically.

Hi All, Please review the fix for JDK13. Bug: https://bugs.openjdk.java.net/browse/JDK-8207938 Webrev: http://cr.openjdk.java.net/~mhalder/8207938/webrev.00/ Fix: Problem occur while tr

Re: [12] Review request for JDK-8215280: Double click on titlebar not working for Frame with extended state set to MAXIMIZED_BOTH

> Why did you drop this check "&& !isMaximizedBoth();" from the > setResizable(resizable)? This change is necessary to fix the bug? > > BTW I have started to feel that probably we should not fix initial bug at all > and leave it as is, and by default use the nati

Re: [12] Review request for JDK-8215280: Double click on titlebar not working for Frame with extended state set to MAXIMIZED_BOTH

Hi Sergey, You are right. I have changed the code to reset the resizable behaviour in NORMAL state. Please review the webrev: http://cr.openjdk.java.net/~mhalder/8215280/webrev.01/ Regards, Manajit > On 05-Jan-2019, at 3:54 AM, Sergey By

[12] Review request for JDK-8215280: Double click on titlebar not working for Frame with extended state set to MAXIMIZED_BOTH

Hi All, Please review the fix for JDK12. Bug: https://bugs.openjdk.java.net/browse/JDK-8215280 Webrev: http://cr.openjdk.java.net/~mhalder/8215280/webrev.00/ Fix: On double clicking a f

Re: [12] Review request for JDK-8209123: [Macosx] Maximized frame is resizable on Mac but not on Windows and Ubuntu

Hi Sergey, You are right, the issue is observed sometimes on double clicking title bar for few times and sometimes it is not observed at all. I have created an issue to work on it. https://bugs.openjdk.java.net/browse/JDK-8215280 Regards, Mana

Re: [12] Review request for JDK-8209123: [Macosx] Maximized frame is resizable on Mac but not on Windows and Ubuntu

moved to the normal state, but in the fix you set > "updateResizableAndMaximizeState(true)" > which changed the frame to non-resizable. > > On 21/09/2018 04:37, Manajit Halder wrote: >> Hi All, >> Please review the fix for JDK12. > > Bug: >> https://bugs.open

[12] Review request for JDK-8208290: [TEST_BUG] The maximized unfocusable frame can be resized

\tx560\tx1120\tx1680\tx2240\tx2800\tx3360\tx3920\tx4480\tx5040\tx5600\tx6160\tx6720\pardirnatural\partightenfactor0 \f0\fs24 \cf2 From: Manajit Halder \ Subject: Re: [12] Review request for JDK-8208743: JDialog with JTextArea can't accept focus when setResizable(false) called\ Date: 20 August

Re: [12] Review request for JDK-8209123: [Macosx] Maximized frame is resizable on Mac but not on Windows and Ubuntu

t is allowing me to resize even though it is maximised. > In Mac a maximized window can be resized but fullscreen window can’t be resized. > Regards > Prasanta > On 22-Nov-18 6:05 PM, Manajit Halder wrote: >> Hi Prasanta, >> >> Please find my answer in

Re: [12] Review request for JDK-8209123: [Macosx] Maximized frame is resizable on Mac but not on Windows and Ubuntu

> Regards > Prasanta > On 13-Nov-18 2:07 PM, Manajit Halder wrote: >> Hi All, >> >> Gentle remainder. Please review this fix. >> >> Regards, >> Manajit >> >> >> On 08/10/18 10:27 AM, Krishna Addepalli wrote: >>> Looks fine. >

Re: [12] Review request for JDK-8209123: [Macosx] Maximized frame is resizable on Mac but not on Windows and Ubuntu

Hi All, Gentle remainder. Please review this fix. Regards, Manajit On 08/10/18 10:27 AM, Krishna Addepalli wrote: Looks fine. Krishna *From:*Manajit Halder *Sent:* Thursday, October 4, 2018 6:01 PM *To:* Krishna Addepalli ; awt-dev@openjdk.java.net *Subject:* Re: [12] Review request for

[12] Review request for JDK-8213522: [TEST_BUG] 16 java/awt/Focus test cases fails on Mac OS when run in group but passes individually

Hi All, Please review the test fix for JDK12. Bug: https://bugs.openjdk.java.net/browse/JDK-8213522 Webrev: http://cr.openjdk.java.net/~mhalder/8213522/webrev.00/ Fix: 16 java/awt/Focus

Re: Swing dev>[12] Review request for JDK-8189253: [macos] JPopupMenu is inadvertently shown when using setComponentPopupMenu

Changed the targeted review version to 12. Regards, Manajit On 31/10/18 10:09 PM, Manajit Halder wrote: Hi Dmitry/Sergey, I have a different fix for this issue in Mac OS specific code. In this proposed fix I am trying to fix the window addition/ordering with respect to the screen on which

Re: [OFF LIST] Swing dev>[10] Review request for JDK-8189253: [macos] JPopupMenu is inadvertently shown when using setComponentPopupMenu

Please clarify why this bug is occurred after JDK-8080729, how=20 orderWindow/addChildWindow are related to the mouse events which we get?=20 Did we start to get more event or less events or we get events in the=20 different order, what is the difference? On 04/01/2018 10:22, Manajit Halder wrot

Re: [12] Review request for JDK-8208543: [macos] Support for apple.awt.documentModalSheet incomplete

e: Hi Manajit, Currently the test is marked as ‘passed’ if timeout takes place. I think we should indicate an error or mark it as ‘failed’ in such case. Thanks, Dmitry On 25 Oct 2018, at 11:35, Manajit Halder wrote: Hi Dmitry, Thanks for your comments. I have addressed all your review comments

Re: [12] Review request for JDK-8208543: [macos] Support for apple.awt.documentModalSheet incomplete

etter to declare createAndShowModalSheet() and createAndShowInstructionFrame() as static. In such case the creation of class instance may be omitted. Thanks, Dmitry On 12 Oct 2018, at 05:36, Manajit Halder wrote: Hi Dmitry, Could you please review this fix related to Modal sheet on Mac OS? Regards, Manaj

Re: [12] Review request for JDK-8208543: [macos] Support for apple.awt.documentModalSheet incomplete

Hi Dmitry, Could you please review this fix related to Modal sheet on Mac OS? Regards, Manajit On 10/10/18 3:33 PM, Manajit Halder wrote: Hi All, Kindly review the fix for JDK12. Bug: https://bugs.openjdk.java.net/browse/JDK-8208543 Webrev: http://cr.openjdk.java.net/~mhalder/8208543

Re: [12] JDK-8061359: [macosx] Checkbox toggles on Space press but does not spoken by Voice Over

Looks good me. Regards, Manajit On 09/10/18 9:50 AM, Shashidhara Veerabhadraiah wrote: Could I get a one more review of this? Thanks and regards, Shashi -Original Message- From: Sergey Bylokhov Sent: Friday, October 5, 2018 4:47 AM To: Shashidhara Veerabhadraiah ; awt-dev@openjdk.ja

[12] Review request for JDK-8208543: [macos] Support for apple.awt.documentModalSheet incomplete

Hi All, Kindly review the fix for JDK12. Bug: https://bugs.openjdk.java.net/browse/JDK-8208543 Webrev: http://cr.openjdk.java.net/~mhalder/8208543/webrev.00/ Problem: "apple.awt.documentModalSheet" was getting set on the Dialog whil

Re: [12] Review request for JDK-8209123: [Macosx] Maximized frame is resizable on Mac but not on Windows and Ubuntu

izable && !isMaximizedBoth()”.     Changed code as per the comment. Thanks, Krishna *From:*Manajit Halder *Sent:* Tuesday, September 25, 2018 3:23 PM *To:* Krishna Addepalli <mailto:krishna.addepa...@oracle.com>> *Subject:* Re: [12] Review request for JDK-8209123: [Macosx] Maximize

[12] Review request for JDK-8209123: [Macosx] Maximized frame is resizable on Mac but not on Windows and Ubuntu

Hi All, Please review the fix for JDK12. 

Bug: https://bugs.openjdk.java.net/browse/JDK-8209123 
Webrev: 
 http://cr.openjdk.java.net/~mhalder/8209123/webrev.00/ Fix: 
     Resizibil

Re: [12] RFR JDK-8191178:[macos] Problem with input of yen symbol

Fix looks good to me. Regards, Manajit On 18/09/18 4:02 PM, Dmitry Markov wrote: That’s right. The changes look good to me. Thanks, Dmitry On 17 Sep 2018, at 17:01, Prasanta Sadhukhan > wrote: Hi Dmitry, I guess fullwidth currency symbols are U+FF04 <

Re: [12] Review request for JDK-8206392: [macosx] Cycling through windows (JFrames) does not work with keyboard shortcut

On 7 Sep 2018, at 12:22, Manajit Halder <mailto:manajit.hal...@oracle.com>> wrote: Hi Dmitry, Thanks for the test scenarios. I have run all the AWT, Swing and JCK automatic (open and closed) test cases along with manual test cases related to Modal Dialog and ordering to ensure that fix

Re: [12] Review request for JDK-8206392: [macosx] Cycling through windows (JFrames) does not work with keyboard shortcut

Front() call, etc. Can you verify that these scenarios still work properly on the build with your fix, please? Also it would be good to execute related AWT/Swing jtreg tests to ensure that nothing is broken. Thanks, Dmitry On 4 Sep 2018, at 18:54, Manajit Halder <mailto:manajit.hal..

Re: [12] Review request for JDK-8206392: [macosx] Cycling through windows (JFrames) does not work with keyboard shortcut

release 8u131. 8169589 introduced new window ordering model and which has introduced the cycling through window issue. Thanks, Dmitry On 31 Aug 2018, at 07:55, Manajit Halder <mailto:manajit.hal...@oracle.com>> wrote: Hi All, Please review the fix for JDK12. 

B

[12] Review request for JDK-8206392: [macosx] Cycling through windows (JFrames) does not work with keyboard shortcut

Hi All, Please review the fix for JDK12. 

Bug: https://bugs.openjdk.java.net/browse/JDK-8206392 
Webrev: 
 http://cr.openjdk.java.net/~mhalder/8206392/webrev.00/ Fix: 
     Window or

Re: [12] Review request for JDK-8208743: JDialog with JTextArea can't accept focus when setResizable(false) called

rds Prasanta On 8/16/2018 5:11 PM, Manajit Halder wrote: Hi All, Please review the fix for JDK12. 

Bug: https://bugs.openjdk.java.net/browse/JDK-8208743 
Webrev: 
 http://cr.openjdk.java.net/~mhalder/8208743/webrev.00/ <http://cr.openjdk.java.net/%7Emhalder/8208743/webrev.00/> Fix: 


[12] Review request for JDK-8208743: JDialog with JTextArea can't accept focus when setResizable(false) called

Hi All, Please review the fix for JDK12. 

Bug: https://bugs.openjdk.java.net/browse/JDK-8208743 
Webrev: 
 http://cr.openjdk.java.net/~mhalder/8208743/webrev.00/ Fix: 
     This reported issue is resolved by fix of issue JDK-8208125

Re: Subject: [11] Review request for JDK-8208125: Cannot input text into JOptionPane Text Input Dialog

g, with the full back story, and reference it here ? -phil. On 08/03/2018 04:23 AM, Manajit Halder wrote: Hi All, Please review the fix for JDK11. 

Bug: 
https://bugs.openjdk.java.net/browse/JDK-8208125 <https://bugs.openjdk.java.net/browse/JDK-8208125> 
Webrev: 
 http://cr

Subject: [11] Review request for JDK-8208125: Cannot input text into JOptionPane Text Input Dialog

Hi All, Please review the fix for JDK11. 

Bug: 
https://bugs.openjdk.java.net/browse/JDK-8208125 
Webrev: 
 http://cr.openjdk.java.net/~mhalder/8208125/webrev.00/ 
Issue:     This

[11] Review request for JDK-8208394: [macosx] test java/awt/Frame/UnfocusableMaximizedFrameResizablity/UnfocusableMaximizedFrameResizablity.java compilation fail

Hi All, Kindly review the fix for JDK11. Bug: https://bugs.openjdk.java.net/browse/JDK-8208394 Webrev: http://cr.openjdk.java.net/~mhalder/8208394/webrev.00/ Regards, Manajit

Re: [11] Review request for JDK-8204860: The frame could be resized by dragging a corner of the frame with the mouse

Manajit. >> Did you run the test on other platforms? >> I am not sure, but look like the line below can throw npe: >> if(!prop1.equals(prop2)) { >> >> On 06/07/2018 16:37, Manajit Halder wrote: >>> Hi Sergey, >>> >>> Checked the behaviour of

Re: [11] Review request for JDK-8204860: The frame could be resized by dragging a corner of the frame with the mouse

tProperty("apple.awt.fullscreenable"); > frame.setVisible(false); > frame.setVisible(true); > v2 = frame.getRootPane().getClientProperty("apple.awt.fullscreenable"); > if(!v1.equals(v2)) Error(); > > > On 02/07/2018 20:12, Manajit Halder wrote: >>

Re: [12] JDK-8195991: [TEST_BUG]:Regression manual Test java/awt/TrayIcon/RightClickWhenBalloonDisplayed/RightClickWhenBalloonDisplayed.html fails

~sveerabhadra/8195991/webrev.02/> > Thanks and regards, > Shashi > > On 03/07/18 1:25 PM, Manajit Halder wrote: >> Hi Shashi, >> >> BUTTON1_MASK and BUTTON3_MASK are deprecated. >> Remaining code changes looks good. >> >> Regards, &

Re: [12] JDK-8195991: [TEST_BUG]:Regression manual Test java/awt/TrayIcon/RightClickWhenBalloonDisplayed/RightClickWhenBalloonDisplayed.html fails

Hi Shashi, BUTTON1_MASK and BUTTON3_MASK are deprecated. Remaining code changes looks good. Regards, Manajit > On 02-Jul-2018, at 9:43 AM, Shashidhara Veerabhadraiah > wrote: > > Thank you Sergey for the review. > > -Shashi > > -Original Message- > From: Sergey Bylokhov > Sent: Sun

Re: [11] Review request for JDK-8204860: The frame could be resized by dragging a corner of the frame with the mouse

et).isResizable() : > ((target instanceof Dialog) ? ((Dialog)target).isResizable() : false > > On 28/06/2018 05:54, Manajit Halder wrote: >> Hi Sergey, >> Thanks for your review comment. I have modified the fix to incorporate your >> suggestions. >> Please re

Re: [11] Review request for JDK-8204860: The frame could be resized by dragging a corner of the frame with the mouse

t to update the testcase to cover all this cases which we found > during review. > > On 21/06/2018 12:26, Manajit Halder wrote: >> Hi Phil and Sergey, >> I have changed the code as per your suggestions. Now window is resized based >> on the following condition: >> I

Re: [11] Review request for JDK-8204860: The frame could be resized by dragging a corner of the frame with the mouse

anajit > On 20-Jun-2018, at 6:27 PM, Manajit Halder wrote: > > Hi Phil, > > Please find my answer inline to your comment. > >> On 15-Jun-2018, at 11:24 PM, Phil Race > <mailto:philip.r...@oracle.com>> wrote: >> >> I would like to refer

Re: [11] Review request for JDK-8204860: The frame could be resized by dragging a corner of the frame with the mouse

e code as per the suggestion. Please review the modified code. http://cr.openjdk.java.net/~mhalder/8204860/webrev.01/ <http://cr.openjdk.java.net/~mhalder/8204860/webrev.01/> Regards, Manajit > -phil. > > On 06/14/2018 11:37 PM, Manajit Halder wrote: >> Hi All, >> &g

[11] Review request for JDK-8204860: The frame could be resized by dragging a corner of the frame with the mouse

Hi All, Kindly review the fix for JDK11. Bug: https://bugs.openjdk.java.net/browse/JDK-8204860 Webrev: http://cr.openjdk.java.net/~mhalder/8204860/webrev.00/ Fix: Frame is focusable:

[11] Review request for JDK-8204859: [macosx] Remove javax/swing/plaf/nimbus/8057791/bug8057791.java from the ProblemList.txt

Hi All, Kindly review the fix for JDK11. Bug: https://bugs.openjdk.java.net/browse/JDK-8204859 Webrev: http://cr.openjdk.java.net/~mhalder/8204859/webrev.00/ Changes: Removed particula

Re: [11] Review request for JDK-8029250: [macosx] There is no tray icon shown in the system tray area when case starts

w method. In this case CMenuItem/CCustomCursor will not be >> changed. >> - The parentheses around target are not necessary >>CTrayIcon.java:359 if (image != (target).getImage()) >> >> >> On 03/05/2018 04:11, Manajit Halder wrote: >>> Hi Sergey,

Re: [11] Review request for JDK-8029250: [macosx] There is no tray icon shown in the system tray area when case starts

t;> changed. >> - The parentheses around target are not necessary >>CTrayIcon.java:359 if (image != (target).getImage()) >> >> >> On 03/05/2018 04:11, Manajit Halder wrote: >>> Hi Sergey, >>> >>> Please review the updated webrev. >

Re: [11] Review request for JDK-8202841: [macosx] test java/awt/Graphics/LCDTextAndGraphicsState.java fails

;t seem ideal. > You can either use a semaphore or it can use a sleep loop waiting for a flag > to be set. > > -phil. > > > > On 05/15/2018 05:19 AM, Manajit Halder wrote: >> Hi Phil, >> >> My observation on test written using manual=yesno: >&g

Re: [11] Review request for JDK-8202841: [macosx] test java/awt/Graphics/LCDTextAndGraphicsState.java fails

s is only implemented for applets. > > So are those other strings applets or main programs. > > -phil. > > On 5/10/18, 1:58 PM, Sergey Bylokhov wrote: >> Hi, Manajit. >> Did you check other tests with such typos? >> I found the same strings in our repo. >>

Re: [11] Review Request: JDK-8196616 java/awt/GraphicsDevice/DisplayModes/CompareToXrandrTest.java fails

Looks good to me Regards, Manajit > On 14-May-2018, at 10:38 PM, Phil Race wrote: > > This works on my system. > > +1 > > -phil. > > On 05/10/2018 01:30 PM, Pankaj Bansal wrote: >> Hi Phil, >> >> Thanks for the quick review. >> >> <> takeWhile() which >> <> internal buffer >> <> Buffered

[11] Review request for JDK-8202841: [macosx] test java/awt/Graphics/LCDTextAndGraphicsState.java fails

Hi Phil, Please review the test fix for JDK11. Bug: https://bugs.openjdk.java.net/browse/JDK-8202841 Webrev: http://cr.openjdk.java.net/~mhalder/8202841/webrev.00/ Issue: Test fails

Re: [11] Review request for JDK-8029250: [macosx] There is no tray icon shown in the system tray area when case starts

t 4:06 PM, Manajit Halder wrote: > > Hi All, > > Kindly review the following AWT enhancement changes: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8029250 > <https://bugs.openjdk.java.net/browse/JDK-8029250> > Webrev: http://cr.openjdk.java.n

[11] Review request for JDK-8029250: [macosx] There is no tray icon shown in the system tray area when case starts

Hi All, Kindly review the following AWT enhancement changes: Bug: https://bugs.openjdk.java.net/browse/JDK-8029250 Webrev: http://cr.openjdk.java.net/~mhalder/8029250/webrev.00/ Fix:

Re: [11] Review Request: 8199932 Missing copyright header in AWT source code

Looks good to me. Regards, Manajit > On 07-Apr-2018, at 5:55 AM, Sergey Bylokhov > wrote: > > Hello. > Please review small cleanup for jdk11. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8199932 > Webrev can be found at: http://cr.openjdk.java.net/~serb/8199932/webrev.00 > > A few place

Re: Subject: [11] Review request for JDK-7158623: [macosx] Should an unfocusable maximized Frame be resizable?

was 11011010 (the 9th bit is not set) The bit setting is done in the native method Java_sun_lwawt_macosx_CPlatformWindow_nativeSetNSWindowStyleBits. Thanks, Manajit > On 26-Feb-2018, at 1:28 PM, Manajit Halder wrote: > > Hi Phil and Kevin, > > Sorry for specifying wrong JDK versi

Re: [11] Review request for JDK-8190767: [macos] if JFrame is maximized on OS X, all new JFrames will be maximized by default

halder/8190767/webrev.04/ <http://cr.openjdk.java.net/~mhalder/8190767/webrev.04/> Regards, Manajit > On 05-Mar-2018, at 11:36 PM, Sergey Bylokhov > wrote: > > Hi, Manajit. > On 26/02/2018 05:45, Manajit Halder wrote: >> Changed the fix as per Sergey’s review comment.

Re: [11][JDK-8197808] Test java/awt/Dialog/MakeWindowAlwaysOnTop/MakeWindowAlwaysOnTop.java fails on Windows

Hi Krishna, Fix looks good. I suggest the following changes before committing. 1) Remove the comma in between the two bug ids. 2) Is the message “Test PASSED” required? Regards, Manajit > On 26-Feb-2018, at 10:23 PM, Semyon Sadetsky > wrote: > > +1 > > --Semyon > > > On 02/25/2018 05:

Re: [11] Review request for JDK-8190767: [macos] if JFrame is maximized on OS X, all new JFrames will be maximized by default

.03/ <http://cr.openjdk.java.net/~mhalder/8190767/webrev.03/> Thanks, Manajit > On 17-Feb-2018, at 8:03 AM, Manajit Halder wrote: > > Correcting the subject to indicate that the fix is for JDK 11. > > Regard, > Manajit > >> On 16-Feb-2018, at 9:48 PM, Kevin

[11] Review Request: JDK-8171381 Test javax/swing/JPopupMenu/7156657/bug7156657.java fails on OS X

Hi All, Please review fix for JDK 11 Bug: https://bugs.openjdk.java.net/browse/JDK-8171381 Webrev: http://cr.openjdk.java.net/~mhalder/8171381/webrev.00/ Fix:

Re: [11] Review Request: JDK-8196435 Regression automated Test 'java/awt/Mouse/GetMousePositionTest/GetMousePositionWithOverlay.java' fails

Looks good. +1 Regards, Manajit > On 26-Feb-2018, at 10:59 AM, Prem Balakrishnan > wrote: > > Hi All, > > Please review fix for JDK 11: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8196435 > > > Webrev: http://cr.openjdk.java.net/

Re: Subject: [11] Review request for JDK-7158623: [macosx] Should an unfocusable maximized Frame be resizable?

es not match > what you > say you are doing. > > -phil. > > On 02/16/2018 08:17 AM, Kevin Rushforth wrote: >> >> > Kindly review the fix for JDK10. >> >> You mean JDK 11, right? >> >> -- Kevin >> >> >> Manajit Halder wr

Re: [10] Review request for JDK-8190767: [macos] if JFrame is maximized on OS X, all new JFrames will be maximized by default

anajit >>> >>> On 31-Jan-2018, at 2:40 AM, Sergey Bylokhov >> <mailto:sergey.bylok...@oracle.com>> wrote: >>> >>> Hi, Manajit. >>> Did you check that it works properly in jdk8? >>> >>> I guess we need to set "WIN

Subject: [11] Review request for JDK-7158623: [macosx] Should an unfocusable maximized Frame be resizable?

Hi All, Kindly review the fix for JDK10. Bug: https://bugs.openjdk.java.net/browse/JDK-7158623 Webrev: http://cr.openjdk.java.net/~mhalder/7158623/webrev.00/ Issue: Unfocusable frame w

Re: [10] Review request for JDK-8190767: [macos] if JFrame is maximized on OS X, all new JFrames will be maximized by default

is MAXIMIZED_BOTH. > > On 29/01/2018 04:39, Manajit Halder wrote: >> Hi All, >> Kindly review the fix for JDK10. >> Bug: >> https://bugs.openjdk.java.net/browse/JDK-8190767 >> Webrev: >> http://cr.openjdk.java.net/~mhalder/8190767/webrev.00/ >> Proble

Re: [11][JDK-8171000]Robot.createScreenCapture() crashes in wayland mode

Looks good to me +1 Regards, Manajit > On 05-Feb-2018, at 9:59 AM, Sergey Bylokhov > wrote: > > OK, then it looks fine. > > On 03/02/2018 20:13, Krishna Addepalli wrote: >> Hi Sergey, >> I'm aware of the C99 thing, so I looked around in the file before making >> those changes. For example, w

Re: [11] Review request for JDK-8190767: [macos] if JFrame is maximized on OS X, all new JFrames will be maximized by default

Correcting the JDK version to be reviewed for to JDK 11. > On 29-Jan-2018, at 6:09 PM, Manajit Halder wrote: > > Hi All, > > Kindly review the fix for JDK11. > > Bug: > https://bugs.openjdk.java.net/browse/JDK-8190767 > <https://bugs.openjdk.java.net/b

[10] Review request for JDK-8190767: [macos] if JFrame is maximized on OS X, all new JFrames will be maximized by default

Hi All, Kindly review the fix for JDK10. Bug: https://bugs.openjdk.java.net/browse/JDK-8190767 Webrev: http://cr.openjdk.java.net/~mhalder/8190767/webrev.00/ Problem: In this

Re: [10] Review request for JDK-8158366: [macosx] Regression: closed/java/awt/dnd/RecognizedActionTest/RecognizedActionTest.html fails

x as well? > > Regards, > Ajit > > From: Manajit Halder > Sent: Monday, November 27, 2017 4:35 PM > To: Ajit Ghaisas > Cc: Prem Balakrishnan; Sergey Bylokhov; awt-dev@openjdk.java.net > Subject: Re: [10] Review request for JDK-8158366: [macosx] > R

Re: [10] Review request for JDK-8158366: [macosx] Regression: closed/java/awt/dnd/RecognizedActionTest/RecognizedActionTest.html fails

> -Original Message- > From: Sergey Bylokhov > Sent: Friday, November 24, 2017 1:16 PM > To: Manajit Halder ; Prem Balakrishnan > > Cc: awt-dev@openjdk.java.net > Subject: Re: [10] Review request for JDK-8158366: [macosx] > Regression: > closed/java/awt/d

[10] Review request for JDK-8158366: [macosx] Regression: closed/java/awt/dnd/RecognizedActionTest/RecognizedActionTest.html fails

Hi All, Kindly review the fix for JDK10. Bug: https://bugs.openjdk.java.net/browse/JDK-8158366 Webrev: http://cr.openjdk.java.net/~mhalder/8158366/webrev.00/ Issue: Test closed/java/

Re: [10] Review request for JDK-8163265: [macosx] numpad 0 instead of VK_0

t; Please update the @bugid in the test before the push. >> >> On 16/10/2017 06:38, Manajit Halder wrote: >>> Hi All, >>> >>> Kindly review the fix for JDK10. >>> >>> Bug: >>> https://bugs.openjdk.java.net/browse/JDK-8163265 >>

[10] Review request for JDK-8163265: [macosx] numpad 0 instead of VK_0

Hi All, Kindly review the fix for JDK10. Bug: https://bugs.openjdk.java.net/browse/JDK-8163265 Webrev: http://cr.openjdk.java.net/~mhalder/8163265/webrev.00/ Issue: Wrong event code

[10] Review request for JDK-8177326: [macosx] mouse event goes to button in java/awt/Mouse/EnterExitEvents/DragWindowOutOfFrameTest.java

Hi All, Kindly review the fix for JDK10. Bug: https://bugs.openjdk.java.net/browse/JDK-8177326/ Webrev: http://cr.openjdk.java.net/~mhalder/8177326/webrev.00/ Issue: [macosx] mouse

[10] Review request for JDK-8165863:[macosx] stack overflow in java/awt/Component/SetEnabledPerformance/SetEnabledPerformance.java

Hi All, Kindly review the fix for JDK10. Bug: https://bugs.openjdk.java.net/browse/JDK-8165863 Webrev: http://cr.openjdk.java.net/~mhalder/8165863/webrev.00/ Root cause: The problem wa

Re: [10] Review request for JDK-8136999: [macosx] NSException and NPE in a crash test

Hi Sergey, Added the test case from the previous iteration of the fix. Please review the webrev: http://cr.openjdk.java.net/~mhalder/8136999/webrev.01/ Regards, Manajit > On 26-Jul-2017, at 10:32 PM, Sergey Bylokhov > wrote: > > Hi, M

[10] Review request for JDK-8136999: [macosx] NSException and NPE in a crash test

Hi All, Kindly review the fix for JDK10. Bug: https://bugs.openjdk.java.net/browse/JDK-8136999 Webrev: http://cr.openjdk.java.net/~mhalder/8136999/webrev.00/ Fix: The flushEvent method

[9] Review request for JDK-8172510: [TEST_BUG][macosx] set autodelay in java/awt/List/ItemEventTest/ItemEventTest.java

Hi All, Kindly review the fix for JDK9. Bug: https://bugs.openjdk.java.net/browse/JDK-8172510 Webrev: http://cr.openjdk.java.net/~mhalder/8172510/webrev.00/ Issue: Wrong ItemEvent is

Re: [9] Review request for JDK-7119774: [macosx] test ComponentMousePositionTest sometimes fail on Mac

Please include the jtreg tag: @key headful > & also include the bug id: 4009555 from the original test. > > Regards, > Ambarish > > From: Sergey Bylokhov > Sent: Monday, February 13, 2017 11:02 PM > To: Manajit Halder > Cc: awt-dev@openjdk.java.net > Subje

Re: [9] Review request for JDK-7119774: [macosx] test ComponentMousePositionTest sometimes fail on Mac

Hi Sergey, Thank you for the review comment. Please review the modified code. http://cr.openjdk.java.net/~mhalder/7119774/webrev.01/ Regards, Manajit > On 13-Feb-2017, at 7:20 pm, Sergey Bylokhov > wrote: > > Hi, Manajit. > Just one co

[9] Review request for JDK-7119774: [macosx] test ComponentMousePositionTest sometimes fail on Mac

Hi All, Kindly review the fix for JDK9. Bug: https://bugs.openjdk.java.net/browse/JDK-7119774 Webrev: http://cr.openjdk.java.net/~mhalder/7119774/webrev.00/ Issue: Test fails sometim

[9] Review request for JDK-8160536: [macosx] Possible regression: com/apple/eawt/DefaultMenuBar/DefaultMenuBarTest.java

Hi All, Kindly review the fix for JDK9. Bug: https://bugs.openjdk.java.net/browse/JDK-8160536 Webrev: http://cr.openjdk.java.net/~mhalder/8160536/webrev.00/ Issue: Menubar event was

[9] Review request for JDK-8160453: [macosx] scary native stack trace in closed/java/awt/FileDialog/FileDialogBufferOverflowTest/FileNameTest.java

Hi All, Kindly review the fix for JDK9. Bug: https://bugs.openjdk.java.net/browse/JDK-8160453 Webrev: http://cr.openjdk.java.net/~mhalder/8160453/webrev.00/ Issue: Test passed but st

Re: [9] Review request for JDK-8165680: [macosx] Enhance handling of UTF-8 characters in CDataTransfer.java

ote: >> >> Looks fine. >> >> On 27.10.16 14:18, Manajit Halder wrote: >>> Hi All, >>> >>> Kindly review the fix for JDK9. >>> >>> Bug: >>> https://bugs.openjdk.java.net/browse/JDK-8165680 >>> >>&g

Re: [9] Review request for JDK-7153700: [macosx] add support for MouseMotionListener to the TrayIcon

ed to nil so it can > contains some non-nil garbage, and calling removeTrackingArea:trackingArea > can cause a crash. > > On 27.10.16 14:08, Manajit Halder wrote: >> Hi Sergey, >> >> Code is modified to correct a memory leak. Please review the modified >> webre

[9] Review request for JDK-8165680: [macosx] Enhance handling of UTF-8 characters in CDataTransfer.java

Hi All, Kindly review the fix for JDK9. Bug: https://bugs.openjdk.java.net/browse/JDK-8165680 Webrev: http://cr.openjdk.java.net/~mhalder/8165680/webrev.00/ Issue: [macosx] Enhance h

Re: [9] Review request for JDK-7153700: [macosx] add support for MouseMotionListener to the TrayIcon

Hi Sergey, Code is modified to correct a memory leak. Please review the modified webrev: http://cr.openjdk.java.net/~mhalder/7153700/webrev.01/ <http://cr.openjdk.java.net/~mhalder/7153700/webrev.01/> Thanks, Manajit > On 21-Oct-2016, at 1:20 pm, Manajit Halder wrote: > > Hi A

[9] Review request for JDK-7153700: [macosx] add support for MouseMotionListener to the TrayIcon

Hi All, Kindly review the fix for JDK9. Bug: https://bugs.openjdk.java.net/browse/JDK-7153700 Webrev: http://cr.openjdk.java.net/~mhalder/7153700/webrev.00/ Issue: [macosx] add suppo

[9] Review request for JDK-8158390: [macosx] Regression: javax/swing/JMenuItem/8139169/ScreenMenuBarInputTwice.java

Hi All, Kindly review the fix for JDK9. Bug: https://bugs.openjdk.java.net/browse/JDK-8158390 Webrev: http://cr.openjdk.java.net/~mhalder/8158390/webrev.00/ Issue: [macosx] Regressio

Re: [9] Review request for JDK-8158380: Regression: java/awt/List/ActionEventTest/ActionEventTest.java

> wrote: > > It seems that "Copyright (c)" is incorrectly updated in both tests. > > On 10.10.16 14:41, Manajit Halder wrote: >> Hi Sergey, >> >> Thank you for the review. Please review the modified webrev. >> http://cr.openjdk.java.net/~mhalder/8158

Re: [9] Review request for JDK-8158380: Regression: java/awt/List/ActionEventTest/ActionEventTest.java

gt; Instead of adding these methods between operations you can call these after > robot creation: >Robot.setAutoDelay(int ms) >Robot.setAutoWaitForIdle(boolean isOn) > > On 07.10.16 15:10, Manajit Halder wrote: >> Hi All, >> >> Kindly review the fix

[9] Review request for JDK-8158380: Regression: java/awt/List/ActionEventTest/ActionEventTest.java

Hi All, Kindly review the fix for JDK9. Bug: https://bugs.openjdk.java.net/browse/JDK-8158380 Webrev: http://cr.openjdk.java.net/~mhalder/8158380/webrev.00/ Issue: Regression: java/a

Re: [9] Review request for JDK-8165555: [macosx] VM crashes on second attempt to execute JCK interactive tests that use Robot (single JVM, agent)

ev.03/ > > <http://cr.openjdk.java.net/~mhalder/816/webrev.03/> > > > > Thanks, > > Manajit > > > > On 27-Sep-2016, at 4:15 pm, Sergey Bylokhov > <mailto:sergey.bylok...@oracle.com>> wrote: > > > On 27.09.16 11:51, Manajit Halder

Re: [9] Review request for JDK-8165555: [macosx] VM crashes on second attempt to execute JCK interactive tests that use Robot (single JVM, agent)

m, Sergey Bylokhov > wrote: > > On 27.09.16 11:51, Manajit Halder wrote: >> Hi Sergey, >> >> Thanks for the comment. “self.javaToMacKeyMap is retaining the reference. >> Please review the modified code: >> >> http://cr.openjdk.java.net/~mhalder/81655

Re: [9] Review request for JDK-8165555: [macosx] VM crashes on second attempt to execute JCK interactive tests that use Robot (single JVM, agent)

Bylokhov > wrote: > > On 21.09.16 16:01, Manajit Halder wrote: >> Hi Sergey, >> >> Thanks for the comment. >> >> Access to "instance" is not broken. The problem is with the dictionary >> variable "javaToMacKeyMap" within the

Re: [9] Review request for JDK-8165555: [macosx] VM crashes on second attempt to execute JCK interactive tests that use Robot (single JVM, agent)

javaToMacKeyMap" inside the "instance"? If not > then "javaToMacKeyMap" should be changed to "self.javaToMacKeyMap". > Do you have a test case to reproduce the bug? > > On 19.09.16 15:26, Manajit Halder wrote: >> Hi All, >> >> Kindly

[9] Review request for JDK-8165555: [macosx] VM crashes on second attempt to execute JCK interactive tests that use Robot (single JVM, agent)

Hi All, Kindly review the fix for JDK9. Bug: https://bugs.openjdk.java.net/browse/JDK-816 Webrev: http://cr.openjdk.java.net/~mhalder/816/webrev.00/ Issue: [macosx] VM crashe

Re: [9] Review request for JDK-8163270: [macosx] Robot(gc) issue on dual-screen system.

Bylokhov > wrote: > > Hi, Manajit. > I recognized that the test can be cleaned a little bit. We can move the code > from the init() to main and remove all other unnecessary stuff: > TestPassedException, pass(), setTimeoutTo(), etc. > > On 09.09.16 8:23, Manajit Halder wr

[9] Review request for JDK-8163270: [macosx] Robot(gc) issue on dual-screen system.

Hi All, Kindly review the fix for JDK9. Bug: https://bugs.openjdk.java.net/browse/JDK-8163270 Webrev: http://cr.openjdk.java.net/~mhalder/8163270/webrev.00/ Issue: [macosx] Robot(gc) issue on dual-screen system. Cause: Calculation of x coordinate value was wrong for the mouse cursor in th

Re: [9] Review request for JDK-8156099: [macosx] Drag and drop of link from web browser, DataFlavor types application/x-java-url and text/uri-list, getTransferData returns null

oks fine. > please change the title of the frame to some text related to this fix, > instead of "Updating TrayIcon Popup Menu Item Test" > > On 14.08.16 23:50, Manajit Halder wrote: >> Hi Sergey, >> >> Thank you for your review comments. >> >&g

Re: [9] Review request for JDK-8156099: [macosx] Drag and drop of link from web browser, DataFlavor types application/x-java-url and text/uri-list, getTransferData returns null

ponents on non-EDT. > - The instructions are a little bit misleading, because popup will be shown > even when the test is passed. > - When I run the test on the current client ws, it is passed. Can you please > double check that the test fails before the fix. > > On 01

Re: [9] Review request for JDK-8156099: [macosx] Drag and drop of link from web browser, DataFlavor types application/x-java-url and text/uri-list, getTransferData returns null

the test creates the Swing components on non-EDT. > - The instructions are a little bit misleading, because popup will be shown > even when the test is passed. > - When I run the test on the current client ws, it is passed. Can you please > double check that the test fails before the fix. >

Re: [9] Review request for JDK-8156099: [macosx] Drag and drop of link from web browser, DataFlavor types application/x-java-url and text/uri-list, getTransferData returns null

uctions are a little bit misleading, because popup will be shown > even when the test is passed. > - When I run the test on the current client ws, it is passed. Can you please > double check that the test fails before the fix. > > On 01.08.16 12:35, Manajit Halder wrote: >>

[9] Review request for JDK-8156099: [macosx] Drag and drop of link from web browser, DataFlavor types application/x-java-url and text/uri-list, getTransferData returns null

Hi All, Kindly review the fix for JDK9. Bug: https://bugs.openjdk.java.net/browse/JDK-8156099 Webrev: http://cr.openjdk.java.net/~mhalder/8156099/webrev.00/ Issue: [macosx] Drag and d

Re: [9] Review request for JDK-8160266: [macosx] NestedModalDialogTest.java and NestedModelessDialogTest.java tests does not run with current JDK codebase after taking the files fro

aseKey(int num) are just direct calls to > the corresponding methods in Robot. > Other necessary methods can be added to > test/java/awt/regtesthelpers/Util.java > > Thanks, > Alexandr. > > On 7/7/2016 1:32 PM, Manajit Halder wrote: >> Hi All, >> &g

  1   2   >