Re: [9] Review request for 8171808: Performance problems in dialogs with large tables when JAB activated

Hi Sergey, http://cr.openjdk.java.net/~mcherkas/8171808/9/webrev.02/ I wrapped the very fist invocations of _getVisibleChildrenCount and _getVisibleChild into InvocationUtils.invokeAndWait and removed all InvocationUtils.invokeAndWait inside those two methods. Thanks, Mikhail. On 2/24/2017 1

[9] Review request for 8171808: Performance problems in dialogs with large tables when JAB activated

Hi all, Could you please review the fix: http://cr.openjdk.java.net/~mcherkas/8171808/9/webrev.01/ for the following issue: https://bugs.openjdk.java.net/browse/JDK-8171808 When JAWS asks java how many visible elements in the frame are, java goes through the whole tree of component and asks eac

Re: Review Request for 8160696: IllegalArgumentException: adding a component to a container on a different GraphicsDevice

, Please add @key heedful jtreg tag. Please correct line 74. Use specific class imports instead of package import. Regards, Ambarish -Original Message- From: Mikhail Cherkasov Sent: Wednesday, August 10, 2016 9:26 PM To: Sergey Bylokhov; awt-dev@openjdk.java.net Subject: Re

Re: Review Request for 8160696: IllegalArgumentException: adding a component to a container on a different GraphicsDevice

Now everything is in place: http://cr.openjdk.java.net/~mcherkas/8160696/webrev.02/test/java/awt/Container/MoveToOtherScreenTest/MoveToOtherScreenTest.java.html On 10.08.2016 18:32, Sergey Bylokhov wrote: but these frames should be disposed

Re: Review Request for 8160696: IllegalArgumentException: adding a component to a container on a different GraphicsDevice

Oops, sorry, I missed this. On 10.08.2016 18:32, Sergey Bylokhov wrote: but these frames should be disposed

Re: Review Request for 8160696: IllegalArgumentException: adding a component to a container on a different GraphicsDevice

, no? On 10.08.16 17:38, Mikhail Cherkasov wrote: Hi Sergey, all, There's an update test: http://cr.openjdk.java.net/~mcherkas/8160696/webrev.01/ Thanks, Mikhail. On 05.08.2016 21:17, Sergey Bylokhov wrote: Hi, Mikhail. Please update the header of the test and rename it to some meaningful

Re: Review Request for 8160696: IllegalArgumentException: adding a component to a container on a different GraphicsDevice

posed at the end of the test. On 05.08.16 19:19, Mikhail Cherkasov wrote: Hi all, Please review a fix for the following bug: https://bugs.openjdk.java.net/browse/JDK-8160696 webrev: http://cr.openjdk.java.net/~mcherkas/8160696/webrev.00/ Java throws exception: "IllegalArgumentException

Review Request for 8160696: IllegalArgumentException: adding a component to a container on a different GraphicsDevice

Hi all, Please review a fix for the following bug: https://bugs.openjdk.java.net/browse/JDK-8160696 webrev: http://cr.openjdk.java.net/~mcherkas/8160696/webrev.00/ Java throws exception: "IllegalArgumentException: adding a component to a container on a different GraphicsDevice" if you move a Ja

Re: [9] Review request for JDK-8156099: [macosx] Drag and drop of link from web browser, DataFlavor types application/x-java-url and text/uri-list, getTransferData returns null

Hi Manajit, The fix looks good. Thanks, Mikhail. On 01.08.2016 12:35, Manajit Halder wrote: Hi All, Kindly review the fix for JDK9. Bug: https://bugs.openjdk.java.net/browse/JDK-8156099 Webrev: http://cr.openjdk.java.net/~mhalder/8156099/webrev.00/

Re: [8] Review request JDK-8160941: [macosx]"text/uri-list" dataflavor concats the first two strings

o Mikhail, thanks for the review. Would you mind performing the actual commit once it is approved (I assume I need a review from a second person) ? I have no commit rights, so I cannot do it myself. Thanks Robin On Tue, Jul 12, 2016 at 2:04 PM, Mikhail

Re: [8] Review request JDK-8160941: [macosx]"text/uri-list" dataflavor concats the first two strings

Alexander, could you please make review it too? Thanks, Mikhail. On 12.07.2016 15:12, Robin Stevens wrote: Would you mind performing the actual commit once it is approved (I assume I need a review from a second person) ?

Re: [8] Review request JDK-8160941: [macosx]"text/uri-list" dataflavor concats the first two strings

Looks good. On 12.07.2016 0:15, Robin Stevens wrote: Hello Mikhail, good catch. I adjusted the code. Webrev: http://cr.openjdk.java.net/~rstevens/8160941/webrev.01 <http://cr.openjdk.java.net/%7Erstevens/8160941/webrev.01> Robin On Mon, Jul 11, 2016 at 6:08 PM, Mikhail Che

Re: [8] Review request JDK-8160941: [macosx]"text/uri-list" dataflavor concats the first two strings

On 11.07.2016 18:55, Robin Stevens wrote: However, that would cause an inconsistency with other operating systems. ok, but then let's simplify it: remove this line: sb.append(strings[0]); and start cycle from 0: for(int i = 0; i < strings.length; i++) { sb.append(strings[i]); sb.app

Re: [8] Review request JDK-8160941: [macosx]"text/uri-list" dataflavor concats the first two strings

Hi Robin, in your fix there will be extra separator at the end of the text, you need to put "sb.append(separator);" before "sb.append(strings[i]);" in for cycle. Thanks, Mikhail. On 08.07.2016 23:06, Robin Stevens wrote: Please review the fix for JDK-8160941 . Webrev: http://cr.openjdk.java.n

[9] Review request for JDK-8160650: Couple awt and swing tests have wrong require jtreg arguments

Hi all, jbs: https://bugs.openjdk.java.net/browse/JDK-8160650 webrev:http://cr.openjdk.java.net/~mcherkas/8160650/9/webrev/ Couple awt and swing tests have wrong require jtreg arguments, the following tests should use "os.family" instead of "os.name": javax/swing/LookAndFeel/8145547/DemandGTK.j

[8] Review request for JDK-8130242 DataFlavorComparator transitivity exception

Hello, Please review the almost direct backport of https://bugs.openjdk.java.net/browse/JDK-8130242 to jdk8: http://cr.openjdk.java.net/~mcherkas/8130242/webrev/ The difference is only that code location in jdk8 and 9 is different. jdk9 changeset: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/74

[9] Review request for: 8020817: JDK-8086038 requires a regression test

Hello, Please please review a regression test for 8086038, it checks that PICT format support is present. bug: https://bugs.openjdk.java.net/browse/JDK-8020817 webrev: http://cr.openjdk.java.net/~mcherkas/8086038/webrev/ Thanks, Mikhail.

Re: [9] Review request for: 8136763 [macosx] java always returns only one value for "text/uri-list" dataflavor even if several files were copied

Thanks a lot! On 10/21/2015 18:32, Alexander Scherbatiy wrote: The fix looks good to me. Thanks, Alexandr. On 10/21/2015 6:08 PM, mikhail cherkasov wrote: Hi again, And one more check was added: http://cr.openjdk.java.net/~mcherkas/8136763/webrev.04/src/java.desktop/macosx/classes

Re: [9] Review request for: 8136763 [macosx] java always returns only one value for "text/uri-list" dataflavor even if several files were copied

Hi again, And one more check was added: http://cr.openjdk.java.net/~mcherkas/8136763/webrev.04/src/java.desktop/macosx/classes/sun/lwawt/macosx/CDataTransferer.java.udiff.html Thanks, Mikhail. On 10/21/2015 17:09, mikhail cherkasov wrote: Hi Alexander, You are right, NPE can be thrown

Re: [9] Review request for: 8136763 [macosx] java always returns only one value for "text/uri-list" dataflavor even if several files were copied

Hi Alexander, You are right, NPE can be thrown there, I added check for null. A new webrev is being uploaded right now: http://cr.openjdk.java.net/~mcherkas/8136763/webrev.03 Thanks, Mikhail. On 10/21/2015 16:42, Alexander Scherbatiy wrote: On 10/21/2015 4:36 PM, mikhail cherkasov wrote

Re: [9] Review request for: 8136763 [macosx] java always returns only one value for "text/uri-list" dataflavor even if several files were copied

Hi all, Please review the fix. it requires to have two reviewer at least, so I need one more reviewer for this fix. Thanks, Mikhail. On 10/19/2015 14:01, mikhail cherkasov wrote: Sergey, thank you. Alexander , could you please review the fix too? Thanks, Mikhail. On 10/19/2015 13:51

Re: [9] Review request for: 8136763 [macosx] java always returns only one value for "text/uri-list" dataflavor even if several files were copied

Sergey, thank you. Alexander , could you please review the fix too? Thanks, Mikhail. On 10/19/2015 13:51, Sergey Bylokhov wrote: The fix looks fine. please fix the typo "returens" in CDataTransferer before the push. On 19.10.15 10:39, mikhail cherkasov wrote: Hi th

Re: [9] Review request for: 8136763 [macosx] java always returns only one value for "text/uri-list" dataflavor even if several files were copied

Hi there, http://cr.openjdk.java.net/~mcherkas/8136763/webrev.02/ During adding the test, I've mistakenly returned flavormap version with removed "text/uri-list". Now "text/uri-list" is in place again. Thanks, Mikhail. On 10/15/2015 11:42, mikhail cherkasov wro

Re: [9] Review request for: 8136763 [macosx] java always returns only one value for "text/uri-list" dataflavor even if several files were copied

Hi Sergey, Alexander, Please review the new version of web rev with updated test. Thanks, Mikhail. On 10/7/2015 15:40, mikhail cherkasov wrote: Hi Sergey, Sorry, I've added wrong test, there's a correct version: http://cr.openjdk.java.net/~mcherkas/8136763/webrev.01/ -Mikhail. On

Re: [9] Review request for: 8136763 [macosx] java always returns only one value for "text/uri-list" dataflavor even if several files were copied

Hi Sergey, Sorry, I've added wrong test, there's a correct version: http://cr.openjdk.java.net/~mcherkas/8136763/webrev.01/ -Mikhail. On 10/6/2015 18:29, Sergey Bylokhov wrote: Looks like the test is not in the final state. On 06.10.15 11:01, mikhail cherkasov wrote: Hi ther

[9] Review request for: 8136763 [macosx] java always returns only one value for "text/uri-list" dataflavor even if several files were copied

Hi there, Please review a fix: bug: https://bugs.openjdk.java.net/browse/JDK-8136763 webrev: http://cr.openjdk.java.net/~mcherkas/8136763/webrev.00/ The problem is similar to https://bugs.openjdk.java.net/browse/JDK-8081787 When user requests data for uri-list flavor, java returns xml without a

Re: [9] Review request for: 8086038 [macosx] No available data flavors when copying from Microsoft Word for Mac

I reverted removing of "text/uri": http://cr.openjdk.java.net/~mcherkas/8086038/webrev.02/ it doesn't relate to original fix, so we can go without this change. On 10/5/2015 17:10, Sergey Bylokhov wrote: On 01.10.15 17:22, mikhail cherkasov wrote: On 9/30/2015 18:48, Sergey Bylo

Re: [9] Review request for: 8086038 [macosx] No available data flavors when copying from Microsoft Word for Mac

t line can make problems, I'll revert this change. Anyway, it doesn't relate with the original problem. Please format the code in CDataTransferer.m in the same way as other lines. fixed: http://cr.openjdk.java.net/~mcherkas/8086038/webrev.01/ On 30.09.15 14:42, mikhail cherkasov wr

[9] Review request for: 8086038 [macosx] No available data flavors when copying from Microsoft Word for Mac

Hi there, Please review a fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8086038 webrev: http://cr.openjdk.java.net/~mcherkas/8086038/webrev.00/ MS Word provides pictures in PICT format https://en.wikipedia.org/wiki/PICT we don't support it and doesn't support any data flavor for it

Re: [9] Review request for: [macosx] java always returns only one value for "text/uri-list" dataflavor even if several files were copied

Hi again, Could you please look at this fix? it's simple one it won't take a lot of your time. Thanks, Mikhail. On 9/21/2015 17:19, mikhail cherkasov wrote: Hi there, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8136763 webrev: http://cr.openjd

[9] Review request for: [macosx] java always returns only one value for "text/uri-list" dataflavor even if several files were copied

Hi there, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8136763 webrev: http://cr.openjdk.java.net/~mcherkas/8136763/webrev.00/ The problem is similar to https://bugs.openjdk.java.net/browse/JDK-8081787 When user requests data for uri-list flavor, java returns xml wit

Re: [9] Review request for 8081787: [macosx] MalformedURLException is thrown during reading data for application/x-java-url; class=java.net.URL flavor

Thank you! On 8/13/2015 15:12, Alexander Scherbatiy wrote: The fix looks good to me. Thanks, Alexandr. On 8/13/2015 3:08 PM, Sergey Bylokhov wrote: The fix looks fine. Thanks! On 05.08.15 19:08, mikhail cherkasov wrote: Hi Sergey, Thanks you for examples of manual tests, I've

Re: [9] Review request for 8081787: [macosx] MalformedURLException is thrown during reading data for application/x-java-url; class=java.net.URL flavor

t for verification. On my osx for example the test from the bug description fails with UnsupportedFlavorException: application/x-java-url On 01.07.15 14:27, mikhail cherkasov wrote: Hi there, Could you please review a fix for: 8081787 [macosx] MalformedURLException is thrown during reading data

Re: [9] Review request for 8081787: [macosx] MalformedURLException is thrown during reading data for application/x-java-url; class=java.net.URL flavor

Hi all, this is kindly reminder about this review request. Thanks, Mikhail. On 7/6/2015 13:53, mikhail cherkasov wrote: Hi Sergey, UnsupportedFlavorException is thrown because clipboard has something that can't be translated to application/x-java-url. You should copy link from Safa

Re: [8-dev] Review request for 8130752: Wrong changes were pushed with 8068886

Thank you. I believe one review is enough to such kind of fixes. On 7/8/2015 15:20, Sergey Bylokhov wrote: Looks fine. On 08.07.15 14:44, mikhail cherkasov wrote: Hello, Into jdk8 repository wrong changes were pushed mistakenly: http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev

[8-dev] Review request for 8130752: Wrong changes were pushed with 8068886

Hello, Into jdk8 repository wrong changes were pushed mistakenly: http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/b26427c5b3fe Those changes were reverted: http://cr.openjdk.java.net/~mcherkas/8130752/webrev.00/src/share/classes/sun/awt/datatransfer/DataTransferer.java.udiff.html bug: https:/

Re: [9] Review request for 8081787: [macosx] MalformedURLException is thrown during reading data for application/x-java-url; class=java.net.URL flavor

14:27, mikhail cherkasov wrote: Hi there, Could you please review a fix for: 8081787 [macosx] MalformedURLException is thrown during reading data for application/x-java-url;class=java.net.URL flavor https://bugs.openjdk.java.net/browse/JDK-8081787 http://cr.openjdk.java.net/~mcherkas/8081787.8/webr

[9] Review request for 8081787: [macosx] MalformedURLException is thrown during reading data for application/x-java-url; class=java.net.URL flavor

Hi there, Could you please review a fix for: 8081787 [macosx] MalformedURLException is thrown during reading data for application/x-java-url;class=java.net.URL flavor https://bugs.openjdk.java.net/browse/JDK-8081787 http://cr.openjdk.java.net/~mcherkas/8081787.8/webrev.01/src/macosx/classes/su

Re: 8077409: Drawing deviates when validate() is invoked on java.awt.ScrollPane

Hello, this is kindly reminder about the review request. Thanks, Mikhail. On 5/22/2015 7:28 PM, mikhail cherkasov wrote: Hello Sergey. There's a second version of fix with a test: http://cr.openjdk.java.net/~mcherkas/8077409v9/webrev.01/ I found out that the problem is in layout metho

Re: 8077409: Drawing deviates when validate() is invoked on java.awt.ScrollPane

test from test/(closed)/java/awt/ScrollPane, all tests are passed. Thanks, Mikhail. On 5/5/2015 7:24 PM, Sergey Bylokhov wrote: Hi, Mikhail. Is it possible to write a test for this issue based on the code in the bug report? On 30.04.15 22:44, mikhail cherkasov wrote: Hi there, Could you plea

8077409: Drawing deviates when validate() is invoked on java.awt.ScrollPane

Hi there, Could you please review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8077409 webrev: http://cr.openjdk.java.net/~mcherkas/8077409v9/webrev.00/ In ScrollPane, move() is called without considering the quota of Insets when invoking ScrollPane$PeerFixer.adjustmentValueChanged().

sync in share native code

Hi there, I need to add synchronization in shared native code, it can't be moved to java side. But for now it's not clear how to make it cross platform. Maybe someone already has similar experience? Furthermore maybe jdk already has a cross platform implementation of mutex in native code? T

Re: Review Request for 8065709: Deadlock in awt/logging apparently introduced by 8019623

Ok, the "lazy" version will be pushed. Thank you . On 1/22/2015 4:23 PM, Sergey Bylokhov wrote: On 22.01.2015 13:42, mikhail cherkasov wrote: Hi Anton, Sergey, Anton advised today to implement eager initialization of EQ's logger instead of lazy initialization of EQ's lo

Re: Review Request for 8065709: Deadlock in awt/logging apparently introduced by 8019623

you removed the new lock at least. Looks better now (no more comments from me). Thank you! Personally I prefered to remove this logging, but this version looks fine also. Regards, Anton. On 20.01.2015 17:26, mikhail cherkasov wrote: Hi Anton, please check new version: http://cr.openjd

Re: Review Request for 8065709: Deadlock in awt/logging apparently introduced by 8019623

synchronized and can be treated as sync block and second check. Thanks, Mikhail. On 1/19/2015 10:38 PM, Anton Tarasov wrote: On 19/01/15 19:15, mikhail cherkasov wrote: On 1/19/2015 5:59 PM, Anton V. Tarasov wrote: Hi Mikhail, It seems the problem is not limited to EventQueue only. Even if you

Re: Review Request for 8065709: Deadlock in awt/logging apparently introduced by 8019623

jdk/rev/83f20d8bc13a should cover all cases, the only possible if EQ ctor will lead to javaAwtAccess, but it doesn't. Regards, Anton. On 16.01.2015 17:18, mikhail cherkasov wrote: Hi all, JBS: https://bugs.openjdk.java.net/browse/JDK-8065709 Webrev: http://cr.openjdk.java.net/~mcherkas/80657

Review Request for 8065709: Deadlock in awt/logging apparently introduced by 8019623

Hi all, JBS: https://bugs.openjdk.java.net/browse/JDK-8065709 Webrev: http://cr.openjdk.java.net/~mcherkas/8065709/webrev.00/ AppContext creation is guarder by getAppContextLockand, but during AppContext creation we also call EventQueue initialization, during EQ initialization logger initializ

Re: [7] Review Request: 8032964 When using an HTML data flavor, pasting non-Latin char into an applet the "start and end fragment" surrounds text.

Hi again, Folks, let's review this before long long new year vacation. Thanks, Mikhail. On 12/17/2014 3:51 PM, mikhail cherkasov wrote: Hi there. Just friendly reminder about this review request. Thanks, Mikhail. On 12/15/2014 2:15 PM, mikhail cherkasov wrote: Hi again, I forg

Re: [7] Review Request: 8032964 When using an HTML data flavor, pasting non-Latin char into an applet the "start and end fragment" surrounds text.

Hi there. Just friendly reminder about this review request. Thanks, Mikhail. On 12/15/2014 2:15 PM, mikhail cherkasov wrote: Hi again, I forgot to mention https://bugs.openjdk.java.net/browse/JDK-221534 - I checked it too and it works fine. Thanks, Mikhail. On 12/12/2014 8:23 PM, mikhail

Re: [7] Review Request: 8032964 When using an HTML data flavor, pasting non-Latin char into an applet the "start and end fragment" surrounds text.

Hi again, I forgot to mention https://bugs.openjdk.java.net/browse/JDK-221534 - I checked it too and it works fine. Thanks, Mikhail. On 12/12/2014 8:23 PM, mikhail cherkasov wrote: Hi Sergey, MSExtraDataTransfer passed. Thanks Mikhail. On 12/12/2014 6:26 PM, Sergey Bylokhov wrote: Hi

Re: [7] Review Request: 8032964 When using an HTML data flavor, pasting non-Latin char into an applet the "start and end fragment" surrounds text.

12.12.2014 18:13, mikhail cherkasov wrote: Hi all, One of our customer faced with the following issue: 8032964 When using an HTML data flavor, pasting non-Latin char into an applet the "start and end fragment" surrounds text. https://bugs.openjdk.java.net/browse/JDK-8032964 I noticed

[7] Review Request: 8032964 When using an HTML data flavor, pasting non-Latin char into an applet the "start and end fragment" surrounds text.

Hi all, One of our customer faced with the following issue: 8032964 When using an HTML data flavor, pasting non-Latin char into an applet the "start and end fragment" surrounds text. https://bugs.openjdk.java.net/browse/JDK-8032964 I noticed that jdk8 doesn't have this problem, after some inve

Re: [7] Review Request for 8047961: [TESTBUG] closed/java/awt/Focus/ActivateFocusTest/ActivateFocusTest.html fails intermittently

ne for me. Thanks! This was an old one... Do you have any plans to fix it in 8/9 as well? Regards, Anton. On 14.11.2014 18:57, mikhail cherkasov wrote: Hello all, Could you please review a simple fix of closed test, the test was moved to open repo and requestFocus was replaced requestFocus

Re: [7] Review Request for 8047961: [TESTBUG] closed/java/awt/Focus/ActivateFocusTest/ActivateFocusTest.html fails intermittently

in 8/9 as well? Regards, Anton. On 14.11.2014 18:57, mikhail cherkasov wrote: Hello all, Could you please review a simple fix of closed test, the test was moved to open repo and requestFocus was replaced requestFocusInWindow. Because "requestFocus" cause infinite war for focus

[7] Review Request for 8047961: [TESTBUG] closed/java/awt/Focus/ActivateFocusTest/ActivateFocusTest.html fails intermittently

Hello all, Could you please review a simple fix of closed test, the test was moved to open repo and requestFocus was replaced requestFocusInWindow. Because "requestFocus" cause infinite war for focus between two windows, however this behavior is correct and doesn't violet spec. [TESTBUG] cl

Re: [7] Review Request for 8001633: Wrong alt processing during switching between windows.

Hi Petr, could you please make the second review? On 11/14/2014 3:54 PM, Anton V. Tarasov wrote: Looks fine for me. Regards, Anton. On 13.11.2014 22:17, mikhail cherkasov wrote: Hello all, Could you please review a backport to jdk7 for the following bug: bug: https://bugs.openjdk.java.net

[7] Review Request for 8001633: Wrong alt processing during switching between windows.

Hello all, Could you please review a backport to jdk7 for the following bug: bug: https://bugs.openjdk.java.net/browse/JDK-8001633 Webrev: http://cr.openjdk.java.net/~mcherkas/8001633/jdk7/webrev.00/ review for jdk8: http://mail.openjdk.java.net/pipermail/awt-dev/2012-October/003732.html It's

[7] Review request: 8041572 [macosx] huge native memory leak in AWTWindow.m

Hello, all. Could you please review the following fix: http://cr.openjdk.java.net/~mcherkas/8051263/webrev.00/ it's a backport of https://bugs.openjdk.java.net/browse/JDK-8041572 But due difference between 7 & 8 it isn't strict direct backport. A part of original fix's changes are missed becau

[9] Review request : 8062021 NPE in sun/lwawt/macosx/CPlatformWindow::toFront after JDK-8060146

Hello all, please review the fix http://cr.openjdk.java.net/~mcherkas/8062021/webrev.00/ bug: NPE in sun/lwawt/macosx/CPlatformWindow::toFront after JDK-8060146 https://bugs.openjdk.java.net/browse/JDK-8062021 Check for null was added. Thanks, Mikhail.

Re: [9] Review request : 8038919, Requesting focus to a modeless dialog doesn't work on Safari

Please fix. On 09.10.2014 19:46, mikhail cherkasov wrote: Hi Anton, Please review a new version: http://cr.openjdk.java.net/~mcherkas/8038919/webrev.04/ Thanks, Mikhail. On 10/8/2014 10:41 AM, Anton V. Tarasov wrote: Hi Mikhail, (sorry, I was away yesterday) On 07.10.2014 19:37, mikhail

Re: [9] Review request : 8038919, Requesting focus to a modeless dialog doesn't work on Safari

Hi Anton, Please review a new version: http://cr.openjdk.java.net/~mcherkas/8038919/webrev.04/ Thanks, Mikhail. On 10/8/2014 10:41 AM, Anton V. Tarasov wrote: Hi Mikhail, (sorry, I was away yesterday) On 07.10.2014 19:37, mikhail cherkasov wrote: Hi Anton, But anyway, I'll have t

Re: [9] Review request : 8038919, Requesting focus to a modeless dialog doesn't work on Safari

s, Anton. On 06.10.2014 11:08, mikhail cherkasov wrote: Hi Anton, it's window problem, toFront doesn't work for windows when embedded frame in browser is active. Mac ignores toFront, because it recognizes browser is active application and doesn't allow to java process activate its wi

Re: [9] Review request : 8038919, Requesting focus to a modeless dialog doesn't work on Safari

ith toFront overriden. Then we can do all the verifications gracefully and call platformWindow.toFrontIgnoringOtherApps() (new method). I would also rename LWCToolkit.activateApplication to match its native API call. What do you think? Regards, Anton. On 16.09.2014 15:39, mikhail cherka

Re: [9] Review request : 8038919, Requesting focus to a modeless dialog doesn't work on Safari

: Hi, Mikhail. Why this code is needed in CPlatformWindow.java? "Container parent = getPeer().getTarget().getParent()" note that getPeer() can return null. On 01.10.2014 15:19, mikhail cherkasov wrote: Hi there, it's just friendly reminder about this review request. Thanks, Mi

Re: [9] Review request : 8038919, Requesting focus to a modeless dialog doesn't work on Safari

Hi there, it's just friendly reminder about this review request. Thanks, Mikhail. On 9/25/2014 7:49 PM, mikhail cherkasov wrote: Hi Sergey, Please review updated version: http://cr.openjdk.java.net/~mcherkas/8038919/webrev.02/ Thanks, Mikhail. On 9/23/2014 7:08 PM, Sergey Bylokhov

Re: [9] Review request : 8038919, Requesting focus to a modeless dialog doesn't work on Safari

it is unrelated to CPlatformWindow. On 19.09.2014 19:02, mikhail cherkasov wrote: Hi there! Just friendly reminder about this review request. Thanks, Mikhail. On 9/16/2014 3:39 PM, mikhail cherkasov wrote: Hello all, please review the fix http://cr.openjdk.java.net/~mcherkas/8038919/webrev

Re: [9] Review request : 8038919, Requesting focus to a modeless dialog doesn't work on Safari

Hi there! Just friendly reminder about this review request. Thanks, Mikhail. On 9/16/2014 3:39 PM, mikhail cherkasov wrote: Hello all, please review the fix http://cr.openjdk.java.net/~mcherkas/8038919/webrev.01/ bug: https://bugs.openjdk.java.net/browse/JDK-8038919 The problem appears if

[9] Review request : 8038919, Requesting focus to a modeless dialog doesn't work on Safari

Hello all, please review the fix http://cr.openjdk.java.net/~mcherkas/8038919/webrev.01/ bug: https://bugs.openjdk.java.net/browse/JDK-8038919 The problem appears if we trying to call toFront when embedded window is active in browser, this call is ignored, because for macosx the browser proces

Re: review request: focus disappears with shift+tab on dialogue having a focus component

thank you for review!. On 4/10/2014 8:13 PM, Sergey Bylokhov wrote: The fix looks good. I guess the test should be pushed to jdk 8,9 as well. ok, Do I need to file a new bug or how it works for this case? On 10.04.2014 18:49, mikhail cherkasov wrote: Thank you! On 4/10/2014 6:45 PM, Artem

Re: review request: focus disappears with shift+tab on dialogue having a focus component

Thank you! On 4/10/2014 6:45 PM, Artem Ananiev wrote: Hi, Mikhail, the fix looks fine. ok, will fix before commit. The test looks fine as well, except the "button" field, which should be volatile. Thanks, Artem On 4/8/2014 6:03 PM, mikhail cherkasov wrote: Hi again, A regre

Re: review request: focus disappears with shift+tab on dialogue having a focus component

Hi there, this is friendly reminder about the review request. Thanks, Mikhail. On 4/8/2014 6:03 PM, mikhail cherkasov wrote: Hi again, A regression test was added: http://cr.openjdk.java.net/~mcherkas/8031075/webrev.01/ Could you please review second version of webrev? Thanks, Mikhail. On

Re: Review request for JDK-8032961: A JTextField of an applet loses the abillity to receive the focus under certain circumstances.

Anthony On 4/9/2014 3:02 PM, mikhail cherkasov wrote: Hi all, please review the fix: http://cr.openjdk.java.net/~mcherkas/8032961/jdk9/webrev.00/ for the following bug: https://bugs.openjdk.java.net/browse/JDK-8032961 The problem is that when we create modal dialog we can't set the whole b

Review request for JDK-8032961: A JTextField of an applet loses the abillity to receive the focus under certain circumstances.

Hi all, please review the fix: http://cr.openjdk.java.net/~mcherkas/8032961/jdk9/webrev.00/ for the following bug: https://bugs.openjdk.java.net/browse/JDK-8032961 The problem is that when we create modal dialog we can't set the whole browser as its parent window, due some limitation of browse

Re: review request: focus disappears with shift+tab on dialogue having a focus component

tests it would be good to add new one. On 31.12.2013 15:59, mikhail cherkasov wrote: Hello all, Could you please review the following fix: https://bugs.openjdk.java.net/browse/JDK-8031075 review request: focus disappears with shift+tab on dialogue having a focus component http://cr.openjdk.java.net

Re: review request: focus disappears with shift+tab on dialogue having a focus component

Hi Sergey, Thank you for review. I'll add test. Thanks, Mikhail. On 09-Jan-14 11:59 AM, Sergey Bylokhov wrote: Hi, Mikhail. The fix looks good. But since this regression was not found by our tests it would be good to add new one. On 31.12.2013 15:59, mikhail cherkasov wrote: Hell

review request: focus disappears with shift+tab on dialogue having a focus component

Hello all, Could you please review the following fix: https://bugs.openjdk.java.net/browse/JDK-8031075 review request: focus disappears with shift+tab on dialogue having a focus component http://cr.openjdk.java.net/~mcherkas/8031075/webrev.00/

hg: jdk8/awt/jdk: 8028271: Wrong alt processing during switching between windows.

Changeset: ab933b508274 Author:mcherkas Date: 2013-11-26 17:16 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/ab933b508274 8028271: Wrong alt processing during switching between windows. Reviewed-by: serb, alexsch ! test/javax/swing/plaf/windows/WindowsRootPaneUI/WrongAltP

Re: [8] Review request for 8028271: Wrong alt processing during switching between windows.

Thank you, Sergey. But I still need one more review. Thanks, Mikhail. On 21.11.2013 14:43, Sergey Bylokhov wrote: Hi, Mikhail. The fix looks good. On 20.11.2013 20:25, mikhail cherkasov wrote: Hi again, I updated review one more time, a hard-coded values (5-10) to click window title was

Re: [8] Review request for 8028271: Wrong alt processing during switching between windows.

g components incorrectly on non-edt thread. On 15.11.2013 21:12, mikhail cherkasov wrote: Hi all, This is a small fix of a test : http://cr.openjdk.java.net/~mcherkas/8028271/webrev.00/ <http://cr.openjdk.java.net/%7Emcherkas/8028271/webrev.00/> jbs bug: https://bugs.openjdk.java.net/

Re: [8] Review request for 8028271: Wrong alt processing during switching between windows.

rectly on non-edt thread. On 15.11.2013 21:12, mikhail cherkasov wrote: Hi all, This is a small fix of a test : http://cr.openjdk.java.net/~mcherkas/8028271/webrev.00/ <http://cr.openjdk.java.net/%7Emcherkas/8028271/webrev.00/> jbs bug: https://bugs.openjdk.java.net/browse/JDK-802

[8] Review request for 8028271: Wrong alt processing during switching between windows.

Hi all, This is a small fix of a test : http://cr.openjdk.java.net/~mcherkas/8028271/webrev.00/ jbs bug: https://bugs.openjdk.java.net/browse/JDK-8028271 Thanks, Mikhail.

hg: jdk8/awt/jdk: 8020688: Broken links in documentation at http://docs.oracle.com/javase/6/docs/api/index.

Changeset: 6ffe50fe06bd Author:mcherkas Date: 2013-10-04 20:13 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/6ffe50fe06bd 8020688: Broken links in documentation at http://docs.oracle.com/javase/6/docs/api/index. Reviewed-by: anthony, alexsch ! src/macosx/classes/apple/app

Re: [8] Review request for 8020688: broken links in documentation at http://docs.oracle.com/javase/6/docs/api/index.

09/27/2013 07:32 PM, mikhail cherkasov wrote: Anthony thank you for this link, it's good replacement for removed link. Also I didn't find replacement for : - * Also see the article href="http://java.sun.com/products/jfc/tsc/tech_topics/jlist_1/jlist.html";>Advanced J

Re: Approved: [7] Review request for backport of 8023310: Thread contention in the method Beans.IsDesignTime()

letter. I almost missed it. SAM Thanks, Mikhail. On 02.10.2013 14:32, sergey malenkov wrote: I changed the subject, which is incorrect. The backport looks good. Do you have a build for Windows to test a performance? Thanks, SAM On 02.10.2013 11:20, mikhail cherkasov wrote: Hello all, Please

Re: [7] Review request for backport of 8023310: Thread contention in the method Beans.IsDesignTime()

02.10.2013 11:20, mikhail cherkasov wrote: Hello all, Please review a backport for the following bug: https://bugs.openjdk.java.net/browse/JDK-8023310 webrev: http://cr.openjdk.java.net/~mcherkas/8023310/webrev.00/ <http://cr.openjdk.java.net/%7Emcherkas/8023310/webrev.00/> Thanks, Mikhail.

[7] Review request for backport of 8023310- Fix Raw and unchecked warnings java.awt.image classes

Hello all, Please review a backport for the following bug: https://bugs.openjdk.java.net/browse/JDK-8023310 webrev: http://cr.openjdk.java.net/~mcherkas/8023310/webrev.00/ Thanks, Mikhail.

Re: [8] Review request for 8020688: broken links in documentation at http://docs.oracle.com/javase/6/docs/api/index.

Hi All, Just a friendly reminder, I'm still waiting for review. Thanks, Mikhail. On 27.09.2013 19:32, mikhail cherkasov wrote: Anthony thank you for this link, it's good replacement for removed link. Also I didn't find replacement for : - * Also see the article href="

Re: [8] Review request for 8020688: broken links in documentation at http://docs.oracle.com/javase/6/docs/api/index.

cts/jfc/tsc";>The Swing Connection. Do you have any suggestion about this link? the link to swing tutorial already are there: http://docs.oracle.com/javase/tutorial/uiswing/components/list.html Thanks, Mikhail. On 27.09.2013 18:31, Anthony Petrov wrote: On 09/27/2013 06:19 PM, mikhail

Re: [8] Review request for 8020688: broken links in documentation at http://docs.oracle.com/javase/6/docs/api/index.

ll places, but this will be too much changes for this fix. -- best regards, Anthony On 09/27/2013 04:50 PM, mikhail cherkasov wrote: Hi Anthony, Please review a new version: http://cr.openjdk.java.net/~mcherkas/8020688/webrev.02/ <http://cr.openjdk.java.net/%7Emcherkas/8020688/webrev.02/&

Re: [8] Review request for 8020688: broken links in documentation at http://docs.oracle.com/javase/6/docs/api/index.

x.html";>Painting in AWT and Swing. The new link doesn't point to the "Painting..." article (and it is a very good article, btw). Could you please check all the new links and update the webrev? -- best regards, Anthony On 09/26/2013 02:27 AM, mikhail cherkasov wrote:

Re: [8] Review request for 8020688: broken links in documentation at http://docs.oracle.com/javase/6/docs/api/index.

a new webrev: http://cr.openjdk.java.net/~mcherkas/8020688/webrev.01/ <http://cr.openjdk.java.net/%7Emcherkas/8020688/webrev.01/> no changes, I've turned off laptop before the webrev upload was complete, so the first could be corrupted. On 25.09.2013 23:29, mikhail cherkasov wro

[8] Review request for 8020688: broken links in documentation at http://docs.oracle.com/javase/6/docs/api/index.

Hi all, Could you please review the fix for the following bug: 8020688: broken links in documentation at http://docs.oracle.com/javase/6/docs/api/index. bug: https://bugs.openjdk.java.net/browse/JDK-8020688 The webrev: http://cr.openjdk.java.net/~mcherkas/8020688/webrev.00/

hg: jdk8/awt/jdk: 8016746: Test javax/swing/JTable/7068740/bug7068740.java fails

Changeset: cc7a15f4c735 Author:mcherkas Date: 2013-09-18 15:12 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/cc7a15f4c735 8016746: Test javax/swing/JTable/7068740/bug7068740.java fails Reviewed-by: serb, alexsch ! test/javax/swing/JTable/7068740/bug7068740.java

hg: jdk8/awt/jdk: 8015601: [macosx] Test javax/swing/JInternalFrame/InternalFrameIsNotCollectedTest.java fails on MacOS X

Changeset: 915d13946f18 Author:mcherkas Date: 2013-09-13 17:48 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/915d13946f18 8015601: [macosx] Test javax/swing/JInternalFrame/InternalFrameIsNotCollectedTest.java fails on MacOS X Reviewed-by: alexp, alexsch ! test/javax/swing

hg: jdk8/awt/jdk: 8024395: Improve fix for line break calculations

Changeset: 3213c388740a Author:dmarkov Date: 2013-09-12 18:44 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/3213c388740a 8024395: Improve fix for line break calculations Reviewed-by: alexp, alexsch ! src/share/classes/javax/swing/text/FlowView.java ! src/share/classes/java

hg: jdk8/awt/jdk: 8023392: Swing text components printed with spaces between chars

Changeset: e4ba3d9ea041 Author:mcherkas Date: 2013-09-05 15:37 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/e4ba3d9ea041 8023392: Swing text components printed with spaces between chars Reviewed-by: alexsch, alexp Contributed-by: anton.nashaty...@oracle.com ! src/share/cl

hg: jdk8/awt/jdk: 8023565: JPG causes javax.imageio.IIOException: ICC APP2 encoutered without prior JFIF

Changeset: ba041df8a554 Author:mcherkas Date: 2013-09-04 18:12 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/ba041df8a554 8023565: JPG causes javax.imageio.IIOException: ICC APP2 encoutered without prior JFIF Reviewed-by: bae, vadim ! src/share/classes/com/sun/imageio/plu

hg: jdk8/awt/jdk: 8016833: Underlines and strikethrough not rendering correctly

Changeset: 27d1bdf2f7d9 Author:mcherkas Date: 2013-08-06 17:29 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/27d1bdf2f7d9 8016833: Underlines and strikethrough not rendering correctly Reviewed-by: alexsch, serb Contributed-by: anton.nashaty...@oracle.com ! src/share/classe

hg: jdk8/awt/jdk: 8015730: PIT: On Linux, OGL=true and fbobject=false leads to deadlock or infinite loop

Changeset: f41758d12409 Author:alitvinov Date: 2013-07-04 16:06 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/f41758d12409 8015730: PIT: On Linux, OGL=true and fbobject=false leads to deadlock or infinite loop Reviewed-by: art, anthony ! src/solaris/classes/sun/awt/X11/XE

hg: jdk8/awt/jdk: 8016534: javax/swing/text/View/8014863/bug8014863.java failed

Changeset: 72f167edf630 Author:dmarkov Date: 2013-06-28 18:32 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/72f167edf630 8016534: javax/swing/text/View/8014863/bug8014863.java failed Reviewed-by: alexp, alexsch ! test/javax/swing/text/View/8014863/bug8014863.java

  1   2   >