[9] Review Request for 6961123: setWMClass fails to null-terminate WM_CLASS string

Hi, I ran across some funny characters appearing in the application title under gnome shell and it turned out to be an old bug. Bug: https://bugs.openjdk.java.net/browse/JDK-6961123 Webrev: http://cr.openjdk.java.net/~omajid/webrevs/6961123-missing-null-wmclass/00/ The ICCCM [1] states: Th

Re: [OpenJDK 2D-Dev] RFR: Allow using the system libjpeg

* Andrew Hughes [2014-05-22 16:10]: > - Original Message - > > On 2014-05-22 02:49, Omair Majid wrote: > > > Would you mind if I did this as a separate patch? I will need to fix > > > other libraries too (libzip, and libgif). > > > > > Ok, I t

RFR: 8043805: Allow using a system-installed libjpeg

* Anthony Petrov [2014-05-22 16:48]: > I think that it would be useful to have a bug id prior to sending a review > request, so that a review thread for the bug can be easily found in the > mailing archive. In the future, please do file a bug first and put its id in > the subject line of your revi

Re: [OpenJDK 2D-Dev] RFR: Allow using the system libjpeg

* Phil Race [2014-05-22 16:02]: > BTW .. I just realised I haven't seen a bug ID in this thread. > Does one already exist ? No. I was going to create one before I push. Thanks, Omair -- PGP Key: 66484681 (http://pgp.mit.edu/) Fingerprint = F072 555B 0A17 3957 4E95 0056 F286 F14F 6648 4681

Re: [OpenJDK 2D-Dev] RFR: Allow using the system libjpeg

* Andrew Hughes [2014-05-21 20:23]: > - Original Message - > > * Andrew Hughes [2014-05-21 12:22]: > > > I'm not keen on the hardcoding of '-ljpeg' > > > > > > + LIBJPEG_LIBS := -ljpeg > > > > There's no pkg-config files for it. Any suggestions on how to get > > something generic? > >

Re: [OpenJDK 2D-Dev] RFR: Allow using the system libjpeg

* Andrew Hughes [2014-05-21 12:22]: > I'm not keen on the hardcoding of '-ljpeg' > > + LIBJPEG_LIBS := -ljpeg There's no pkg-config files for it. Any suggestions on how to get something generic? > Could this not at least be conditionally assigned? (?=) It can still be overridden on the make c

Re: [OpenJDK 2D-Dev] RFR: Allow using the system libjpeg

Hi, * Phil Race [2014-05-20 18:34]: > I only tried the default (not specifying the system libjpeg) but my builds > all succeeded and SwingSet & Java2D demo ran fine on Mac & Windows > with the closed builds (after generating a closed generated-configure.sh) > so this all looks good to push. Than

Re: RFR: Allow using the system libjpeg

Hi, Updated webrevs: http://cr.openjdk.java.net/~omajid/webrevs/system-libjpeg/01/ http://cr.openjdk.java.net/~omajid/webrevs/system-libjpeg/01.jdk/ * Anthony Petrov [2014-05-19 14:42]: > make/lib/Awt2dLibraries.gmk > >1236 LIBJPEG_CFLAGS := $(JDK_TOPDIR)/src/share/native/sun/awt/image/jpeg

RFR: Allow using the system libjpeg

Hi, Webrevs are at: http://cr.openjdk.java.net/~omajid/webrevs/system-libjpeg/00 http://cr.openjdk.java.net/~omajid/webrevs/system-libjpeg/00.jdk This patch modifies OpenJDK to allow building and running using the system copy of libjpeg. This follows my previous changes for lcms and a lot of the

Re: [OpenJDK 2D-Dev] Dont use libjpeg-internal macros in splashscreen

* Anthony Petrov [2014-05-05 10:12]: > The fix looks good to me, too. Thanks. I have pushed it: http://hg.openjdk.java.net/jdk9/client/jdk/rev/8b9bbe3b2e83 Regards, Omair -- PGP Key: 66484681 (http://pgp.mit.edu/) Fingerprint = F072 555B 0A17 3957 4E95 0056 F286 F14F 6648 4681

Re: RFR: Allow using a system installed libpng

* Magnus Ihse Bursie [2014-02-20 05:35]: > From my point of view, you can go either way. The changes are mostly > in the build code, except for an include statement. But if the AWT > folks feel more confident that way, sure, you can go via client. Pushed: http://hg.openjdk.java.net/jdk9/client/re

Re: RFR: Allow using a system installed libpng

* Magnus Ihse Bursie [2014-02-19 06:59]: > On 2014-02-17 10:16, Erik Joelsson wrote: > >At least to me this looks good, but better let Magnus and Andrew > >have their say too. > > Looks good to me! Thanks for the reviews, everyone! I have filed https://bugs.openjdk.java.net/browse/JDK-8035341 t

Re: RFR: Allow using a system installed libpng

* Sergey Bylokhov [2014-02-18 12:35]: > cc 2d alias also. > > The fix looks good. I am curious who will document all new options > in README-builds.html? One thing I have always loved about autotools is self documentation. With this patch, for example, ./configure --help gives me the new option

Re: RFR: Allow using a system installed libpng

* Erik Joelsson [2014-02-17 04:16]: > At least to me this looks good, but better let Magnus and Andrew > have their say too. Feedback from an AWT expert would be appreciated too! Thanks, Omair -- PGP Key: 66484681 (http://pgp.mit.edu/) Fingerprint = F072 555B 0A17 3957 4E95 0056 F286 F14F 664

Re: RFR: Allow using a system installed libpng

* Andrew Hughes [2014-02-13 23:59]: > As I said in the previous e-mail, the minimum I'd be happy with is if > the current patch was updated so settings weren't being hardcoded into > the makefiles. Passing them from configure would be sufficient for now, > then it can be replaced by PKG_CONFIG. H

Re: RFR: Allow using a system installed libpng

Hi, * Magnus Ihse Bursie [2014-02-12 17:49]: > > On 2014-02-12 18:47, Andrew Hughes wrote: > >>To be extremely clear: Andrew, do you object to bringing Omairs patch, > >>as it is, into OpenJDK? > >> > >Yes. > > Okay then. > > I'll put a mental note to revisit libpng when cleaning up > librarie

Re: RFR: Allow using a system installed libpng

* Andrew Hughes [2014-02-04 19:26]: > > On 2014-02-03 18:43, Omair Majid wrote: > > > The following webrevs modify the build system to allow building against > > > the system-installed copy of libpng as well as using the bundled copy of > > > libpng > > &

Re: RFR: Allow using a system installed libpng

* Magnus Ihse Bursie [2014-02-03 14:42]: > > On 2014-02-03 18:43, Omair Majid wrote: > >Hi, > > > >The following webrevs modify the build system to allow building against > >the system-installed copy of libpng as well as using the bundled copy of > >libpng >

RFR: Allow using a system installed libpng

Hi, The following webrevs modify the build system to allow building against the system-installed copy of libpng as well as using the bundled copy of libpng ROOT: http://cr.openjdk.java.net/~omajid/webrevs/system-libpng/01/ JDK: http://cr.openjdk.java.net/~omajid/webrevs/system-libpng/01-jdk/ A n

Re: RFR: Support GNOME Shell as mutter

Hi Anthony, On 09/16/2013 03:32 PM, Anthony Petrov wrote: > Alexander doesn't have an OpenJDK id yet. But still, having an > additional review never hurts. Agreed, the more reviewers the better :) > Please feel free to push the fix listing only me as a reviewer, and let > me know if you need any

Re: RFR: Support GNOME Shell as mutter

On 09/16/2013 10:02 AM, Anthony Petrov wrote: > Hi Omair, > > Thanks for the patch. Looks fine to me. I've just filed a bug for this fix: > > 8024863: X11: Support GNOME Shell as mutter Thanks for the review! > Do you have commit rights for the awt-gate, or do you want me to push > the fix for

Re: RFR: Support GNOME Shell as mutter

Hi Alexander, On 09/16/2013 10:27 AM, Alexander Zvegintsev wrote: > The patch looks fine to me. Thanks for the review! I wanted to credit you in the Reviewed-by line of the commit message, but I cant find you in the census: http://openjdk.java.net/census Thanks, Omair -- PGP Key: 66484681 (htt

Re: RFR: Support GNOME Shell as mutter

On 09/08/2013 04:11 PM, Omair Majid wrote: > Hi, > > With recent versions of GNOME shell, GNOME shell sets the _NET_WM_NAME > to "GNOME Shell" instead of mutter. It's still mutter that's running, > but with a different _NET_WM_NAME. > > The following w

RFR: Support GNOME Shell as mutter

Hi, With recent versions of GNOME shell, GNOME shell sets the _NET_WM_NAME to "GNOME Shell" instead of mutter. It's still mutter that's running, but with a different _NET_WM_NAME. The following webrev makes OpenJDK compatible with these newer versions: http://cr.openjdk.java.net/~omajid/webrevs/n

Re: [8] Review request for 7190587 Open source and jtreg'ify JAWT regression test

On 08/29/2012 01:15 PM, Konstantin Shefov wrote: > Here is updated webrev: > http://cr.openjdk.java.net/~kshefov/7190587/webrev.02/ > Thanks, that resolves my concerns! Cheers, Omair

Re: [8] Review request for 7190587 Open source and jtreg'ify JAWT regression test

Hi Konstantin, On 08/29/2012 12:43 PM, Konstantin Shefov wrote: > I can remove path to libjawt.so from LD_LIBRARY_PATH, but I have to > leave working dir in it, i.e. > export LD_LIBRARY_PATH="." > Without it test cannot find libmylib.so in working directory. > Oh, of course. I somehow thought th

Re: [8] Review request for 7190587 Open source and jtreg'ify JAWT regression test

Hi, On 08/27/2012 12:29 PM, Konstantin Shefov wrote: > Please review a fix for the issue: > > 7190587 Open source and jtreg'ify JAWT regression test > > Test was modified in to be run with jtreg. > > The webrev is http://cr.openjdk.java.net/~kshefov/7190587/webrev.00/ Is this the test case I w

Re: JAWT Breakage in OpenJDK 7/8

Hi Anthony, On 08/07/2012 09:18 AM, Anthony Petrov wrote: > I've also read the discussion that took place on build-dev@ regarding > this issue, and it seems to me that adding an RPATH entry to launchers > is the right solution for this issue. We may want to also add a comment > there and state tha

Re: JAWT Breakage in OpenJDK 7/8

Hi Artem, Thanks for your thoughts and comments. On 07/30/2012 08:54 AM, Artem Ananiev wrote: > On 7/25/2012 6:40 PM, Omair Majid wrote: >> On 07/25/2012 05:33 AM, Artem Ananiev wrote: >>> Hi, Omair, >>> >>> I don't remember the exact reason for L

Re: JAWT Breakage in OpenJDK 7/8

On 07/25/2012 05:33 AM, Artem Ananiev wrote: > Hi, Omair, > > I don't remember the exact reason for LD_LIBRARY_PATH changes, but it's > very unlikely they can be reverted. Your proposed patch will probably > solve the problem (I haven't checked, though), but it has major > side-effect: increased s

JAWT Breakage in OpenJDK 7/8

Hi, I recently discovered that a number of applications making use of JAWT [1] are broken on OpenJDK 7 and 8, while they were working with OpenJDK6. The docs for JAWT state [1]: """ The final step ­ the most interesting one ­ is to write the native rendering method, with an interface that conform

Re: [7u6] Review request for 7043963: AWT workaround missing for Mutter.

On 06/06/2012 11:15 AM, Artem Ananiev wrote: > Hi, Anthony, Omair, > > since the fix is a direct backport from JDK8, it should be fine. > > I've got a question, though. Since Mutter is a replacement for Metacity > in GNOME 3, is it possible that it shares some code with Metacity and Actually, Mu

Re: [7u6] Review request for 7043963: AWT workaround missing for Mutter.

Hi Anthony, On 06/05/2012 08:15 AM, Anthony Petrov wrote: > Please review a fix for http://bugs.sun.com/view_bug.do?bug_id=7043963 at: > > http://cr.openjdk.java.net/~anthony/7u6-10-Mutter-7043963.0/ > > This is a 100% direct back-port of the same fix from JDK 8. > I was going to request to ba

Re: Add mutter as a window manager.

Hi Mario, On 04/11/2012 07:39 AM, Mario Torre wrote: > I also agree with Omair. > > To be honest, I'm not that happy with the fix, but not because of > Omair's patch, which is very fine given the current state of things, > but because we keep adding this to each and every new WM we find, > althou

Re: Add mutter as a window manager.

On 04/20/2012 11:01 AM, Artem Ananiev wrote: > > On 4/11/2012 11:21 PM, Anthony Petrov wrote: >> Hi Omair and Artem, >> >> On 4/11/2012 9:20 PM, Omair Majid wrote: >>>> PS. Perhaps it also makes sense to rewrite that comment in the >>>> XDecora

Re: Add mutter as a window manager.

On 04/11/2012 06:43 AM, Anthony Petrov wrote: > Hi Omair, > > The analysis below sounds reasonable to me, and as I've already > mentioned I'm OK with your fix. > > Let's hear what Artem says though. Glad to see he agreed :) > PS. Perhaps it also makes sense to rewrite that comment in the > XDec

Re: Add mutter as a window manager.

On 04/11/2012 06:43 AM, Anthony Petrov wrote: > Hi Omair, > > The analysis below sounds reasonable to me, and as I've already > mentioned I'm OK with your fix. > > Let's hear what Artem says though. Yes, I was trying to convince Artem all this time ;) > PS. Perhaps it also makes sense to rewrit

Re: Add mutter as a window manager.

Hi Artem, On 04/09/2012 07:10 AM, Artem Ananiev wrote: > I really hope we can drop most of the ancient WMs listed in the XWM > class (MOTIF, OPENLOOK, CDE, SAWFISH, etc) in JDK8. We know AWT/Swing > works fine on the modern WMs that conform to ICCCM and NET standards, > and I don't see any reasons

Re: Add mutter as a window manager.

Hi Anthony, On 04/09/2012 09:22 AM, Anthony Petrov wrote: > Mutter is the direct descendant of Metacity, so there's nothing wrong > with it inheriting some "inconvenient" behavior of its parent. Given > that Mutter is the standard WM for Gnome 3.0. I'm fine with the fix. > > A comment regarding t

Re: Add mutter as a window manager.

Hi Artem, On 04/09/2012 07:10 AM, Artem Ananiev wrote: > although the patch is technically fine, I'm reluctant to any changes > like this. Thanks for taking a look. > Ideally, in AWT code we shouldn't have any WM checks at all: > all of them are workarounds for various problems with our and thei

Re: Add mutter as a window manager.

On 05/10/2011 12:07 PM, Phil Race wrote: > So the repos aren't "open" any more. Only approved fixes can go in. > There was email on this a couple of weeks ago. I have updated Denis' patch to apply to jdk8. Webrev available at: http://cr.openjdk.java.net/~omajid/mutter-support/01/ Thoughts? Chee

Re: [RFC] Tray icons for applications are not displayed in the GNOME notification bar.

On 11/22/2011 08:58 AM, Anthony Petrov wrote: Hi Omair, On 11/21/2011 10:18 PM, Omair Majid wrote: Thank you Danesh for your contribution! I've just pushed the fix to JDK8 AWT repository. My pleasure, thank you for the review and your feedback! I'd like to request this be backport

Re: [RFC] Tray icons for applications are not displayed in the GNOME notification bar.

On 11/16/2011 07:25 AM, Anthony Petrov wrote: Hello Danesh and OpenJDK6 team, On 11/16/2011 1:13 AM, Danesh Dadachanji wrote: On 11/11/11 07:28 AM, Anthony Petrov wrote: Thank you Danesh for your contribution! I've just pushed the fix to JDK8 AWT repository. My pleasure, thank you for the re

Re: Can't compile (external) code against sun.awt.event package?

On 09/28/2011 05:05 PM, Roman Kennke wrote: Hi, I am trying to compile the Cacio project against vanilla OpenJDK7. One of the classes references IgnorePaintEvent. This class cannot be compiled: [INFO] Compilation failure /home/roman/src/hg/caciocavallo/shared/src/main/java/sun/awt/peer/cacio/C

Re: Request for review: x11 - ensure non zero heights and widths

o that you could push your fix. Thanks! Thanks for taking care of the bug id. I have pushed the changeset as 6994facc6a8b. Cheers, Omair -- best regards, Anthony On 09/27/2010 08:36 PM, Omair Majid wrote: Hi Anthony, On 09/24/2010 04:27 PM, Anthony Petrov wrote: Hi Omair, On 9/24/20

Re: Request for review: x11 - ensure non zero heights and widths

Hi Anthony, On 09/24/2010 04:27 PM, Anthony Petrov wrote: Hi Omair, On 9/24/2010 6:12 PM, Omair Majid wrote: While trying out a Java program, I noticed that some BadValue X errors were being reported (I had to set -Dsun.awt.noisyerrorhandler=True first). The webrev at http

Request for review: x11 - ensure non zero heights and widths

Hi, While trying out a Java program, I noticed that some BadValue X errors were being reported (I had to set -Dsun.awt.noisyerrorhandler=True first). The webrev at http://cr.openjdk.java.net/~omajid/webrevs/x11-bad-widths-heights/webrev.00/ attempts to fix the issue. The problem is that the

Re: Request for review: Crash on XIM server restart

rev.01/ Cheers, Omair On 9/16/2010 11:58 PM, Omair Majid wrote: Hi, While looking at the bug filed at https://bugzilla.redhat.com/show_bug.cgi?id=572147, I noticed that Java applications crash if IBus (an X input server) is restarted. The webrev is at http://cr.openjdk.java.net/~omajid/webre

Request for review: Crash on XIM server restart

Hi, While looking at the bug filed at https://bugzilla.redhat.com/show_bug.cgi?id=572147, I noticed that Java applications crash if IBus (an X input server) is restarted. The webrev is at http://cr.openjdk.java.net/~omajid/webrevs/crash-on-xim-server-restart/webrev.00/ The code in awt_Inpu

Re: [PATCH] Fix X11 window size calculation

Artem Ananiev wrote: Anthony Petrov wrote: Hi Omair, The fix looks fine, and I approve it. If Artem is OK with it also, he will push the fix in a while. Thank you for your contribution! The fix has just been pushed into AWT workspace. Thank you for contribution. Glad I could help. Cheer

Re: [PATCH] Fix X11 window size calculation

cense version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + */ + +/* + @test + @bug 6721088 + @summary X11 Window sizes should be what we set them to + @author Omair Majid +

Re: [PATCH] Fix X11 window size calculation

Hi Artem, Artem Ananiev wrote: Note, to push the changes into OpenJDK you need a valid mercurial user (which is also the author of the corresponding revision) with the access to AWT workspace. Do you have one or need any help with this? I dont have commit access to mercurial. How do I go

Re: [PATCH] Fix X11 window size calculation

11:51:39 2009 -0500 @@ -0,0 +1,49 @@ +/* + @test + @bug 6721088 + @summary X11 Window sizes should be what we set them to + @author Omair Majid + @run main TestFrameSize + */ + +import java.awt.Dimension; +import java.awt.Frame; + +/** + * TestFrameSize.java + * + * Summary: test that X11 Awt wi

Re: [PATCH] Fix X11 window size calculation

Hi Artem, Artem Ananiev wrote: Hi, Omair, I've just updated bug #6721088 and included the information about the fix and the source of the problem. Do you prefer to push the fix into workspace yourself? You/your company must have signed SCA for doing that, and you also need a second reviewer

Re: [PATCH] Fix X11 window size calculation

Hi Artem, Artem Ananiev wrote: Hi, Omair, thank you for the patch. It seems that the bug was closed by mistake, so I have just reopened it against AWT. Thanks! As for proposed changes, there is a single question: --- jdk/src/solaris/classes/sun/awt/X11/XDecoratedPeer.java.orig 2009-01-0

[PATCH] Fix X11 window size calculation

@@ +/* + @test + @bug 6721088 + @summary X11 Window sizes should be what we set them to + @author Omair Majid + @run main TestFrameSize + */ + +import java.awt.Dimension; +import java.awt.Frame; + +/** + * TestFrameSize.java + * + * Summary: test that X11 Awt windows are drawn with correct

[PATCH] Fix invalid PropertyChangeEvents from being propagated

Hi, The current implementation of AccessibleContext propagates PropertyChangeEvents that dont correspond do a change. This patch checks that the new value and the old value are different before firing a PropertyChangeEvent. This has been committed to icedtea as http://icedtea.classpath.org/hg