+1
-phil.
On 4/13/16, 11:32 AM, Semyon Sadetsky wrote:
The fix was updated with the specification for the class serialization
protocol changes which I forget to add:
- the new cause field
- readResolve() method
The updated webrev:
http://cr.openjdk.java.net/~ssadetsky/8080395/webrev.06/
The fix was updated with the specification for the class serialization
protocol changes which I forget to add:
- the new cause field
- readResolve() method
The updated webrev: http://cr.openjdk.java.net/~ssadetsky/8080395/webrev.06/
--Semyon
On 4/5/2016 9:48 AM, Semyon Sadetsky wrote:
On
On 4/4/2016 9:47 PM, Philip Race wrote:
+1 (assuming only the one change, since I didn't re-review in entirety.).
Also assuming the answer to this :
> 39 private static final long serialVersionUID =
-3647309088427840738L;
> Is this the value generated by JDK 8 ? It should be ..
was
The fix looks good to me.
Thanks,
Alexandr.
On 4/4/2016 9:48 AM, Semyon Sadetsky wrote:
Thank you, Phil.
The updates webrev:
http://cr.openjdk.java.net/~ssadetsky/8080395/webrev.05/
--Semyon
On 3/30/2016 7:22 PM, Phil Race wrote:
> 39 private static final long serialVersionUID
Thank you, Phil.
The updates webrev: http://cr.openjdk.java.net/~ssadetsky/8080395/webrev.05/
--Semyon
On 3/30/2016 7:22 PM, Phil Race wrote:
> 39 private static final long serialVersionUID = -3647309088427840738L;
Is this the value generated by JDK 8 ? It should be ..
I agree getCause()
Please review the updated webrev:
http://cr.openjdk.java.net/~ssadetsky/8080395/webrev.04/
- CausedFocusEvent is restored to avoid CNFE during deserialization.
- readResolve() is added to FocusEvent to handle the null cause test.
- deserialization compatibility test scenarios added
--Semyon
There is a problem with FocusEvent deserialization that the read cause
value is not checked to null.
You can fix it with the current fix or just create a separate issue on it.
Otherwise, the fix looks good to me.
Thanks,
Alexandr.
On 10/29/2015 12:33 AM, Sergey Bylokhov wrote:
On 27.10.15
On 27.10.15 13:01, Semyon Sadetsky wrote:
On 10/26/2015 5:31 PM, Sergey Bylokhov wrote:
The test should verify this also.
I assume it should be reverted and updated to:
252 if (cause == null)
253 throw new IllegalArgumentException("null cause");
Please review the updated webrev
The test should verify this also.
I assume it should be reverted and updated to:
252 if (cause == null)
253 throw new IllegalArgumentException("null cause");
Please review the updated webrev
http://cr.openjdk.java.net/~ssadetsky/8080395/webrev.02/
is possible to write a test fox this missed
On 10/19/2015 8:41 PM, Sergey Bylokhov wrote:
On 15.10.15 9:57, Semyon Sadetsky wrote:
- Why did you add a check to the new constructor of FocusEvent? This
check should be done already in the EventObject, and executes before
your new check? Is it a typo and it should be cause? When why do not
On 15.10.15 9:57, Semyon Sadetsky wrote:
- Why did you add a check to the new constructor of FocusEvent? This
check should be done already in the EventObject, and executes before
your new check? Is it a typo and it should be cause? When why do not
throw an NPE? The test should verify this also.
On 10/5/2015 6:47 PM, Sergey Bylokhov wrote:
A few notes:
- Typo in the header of the test: "Copyright (c) 20015", also please
dispose the window before "throw new RuntimeException"
- FocusEvent.java: some of the new javadoc overlap the 80 chars per
line, also remove double spaces in the
A few notes:
- Typo in the header of the test: "Copyright (c) 20015", also please
dispose the window before "throw new RuntimeException"
- FocusEvent.java: some of the new javadoc overlap the 80 chars per
line, also remove double spaces in the text.
- I wonder about serialization, the new field
13 matches
Mail list logo
