Re: Add mutter as a window manager.

2012-06-05 Thread Anthony Petrov
On 6/5/2012 3:14 AM, Omair Majid wrote: Thanks. I have pushed the fix: http://hg.openjdk.java.net/jdk8/awt-gate/jdk/rev/79df0a4a6573 Thanks Omair. -- best regards, Anthony

Re: Add mutter as a window manager.

2012-06-04 Thread Omair Majid
Hi Mario, On 04/11/2012 07:39 AM, Mario Torre wrote: > I also agree with Omair. > > To be honest, I'm not that happy with the fix, but not because of > Omair's patch, which is very fine given the current state of things, > but because we keep adding this to each and every new WM we find, > althou

Re: Add mutter as a window manager.

2012-06-04 Thread Omair Majid
On 04/20/2012 11:01 AM, Artem Ananiev wrote: > > On 4/11/2012 11:21 PM, Anthony Petrov wrote: >> Hi Omair and Artem, >> >> On 4/11/2012 9:20 PM, Omair Majid wrote: PS. Perhaps it also makes sense to rewrite that comment in the XDecoratedPeer to replace the word "bug" with something sayin

Re: Add mutter as a window manager.

2012-04-27 Thread Anthony Petrov
Looks fine to me. Thank you! -- best regards, Anthony On 4/27/2012 3:12 AM, Omair Majid wrote: On 04/11/2012 06:43 AM, Anthony Petrov wrote: Hi Omair, The analysis below sounds reasonable to me, and as I've already mentioned I'm OK with your fix. Let's hear what Artem says though. Glad to

Re: Add mutter as a window manager.

2012-04-26 Thread Omair Majid
On 04/11/2012 06:43 AM, Anthony Petrov wrote: > Hi Omair, > > The analysis below sounds reasonable to me, and as I've already > mentioned I'm OK with your fix. > > Let's hear what Artem says though. Glad to see he agreed :) > PS. Perhaps it also makes sense to rewrite that comment in the > XDec

Re: Add mutter as a window manager.

2012-04-20 Thread Anthony Petrov
On 4/20/2012 7:08 PM, Artem Ananiev wrote: On 4/11/2012 11:21 PM, Anthony Petrov wrote: Hi Omair and Artem, On 4/11/2012 9:20 PM, Omair Majid wrote: PS. Perhaps it also makes sense to rewrite that comment in the XDecoratedPeer to replace the word "bug" with something saying that this is imp

Re: Add mutter as a window manager.

2012-04-20 Thread Artem Ananiev
On 4/11/2012 11:21 PM, Anthony Petrov wrote: Hi Omair and Artem, On 4/11/2012 9:20 PM, Omair Majid wrote: PS. Perhaps it also makes sense to rewrite that comment in the XDecoratedPeer to replace the word "bug" with something saying that this is implemented according to the ICCCM specification

Re: Add mutter as a window manager.

2012-04-20 Thread Artem Ananiev
On 4/11/2012 11:21 PM, Anthony Petrov wrote: Hi Omair and Artem, On 4/11/2012 9:20 PM, Omair Majid wrote: PS. Perhaps it also makes sense to rewrite that comment in the XDecoratedPeer to replace the word "bug" with something saying that this is implemented according to the ICCCM specification

Re: Add mutter as a window manager.

2012-04-11 Thread Anthony Petrov
Hi Omair and Artem, On 4/11/2012 9:20 PM, Omair Majid wrote: PS. Perhaps it also makes sense to rewrite that comment in the XDecoratedPeer to replace the word "bug" with something saying that this is implemented according to the ICCCM specification with a reference to the paragraph 4.1.5 of it?

Re: Add mutter as a window manager.

2012-04-11 Thread Omair Majid
On 04/11/2012 06:43 AM, Anthony Petrov wrote: > Hi Omair, > > The analysis below sounds reasonable to me, and as I've already > mentioned I'm OK with your fix. > > Let's hear what Artem says though. Yes, I was trying to convince Artem all this time ;) > PS. Perhaps it also makes sense to rewrit

Re: Add mutter as a window manager.

2012-04-11 Thread Anthony Petrov
Hi Mario, On 4/11/2012 3:39 PM, Mario Torre wrote: I also agree with Omair. To be honest, I'm not that happy with the fix, but not because of Omair's patch, which is very fine given the current state of things, but because we keep adding this to each and every new WM we find, although fixing AW

Re: Add mutter as a window manager.

2012-04-11 Thread Mario Torre
Hi all, I also agree with Omair. To be honest, I'm not that happy with the fix, but not because of Omair's patch, which is very fine given the current state of things, but because we keep adding this to each and every new WM we find, although fixing AWT in this regard will be probably more work t

Re: Add mutter as a window manager.

2012-04-11 Thread Anthony Petrov
Hi Omair, The analysis below sounds reasonable to me, and as I've already mentioned I'm OK with your fix. Let's hear what Artem says though. PS. Perhaps it also makes sense to rewrite that comment in the XDecoratedPeer to replace the word "bug" with something saying that this is implemented

Re: Add mutter as a window manager.

2012-04-10 Thread Omair Majid
Hi Artem, On 04/09/2012 07:10 AM, Artem Ananiev wrote: > I really hope we can drop most of the ancient WMs listed in the XWM > class (MOTIF, OPENLOOK, CDE, SAWFISH, etc) in JDK8. We know AWT/Swing > works fine on the modern WMs that conform to ICCCM and NET standards, > and I don't see any reasons

Re: Add mutter as a window manager.

2012-04-10 Thread Anthony Petrov
On 4/10/2012 7:03 PM, Omair Majid wrote: On 04/09/2012 09:22 AM, Anthony Petrov wrote: Mutter is the direct descendant of Metacity, so there's nothing wrong with it inheriting some "inconvenient" behavior of its parent. Given that Mutter is the standard WM for Gnome 3.0. I'm fine with the fix.

Re: Add mutter as a window manager.

2012-04-10 Thread Omair Majid
Hi Anthony, On 04/09/2012 09:22 AM, Anthony Petrov wrote: > Mutter is the direct descendant of Metacity, so there's nothing wrong > with it inheriting some "inconvenient" behavior of its parent. Given > that Mutter is the standard WM for Gnome 3.0. I'm fine with the fix. > > A comment regarding t

Re: Add mutter as a window manager.

2012-04-10 Thread Omair Majid
Hi Artem, On 04/09/2012 07:10 AM, Artem Ananiev wrote: > although the patch is technically fine, I'm reluctant to any changes > like this. Thanks for taking a look. > Ideally, in AWT code we shouldn't have any WM checks at all: > all of them are workarounds for various problems with our and thei

Re: Add mutter as a window manager.

2012-04-09 Thread Anthony Petrov
Hi Omair, Mutter is the direct descendant of Metacity, so there's nothing wrong with it inheriting some "inconvenient" behavior of its parent. Given that Mutter is the standard WM for Gnome 3.0. I'm fine with the fix. A comment regarding the test: 61 frame.pack(); 62 fra

Re: Add mutter as a window manager.

2012-04-09 Thread Artem Ananiev
Hi, Omair, although the patch is technically fine, I'm reluctant to any changes like this. Ideally, in AWT code we shouldn't have any WM checks at all: all of them are workarounds for various problems with our and their code. I really hope we can drop most of the ancient WMs listed in the XWM

Re: Add mutter as a window manager.

2012-04-08 Thread Omair Majid
On 05/10/2011 12:07 PM, Phil Race wrote: > So the repos aren't "open" any more. Only approved fixes can go in. > There was email on this a couple of weeks ago. I have updated Denis' patch to apply to jdk8. Webrev available at: http://cr.openjdk.java.net/~omajid/mutter-support/01/ Thoughts? Chee

Re: Add mutter as a window manager.

2011-05-13 Thread Artem Ananiev
On 5/12/2011 7:28 PM, Denis Lila wrote: Hi Denis. we could use implementation for them as a default one and skip it in case if custom querying is not needed. I'm not sure what you mean by this. Can you please ellaborate, or possibly give a short pseudocode example? I think Denis F. meant t

Re: Add mutter as a window manager.

2011-05-12 Thread Denis Lila
Hi Denis. > we could use implementation for them as a default one and skip it in > case if custom querying is not needed. I'm not sure what you mean by this. Can you please ellaborate, or possibly give a short pseudocode example? Thank you, Denis. - Original Message - > Hi Denis, > > t

Re: Add mutter as a window manager.

2011-05-10 Thread Phil Race
The fix looks like it should do something useful :-), and appears harmless for other WMs. The only thing is you will need to have 1) a bug id, 2) an AWT sponsor who can request of the release team if this fix can go into JDK 7 as we already froze to work towards RC. So the repos aren't "open" a

Add mutter as a window manager.

2011-05-10 Thread Denis Lila
Hi. We have this bug where, using the mutter window manager, if one moves netbeans anywhere on the screen except at the top left and then maximizes it, clicking is broken. This is because after maximizing the position of the XDecoratedPeer is not updated. On Metacity and some other WMs this is don