Re: AWT Dev [9] Review Request: 8132382 [macosx] Crash during JMC execution

2015-08-04 Thread Semyon Sadetsky
On 8/3/2015 4:41 PM, Sergey Bylokhov wrote: On 31.07.15 21:34, Semyon Sadetsky wrote: On 7/31/2015 6:28 PM, Sergey Bylokhov wrote: On 31.07.15 18:12, Semyon Sadetsky wrote: On 7/31/2015 5:55 PM, Sergey Bylokhov wrote: On 31.07.15 17:29, Semyon Sadetsky wrote: So the test could use one

Re: AWT Dev [9] Review Request: 8132382 [macosx] Crash during JMC execution

2015-08-03 Thread Sergey Bylokhov
On 31.07.15 21:34, Semyon Sadetsky wrote: On 7/31/2015 6:28 PM, Sergey Bylokhov wrote: On 31.07.15 18:12, Semyon Sadetsky wrote: On 7/31/2015 5:55 PM, Sergey Bylokhov wrote: On 31.07.15 17:29, Semyon Sadetsky wrote: So the test could use one of these java resources inside the native app

Re: AWT Dev [9] Review Request: 8132382 [macosx] Crash during JMC execution

2015-07-31 Thread Semyon Sadetsky
There are plenty classes extending CFRetainedResource, TryIcon for example. Will disposing them cause the same issue inside the native app? On 7/31/2015 4:37 PM, Sergey Bylokhov wrote: Yes, it is possible if this simple native application emulate initialization of these libraries. On

Re: AWT Dev [9] Review Request: 8132382 [macosx] Crash during JMC execution

2015-07-31 Thread Sergey Bylokhov
On 31.07.15 16:51, Semyon Sadetsky wrote: There are plenty classes extending CFRetainedResource, TryIcon for example. Will disposing them cause the same issue inside the native app? The crash occurs when any of these subclasses will be disposed, in some cases app will crash immediately, in

Re: AWT Dev [9] Review Request: 8132382 [macosx] Crash during JMC execution

2015-07-31 Thread Semyon Sadetsky
Is it possible to reproduce the scenario using simple native application which embeds the Java VM? On 7/31/2015 3:37 PM, Sergey Bylokhov wrote: On 31.07.15 10:30, Semyon Sadetsky wrote: JMC-4034 is not an OpenJDK project. Souldn't this test be copied to the client-libs test base? JDK-8132469

Re: AWT Dev [9] Review Request: 8132382 [macosx] Crash during JMC execution

2015-07-31 Thread Sergey Bylokhov
On 31.07.15 17:29, Semyon Sadetsky wrote: So the test could use one of these java resources inside the native app without any external libraries only using JNI library, right? Since we do not place a binary files to the ws, It will require an xcode and comandline tools. On 7/31/2015 5:18

Re: AWT Dev [9] Review Request: 8132382 [macosx] Crash during JMC execution

2015-07-31 Thread Semyon Sadetsky
On 7/31/2015 5:55 PM, Sergey Bylokhov wrote: On 31.07.15 17:29, Semyon Sadetsky wrote: So the test could use one of these java resources inside the native app without any external libraries only using JNI library, right? Since we do not place a binary files to the ws, It will require an

Re: AWT Dev [9] Review Request: 8132382 [macosx] Crash during JMC execution

2015-07-31 Thread Sergey Bylokhov
On 31.07.15 18:12, Semyon Sadetsky wrote: On 7/31/2015 5:55 PM, Sergey Bylokhov wrote: On 31.07.15 17:29, Semyon Sadetsky wrote: So the test could use one of these java resources inside the native app without any external libraries only using JNI library, right? Since we do not place a

Re: AWT Dev [9] Review Request: 8132382 [macosx] Crash during JMC execution

2015-07-31 Thread Sergey Bylokhov
On 31.07.15 10:30, Semyon Sadetsky wrote: JMC-4034 is not an OpenJDK project. Souldn't this test be copied to the client-libs test base? JDK-8132469 description contains manual steps executed using SwingSet2, right? All sqe tests is not a part of openjdk project. These particular tests cannot

Re: AWT Dev [9] Review Request: 8132382 [macosx] Crash during JMC execution

2015-07-31 Thread Sergey Bylokhov
Yes, it is possible if this simple native application emulate initialization of these libraries. On 31.07.15 16:07, Semyon Sadetsky wrote: Is it possible to reproduce the scenario using simple native application which embeds the Java VM? On 7/31/2015 3:37 PM, Sergey Bylokhov wrote: On

Re: AWT Dev [9] Review Request: 8132382 [macosx] Crash during JMC execution

2015-07-31 Thread Semyon Sadetsky
So the test could use one of these java resources inside the native app without any external libraries only using JNI library, right? On 7/31/2015 5:18 PM, Sergey Bylokhov wrote: On 31.07.15 16:51, Semyon Sadetsky wrote: There are plenty classes extending CFRetainedResource, TryIcon for

Re: AWT Dev [9] Review Request: 8132382 [macosx] Crash during JMC execution

2015-07-31 Thread Semyon Sadetsky
On 7/31/2015 6:28 PM, Sergey Bylokhov wrote: On 31.07.15 18:12, Semyon Sadetsky wrote: On 7/31/2015 5:55 PM, Sergey Bylokhov wrote: On 31.07.15 17:29, Semyon Sadetsky wrote: So the test could use one of these java resources inside the native app without any external libraries only using

Re: AWT Dev [9] Review Request: 8132382 [macosx] Crash during JMC execution

2015-07-31 Thread Semyon Sadetsky
JMC-4034 is not an OpenJDK project. Souldn't this test be copied to the client-libs test base? JDK-8132469 description contains manual steps executed using SwingSet2, right? --Semyon On 7/30/2015 5:55 PM, Sergey Bylokhov wrote: Hi, Semyon. There are two tests which failed, see JMC-4034(

Re: AWT Dev [9] Review Request: 8132382 [macosx] Crash during JMC execution

2015-07-30 Thread Sergey Bylokhov
Hi, Semyon. There are two tests which failed, see JMC-4034( jmc_plugintest/swt case) and JDK-8132469(swingnode/fx case). On 30.07.15 9:49, Semyon Sadetsky wrote: Hi Sergey, You've marked the bug as noreg-sqe. I could not find the existing test that crashes during the bug scenario. Could add

Re: AWT Dev [9] Review Request: 8132382 [macosx] Crash during JMC execution

2015-07-30 Thread Semyon Sadetsky
Hi Sergey, You've marked the bug as noreg-sqe. I could not find the existing test that crashes during the bug scenario. Could add this info? --Semyon On 7/29/2015 6:51 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk9. In the fix 8068886[1] the new native resources

Re: AWT Dev [9] Review Request: 8132382 [macosx] Crash during JMC execution

2015-07-30 Thread Alexander Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 7/29/2015 6:54 PM, Alexander Zuev wrote: Looks fine to me. /Alex On 29/07/15 18:51, Sergey Bylokhov wrote: Hello. Please review the fix for jdk9. In the fix 8068886[1] the new native resources deallocation code assumes that we have a

AWT Dev [9] Review Request: 8132382 [macosx] Crash during JMC execution

2015-07-29 Thread Sergey Bylokhov
Hello. Please review the fix for jdk9. In the fix 8068886[1] the new native resources deallocation code assumes that we have a full control over the Cocoa NSApplication. This is incorrect in case of embedding, when NSApplication is controlled by swt or fx libraries. In the fix I add an

Re: AWT Dev [9] Review Request: 8132382 [macosx] Crash during JMC execution

2015-07-29 Thread Alexander Zuev
Looks fine to me. /Alex On 29/07/15 18:51, Sergey Bylokhov wrote: Hello. Please review the fix for jdk9. In the fix 8068886[1] the new native resources deallocation code assumes that we have a full control over the Cocoa NSApplication. This is incorrect in case of embedding, when