Re: [blink-dev] Intent to Ship: Ruby-specific display values

2023-11-01 Thread TAMURA, Kent
On Thu, Nov 2, 2023 at 12:53 AM Rick Byers wrote: > Hey Kent, > To Fantasai's point, can you point to the specific WPT test cases for this > intent? Are Chrome or Firefox failing any, and if so can you explain why? > > Tentative LGTM2 assuming WPT coverage shows we're matching Firefox >

[blink-dev] Intent to Prototype: checkVisibility: contentVisibilityAuto, opacityProperty, and visibilityProperty

2023-11-01 Thread Vladimir Levin
Contact emailsvmp...@chromium.org Specification https://drafts.csswg.org/cssom-view/#dom-element-checkvisibility Summary This feature adds three more values to the checkVisibility ( https://drafts.csswg.org/cssom-view/#dom-element-checkvisibility) dictionary members: * opacityProperty as an

Re: [blink-dev] Re: Intent to Deprecate: Remove "Sanitizer API MVP"

2023-11-01 Thread 'Elijah Grey' via blink-dev
Ignore that confidentiality notice if it came from my client. On Tuesday, October 31, 2023 at 6:41:30 PM UTC-7 Elijah Grey wrote: > Hey all, > > Note: If future versions of this API re-use the Element.prototype.setHTML > method in new ways, there may be potential for breakage. Transcend ships a

[blink-dev] Intent to Implement and Ship: VideoEncoderConfig.contentHint

2023-11-01 Thread 'Eugene Zemtsov' via blink-dev
Contact emailsezemt...@google.com Specification https://www.w3.org/TR/webcodecs/#dom-videoencoderconfig-contenthint Explainerhttps://gist.github.com/Djuffin/c3742404b7c53ada227849c8b2b76b4c Summary Adding a contentHint field to VideoEncoderConfig Content hint takes values that are already used

RE: [blink-dev] Intent to Ship: EditContext API

2023-11-01 Thread 'Daniel Clark' via blink-dev
To the extent that firing keydown before compositionstart is a problem for apps, that’s an issue that equally affects contenteditable. Changing the order may be a good improvement, but it will be a breaking change for the web that should be carefully considered and hopefully done in tandem with

Re: [blink-dev] Intent to Ship: Protected Audience clearOriginJoinedAdInterestGroups() & interest group limit changes & kAnonStatus

2023-11-01 Thread 'Orr Bernstein' via blink-dev
Sorry for the delay in response. All of the PRs have since landed. Regarding your question on the interest group limit changes, these limits are intended to be guardrails against exceptional behavior, and not meant to be reached under normal conditions. In the best practices we previously

Re: [blink-dev] Re: Intent to Experiment: IP Protection Phase 0

2023-11-01 Thread 'Rick Byers' via blink-dev
LGTM, no concerns from me with experimenting. It seems like user and enterprise controls are in place, and since this is just about proxying 3P resources that reduces the risk of it impacting either site functionality or network filtering policy. Note that Chrome already has another (fully

Re: [blink-dev] Intent to Ship: Ruby-specific display values

2023-11-01 Thread Daniel Bratell
LGTM3 but attend to Rick's comment below before shipping. (Fantasia/Kent: It should be possible to test the implementation using the flags the WPT bots use to test so I assume Fantasia can test it with an appropriate flag and new enough build?

Re: [blink-dev] Intent to Ship: Ruby-specific display values

2023-11-01 Thread Rick Byers
Hey Kent, To Fantasai's point, can you point to the specific WPT test cases for this intent? Are Chrome or Firefox failing any, and if so can you explain why? Tentative LGTM2 assuming WPT coverage shows we're matching Firefox behavior. Also happy to discuss the nuance here first if it's not

Re: [EXTERNAL] Re: [blink-dev] Intent to Implement and Ship: Feature detection for supported clipboard formats

2023-11-01 Thread Chris Harrelson
LGTM3 On Wed, Nov 1, 2023 at 8:44 AM Philip Jägenstedt wrote: > LGTM2 > > This looks like a small addition that we should ship. It's tested and > passing here: > > https://wpt.fyi/results/clipboard-apis/clipboard-item.https.html?label=experimental=master > > On Wed, Nov 1, 2023 at 4:43 PM Rick

Re: [EXTERNAL] Re: [blink-dev] Intent to Implement and Ship: Feature detection for supported clipboard formats

2023-11-01 Thread Philip Jägenstedt
LGTM2 This looks like a small addition that we should ship. It's tested and passing here: https://wpt.fyi/results/clipboard-apis/clipboard-item.https.html?label=experimental=master On Wed, Nov 1, 2023 at 4:43 PM Rick Byers wrote: > LGTM1 > > On Wed, Oct 25, 2023 at 4:33 PM 'Anupam Snigdha' via

Re: [EXTERNAL] Re: [blink-dev] Intent to Implement and Ship: Feature detection for supported clipboard formats

2023-11-01 Thread Rick Byers
LGTM1 On Wed, Oct 25, 2023 at 4:33 PM 'Anupam Snigdha' via blink-dev < blink-dev@chromium.org> wrote: > I found a similar API canPlayType > > for > media element that informs the user about the supported MIME types.

Re: [blink-dev] Intent to Experiment: Extending Storage Access API (SAA) to non-cookie storage

2023-11-01 Thread Rick Byers
This makes a lot of sense to me. I hate the idea of pushing folks to use cookies just due to SAA. I see the debate about wanting to deprecate the sync storage APIs, but I agree with you that this is not a useful lever in that debate. Instead we should come up with a holistic deprecation strategy.

Re: [blink-dev] Intent to Ship: CSS Highlight Inheritance

2023-11-01 Thread Stephen Chenney
Answers inline. Regarding Ander's comment on the current base_feature setting: I'll fix that. Cheers, Stephen. On Wed, Nov 1, 2023 at 4:17 AM Yoav Weiss wrote: > > > On Tue, Oct 31, 2023 at 1:45 PM Stephen Chenney > wrote: > >> Contact emailsschen...@chromium.org >> >>

Re: [blink-dev] Intent to Ship: Fenced Frame - Functionality Updates

2023-11-01 Thread Rick Byers
LGTM3 On Fri, Oct 27, 2023 at 4:49 PM Chris Harrelson wrote: > LGTM2 > > On Thu, Oct 26, 2023 at 10:30 AM Mike Taylor > wrote: > >> Thanks for the design doc! The quote from kleber@ really helped me to >> understand the use case and developer need. It sounds like this is a small >> tweak to

Re: [blink-dev] Intent to Ship: WebCodecs support for enabling AV1 screen content coding tools

2023-11-01 Thread 'Philipp Hancke' via blink-dev
Am Mi., 25. Okt. 2023 um 18:40 Uhr schrieb Mike Taylor < miketa...@chromium.org>: > On 10/20/23 2:27 PM, 'Philipp Hancke' via blink-dev wrote: > > Contact emails > > > * phan...@microsoft.com , > bernard.ab...@microsoft.com * Explainer > > * None * > > For those looking for an explainer, hope

[blink-dev] Intent to Ship: No-Vary-Search support in navigation prefetch cache

2023-11-01 Thread Liviu Tinta
Contact emailsdome...@chromium.org, jbro...@chromium.org, liviuti...@chromium.org Explainerhttps://github.com/WICG/nav-speculation/blob/main/no-vary-search.md Specificationhttps://wicg.github.io/nav-speculation/no-vary-search.html Summary Enables prefetch to match even if URL query parameters

[blink-dev] Intent to Ship: No-Vary-Search Hint for Prefetch Speculation Rules

2023-11-01 Thread Liviu Tinta
Contact emailsdome...@chromium.org, jbro...@chromium.org, liviuti...@chromium.org Explainer https://github.com/WICG/nav-speculation/blob/main/triggers.md#no-vary-search-hint Specification https://wicg.github.io/nav-speculation/speculation-rules.html#speculation-rules-processing Summary Adds a

Re: [blink-dev] Intent to Ship: CSS spelling and grammar features

2023-11-01 Thread Rune Lillesveen
On Tue, Oct 31, 2023 at 1:37 AM Stephen Chenney wrote: > The CSS Spelling and Grammar feature has been active behind experimental > web platform features since M89! There are no open bugs. I would like to > turn it on at last for M120. > > Finch feature nameCSSSpellingGrammarErrors > Please

Re: [blink-dev] Intent to Ship: CSS Highlight Inheritance

2023-11-01 Thread Anders Hartvoll Ruud
On Tue, Oct 31, 2023 at 1:45 PM Stephen Chenney wrote: > Contact emailsschen...@chromium.org > > Specificationhttps://drafts.csswg.org/css-pseudo-4/#highlight-cascade > > Summary > > With CSS Highlight Inheritance, the CSS Highlight pseudo classes, such as > ::selection and ::highlight, inherit

Re: [blink-dev] Re: Intent to Ship: FedCM extensions: Error API and Auto-Selected Flag API

2023-11-01 Thread Yoav Weiss
LGTM3 On Mon, Oct 30, 2023 at 7:35 PM Rick Byers wrote: > Thanks Mike. LGTM2 > > On Mon, Oct 30, 2023 at 12:21 PM Mike Taylor > wrote: > >> I'd like to remove my condition around my LGTM - I was able to reach out >> to Ben offline to confirm that he's roughly in favor of the proposed >>

Re: [blink-dev] Intent to Ship: CSS spelling and grammar features

2023-11-01 Thread Yoav Weiss
On Tue, Oct 31, 2023 at 1:37 AM Stephen Chenney wrote: > The CSS Spelling and Grammar feature has been active behind experimental > web platform features since M89! There are no open bugs. I would like to > turn it on at last for M120. > > Contact emailsschen...@chromium.org, dazab...@igalia.com

Re: [blink-dev] Intent to Ship: CSS Highlight Inheritance

2023-11-01 Thread Yoav Weiss
On Tue, Oct 31, 2023 at 1:45 PM Stephen Chenney wrote: > Contact emailsschen...@chromium.org > > Specificationhttps://drafts.csswg.org/css-pseudo-4/#highlight-cascade > > Summary > > With CSS Highlight Inheritance, the CSS Highlight pseudo classes, such as > ::selection and ::highlight, inherit