Re: [blink-dev] Intent to Ship: Attribution Reporting API feature (aggregation coordinator selection)

2023-10-17 Thread Chris Harrelson
LGTM3 On Tue, Oct 17, 2023, 4:20 AM Yoav Weiss wrote: > LGTM2 > > On Tue, Oct 17, 2023 at 12:05 AM Mike Taylor > wrote: > >> LGTM1 >> On 10/16/23 7:48 AM, Nan Lin wrote: >> >> Thanks Mike, please see the inline comment. >> >> On Mon, Oct 16, 2023 at 10:41 AM Mike Taylor >> wrote: >> >>> >>>

Re: [blink-dev] Intent to Ship: Attribution Reporting API feature (aggregation coordinator selection)

2023-10-17 Thread Yoav Weiss
LGTM2 On Tue, Oct 17, 2023 at 12:05 AM Mike Taylor wrote: > LGTM1 > On 10/16/23 7:48 AM, Nan Lin wrote: > > Thanks Mike, please see the inline comment. > > On Mon, Oct 16, 2023 at 10:41 AM Mike Taylor > wrote: > >> >> Interoperability and Compatibility >> >> The change is backwards compatible,

Re: [blink-dev] Intent to Ship: Attribution Reporting API feature (aggregation coordinator selection)

2023-10-16 Thread Mike Taylor
LGTM1 On 10/16/23 7:48 AM, Nan Lin wrote: Thanks Mike, please see the inline comment. On Mon, Oct 16, 2023 at 10:41 AM Mike Taylor wrote: Interoperability and Compatibility The change is backwards compatible, and allows developers to select the deployment option for

Re: [blink-dev] Intent to Ship: Attribution Reporting API feature (aggregation coordinator selection)

2023-10-16 Thread Mike Taylor
On 10/16/23 7:57 AM, Nan Lin wrote: A few more inline comments, thanks! On Mon, Oct 16, 2023 at 10:41 AM Mike Taylor wrote: Hi Nan, a few questions inline: On 10/6/23 8:45 AM, Nan Lin wrote: Contact emails lin...@chromium.org ,

Re: [blink-dev] Intent to Ship: Attribution Reporting API feature (aggregation coordinator selection)

2023-10-16 Thread Nan Lin
A few more inline comments, thanks! On Mon, Oct 16, 2023 at 10:41 AM Mike Taylor wrote: > Hi Nan, a few questions inline: > On 10/6/23 8:45 AM, Nan Lin wrote: > > Contact emails > > lin...@chromium.org, johni...@chromium.org > > Explainer > > Attribution Reporting with event-level reports >

Re: [blink-dev] Intent to Ship: Attribution Reporting API feature (aggregation coordinator selection)

2023-10-16 Thread Nan Lin
Thanks Mike, please see the inline comment. On Mon, Oct 16, 2023 at 10:41 AM Mike Taylor wrote: > Hi Nan, a few questions inline: > On 10/6/23 8:45 AM, Nan Lin wrote: > > Contact emails > > lin...@chromium.org, johni...@chromium.org > > Explainer > > Attribution Reporting with event-level

Re: [blink-dev] Intent to Ship: Attribution Reporting API feature (aggregation coordinator selection)

2023-10-16 Thread Mike Taylor
Hi Nan, a few questions inline: On 10/6/23 8:45 AM, Nan Lin wrote: Contact emails lin...@chromium.org , johni...@chromium.org Explainer Attribution Reporting with event-level reports

Re: [blink-dev] Intent to Ship: Attribution Reporting API feature (aggregation coordinator selection)

2023-10-11 Thread Chris Harrelson
Great thank you! On Wed, Oct 11, 2023 at 9:32 AM Nan Lin wrote: > Thanks Chris. > > I kicked off those reviews in chromestatus, and will ping this thread when > those reviews are complete. > > Thanks, > Nan > > On Wed, Oct 11, 2023 at 10:53 AM Chris Harrelson > wrote: > >> Please fill out the

Re: [blink-dev] Intent to Ship: Attribution Reporting API feature (aggregation coordinator selection)

2023-10-11 Thread Nan Lin
Thanks Chris. I kicked off those reviews in chromestatus, and will ping this thread when those reviews are complete. Thanks, Nan On Wed, Oct 11, 2023 at 10:53 AM Chris Harrelson wrote: > Please fill out the 5 other review categories (security, privacy, etc) in > chromestatus. Those will need

Re: [blink-dev] Intent to Ship: Attribution Reporting API feature (aggregation coordinator selection)

2023-10-11 Thread 'Nan Lin' via blink-dev
Hi Chris, I don't see the other review categories (security, privacy, etc) in the Prepare to Ship stage in chromestatus. How shall I edit and request review for those? Thanks. Best, Nan On Wed, Oct 11, 2023 at 10:53 AM Chris Harrelson wrote: > Please fill out the 5 other review categories

Re: [blink-dev] Intent to Ship: Attribution Reporting API feature (aggregation coordinator selection)

2023-10-11 Thread Chris Harrelson
Please fill out the 5 other review categories (security, privacy, etc) in chromestatus. Those will need to be started before the API owners can review. On Fri, Oct 6, 2023 at 5:46 AM Nan Lin wrote: > Contact emails > > lin...@chromium.org, johni...@chromium.org > > Explainer > > Attribution

[blink-dev] Intent to Ship: Attribution Reporting API feature (aggregation coordinator selection)

2023-10-06 Thread Nan Lin
Contact emails lin...@chromium.org, johni...@chromium.org Explainer Attribution Reporting with event-level reports Attribution Reporting API with Aggregatable Reports