Re: [blink-dev] Intent to Ship: Conditional Focus

2022-10-20 Thread Chris Harrelson
On Thu, Oct 20, 2022, 7:37 AM 'Elad Alon' via blink-dev < blink-dev@chromium.org> wrote: > Thanks for approving. > May this be a gapless ship? This would show consideration to our OT > partners and their effort. > Per a recent policy change, gapless is always allowed without approvals needed.

Re: [blink-dev] Intent to Ship: Conditional Focus

2022-10-20 Thread 'Elad Alon' via blink-dev
Thanks for approving. May this be a gapless ship? This would show consideration to our OT partners and their effort. On Wednesday, October 19, 2022 at 5:58:25 PM UTC+2 Daniel Bratell wrote: > LGTM3 > > /Daniel > > *Sent with my Thunderbird* > > On 2022-10-19 17:55, 'Elad Alon' via blink-dev wrot

Re: [blink-dev] Intent to Ship: Conditional Focus

2022-10-19 Thread Daniel Bratell
LGTM3 /Daniel /Sent with my Thunderbird/ On 2022-10-19 17:55, 'Elad Alon' via blink-dev wrote: (Ack the nit.) On Wednesday, October 19, 2022 at 5:55:05 PM UTC+2 yoav...@chromium.org wrote: LGTM2 On Wednesday, October 19, 2022 at 5:53:47 PM UTC+2 Chris Harrelson wrote:

Re: [blink-dev] Intent to Ship: Conditional Focus

2022-10-19 Thread 'Elad Alon' via blink-dev
(Ack the nit.) On Wednesday, October 19, 2022 at 5:55:05 PM UTC+2 yoav...@chromium.org wrote: > LGTM2 > > On Wednesday, October 19, 2022 at 5:53:47 PM UTC+2 Chris Harrelson wrote: > >> LGTM1 >> >> On Wed, Oct 19, 2022 at 1:39 AM Yoav Weiss wrote: >> >>> OK, so we have WPTs covering the current

Re: [blink-dev] Intent to Ship: Conditional Focus

2022-10-19 Thread Yoav Weiss
LGTM2 On Wednesday, October 19, 2022 at 5:53:47 PM UTC+2 Chris Harrelson wrote: > LGTM1 > > On Wed, Oct 19, 2022 at 1:39 AM Yoav Weiss wrote: > >> OK, so we have WPTs covering the currently testable parts of the API, as >> required by spec and browser tests covering the UA-specific parts. Makes

Re: [blink-dev] Intent to Ship: Conditional Focus

2022-10-19 Thread Chris Harrelson
LGTM1 On Wed, Oct 19, 2022 at 1:39 AM Yoav Weiss wrote: > OK, so we have WPTs covering the currently testable parts of the API, as > required by spec and browser tests covering the UA-specific parts. Makes > sense. > > > On Wed, Oct 19, 2022 at 9:36 AM Elad Alon wrote: > >> The main reason for

Re: [blink-dev] Intent to Ship: Conditional Focus

2022-10-19 Thread Yoav Weiss
OK, so we have WPTs covering the currently testable parts of the API, as required by spec and browser tests covering the UA-specific parts. Makes sense. On Wed, Oct 19, 2022 at 9:36 AM Elad Alon wrote: > The main reason for partial WPT coverage is that the API is formulated > with some key MAY-

Re: [blink-dev] Intent to Ship: Conditional Focus

2022-10-19 Thread 'Elad Alon' via blink-dev
The main reason for partial WPT coverage is that the API is formulated with some key MAY-s, in order to accommodate Safari's different media-picker model. The errors should be the same on all platforms, and are tested. But whether the focus goes to the captured or capturing page is left to the U

Re: [blink-dev] Intent to Ship: Conditional Focus

2022-10-18 Thread Yoav Weiss
On Thu, Oct 13, 2022 at 10:24 PM 'Elad Alon' via blink-dev < blink-dev@chromium.org> wrote: > Contact emailselada...@chromium.org > > Explainerhttps://github.com/WICG/conditional-focus/blob/main/README.md > > Specification > https://w3c.github.io/mediacapture-screen-share/#dom-capturecontroller-se

[blink-dev] Intent to Ship: Conditional Focus

2022-10-13 Thread 'Elad Alon' via blink-dev
Contact emailselada...@chromium.org Explainerhttps://github.com/WICG/conditional-focus/blob/main/README.md Specification https://w3c.github.io/mediacapture-screen-share/#dom-capturecontroller-setfocusbehavior Design docs https://docs.google.com/document/d/1LHJRt-ry9hwzFTbPxKrmD0VvtEFEU6lvqsD7k6w